Re: [PATCH] rockchip: Pinebook Pro: Do not initialize i2c before relocation
Hi Simon,
On 2022/12/6 07:55, Simon Glass wrote:
Hi,
On Tue, 6 Dec 2022 at 11:25, Tom Rini wrote:
On Mon, Dec 05, 2022 at 09:35:41PM +, Peter Robinson wrote:
On Sat, Dec 3, 2022 at 12:31 PM Michal Suchanek wrote:
The i2c locks up when initialized before relocation, and it stays broken
in Linux as well breaking the ability to boot Linux.
The i2c bus and pmic was not actually used in pre-reloc before
commit ad607512f575 ("power: pmic: rk8xx: Support sysreset shutdown method")
The cause is not known.
This is board-specific, other boards that do not add the option to
include the i2c bus in pre-reloc DT are not affected.
Signed-off-by: Michal Suchanek
Reviewed-by: Peter Robinson
Tested-by: Peter Robinson
Thanks for checking this out, I had noticed a regression and had got
as far as bisecting it but not getting to a fix.
Tom: can we get this pulled into 2023.01 please?
Probably should be, yes. Kever, are there any other rockchip must-fixes
for v2023.01? I can take this directly if you don't have others and/or
don't want to make up a PR, thanks!
There is also this one:
https://patchwork.ozlabs.org/project/uboot/patch/20220928024046.2657593-1-...@chromium.org/
This patch has been merge into mainline at about 21th Oct.
I forgot to update the patch status in patchwork system.
Thanks,
- Kever
Regards,
Simon
Re: [PATCH] rockchip: Pinebook Pro: Do not initialize i2c before relocation
On 2022/12/3 20:31, Michal Suchanek wrote:
The i2c locks up when initialized before relocation, and it stays broken
in Linux as well breaking the ability to boot Linux.
The i2c bus and pmic was not actually used in pre-reloc before
commit ad607512f575 ("power: pmic: rk8xx: Support sysreset shutdown method")
The cause is not known.
This is board-specific, other boards that do not add the option to
include the i2c bus in pre-reloc DT are not affected.
Signed-off-by: Michal Suchanek
Reviewed-by: Kever Yang
Thanks,
- Kever
---
This is not tested, my board does not currentl;y boot at all, YMMV
---
arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi | 8
1 file changed, 8 deletions(-)
diff --git a/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
b/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
index 2d87bea933..fd87102c0b 100644
--- a/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
+++ b/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
@@ -20,14 +20,6 @@
rockchip,panel = <&edp_panel>;
};
-&i2c0 {
- u-boot,dm-pre-reloc;
-};
-
-&rk808 {
- u-boot,dm-pre-reloc;
-};
-
&sdhci {
max-frequency = <2500>;
u-boot,dm-pre-reloc;
Re: [PATCH] rockchip: Pinebook Pro: Do not initialize i2c before relocation
Hi Tom,
On 2022/12/6 06:25, Tom Rini wrote:
On Mon, Dec 05, 2022 at 09:35:41PM +, Peter Robinson wrote:
On Sat, Dec 3, 2022 at 12:31 PM Michal Suchanek wrote:
The i2c locks up when initialized before relocation, and it stays broken
in Linux as well breaking the ability to boot Linux.
The i2c bus and pmic was not actually used in pre-reloc before
commit ad607512f575 ("power: pmic: rk8xx: Support sysreset shutdown method")
The cause is not known.
This is board-specific, other boards that do not add the option to
include the i2c bus in pre-reloc DT are not affected.
Signed-off-by: Michal Suchanek
Reviewed-by: Peter Robinson
Tested-by: Peter Robinson
Thanks for checking this out, I had noticed a regression and had got
as far as bisecting it but not getting to a fix.
Tom: can we get this pulled into 2023.01 please?
Probably should be, yes. Kever, are there any other rockchip must-fixes
for v2023.01? I can take this directly if you don't have others and/or
don't want to make up a PR, thanks!
I will take these fixes, and send a PR to you later.
Thanks,
- Kever
Re: [PATCH] rockchip: Pinebook Pro: Do not initialize i2c before relocation
Hi,
On Tue, 6 Dec 2022 at 11:25, Tom Rini wrote:
>
> On Mon, Dec 05, 2022 at 09:35:41PM +, Peter Robinson wrote:
> > On Sat, Dec 3, 2022 at 12:31 PM Michal Suchanek wrote:
> > >
> > > The i2c locks up when initialized before relocation, and it stays broken
> > > in Linux as well breaking the ability to boot Linux.
> > >
> > > The i2c bus and pmic was not actually used in pre-reloc before
> > > commit ad607512f575 ("power: pmic: rk8xx: Support sysreset shutdown
> > > method")
> > >
> > > The cause is not known.
> > >
> > > This is board-specific, other boards that do not add the option to
> > > include the i2c bus in pre-reloc DT are not affected.
> > >
> > > Signed-off-by: Michal Suchanek
> >
> > Reviewed-by: Peter Robinson
> > Tested-by: Peter Robinson
> >
> > Thanks for checking this out, I had noticed a regression and had got
> > as far as bisecting it but not getting to a fix.
> >
> > Tom: can we get this pulled into 2023.01 please?
>
> Probably should be, yes. Kever, are there any other rockchip must-fixes
> for v2023.01? I can take this directly if you don't have others and/or
> don't want to make up a PR, thanks!
There is also this one:
https://patchwork.ozlabs.org/project/uboot/patch/20220928024046.2657593-1-...@chromium.org/
Regards,
Simon
Re: [PATCH] rockchip: Pinebook Pro: Do not initialize i2c before relocation
On Mon, Dec 05, 2022 at 09:35:41PM +, Peter Robinson wrote:
> On Sat, Dec 3, 2022 at 12:31 PM Michal Suchanek wrote:
> >
> > The i2c locks up when initialized before relocation, and it stays broken
> > in Linux as well breaking the ability to boot Linux.
> >
> > The i2c bus and pmic was not actually used in pre-reloc before
> > commit ad607512f575 ("power: pmic: rk8xx: Support sysreset shutdown method")
> >
> > The cause is not known.
> >
> > This is board-specific, other boards that do not add the option to
> > include the i2c bus in pre-reloc DT are not affected.
> >
> > Signed-off-by: Michal Suchanek
>
> Reviewed-by: Peter Robinson
> Tested-by: Peter Robinson
>
> Thanks for checking this out, I had noticed a regression and had got
> as far as bisecting it but not getting to a fix.
>
> Tom: can we get this pulled into 2023.01 please?
Probably should be, yes. Kever, are there any other rockchip must-fixes
for v2023.01? I can take this directly if you don't have others and/or
don't want to make up a PR, thanks!
--
Tom
signature.asc
Description: PGP signature
Re: [PATCH] rockchip: Pinebook Pro: Do not initialize i2c before relocation
On Sat, Dec 3, 2022 at 12:31 PM Michal Suchanek wrote:
>
> The i2c locks up when initialized before relocation, and it stays broken
> in Linux as well breaking the ability to boot Linux.
>
> The i2c bus and pmic was not actually used in pre-reloc before
> commit ad607512f575 ("power: pmic: rk8xx: Support sysreset shutdown method")
>
> The cause is not known.
>
> This is board-specific, other boards that do not add the option to
> include the i2c bus in pre-reloc DT are not affected.
>
> Signed-off-by: Michal Suchanek
Reviewed-by: Peter Robinson
Tested-by: Peter Robinson
Thanks for checking this out, I had noticed a regression and had got
as far as bisecting it but not getting to a fix.
Tom: can we get this pulled into 2023.01 please?
Peter
> ---
>
> This is not tested, my board does not currentl;y boot at all, YMMV
> ---
> arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi | 8
> 1 file changed, 8 deletions(-)
>
> diff --git a/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
> b/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
> index 2d87bea933..fd87102c0b 100644
> --- a/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
> +++ b/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
> @@ -20,14 +20,6 @@
> rockchip,panel = <&edp_panel>;
> };
>
> -&i2c0 {
> - u-boot,dm-pre-reloc;
> -};
> -
> -&rk808 {
> - u-boot,dm-pre-reloc;
> -};
> -
> &sdhci {
> max-frequency = <2500>;
> u-boot,dm-pre-reloc;
> --
> 2.38.1
>
[PATCH] rockchip: Pinebook Pro: Do not initialize i2c before relocation
The i2c locks up when initialized before relocation, and it stays broken
in Linux as well breaking the ability to boot Linux.
The i2c bus and pmic was not actually used in pre-reloc before
commit ad607512f575 ("power: pmic: rk8xx: Support sysreset shutdown method")
The cause is not known.
This is board-specific, other boards that do not add the option to
include the i2c bus in pre-reloc DT are not affected.
Signed-off-by: Michal Suchanek
---
This is not tested, my board does not currentl;y boot at all, YMMV
---
arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi | 8
1 file changed, 8 deletions(-)
diff --git a/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
b/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
index 2d87bea933..fd87102c0b 100644
--- a/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
+++ b/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
@@ -20,14 +20,6 @@
rockchip,panel = <&edp_panel>;
};
-&i2c0 {
- u-boot,dm-pre-reloc;
-};
-
-&rk808 {
- u-boot,dm-pre-reloc;
-};
-
&sdhci {
max-frequency = <2500>;
u-boot,dm-pre-reloc;
--
2.38.1
