Re: [PATCH] setexpr: Silence some diagnostic messages

[Simon Glass]

On Thu, 24 Aug 2023 at 06:51, Łukasz Stelmach  wrote:
>
> Neither successful match nor lack thereof should be considered an
> extraordinary situation. Thus, neither require printing a message.
>
> Signed-off-by: Łukasz Stelmach 
> ---
>  cmd/setexpr.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>

Reviewed-by: Simon Glass 

[PATCH] setexpr: Silence some diagnostic messages

[Łukasz Stelmach]

Neither successful match nor lack thereof should be considered an
extraordinary situation. Thus, neither require printing a message.

Signed-off-by: Łukasz Stelmach 
---
 cmd/setexpr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/cmd/setexpr.c b/cmd/setexpr.c
index 4d671e7ef1..233471f6cb 100644
--- a/cmd/setexpr.c
+++ b/cmd/setexpr.c
@@ -215,7 +215,7 @@ int setexpr_regex_sub(char *data, uint data_size, char 
*nbuf, uint nbuf_size,
 
if (res == 0) {
if (loop == 0) {
-   printf("%s: No match\n", data);
+   debug("%s: No match\n", data);
return 1;
} else {
break;
@@ -359,7 +359,7 @@ static int regex_sub_var(const char *name, const char *r, 
const char *s,
if (ret)
return 1;
 
-   printf("%s=%s\n", name, data);
+   debug("%s=%s\n", name, data);
 
return env_set(name, data);
 }
-- 
2.39.2