Re: [PATCH] spl_imx_romapi: Remove extraneous character
On Thu, Apr 28, 2022 at 2:00 AM Peng Fan (OSS) wrote:
>
>
>
> On 2022/4/21 22:01, Fabio Estevam wrote:
> > From: Fabio Estevam
> >
> > Currently the following output is shown:
> > ...
> > Trying to boot from BOOTROM
> > Find img info 0x&48020a00, size 872
> > ...
> >
> > Remove the extraneous "&" character, so that the correct output
> > can be seen.
> >
> > Signed-off-by: Fabio Estevam
>
> Acked-by: Peng Fan
>
> > ---
> > arch/arm/mach-imx/spl_imx_romapi.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/mach-imx/spl_imx_romapi.c
> > b/arch/arm/mach-imx/spl_imx_romapi.c
> > index c47f5a6bdb44..2996d2761690 100644
> > --- a/arch/arm/mach-imx/spl_imx_romapi.c
> > +++ b/arch/arm/mach-imx/spl_imx_romapi.c
> > @@ -306,7 +306,7 @@ static int spl_romapi_load_image_stream(struct
> > spl_image_info *spl_image,
> > }
> >
> > imagesize = img_info_size(phdr);
> > - printf("Find img info 0x&%p, size %d\n", phdr, imagesize);
> > + printf("Find img info 0x%p, size %d\n", phdr, imagesize);
> >
> > if (p - phdr < imagesize) {
> > imagesize -= p - phdr;
> >
Stefano and Fabio,
This patch was ack'd but never seemed to make it into the imx tree and
I don't see it in Peng's queue on patchwork any more.
Now that the merge window is open, when are you planning on working
through the current imx patch queue? I believe there are several
patches that will need to be rebased due to collisions.
Best Regards,
Tim
Re: [PATCH] spl_imx_romapi: Remove extraneous character
On 2022/4/21 22:01, Fabio Estevam wrote:
From: Fabio Estevam
Currently the following output is shown:
...
Trying to boot from BOOTROM
Find img info 0x&48020a00, size 872
...
Remove the extraneous "&" character, so that the correct output
can be seen.
Signed-off-by: Fabio Estevam
Acked-by: Peng Fan
---
arch/arm/mach-imx/spl_imx_romapi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-imx/spl_imx_romapi.c
b/arch/arm/mach-imx/spl_imx_romapi.c
index c47f5a6bdb44..2996d2761690 100644
--- a/arch/arm/mach-imx/spl_imx_romapi.c
+++ b/arch/arm/mach-imx/spl_imx_romapi.c
@@ -306,7 +306,7 @@ static int spl_romapi_load_image_stream(struct
spl_image_info *spl_image,
}
imagesize = img_info_size(phdr);
- printf("Find img info 0x&%p, size %d\n", phdr, imagesize);
+ printf("Find img info 0x%p, size %d\n", phdr, imagesize);
if (p - phdr < imagesize) {
imagesize -= p - phdr;
Re: [PATCH] spl_imx_romapi: Remove extraneous character
On 4/21/22 16:01, Fabio Estevam wrote: From: Fabio Estevam Currently the following output is shown: ... Trying to boot from BOOTROM Find img info 0x&48020a00, size 872 ... Remove the extraneous "&" character, so that the correct output can be seen. Signed-off-by: Fabio Estevam Acked-by: Marek Vasut
[PATCH] spl_imx_romapi: Remove extraneous character
From: Fabio Estevam
Currently the following output is shown:
...
Trying to boot from BOOTROM
Find img info 0x&48020a00, size 872
...
Remove the extraneous "&" character, so that the correct output
can be seen.
Signed-off-by: Fabio Estevam
---
arch/arm/mach-imx/spl_imx_romapi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-imx/spl_imx_romapi.c
b/arch/arm/mach-imx/spl_imx_romapi.c
index c47f5a6bdb44..2996d2761690 100644
--- a/arch/arm/mach-imx/spl_imx_romapi.c
+++ b/arch/arm/mach-imx/spl_imx_romapi.c
@@ -306,7 +306,7 @@ static int spl_romapi_load_image_stream(struct
spl_image_info *spl_image,
}
imagesize = img_info_size(phdr);
- printf("Find img info 0x&%p, size %d\n", phdr, imagesize);
+ printf("Find img info 0x%p, size %d\n", phdr, imagesize);
if (p - phdr < imagesize) {
imagesize -= p - phdr;
--
2.25.1
