[PATCH] zfs: fix missing include for disk_partition definition
Commit 0528979fa7ab ("part: Drop disk_partition_t typedef") changed to a struct. As a result it uncovered an apparent missing include in zfs_common.h for part.h which actually contains the definition. The ZFS handles the struct exclusively as pointers so it was only a warning. warning: ‘struct disk_partition’ declared inside parameter list will not be visible outside of this definition or declaration void zfs_set_blk_dev(struct blk_desc *rbdd, struct disk_partition *info); Signed-off-by: Joel Johnson Series-CC: Simon Glass --- include/zfs_common.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/zfs_common.h b/include/zfs_common.h index 027ba91b28..cb83e59e83 100644 --- a/include/zfs_common.h +++ b/include/zfs_common.h @@ -22,6 +22,8 @@ #ifndef __ZFS_COMMON__ #define __ZFS_COMMON__ +#include + #define SECTOR_SIZE0x200 #define SECTOR_BITS9 -- 2.26.2
Re: [PATCH] zfs: fix missing include for disk_partition definition
On Fri, Jun 19, 2020 at 10:45:47PM -0600, Joel Johnson wrote: > Commit 0528979fa7ab ("part: Drop disk_partition_t typedef") changed to > a struct. As a result it uncovered an apparent missing include in > zfs_common.h for part.h which actually contains the definition. The ZFS > handles the struct exclusively as pointers so it was only a warning. > > warning: ‘struct disk_partition’ declared inside parameter list > will not be visible outside of this definition or declaration > void zfs_set_blk_dev(struct blk_desc *rbdd, struct disk_partition *info); > > Signed-off-by: Joel Johnson > > Series-CC: Simon Glass Applied (back on June 23rd) to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature