Re: [PATCH 00/11] Reduce usage of timestamp macros
On Fri, Sep 10, 2021 at 10:56:18PM +0200, Pali Rohár wrote: > On Wednesday 01 September 2021 23:49:57 Pali Rohár wrote: > > On Wednesday 01 September 2021 23:44:52 Pali Rohár wrote: > > > On Wednesday 01 September 2021 17:33:57 Tom Rini wrote: > > > > On Wed, Sep 01, 2021 at 11:28:54PM +0200, Pali Rohár wrote: > > > > > On Wednesday 01 September 2021 17:17:06 Tom Rini wrote: > > > > > > On Wed, Sep 01, 2021 at 11:05:45PM +0200, Pali Rohár wrote: > > > > > > > On Wednesday 01 September 2021 16:59:09 Tom Rini wrote: > > > > > > > > On Mon, Aug 02, 2021 at 03:18:27PM +0200, Pali Rohár wrote: > > > > > > > > > > > > > > > > > Including timestamp.h (either directly or transitionally) > > > > > > > > > cause build > > > > > > > > > system to recompile binaries at every 'make' run. This has > > > > > > > > > disadvantage > > > > > > > > > in U-Boot development as for every small change 'make' > > > > > > > > > recompiles lot of > > > > > > > > > other irrelevant files which were not touched / changed. > > > > > > > > > > > > > > > > > > This patch series eliminate transitional / indirect usage of > > > > > > > > > timestamp.h by removing unneeded inclusion of header files, > > > > > > > > > moving > > > > > > > > > timestamp values from macros to global variables, etc... > > > > > > > > > > > > > > > > > > After these patches, U-Boot tools are not recompiled by every > > > > > > > > > 'make' run, > > > > > > > > > which decrease time for incremental U-Boot recompilation. > > > > > > > > > > > > > > > > > > Please test these patches, specially m68k and powerpc parts > > > > > > > > > as I do not > > > > > > > > > have any of these boards. > > > > > > > > > > > > > > > > > > Patch series depend on this patch (now marked as accepted): > > > > > > > > > http://patchwork.ozlabs.org/project/uboot/patch/20210710111001.32325-1-p...@kernel.org/ > > > > > > > > > > > > > > > > > > Pali Rohár (11): > > > > > > > > > Remove #include from files which do not need > > > > > > > > > it > > > > > > > > > Remove #include from files which do not need it > > > > > > > > > efi_loader: Use directly version_string variable > > > > > > > > > version: Move version_string[] from version.h to > > > > > > > > > version_string.h > > > > > > > > > m68k: mcf: Remove overloading version_string > > > > > > > > > version: Put version_string[] variable into section > > > > > > > > > .text_version_string > > > > > > > > > powerpc: mpc: Put U-Boot version string at correct place by > > > > > > > > > linker > > > > > > > > > script > > > > > > > > > version: Do not make version_string[] variable as a weak > > > > > > > > > x86: quark: MRC: Remove U_BOOT_DATE and U_BOOT_TIME from > > > > > > > > > debug log > > > > > > > > > version: Remove global macro U_BOOT_VERSION_STRING from > > > > > > > > > version.h > > > > > > > > > Remove including timestamp.h in version.h > > > > > > > > > > > > > > > > So, looking at > > > > > > > > https://source.denx.de/u-boot/u-boot/-/pipelines/8948 > > > > > > > > this fails to build for at least qemu-ppce500 and xtfpga. Over > > > > > > > > in > > > > > > > > doc/develop/ci_testing.rst we document how to run a world > > > > > > > > build. Please > > > > > > > > fix these build errors and re-submit, thanks. > > > > > > > > > > > > > > Already happened about month ago > > > > > > > https://patchwork.ozlabs.org/project/uboot/patch/20210808112038.7942-1-p...@kernel.org/ > > > > > > > > > > > > > > As stated, following build command now passes: > > > > > > > make CROSS_COMPILE=powerpc-linux-gnu- MCR3000_defconfig u-boot.bin > > > > > > > > > > > > OK, I'll make sure to grab that. Note that xtfpga isn't PowerPC... > > > > > > > > > > I saw only error https://source.denx.de/u-boot/u-boot/-/jobs/316601 > > > > > and > > > > > this should be fixed above patch. At least I got similar error for > > > > > MCR3000_defconfig with new gcc before that. > > > > > > > > > > But now after scrolling down I see that second xtfpga error > > > > > https://source.denx.de/u-boot/u-boot/-/jobs/316614 > > > > > But seems that in this UI is error log truncated. I see only > > > > > > > > > > +xtensa-dc233c-elf-ld.bfd: section .text_version_string LMA > > > > > [fe021584,fe0215c7] overlaps section .u_boot_list LMA > > > > > [fe021584,fe021e6b] > > > > > > > > > > Is there a way how to show full build log? And which defconfig and > > > > > compiler is used? Because that error does not help me what is wrong > > > > > here... > > > > > > > > That's the full error log, from the linker, I believe. It's the xtfpga > > > > config for the xtensa architecture. It's one of the few that buildman > > > > won't fetch a good toolchain for so you'll want to look at > > > > tools/docker/Dockerfile and see we get it from > > > > https://github.com/foss-xtensa/toolchain/releases/download/2020.07/x86_64-2020.07-xtensa-dc233c-elf.tar.gz > > > > if you don't have the
Re: [PATCH 00/11] Reduce usage of timestamp macros
On Wednesday 01 September 2021 23:49:57 Pali Rohár wrote: > On Wednesday 01 September 2021 23:44:52 Pali Rohár wrote: > > On Wednesday 01 September 2021 17:33:57 Tom Rini wrote: > > > On Wed, Sep 01, 2021 at 11:28:54PM +0200, Pali Rohár wrote: > > > > On Wednesday 01 September 2021 17:17:06 Tom Rini wrote: > > > > > On Wed, Sep 01, 2021 at 11:05:45PM +0200, Pali Rohár wrote: > > > > > > On Wednesday 01 September 2021 16:59:09 Tom Rini wrote: > > > > > > > On Mon, Aug 02, 2021 at 03:18:27PM +0200, Pali Rohár wrote: > > > > > > > > > > > > > > > Including timestamp.h (either directly or transitionally) cause > > > > > > > > build > > > > > > > > system to recompile binaries at every 'make' run. This has > > > > > > > > disadvantage > > > > > > > > in U-Boot development as for every small change 'make' > > > > > > > > recompiles lot of > > > > > > > > other irrelevant files which were not touched / changed. > > > > > > > > > > > > > > > > This patch series eliminate transitional / indirect usage of > > > > > > > > timestamp.h by removing unneeded inclusion of header files, > > > > > > > > moving > > > > > > > > timestamp values from macros to global variables, etc... > > > > > > > > > > > > > > > > After these patches, U-Boot tools are not recompiled by every > > > > > > > > 'make' run, > > > > > > > > which decrease time for incremental U-Boot recompilation. > > > > > > > > > > > > > > > > Please test these patches, specially m68k and powerpc parts as > > > > > > > > I do not > > > > > > > > have any of these boards. > > > > > > > > > > > > > > > > Patch series depend on this patch (now marked as accepted): > > > > > > > > http://patchwork.ozlabs.org/project/uboot/patch/20210710111001.32325-1-p...@kernel.org/ > > > > > > > > > > > > > > > > Pali Rohár (11): > > > > > > > > Remove #include from files which do not need it > > > > > > > > Remove #include from files which do not need it > > > > > > > > efi_loader: Use directly version_string variable > > > > > > > > version: Move version_string[] from version.h to > > > > > > > > version_string.h > > > > > > > > m68k: mcf: Remove overloading version_string > > > > > > > > version: Put version_string[] variable into section > > > > > > > > .text_version_string > > > > > > > > powerpc: mpc: Put U-Boot version string at correct place by > > > > > > > > linker > > > > > > > > script > > > > > > > > version: Do not make version_string[] variable as a weak > > > > > > > > x86: quark: MRC: Remove U_BOOT_DATE and U_BOOT_TIME from > > > > > > > > debug log > > > > > > > > version: Remove global macro U_BOOT_VERSION_STRING from > > > > > > > > version.h > > > > > > > > Remove including timestamp.h in version.h > > > > > > > > > > > > > > So, looking at > > > > > > > https://source.denx.de/u-boot/u-boot/-/pipelines/8948 > > > > > > > this fails to build for at least qemu-ppce500 and xtfpga. Over > > > > > > > in > > > > > > > doc/develop/ci_testing.rst we document how to run a world build. > > > > > > > Please > > > > > > > fix these build errors and re-submit, thanks. > > > > > > > > > > > > Already happened about month ago > > > > > > https://patchwork.ozlabs.org/project/uboot/patch/20210808112038.7942-1-p...@kernel.org/ > > > > > > > > > > > > As stated, following build command now passes: > > > > > > make CROSS_COMPILE=powerpc-linux-gnu- MCR3000_defconfig u-boot.bin > > > > > > > > > > OK, I'll make sure to grab that. Note that xtfpga isn't PowerPC... > > > > > > > > I saw only error https://source.denx.de/u-boot/u-boot/-/jobs/316601 and > > > > this should be fixed above patch. At least I got similar error for > > > > MCR3000_defconfig with new gcc before that. > > > > > > > > But now after scrolling down I see that second xtfpga error > > > > https://source.denx.de/u-boot/u-boot/-/jobs/316614 > > > > But seems that in this UI is error log truncated. I see only > > > > > > > > +xtensa-dc233c-elf-ld.bfd: section .text_version_string LMA > > > > [fe021584,fe0215c7] overlaps section .u_boot_list LMA > > > > [fe021584,fe021e6b] > > > > > > > > Is there a way how to show full build log? And which defconfig and > > > > compiler is used? Because that error does not help me what is wrong > > > > here... > > > > > > That's the full error log, from the linker, I believe. It's the xtfpga > > > config for the xtensa architecture. It's one of the few that buildman > > > won't fetch a good toolchain for so you'll want to look at > > > tools/docker/Dockerfile and see we get it from > > > https://github.com/foss-xtensa/toolchain/releases/download/2020.07/x86_64-2020.07-xtensa-dc233c-elf.tar.gz > > > if you don't have the CI builder container itself handy already. > > > > So this is the only other build which failed, right? I suspect that > > there is some other bug in xtfpga linker script, that it missed > > specifying wildcard sections and this change triggered it. > > > > I will tr
Re: [PATCH 00/11] Reduce usage of timestamp macros
On Wed, Sep 01, 2021 at 11:44:52PM +0200, Pali Rohár wrote: > On Wednesday 01 September 2021 17:33:57 Tom Rini wrote: > > On Wed, Sep 01, 2021 at 11:28:54PM +0200, Pali Rohár wrote: > > > On Wednesday 01 September 2021 17:17:06 Tom Rini wrote: > > > > On Wed, Sep 01, 2021 at 11:05:45PM +0200, Pali Rohár wrote: > > > > > On Wednesday 01 September 2021 16:59:09 Tom Rini wrote: > > > > > > On Mon, Aug 02, 2021 at 03:18:27PM +0200, Pali Rohár wrote: > > > > > > > > > > > > > Including timestamp.h (either directly or transitionally) cause > > > > > > > build > > > > > > > system to recompile binaries at every 'make' run. This has > > > > > > > disadvantage > > > > > > > in U-Boot development as for every small change 'make' recompiles > > > > > > > lot of > > > > > > > other irrelevant files which were not touched / changed. > > > > > > > > > > > > > > This patch series eliminate transitional / indirect usage of > > > > > > > timestamp.h by removing unneeded inclusion of header files, moving > > > > > > > timestamp values from macros to global variables, etc... > > > > > > > > > > > > > > After these patches, U-Boot tools are not recompiled by every > > > > > > > 'make' run, > > > > > > > which decrease time for incremental U-Boot recompilation. > > > > > > > > > > > > > > Please test these patches, specially m68k and powerpc parts as I > > > > > > > do not > > > > > > > have any of these boards. > > > > > > > > > > > > > > Patch series depend on this patch (now marked as accepted): > > > > > > > http://patchwork.ozlabs.org/project/uboot/patch/20210710111001.32325-1-p...@kernel.org/ > > > > > > > > > > > > > > Pali Rohár (11): > > > > > > > Remove #include from files which do not need it > > > > > > > Remove #include from files which do not need it > > > > > > > efi_loader: Use directly version_string variable > > > > > > > version: Move version_string[] from version.h to > > > > > > > version_string.h > > > > > > > m68k: mcf: Remove overloading version_string > > > > > > > version: Put version_string[] variable into section > > > > > > > .text_version_string > > > > > > > powerpc: mpc: Put U-Boot version string at correct place by > > > > > > > linker > > > > > > > script > > > > > > > version: Do not make version_string[] variable as a weak > > > > > > > x86: quark: MRC: Remove U_BOOT_DATE and U_BOOT_TIME from debug > > > > > > > log > > > > > > > version: Remove global macro U_BOOT_VERSION_STRING from > > > > > > > version.h > > > > > > > Remove including timestamp.h in version.h > > > > > > > > > > > > So, looking at https://source.denx.de/u-boot/u-boot/-/pipelines/8948 > > > > > > this fails to build for at least qemu-ppce500 and xtfpga. Over in > > > > > > doc/develop/ci_testing.rst we document how to run a world build. > > > > > > Please > > > > > > fix these build errors and re-submit, thanks. > > > > > > > > > > Already happened about month ago > > > > > https://patchwork.ozlabs.org/project/uboot/patch/20210808112038.7942-1-p...@kernel.org/ > > > > > > > > > > As stated, following build command now passes: > > > > > make CROSS_COMPILE=powerpc-linux-gnu- MCR3000_defconfig u-boot.bin > > > > > > > > OK, I'll make sure to grab that. Note that xtfpga isn't PowerPC... > > > > > > I saw only error https://source.denx.de/u-boot/u-boot/-/jobs/316601 and > > > this should be fixed above patch. At least I got similar error for > > > MCR3000_defconfig with new gcc before that. > > > > > > But now after scrolling down I see that second xtfpga error > > > https://source.denx.de/u-boot/u-boot/-/jobs/316614 > > > But seems that in this UI is error log truncated. I see only > > > > > > +xtensa-dc233c-elf-ld.bfd: section .text_version_string LMA > > > [fe021584,fe0215c7] overlaps section .u_boot_list LMA > > > [fe021584,fe021e6b] > > > > > > Is there a way how to show full build log? And which defconfig and > > > compiler is used? Because that error does not help me what is wrong > > > here... > > > > That's the full error log, from the linker, I believe. It's the xtfpga > > config for the xtensa architecture. It's one of the few that buildman > > won't fetch a good toolchain for so you'll want to look at > > tools/docker/Dockerfile and see we get it from > > https://github.com/foss-xtensa/toolchain/releases/download/2020.07/x86_64-2020.07-xtensa-dc233c-elf.tar.gz > > if you don't have the CI builder container itself handy already. > > So this is the only other build which failed, right? I suspect that I don't know. The GitLab job is configured in three stages so if something early fails we don't wait forever to fail. The Azure job is over at https://dev.azure.com/u-boot/u-boot/_build/results?buildId=2792&view=results and hasn't completed but doesn't look like it's showing anything you haven't already fixed. > there is some other bug in xtfpga linker script, that it missed > specifying wildcard sections and this change
Re: [PATCH 00/11] Reduce usage of timestamp macros
On Wednesday 01 September 2021 23:44:52 Pali Rohár wrote: > On Wednesday 01 September 2021 17:33:57 Tom Rini wrote: > > On Wed, Sep 01, 2021 at 11:28:54PM +0200, Pali Rohár wrote: > > > On Wednesday 01 September 2021 17:17:06 Tom Rini wrote: > > > > On Wed, Sep 01, 2021 at 11:05:45PM +0200, Pali Rohár wrote: > > > > > On Wednesday 01 September 2021 16:59:09 Tom Rini wrote: > > > > > > On Mon, Aug 02, 2021 at 03:18:27PM +0200, Pali Rohár wrote: > > > > > > > > > > > > > Including timestamp.h (either directly or transitionally) cause > > > > > > > build > > > > > > > system to recompile binaries at every 'make' run. This has > > > > > > > disadvantage > > > > > > > in U-Boot development as for every small change 'make' recompiles > > > > > > > lot of > > > > > > > other irrelevant files which were not touched / changed. > > > > > > > > > > > > > > This patch series eliminate transitional / indirect usage of > > > > > > > timestamp.h by removing unneeded inclusion of header files, moving > > > > > > > timestamp values from macros to global variables, etc... > > > > > > > > > > > > > > After these patches, U-Boot tools are not recompiled by every > > > > > > > 'make' run, > > > > > > > which decrease time for incremental U-Boot recompilation. > > > > > > > > > > > > > > Please test these patches, specially m68k and powerpc parts as I > > > > > > > do not > > > > > > > have any of these boards. > > > > > > > > > > > > > > Patch series depend on this patch (now marked as accepted): > > > > > > > http://patchwork.ozlabs.org/project/uboot/patch/20210710111001.32325-1-p...@kernel.org/ > > > > > > > > > > > > > > Pali Rohár (11): > > > > > > > Remove #include from files which do not need it > > > > > > > Remove #include from files which do not need it > > > > > > > efi_loader: Use directly version_string variable > > > > > > > version: Move version_string[] from version.h to > > > > > > > version_string.h > > > > > > > m68k: mcf: Remove overloading version_string > > > > > > > version: Put version_string[] variable into section > > > > > > > .text_version_string > > > > > > > powerpc: mpc: Put U-Boot version string at correct place by > > > > > > > linker > > > > > > > script > > > > > > > version: Do not make version_string[] variable as a weak > > > > > > > x86: quark: MRC: Remove U_BOOT_DATE and U_BOOT_TIME from debug > > > > > > > log > > > > > > > version: Remove global macro U_BOOT_VERSION_STRING from > > > > > > > version.h > > > > > > > Remove including timestamp.h in version.h > > > > > > > > > > > > So, looking at https://source.denx.de/u-boot/u-boot/-/pipelines/8948 > > > > > > this fails to build for at least qemu-ppce500 and xtfpga. Over in > > > > > > doc/develop/ci_testing.rst we document how to run a world build. > > > > > > Please > > > > > > fix these build errors and re-submit, thanks. > > > > > > > > > > Already happened about month ago > > > > > https://patchwork.ozlabs.org/project/uboot/patch/20210808112038.7942-1-p...@kernel.org/ > > > > > > > > > > As stated, following build command now passes: > > > > > make CROSS_COMPILE=powerpc-linux-gnu- MCR3000_defconfig u-boot.bin > > > > > > > > OK, I'll make sure to grab that. Note that xtfpga isn't PowerPC... > > > > > > I saw only error https://source.denx.de/u-boot/u-boot/-/jobs/316601 and > > > this should be fixed above patch. At least I got similar error for > > > MCR3000_defconfig with new gcc before that. > > > > > > But now after scrolling down I see that second xtfpga error > > > https://source.denx.de/u-boot/u-boot/-/jobs/316614 > > > But seems that in this UI is error log truncated. I see only > > > > > > +xtensa-dc233c-elf-ld.bfd: section .text_version_string LMA > > > [fe021584,fe0215c7] overlaps section .u_boot_list LMA > > > [fe021584,fe021e6b] > > > > > > Is there a way how to show full build log? And which defconfig and > > > compiler is used? Because that error does not help me what is wrong > > > here... > > > > That's the full error log, from the linker, I believe. It's the xtfpga > > config for the xtensa architecture. It's one of the few that buildman > > won't fetch a good toolchain for so you'll want to look at > > tools/docker/Dockerfile and see we get it from > > https://github.com/foss-xtensa/toolchain/releases/download/2020.07/x86_64-2020.07-xtensa-dc233c-elf.tar.gz > > if you don't have the CI builder container itself handy already. > > So this is the only other build which failed, right? I suspect that > there is some other bug in xtfpga linker script, that it missed > specifying wildcard sections and this change triggered it. > > I will try to look at it. Just a quick look... https://source.denx.de/u-boot/u-boot/-/blob/master/arch/xtensa/cpu/u-boot.lds#L78 Probably it is needed to specify .text_version_string section here, like is specified .text section there. > It is pity that in above gitlab build log is missing full
Re: [PATCH 00/11] Reduce usage of timestamp macros
On Wednesday 01 September 2021 17:33:57 Tom Rini wrote: > On Wed, Sep 01, 2021 at 11:28:54PM +0200, Pali Rohár wrote: > > On Wednesday 01 September 2021 17:17:06 Tom Rini wrote: > > > On Wed, Sep 01, 2021 at 11:05:45PM +0200, Pali Rohár wrote: > > > > On Wednesday 01 September 2021 16:59:09 Tom Rini wrote: > > > > > On Mon, Aug 02, 2021 at 03:18:27PM +0200, Pali Rohár wrote: > > > > > > > > > > > Including timestamp.h (either directly or transitionally) cause > > > > > > build > > > > > > system to recompile binaries at every 'make' run. This has > > > > > > disadvantage > > > > > > in U-Boot development as for every small change 'make' recompiles > > > > > > lot of > > > > > > other irrelevant files which were not touched / changed. > > > > > > > > > > > > This patch series eliminate transitional / indirect usage of > > > > > > timestamp.h by removing unneeded inclusion of header files, moving > > > > > > timestamp values from macros to global variables, etc... > > > > > > > > > > > > After these patches, U-Boot tools are not recompiled by every > > > > > > 'make' run, > > > > > > which decrease time for incremental U-Boot recompilation. > > > > > > > > > > > > Please test these patches, specially m68k and powerpc parts as I do > > > > > > not > > > > > > have any of these boards. > > > > > > > > > > > > Patch series depend on this patch (now marked as accepted): > > > > > > http://patchwork.ozlabs.org/project/uboot/patch/20210710111001.32325-1-p...@kernel.org/ > > > > > > > > > > > > Pali Rohár (11): > > > > > > Remove #include from files which do not need it > > > > > > Remove #include from files which do not need it > > > > > > efi_loader: Use directly version_string variable > > > > > > version: Move version_string[] from version.h to version_string.h > > > > > > m68k: mcf: Remove overloading version_string > > > > > > version: Put version_string[] variable into section > > > > > > .text_version_string > > > > > > powerpc: mpc: Put U-Boot version string at correct place by linker > > > > > > script > > > > > > version: Do not make version_string[] variable as a weak > > > > > > x86: quark: MRC: Remove U_BOOT_DATE and U_BOOT_TIME from debug log > > > > > > version: Remove global macro U_BOOT_VERSION_STRING from version.h > > > > > > Remove including timestamp.h in version.h > > > > > > > > > > So, looking at https://source.denx.de/u-boot/u-boot/-/pipelines/8948 > > > > > this fails to build for at least qemu-ppce500 and xtfpga. Over in > > > > > doc/develop/ci_testing.rst we document how to run a world build. > > > > > Please > > > > > fix these build errors and re-submit, thanks. > > > > > > > > Already happened about month ago > > > > https://patchwork.ozlabs.org/project/uboot/patch/20210808112038.7942-1-p...@kernel.org/ > > > > > > > > As stated, following build command now passes: > > > > make CROSS_COMPILE=powerpc-linux-gnu- MCR3000_defconfig u-boot.bin > > > > > > OK, I'll make sure to grab that. Note that xtfpga isn't PowerPC... > > > > I saw only error https://source.denx.de/u-boot/u-boot/-/jobs/316601 and > > this should be fixed above patch. At least I got similar error for > > MCR3000_defconfig with new gcc before that. > > > > But now after scrolling down I see that second xtfpga error > > https://source.denx.de/u-boot/u-boot/-/jobs/316614 > > But seems that in this UI is error log truncated. I see only > > > > +xtensa-dc233c-elf-ld.bfd: section .text_version_string LMA > > [fe021584,fe0215c7] overlaps section .u_boot_list LMA > > [fe021584,fe021e6b] > > > > Is there a way how to show full build log? And which defconfig and > > compiler is used? Because that error does not help me what is wrong > > here... > > That's the full error log, from the linker, I believe. It's the xtfpga > config for the xtensa architecture. It's one of the few that buildman > won't fetch a good toolchain for so you'll want to look at > tools/docker/Dockerfile and see we get it from > https://github.com/foss-xtensa/toolchain/releases/download/2020.07/x86_64-2020.07-xtensa-dc233c-elf.tar.gz > if you don't have the CI builder container itself handy already. So this is the only other build which failed, right? I suspect that there is some other bug in xtfpga linker script, that it missed specifying wildcard sections and this change triggered it. I will try to look at it. It is pity that in above gitlab build log is missing full command which produced that error as in its arguments could be something interesting, like path to linker script or compile flags...
Re: [PATCH 00/11] Reduce usage of timestamp macros
On Wed, Sep 01, 2021 at 11:28:54PM +0200, Pali Rohár wrote: > On Wednesday 01 September 2021 17:17:06 Tom Rini wrote: > > On Wed, Sep 01, 2021 at 11:05:45PM +0200, Pali Rohár wrote: > > > On Wednesday 01 September 2021 16:59:09 Tom Rini wrote: > > > > On Mon, Aug 02, 2021 at 03:18:27PM +0200, Pali Rohár wrote: > > > > > > > > > Including timestamp.h (either directly or transitionally) cause build > > > > > system to recompile binaries at every 'make' run. This has > > > > > disadvantage > > > > > in U-Boot development as for every small change 'make' recompiles lot > > > > > of > > > > > other irrelevant files which were not touched / changed. > > > > > > > > > > This patch series eliminate transitional / indirect usage of > > > > > timestamp.h by removing unneeded inclusion of header files, moving > > > > > timestamp values from macros to global variables, etc... > > > > > > > > > > After these patches, U-Boot tools are not recompiled by every 'make' > > > > > run, > > > > > which decrease time for incremental U-Boot recompilation. > > > > > > > > > > Please test these patches, specially m68k and powerpc parts as I do > > > > > not > > > > > have any of these boards. > > > > > > > > > > Patch series depend on this patch (now marked as accepted): > > > > > http://patchwork.ozlabs.org/project/uboot/patch/20210710111001.32325-1-p...@kernel.org/ > > > > > > > > > > Pali Rohár (11): > > > > > Remove #include from files which do not need it > > > > > Remove #include from files which do not need it > > > > > efi_loader: Use directly version_string variable > > > > > version: Move version_string[] from version.h to version_string.h > > > > > m68k: mcf: Remove overloading version_string > > > > > version: Put version_string[] variable into section > > > > > .text_version_string > > > > > powerpc: mpc: Put U-Boot version string at correct place by linker > > > > > script > > > > > version: Do not make version_string[] variable as a weak > > > > > x86: quark: MRC: Remove U_BOOT_DATE and U_BOOT_TIME from debug log > > > > > version: Remove global macro U_BOOT_VERSION_STRING from version.h > > > > > Remove including timestamp.h in version.h > > > > > > > > So, looking at https://source.denx.de/u-boot/u-boot/-/pipelines/8948 > > > > this fails to build for at least qemu-ppce500 and xtfpga. Over in > > > > doc/develop/ci_testing.rst we document how to run a world build. Please > > > > fix these build errors and re-submit, thanks. > > > > > > Already happened about month ago > > > https://patchwork.ozlabs.org/project/uboot/patch/20210808112038.7942-1-p...@kernel.org/ > > > > > > As stated, following build command now passes: > > > make CROSS_COMPILE=powerpc-linux-gnu- MCR3000_defconfig u-boot.bin > > > > OK, I'll make sure to grab that. Note that xtfpga isn't PowerPC... > > I saw only error https://source.denx.de/u-boot/u-boot/-/jobs/316601 and > this should be fixed above patch. At least I got similar error for > MCR3000_defconfig with new gcc before that. > > But now after scrolling down I see that second xtfpga error > https://source.denx.de/u-boot/u-boot/-/jobs/316614 > But seems that in this UI is error log truncated. I see only > > +xtensa-dc233c-elf-ld.bfd: section .text_version_string LMA > [fe021584,fe0215c7] overlaps section .u_boot_list LMA > [fe021584,fe021e6b] > > Is there a way how to show full build log? And which defconfig and > compiler is used? Because that error does not help me what is wrong > here... That's the full error log, from the linker, I believe. It's the xtfpga config for the xtensa architecture. It's one of the few that buildman won't fetch a good toolchain for so you'll want to look at tools/docker/Dockerfile and see we get it from https://github.com/foss-xtensa/toolchain/releases/download/2020.07/x86_64-2020.07-xtensa-dc233c-elf.tar.gz if you don't have the CI builder container itself handy already. -- Tom signature.asc Description: PGP signature
Re: [PATCH 00/11] Reduce usage of timestamp macros
On Wednesday 01 September 2021 17:17:06 Tom Rini wrote: > On Wed, Sep 01, 2021 at 11:05:45PM +0200, Pali Rohár wrote: > > On Wednesday 01 September 2021 16:59:09 Tom Rini wrote: > > > On Mon, Aug 02, 2021 at 03:18:27PM +0200, Pali Rohár wrote: > > > > > > > Including timestamp.h (either directly or transitionally) cause build > > > > system to recompile binaries at every 'make' run. This has disadvantage > > > > in U-Boot development as for every small change 'make' recompiles lot of > > > > other irrelevant files which were not touched / changed. > > > > > > > > This patch series eliminate transitional / indirect usage of > > > > timestamp.h by removing unneeded inclusion of header files, moving > > > > timestamp values from macros to global variables, etc... > > > > > > > > After these patches, U-Boot tools are not recompiled by every 'make' > > > > run, > > > > which decrease time for incremental U-Boot recompilation. > > > > > > > > Please test these patches, specially m68k and powerpc parts as I do not > > > > have any of these boards. > > > > > > > > Patch series depend on this patch (now marked as accepted): > > > > http://patchwork.ozlabs.org/project/uboot/patch/20210710111001.32325-1-p...@kernel.org/ > > > > > > > > Pali Rohár (11): > > > > Remove #include from files which do not need it > > > > Remove #include from files which do not need it > > > > efi_loader: Use directly version_string variable > > > > version: Move version_string[] from version.h to version_string.h > > > > m68k: mcf: Remove overloading version_string > > > > version: Put version_string[] variable into section > > > > .text_version_string > > > > powerpc: mpc: Put U-Boot version string at correct place by linker > > > > script > > > > version: Do not make version_string[] variable as a weak > > > > x86: quark: MRC: Remove U_BOOT_DATE and U_BOOT_TIME from debug log > > > > version: Remove global macro U_BOOT_VERSION_STRING from version.h > > > > Remove including timestamp.h in version.h > > > > > > So, looking at https://source.denx.de/u-boot/u-boot/-/pipelines/8948 > > > this fails to build for at least qemu-ppce500 and xtfpga. Over in > > > doc/develop/ci_testing.rst we document how to run a world build. Please > > > fix these build errors and re-submit, thanks. > > > > Already happened about month ago > > https://patchwork.ozlabs.org/project/uboot/patch/20210808112038.7942-1-p...@kernel.org/ > > > > As stated, following build command now passes: > > make CROSS_COMPILE=powerpc-linux-gnu- MCR3000_defconfig u-boot.bin > > OK, I'll make sure to grab that. Note that xtfpga isn't PowerPC... I saw only error https://source.denx.de/u-boot/u-boot/-/jobs/316601 and this should be fixed above patch. At least I got similar error for MCR3000_defconfig with new gcc before that. But now after scrolling down I see that second xtfpga error https://source.denx.de/u-boot/u-boot/-/jobs/316614 But seems that in this UI is error log truncated. I see only +xtensa-dc233c-elf-ld.bfd: section .text_version_string LMA [fe021584,fe0215c7] overlaps section .u_boot_list LMA [fe021584,fe021e6b] Is there a way how to show full build log? And which defconfig and compiler is used? Because that error does not help me what is wrong here...
Re: [PATCH 00/11] Reduce usage of timestamp macros
On Wed, Sep 01, 2021 at 11:05:45PM +0200, Pali Rohár wrote: > On Wednesday 01 September 2021 16:59:09 Tom Rini wrote: > > On Mon, Aug 02, 2021 at 03:18:27PM +0200, Pali Rohár wrote: > > > > > Including timestamp.h (either directly or transitionally) cause build > > > system to recompile binaries at every 'make' run. This has disadvantage > > > in U-Boot development as for every small change 'make' recompiles lot of > > > other irrelevant files which were not touched / changed. > > > > > > This patch series eliminate transitional / indirect usage of > > > timestamp.h by removing unneeded inclusion of header files, moving > > > timestamp values from macros to global variables, etc... > > > > > > After these patches, U-Boot tools are not recompiled by every 'make' run, > > > which decrease time for incremental U-Boot recompilation. > > > > > > Please test these patches, specially m68k and powerpc parts as I do not > > > have any of these boards. > > > > > > Patch series depend on this patch (now marked as accepted): > > > http://patchwork.ozlabs.org/project/uboot/patch/20210710111001.32325-1-p...@kernel.org/ > > > > > > Pali Rohár (11): > > > Remove #include from files which do not need it > > > Remove #include from files which do not need it > > > efi_loader: Use directly version_string variable > > > version: Move version_string[] from version.h to version_string.h > > > m68k: mcf: Remove overloading version_string > > > version: Put version_string[] variable into section > > > .text_version_string > > > powerpc: mpc: Put U-Boot version string at correct place by linker > > > script > > > version: Do not make version_string[] variable as a weak > > > x86: quark: MRC: Remove U_BOOT_DATE and U_BOOT_TIME from debug log > > > version: Remove global macro U_BOOT_VERSION_STRING from version.h > > > Remove including timestamp.h in version.h > > > > So, looking at https://source.denx.de/u-boot/u-boot/-/pipelines/8948 > > this fails to build for at least qemu-ppce500 and xtfpga. Over in > > doc/develop/ci_testing.rst we document how to run a world build. Please > > fix these build errors and re-submit, thanks. > > Already happened about month ago > https://patchwork.ozlabs.org/project/uboot/patch/20210808112038.7942-1-p...@kernel.org/ > > As stated, following build command now passes: > make CROSS_COMPILE=powerpc-linux-gnu- MCR3000_defconfig u-boot.bin OK, I'll make sure to grab that. Note that xtfpga isn't PowerPC... -- Tom signature.asc Description: PGP signature
Re: [PATCH 00/11] Reduce usage of timestamp macros
On Wednesday 01 September 2021 16:59:09 Tom Rini wrote: > On Mon, Aug 02, 2021 at 03:18:27PM +0200, Pali Rohár wrote: > > > Including timestamp.h (either directly or transitionally) cause build > > system to recompile binaries at every 'make' run. This has disadvantage > > in U-Boot development as for every small change 'make' recompiles lot of > > other irrelevant files which were not touched / changed. > > > > This patch series eliminate transitional / indirect usage of > > timestamp.h by removing unneeded inclusion of header files, moving > > timestamp values from macros to global variables, etc... > > > > After these patches, U-Boot tools are not recompiled by every 'make' run, > > which decrease time for incremental U-Boot recompilation. > > > > Please test these patches, specially m68k and powerpc parts as I do not > > have any of these boards. > > > > Patch series depend on this patch (now marked as accepted): > > http://patchwork.ozlabs.org/project/uboot/patch/20210710111001.32325-1-p...@kernel.org/ > > > > Pali Rohár (11): > > Remove #include from files which do not need it > > Remove #include from files which do not need it > > efi_loader: Use directly version_string variable > > version: Move version_string[] from version.h to version_string.h > > m68k: mcf: Remove overloading version_string > > version: Put version_string[] variable into section > > .text_version_string > > powerpc: mpc: Put U-Boot version string at correct place by linker > > script > > version: Do not make version_string[] variable as a weak > > x86: quark: MRC: Remove U_BOOT_DATE and U_BOOT_TIME from debug log > > version: Remove global macro U_BOOT_VERSION_STRING from version.h > > Remove including timestamp.h in version.h > > So, looking at https://source.denx.de/u-boot/u-boot/-/pipelines/8948 > this fails to build for at least qemu-ppce500 and xtfpga. Over in > doc/develop/ci_testing.rst we document how to run a world build. Please > fix these build errors and re-submit, thanks. Already happened about month ago https://patchwork.ozlabs.org/project/uboot/patch/20210808112038.7942-1-p...@kernel.org/ As stated, following build command now passes: make CROSS_COMPILE=powerpc-linux-gnu- MCR3000_defconfig u-boot.bin
Re: [PATCH 00/11] Reduce usage of timestamp macros
On Mon, Aug 02, 2021 at 03:18:27PM +0200, Pali Rohár wrote: > Including timestamp.h (either directly or transitionally) cause build > system to recompile binaries at every 'make' run. This has disadvantage > in U-Boot development as for every small change 'make' recompiles lot of > other irrelevant files which were not touched / changed. > > This patch series eliminate transitional / indirect usage of > timestamp.h by removing unneeded inclusion of header files, moving > timestamp values from macros to global variables, etc... > > After these patches, U-Boot tools are not recompiled by every 'make' run, > which decrease time for incremental U-Boot recompilation. > > Please test these patches, specially m68k and powerpc parts as I do not > have any of these boards. > > Patch series depend on this patch (now marked as accepted): > http://patchwork.ozlabs.org/project/uboot/patch/20210710111001.32325-1-p...@kernel.org/ > > Pali Rohár (11): > Remove #include from files which do not need it > Remove #include from files which do not need it > efi_loader: Use directly version_string variable > version: Move version_string[] from version.h to version_string.h > m68k: mcf: Remove overloading version_string > version: Put version_string[] variable into section > .text_version_string > powerpc: mpc: Put U-Boot version string at correct place by linker > script > version: Do not make version_string[] variable as a weak > x86: quark: MRC: Remove U_BOOT_DATE and U_BOOT_TIME from debug log > version: Remove global macro U_BOOT_VERSION_STRING from version.h > Remove including timestamp.h in version.h So, looking at https://source.denx.de/u-boot/u-boot/-/pipelines/8948 this fails to build for at least qemu-ppce500 and xtfpga. Over in doc/develop/ci_testing.rst we document how to run a world build. Please fix these build errors and re-submit, thanks. -- Tom signature.asc Description: PGP signature
Re: [PATCH 00/11] Reduce usage of timestamp macros
On Tue, Aug 17, 2021 at 01:02:41PM +0200, Pali Rohár wrote: > On Monday 02 August 2021 15:18:27 Pali Rohár wrote: > > Including timestamp.h (either directly or transitionally) cause build > > system to recompile binaries at every 'make' run. This has disadvantage > > in U-Boot development as for every small change 'make' recompiles lot of > > other irrelevant files which were not touched / changed. > > > > This patch series eliminate transitional / indirect usage of > > timestamp.h by removing unneeded inclusion of header files, moving > > timestamp values from macros to global variables, etc... > > > > After these patches, U-Boot tools are not recompiled by every 'make' run, > > which decrease time for incremental U-Boot recompilation. > > > > Please test these patches, specially m68k and powerpc parts as I do not > > have any of these boards. > > > > Patch series depend on this patch (now marked as accepted): > > http://patchwork.ozlabs.org/project/uboot/patch/20210710111001.32325-1-p...@kernel.org/ > > Hello! Is there anything else needed for this patch series? This is likely going to wait for the next branch to open, thanks. -- Tom signature.asc Description: PGP signature
Re: [PATCH 00/11] Reduce usage of timestamp macros
On Monday 02 August 2021 15:18:27 Pali Rohár wrote: > Including timestamp.h (either directly or transitionally) cause build > system to recompile binaries at every 'make' run. This has disadvantage > in U-Boot development as for every small change 'make' recompiles lot of > other irrelevant files which were not touched / changed. > > This patch series eliminate transitional / indirect usage of > timestamp.h by removing unneeded inclusion of header files, moving > timestamp values from macros to global variables, etc... > > After these patches, U-Boot tools are not recompiled by every 'make' run, > which decrease time for incremental U-Boot recompilation. > > Please test these patches, specially m68k and powerpc parts as I do not > have any of these boards. > > Patch series depend on this patch (now marked as accepted): > http://patchwork.ozlabs.org/project/uboot/patch/20210710111001.32325-1-p...@kernel.org/ Hello! Is there anything else needed for this patch series? > Pali Rohár (11): > Remove #include from files which do not need it > Remove #include from files which do not need it > efi_loader: Use directly version_string variable > version: Move version_string[] from version.h to version_string.h > m68k: mcf: Remove overloading version_string > version: Put version_string[] variable into section > .text_version_string > powerpc: mpc: Put U-Boot version string at correct place by linker > script > version: Do not make version_string[] variable as a weak > x86: quark: MRC: Remove U_BOOT_DATE and U_BOOT_TIME from debug log > version: Remove global macro U_BOOT_VERSION_STRING from version.h > Remove including timestamp.h in version.h > > arch/arm/mach-rockchip/px30-board-tpl.c | 1 - > arch/arm/mach-rockchip/tpl.c | 4 > arch/m68k/cpu/mcf5227x/start.S| 6 -- > arch/m68k/cpu/mcf523x/start.S | 6 -- > arch/m68k/cpu/mcf52x2/start.S | 6 -- > arch/m68k/cpu/mcf530x/start.S | 8 --- > arch/m68k/cpu/mcf532x/start.S | 6 -- > arch/m68k/cpu/mcf5445x/start.S| 7 --- > arch/nios2/cpu/start.S| 1 - > arch/powerpc/cpu/mpc83xx/start.S | 10 +++-- > arch/powerpc/cpu/mpc83xx/u-boot.lds | 3 +++ > arch/powerpc/cpu/mpc85xx/start.S | 10 - > arch/powerpc/cpu/mpc85xx/u-boot-nand.lds | 4 > arch/powerpc/cpu/mpc85xx/u-boot-spl.lds | 4 > arch/powerpc/cpu/mpc85xx/u-boot.lds | 4 > arch/powerpc/cpu/mpc8xx/start.S | 9 > arch/x86/cpu/quark/mrc.c | 4 +--- > arch/x86/lib/acpi_table.c | 1 - > board/atmel/sama5d2_ptc_ek/sama5d2_ptc_ek.c | 1 - > board/cssi/MCR3000/u-boot.lds | 2 ++ > board/ge/b1x5v2/b1x5v2.c | 2 +- > board/ge/bx50v3/bx50v3.c | 2 +- > board/ge/mx53ppd/mx53ppd.c| 2 +- > board/l+g/vinco/vinco.c | 1 - > board/renesas/grpeach/lowlevel_init.S | 1 - > .../work_92105/work_92105_display.c | 1 + > cmd/version.c | 7 ++- > common/main.c | 2 +- > common/spl/spl.c | 4 > doc/develop/version.rst | 21 +++ > drivers/rtc/emul_rtc.c| 2 +- > drivers/usb/gadget/f_rockusb.c| 1 - > drivers/video/cfb_console.c | 3 +-- > include/configs/bcmstb.h | 1 - > include/version.h | 8 --- > include/version_string.h | 8 +++ > lib/display_options.c | 2 +- > lib/efi_loader/efi_tcg2.c | 7 +++ > net/cdp.c | 3 --- > test/print_ut.c | 2 +- > 40 files changed, 75 insertions(+), 102 deletions(-) > create mode 100644 include/version_string.h > > -- > 2.20.1 >
[PATCH 00/11] Reduce usage of timestamp macros
Including timestamp.h (either directly or transitionally) cause build system to recompile binaries at every 'make' run. This has disadvantage in U-Boot development as for every small change 'make' recompiles lot of other irrelevant files which were not touched / changed. This patch series eliminate transitional / indirect usage of timestamp.h by removing unneeded inclusion of header files, moving timestamp values from macros to global variables, etc... After these patches, U-Boot tools are not recompiled by every 'make' run, which decrease time for incremental U-Boot recompilation. Please test these patches, specially m68k and powerpc parts as I do not have any of these boards. Patch series depend on this patch (now marked as accepted): http://patchwork.ozlabs.org/project/uboot/patch/20210710111001.32325-1-p...@kernel.org/ Pali Rohár (11): Remove #include from files which do not need it Remove #include from files which do not need it efi_loader: Use directly version_string variable version: Move version_string[] from version.h to version_string.h m68k: mcf: Remove overloading version_string version: Put version_string[] variable into section .text_version_string powerpc: mpc: Put U-Boot version string at correct place by linker script version: Do not make version_string[] variable as a weak x86: quark: MRC: Remove U_BOOT_DATE and U_BOOT_TIME from debug log version: Remove global macro U_BOOT_VERSION_STRING from version.h Remove including timestamp.h in version.h arch/arm/mach-rockchip/px30-board-tpl.c | 1 - arch/arm/mach-rockchip/tpl.c | 4 arch/m68k/cpu/mcf5227x/start.S| 6 -- arch/m68k/cpu/mcf523x/start.S | 6 -- arch/m68k/cpu/mcf52x2/start.S | 6 -- arch/m68k/cpu/mcf530x/start.S | 8 --- arch/m68k/cpu/mcf532x/start.S | 6 -- arch/m68k/cpu/mcf5445x/start.S| 7 --- arch/nios2/cpu/start.S| 1 - arch/powerpc/cpu/mpc83xx/start.S | 10 +++-- arch/powerpc/cpu/mpc83xx/u-boot.lds | 3 +++ arch/powerpc/cpu/mpc85xx/start.S | 10 - arch/powerpc/cpu/mpc85xx/u-boot-nand.lds | 4 arch/powerpc/cpu/mpc85xx/u-boot-spl.lds | 4 arch/powerpc/cpu/mpc85xx/u-boot.lds | 4 arch/powerpc/cpu/mpc8xx/start.S | 9 arch/x86/cpu/quark/mrc.c | 4 +--- arch/x86/lib/acpi_table.c | 1 - board/atmel/sama5d2_ptc_ek/sama5d2_ptc_ek.c | 1 - board/cssi/MCR3000/u-boot.lds | 2 ++ board/ge/b1x5v2/b1x5v2.c | 2 +- board/ge/bx50v3/bx50v3.c | 2 +- board/ge/mx53ppd/mx53ppd.c| 2 +- board/l+g/vinco/vinco.c | 1 - board/renesas/grpeach/lowlevel_init.S | 1 - .../work_92105/work_92105_display.c | 1 + cmd/version.c | 7 ++- common/main.c | 2 +- common/spl/spl.c | 4 doc/develop/version.rst | 21 +++ drivers/rtc/emul_rtc.c| 2 +- drivers/usb/gadget/f_rockusb.c| 1 - drivers/video/cfb_console.c | 3 +-- include/configs/bcmstb.h | 1 - include/version.h | 8 --- include/version_string.h | 8 +++ lib/display_options.c | 2 +- lib/efi_loader/efi_tcg2.c | 7 +++ net/cdp.c | 3 --- test/print_ut.c | 2 +- 40 files changed, 75 insertions(+), 102 deletions(-) create mode 100644 include/version_string.h -- 2.20.1
