Re: [PATCH 02/17] usb: sandbox: Add DM_USB_GADGET support

[Mattijs Korpershoek]

On sam., août 19, 2023 at 16:23, Marek Vasut  wrote:

> Remove local usb_gadget_register_driver()/usb_gadget_unregister_driver()
> implementation which is implemented in udc-core.c instead if DM_USB_GADGET
> is enabled. Add no-op dm_usb_gadget_handle_interrupts() implementation.
>
> Signed-off-by: Marek Vasut 
> ---
> Cc: Angus Ainslie 
> Cc: Dmitrii Merkurev 
> Cc: Eddie Cai 
> Cc: Kever Yang 
> Cc: Lukasz Majewski 
> Cc: Miquel Raynal 
> Cc: Mattijs Korpershoek 
> Cc: Nishanth Menon 
> Cc: Patrice Chotard 
> Cc: Patrick Delaunay 
> Cc: Philipp Tomsich 
> Cc: Simon Glass 
> Cc: Stefan Roese 
> Cc: ker...@puri.sm
> ---
>  drivers/usb/host/usb-sandbox.c | 7 +++
>  1 file changed, 7 insertions(+)

Reviewed-by: Mattijs Korpershoek 

>
> diff --git a/drivers/usb/host/usb-sandbox.c b/drivers/usb/host/usb-sandbox.c
> index d1103dcb2e9..582f72d00c1 100644
> --- a/drivers/usb/host/usb-sandbox.c
> +++ b/drivers/usb/host/usb-sandbox.c
> @@ -124,6 +124,12 @@ static int sandbox_submit_int(struct udevice *bus, 
> struct usb_device *udev,
>   return ret;
>  }
>  
> +#if CONFIG_IS_ENABLED(DM_USB_GADGET)
> +int dm_usb_gadget_handle_interrupts(struct udevice *dev)
> +{
> + return 0;
> +}
> +#else
>  int usb_gadget_handle_interrupts(int index)
>  {
>   return 0;
> @@ -144,6 +150,7 @@ int usb_gadget_unregister_driver(struct usb_gadget_driver 
> *driver)
>  
>   return 0;
>  }
> +#endif
>  
>  static int sandbox_alloc_device(struct udevice *dev, struct usb_device *udev)
>  {
> -- 
> 2.40.1

Re: [PATCH 02/17] usb: sandbox: Add DM_USB_GADGET support

[Simon Glass]

On Sat, 19 Aug 2023 at 08:24, Marek Vasut  wrote:
>
> Remove local usb_gadget_register_driver()/usb_gadget_unregister_driver()
> implementation which is implemented in udc-core.c instead if DM_USB_GADGET
> is enabled. Add no-op dm_usb_gadget_handle_interrupts() implementation.
>
> Signed-off-by: Marek Vasut 
> ---
> Cc: Angus Ainslie 
> Cc: Dmitrii Merkurev 
> Cc: Eddie Cai 
> Cc: Kever Yang 
> Cc: Lukasz Majewski 
> Cc: Miquel Raynal 
> Cc: Mattijs Korpershoek 
> Cc: Nishanth Menon 
> Cc: Patrice Chotard 
> Cc: Patrick Delaunay 
> Cc: Philipp Tomsich 
> Cc: Simon Glass 
> Cc: Stefan Roese 
> Cc: ker...@puri.sm
> ---
>  drivers/usb/host/usb-sandbox.c | 7 +++
>  1 file changed, 7 insertions(+)

Reviewed-by: Simon Glass 

[PATCH 02/17] usb: sandbox: Add DM_USB_GADGET support

[Marek Vasut]

Remove local usb_gadget_register_driver()/usb_gadget_unregister_driver()
implementation which is implemented in udc-core.c instead if DM_USB_GADGET
is enabled. Add no-op dm_usb_gadget_handle_interrupts() implementation.

Signed-off-by: Marek Vasut 
---
Cc: Angus Ainslie 
Cc: Dmitrii Merkurev 
Cc: Eddie Cai 
Cc: Kever Yang 
Cc: Lukasz Majewski 
Cc: Miquel Raynal 
Cc: Mattijs Korpershoek 
Cc: Nishanth Menon 
Cc: Patrice Chotard 
Cc: Patrick Delaunay 
Cc: Philipp Tomsich 
Cc: Simon Glass 
Cc: Stefan Roese 
Cc: ker...@puri.sm
---
 drivers/usb/host/usb-sandbox.c | 7 +++
 1 file changed, 7 insertions(+)

diff --git a/drivers/usb/host/usb-sandbox.c b/drivers/usb/host/usb-sandbox.c
index d1103dcb2e9..582f72d00c1 100644
--- a/drivers/usb/host/usb-sandbox.c
+++ b/drivers/usb/host/usb-sandbox.c
@@ -124,6 +124,12 @@ static int sandbox_submit_int(struct udevice *bus, struct 
usb_device *udev,
return ret;
 }
 
+#if CONFIG_IS_ENABLED(DM_USB_GADGET)
+int dm_usb_gadget_handle_interrupts(struct udevice *dev)
+{
+   return 0;
+}
+#else
 int usb_gadget_handle_interrupts(int index)
 {
return 0;
@@ -144,6 +150,7 @@ int usb_gadget_unregister_driver(struct usb_gadget_driver 
*driver)
 
return 0;
 }
+#endif
 
 static int sandbox_alloc_device(struct udevice *dev, struct usb_device *udev)
 {
-- 
2.40.1