Re: [PATCH 02/27] imx: imx8ulp: include pcc/cgc header in clock header

2022-03-03 Thread Peng Fan (OSS) 




On 2022/2/26 21:34, Fabio Estevam wrote:

On Mon, Feb 14, 2022 at 9:08 AM Peng Fan (OSS)  wrote:


From: Peng Fan 

Only including clock.h could simplify header files.


Sorry, I don't understand this commit log.


Signed-off-by: Peng Fan 
---
  arch/arm/include/asm/arch-imx8ulp/clock.h | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/arch/arm/include/asm/arch-imx8ulp/clock.h 
b/arch/arm/include/asm/arch-imx8ulp/clock.h
index c0f32cc087..d7c92f7058 100644
--- a/arch/arm/include/asm/arch-imx8ulp/clock.h
+++ b/arch/arm/include/asm/arch-imx8ulp/clock.h
@@ -6,6 +6,9 @@
  #ifndef _ASM_ARCH_IMX8ULP_CLOCK_H
  #define _ASM_ARCH_IMX8ULP_CLOCK_H

+#include 
+#include 


Please explain why you need to include these two header files.


No need to include pcc/cgc header file both for users, only need
include clock.h

Thanks,
Peng.

Re: [PATCH 02/27] imx: imx8ulp: include pcc/cgc header in clock header

2022-02-26 Thread Fabio Estevam 
On Mon, Feb 14, 2022 at 9:08 AM Peng Fan (OSS)  wrote:
>
> From: Peng Fan 
>
> Only including clock.h could simplify header files.

Sorry, I don't understand this commit log.

> Signed-off-by: Peng Fan 
> ---
>  arch/arm/include/asm/arch-imx8ulp/clock.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/include/asm/arch-imx8ulp/clock.h 
> b/arch/arm/include/asm/arch-imx8ulp/clock.h
> index c0f32cc087..d7c92f7058 100644
> --- a/arch/arm/include/asm/arch-imx8ulp/clock.h
> +++ b/arch/arm/include/asm/arch-imx8ulp/clock.h
> @@ -6,6 +6,9 @@
>  #ifndef _ASM_ARCH_IMX8ULP_CLOCK_H
>  #define _ASM_ARCH_IMX8ULP_CLOCK_H
>
> +#include 
> +#include 

Please explain why you need to include these two header files.

[PATCH 02/27] imx: imx8ulp: include pcc/cgc header in clock header

2022-02-14 Thread Peng Fan (OSS) 
From: Peng Fan 

Only including clock.h could simplify header files.

Signed-off-by: Peng Fan 
---
 arch/arm/include/asm/arch-imx8ulp/clock.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/include/asm/arch-imx8ulp/clock.h 
b/arch/arm/include/asm/arch-imx8ulp/clock.h
index c0f32cc087..d7c92f7058 100644
--- a/arch/arm/include/asm/arch-imx8ulp/clock.h
+++ b/arch/arm/include/asm/arch-imx8ulp/clock.h
@@ -6,6 +6,9 @@
 #ifndef _ASM_ARCH_IMX8ULP_CLOCK_H
 #define _ASM_ARCH_IMX8ULP_CLOCK_H
 
+#include 
+#include 
+
 /* Mainly for compatible to imx common code. */
 enum mxc_clock {
MXC_ARM_CLK = 0,
-- 
2.30.0