Re: [PATCH 05/12] clk: clk-k3: Add support for J784S4 SoC

[Sean Anderson]

On 11/19/22 13:59, Hari Nagalla wrote:

Add support for J784S4 SoC.

Signed-off-by: Hari Nagalla 
Signed-off-by: Apurva Nandan 
---
  drivers/clk/ti/clk-k3.c | 6 ++
  include/k3-clk.h| 1 +
  2 files changed, 7 insertions(+)

diff --git a/drivers/clk/ti/clk-k3.c b/drivers/clk/ti/clk-k3.c
index 0dd65934b3..17e5b757f0 100644
--- a/drivers/clk/ti/clk-k3.c
+++ b/drivers/clk/ti/clk-k3.c
@@ -79,6 +79,12 @@ static const struct soc_attr ti_k3_soc_clk_data[] = {
.family = "AM62X",
.data = _clk_platdata,
},
+#endif
+#ifdef CONFIG_SOC_K3_J784S4
+   {
+   .family = "J784S4",
+   .data = _clk_platdata,


Please move the definition of this member from patch 3 to this patch. It
makes it easier to review.

--Sean


+   },
  #endif
{ /* sentinel */ }
  };
diff --git a/include/k3-clk.h b/include/k3-clk.h
index 371f077c44..42a0f25652 100644
--- a/include/k3-clk.h
+++ b/include/k3-clk.h
@@ -175,6 +175,7 @@ extern const struct ti_k3_clk_platdata j721e_clk_platdata;
  extern const struct ti_k3_clk_platdata j7200_clk_platdata;
  extern const struct ti_k3_clk_platdata j721s2_clk_platdata;
  extern const struct ti_k3_clk_platdata am62x_clk_platdata;
+extern const struct ti_k3_clk_platdata j784s4_clk_platdata;
  
  struct clk *clk_register_ti_pll(const char *name, const char *parent_name,

void __iomem *reg);

[PATCH 05/12] clk: clk-k3: Add support for J784S4 SoC

[Hari Nagalla]

Add support for J784S4 SoC.

Signed-off-by: Hari Nagalla 
Signed-off-by: Apurva Nandan 
---
 drivers/clk/ti/clk-k3.c | 6 ++
 include/k3-clk.h| 1 +
 2 files changed, 7 insertions(+)

diff --git a/drivers/clk/ti/clk-k3.c b/drivers/clk/ti/clk-k3.c
index 0dd65934b3..17e5b757f0 100644
--- a/drivers/clk/ti/clk-k3.c
+++ b/drivers/clk/ti/clk-k3.c
@@ -79,6 +79,12 @@ static const struct soc_attr ti_k3_soc_clk_data[] = {
.family = "AM62X",
.data = _clk_platdata,
},
+#endif
+#ifdef CONFIG_SOC_K3_J784S4
+   {
+   .family = "J784S4",
+   .data = _clk_platdata,
+   },
 #endif
{ /* sentinel */ }
 };
diff --git a/include/k3-clk.h b/include/k3-clk.h
index 371f077c44..42a0f25652 100644
--- a/include/k3-clk.h
+++ b/include/k3-clk.h
@@ -175,6 +175,7 @@ extern const struct ti_k3_clk_platdata j721e_clk_platdata;
 extern const struct ti_k3_clk_platdata j7200_clk_platdata;
 extern const struct ti_k3_clk_platdata j721s2_clk_platdata;
 extern const struct ti_k3_clk_platdata am62x_clk_platdata;
+extern const struct ti_k3_clk_platdata j784s4_clk_platdata;
 
 struct clk *clk_register_ti_pll(const char *name, const char *parent_name,
void __iomem *reg);
-- 
2.17.1