Re: [PATCH 06/10] fdtgrep: Simplify code to inverting the match

2024-01-01 Thread Simon Glass 
The code to invert the match in h_include() is a bit convoluted.
Simplify it by using disp->invert only once.

Signed-off-by: Simon Glass 
---

 tools/fdtgrep.c | 10 ++
 1 file changed, 2 insertions(+), 8 deletions(-)

Applied to u-boot-dm/next, thanks!

[PATCH 06/10] fdtgrep: Simplify code to inverting the match

2023-12-17 Thread Simon Glass 
The code to invert the match in h_include() is a bit convoluted.
Simplify it by using disp->invert only once.

Signed-off-by: Simon Glass 
---

 tools/fdtgrep.c | 10 ++
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/tools/fdtgrep.c b/tools/fdtgrep.c
index a6cdc326709d..b06a1a7a8384 100644
--- a/tools/fdtgrep.c
+++ b/tools/fdtgrep.c
@@ -634,14 +634,8 @@ static int h_include(void *priv, const void *fdt, int 
offset, int type,
inc = 0;
}
 
-   switch (inc) {
-   case 1:
-   inc = !disp->invert;
-   break;
-   case 0:
-   inc = disp->invert;
-   break;
-   }
+   if (inc != -1 && disp->invert)
+   inc = !inc;
debug("   - returning %d\n", inc);
 
return inc;
-- 
2.43.0.472.g3155946c3a-goog