Re: [PATCH 06/18] video: kconfig: Fix wrong text for the PCI default FB size

[Anatolij Gustschin]

On Sun, 23 Jul 2023 12:40:29 +0800
Bin Meng bm...@tinylab.org wrote:

> There is an example in the VIDEO_PCI_DEFAULT_FB_SIZE help text to
> tell people how to calculate its value but the resolution given
> does not match the value. Fix it.
> 
> Signed-off-by: Bin Meng 
> ---
> 
>  drivers/video/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

applied to u-boot-video/master, thanks!

--
Anatolij

Re: [PATCH 06/18] video: kconfig: Fix wrong text for the PCI default FB size

[Simon Glass]

On Sat, 22 Jul 2023 at 22:41, Bin Meng  wrote:
>
> There is an example in the VIDEO_PCI_DEFAULT_FB_SIZE help text to
> tell people how to calculate its value but the resolution given
> does not match the value. Fix it.
>
> Signed-off-by: Bin Meng 
> ---
>
>  drivers/video/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Simon Glass 

[PATCH 06/18] video: kconfig: Fix wrong text for the PCI default FB size

[Bin Meng]

There is an example in the VIDEO_PCI_DEFAULT_FB_SIZE help text to
tell people how to calculate its value but the resolution given
does not match the value. Fix it.

Signed-off-by: Bin Meng 
---

 drivers/video/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 3cdaa5ff27..43ec7e6695 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -77,7 +77,7 @@ config VIDEO_PCI_DEFAULT_FB_SIZE
  devices to have a framebuffer allocated by U-Boot.
 
  Note: the framebuffer needs to be large enough to store all pixels at
- maximum resolution. For example, at 1920 x 1200 with 32 bits per
+ maximum resolution. For example, at 2560 x 1600 with 32 bits per
  pixel, 2560 * 1600 * 32 / 8 = 0xfa bytes are needed.
 
 config VIDEO_COPY
@@ -1049,7 +1049,7 @@ config SPL_VIDEO_PCI_DEFAULT_FB_SIZE
  devices to have a framebuffer allocated by U-Boot.
 
  Note: the framebuffer needs to be large enough to store all pixels at
- maximum resolution. For example, at 1920 x 1200 with 32 bits per
+ maximum resolution. For example, at 2560 x 1600 with 32 bits per
  pixel, 2560 * 1600 * 32 / 8 = 0xfa bytes are needed.
 
 config SPL_CONSOLE_SCROLL_LINES
-- 
2.34.1