Re: [PATCH 1/1] dfu: add missing dependency for SPI flash DFU driver

[Mattijs Korpershoek]

Hi,

On Tue, 04 Jun 2024 07:44:25 +0200, Heinrich Schuchardt wrote:
> Building the SPI flash DFU driver fails if SPI flash support is missing.
> 
> drivers/dfu/dfu_sf.c:123:29: error:
> ‘CONFIG_SF_DEFAULT_MODE’ undeclared (first use in this function);
> 
> Add the missing dependency.
> 
> [...]

Thanks, Applied to https://source.denx.de/u-boot/custodians/u-boot-dfu 
(u-boot-dfu)

[1/1] dfu: add missing dependency for SPI flash DFU driver
  
https://source.denx.de/u-boot/custodians/u-boot-dfu/-/commit/4339138a2086f8449b9356130cb6e97a81aa8679

--
Mattijs

Re: [PATCH 1/1] dfu: add missing dependency for SPI flash DFU driver

[Mattijs Korpershoek]

Hi Heinrich,

Thank you for the patch.

On mar., juin 04, 2024 at 07:44, Heinrich Schuchardt 
 wrote:

> Building the SPI flash DFU driver fails if SPI flash support is missing.
>
> drivers/dfu/dfu_sf.c:123:29: error:
> ‘CONFIG_SF_DEFAULT_MODE’ undeclared (first use in this function);
>
> Add the missing dependency.
>
> Signed-off-by: Heinrich Schuchardt 

Reviewed-by: Mattijs Korpershoek 

> ---
>  drivers/dfu/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dfu/Kconfig b/drivers/dfu/Kconfig
> index 0360d9da142..971204758aa 100644
> --- a/drivers/dfu/Kconfig
> +++ b/drivers/dfu/Kconfig
> @@ -68,6 +68,7 @@ config DFU_RAM
>  
>  config DFU_SF
>   bool "SPI flash back end for DFU"
> + depends on SPI_FLASH || DM_SPI_FLASH
>   help
> This option enables using DFU to read and write to SPI flash based
> storage.
> -- 
> 2.43.0

[PATCH 1/1] dfu: add missing dependency for SPI flash DFU driver

[Heinrich Schuchardt]

Building the SPI flash DFU driver fails if SPI flash support is missing.

drivers/dfu/dfu_sf.c:123:29: error:
‘CONFIG_SF_DEFAULT_MODE’ undeclared (first use in this function);

Add the missing dependency.

Signed-off-by: Heinrich Schuchardt 
---
 drivers/dfu/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/dfu/Kconfig b/drivers/dfu/Kconfig
index 0360d9da142..971204758aa 100644
--- a/drivers/dfu/Kconfig
+++ b/drivers/dfu/Kconfig
@@ -68,6 +68,7 @@ config DFU_RAM
 
 config DFU_SF
bool "SPI flash back end for DFU"
+   depends on SPI_FLASH || DM_SPI_FLASH
help
  This option enables using DFU to read and write to SPI flash based
  storage.
-- 
2.43.0