Re: [PATCH 1/2] tee: optee: don't fail probe because of optee-rng
Hi, On 12/7/22 16:29, Etienne Carriere wrote: Fixes optee-rng driver bind sequence in optee driver to print a warning message but not report an error status when a optee-rng service driver fails to be bound as the optee driver itself is still fully functional. Signed-off-by: Etienne Carriere --- drivers/tee/optee/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c index 9240277579..604fd1414f 100644 --- a/drivers/tee/optee/core.c +++ b/drivers/tee/optee/core.c @@ -834,7 +834,7 @@ static int optee_probe(struct udevice *dev) */ ret = device_bind_driver(dev, "optee-rng", "optee-rng", NULL); if (ret) - return ret; + dev_warn(dev, "ftpm_tee failed to bind: %d\n", ret); } return 0; Reviewed-by: Patrick Delaunay Thanks Patrick
Re: [PATCH 1/2] tee: optee: don't fail probe because of optee-rng
On Wed, Dec 7, 2022 at 4:30 PM Etienne Carriere wrote: > > Fixes optee-rng driver bind sequence in optee driver to print a warning > message but not report an error status when a optee-rng service driver > fails to be bound as the optee driver itself is still fully functional. > > Signed-off-by: Etienne Carriere > --- > drivers/tee/optee/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Jens Wiklander Thanks, Jens > > diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c > index 9240277579..604fd1414f 100644 > --- a/drivers/tee/optee/core.c > +++ b/drivers/tee/optee/core.c > @@ -834,7 +834,7 @@ static int optee_probe(struct udevice *dev) > */ > ret = device_bind_driver(dev, "optee-rng", "optee-rng", NULL); > if (ret) > - return ret; > + dev_warn(dev, "ftpm_tee failed to bind: %d\n", ret); > } > > return 0; > -- > 2.25.1 >
Re: [PATCH 1/2] tee: optee: don't fail probe because of optee-rng
On Wed, Dec 07, 2022 at 04:29:59PM +0100, Etienne Carriere wrote: > Fixes optee-rng driver bind sequence in optee driver to print a warning > message but not report an error status when a optee-rng service driver > fails to be bound as the optee driver itself is still fully functional. > > Signed-off-by: Etienne Carriere > --- > drivers/tee/optee/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c > index 9240277579..604fd1414f 100644 > --- a/drivers/tee/optee/core.c > +++ b/drivers/tee/optee/core.c > @@ -834,7 +834,7 @@ static int optee_probe(struct udevice *dev) >*/ > ret = device_bind_driver(dev, "optee-rng", "optee-rng", NULL); > if (ret) > - return ret; > + dev_warn(dev, "ftpm_tee failed to bind: %d\n", ret); > } > > return 0; > -- > 2.25.1 > Reviewed-by: Ilias Apalodimas
[PATCH 1/2] tee: optee: don't fail probe because of optee-rng
Fixes optee-rng driver bind sequence in optee driver to print a warning message but not report an error status when a optee-rng service driver fails to be bound as the optee driver itself is still fully functional. Signed-off-by: Etienne Carriere --- drivers/tee/optee/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c index 9240277579..604fd1414f 100644 --- a/drivers/tee/optee/core.c +++ b/drivers/tee/optee/core.c @@ -834,7 +834,7 @@ static int optee_probe(struct udevice *dev) */ ret = device_bind_driver(dev, "optee-rng", "optee-rng", NULL); if (ret) - return ret; + dev_warn(dev, "ftpm_tee failed to bind: %d\n", ret); } return 0; -- 2.25.1
