Re: [PATCH 1/3] configs: stm32f746-disco: limit resolution to 480x272
On 8/20/23 18:24, Dario Binacchi wrote: > The patch fixes the y-resolution, which was causing the creation of a > framebuffer larger than actually needed, resulting in memory waste. > > Fixes: cc1b0e7b8e55b ("board: Add display to STM32F746 SoC discovery board") > Signed-off-by: Dario Binacchi > --- > > configs/stm32f746-disco_defconfig | 2 +- > configs/stm32f746-disco_spl_defconfig | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configs/stm32f746-disco_defconfig > b/configs/stm32f746-disco_defconfig > index bb98ee307a6e..8403679d7fa6 100644 > --- a/configs/stm32f746-disco_defconfig > +++ b/configs/stm32f746-disco_defconfig > @@ -59,7 +59,7 @@ CONFIG_VIDEO=y > CONFIG_BACKLIGHT_GPIO=y > CONFIG_VIDEO_STM32=y > CONFIG_VIDEO_STM32_MAX_XRES=480 > -CONFIG_VIDEO_STM32_MAX_YRES=640 > +CONFIG_VIDEO_STM32_MAX_YRES=272 > CONFIG_SPLASH_SCREEN=y > CONFIG_SPLASH_SCREEN_ALIGN=y > CONFIG_VIDEO_BMP_RLE8=y > diff --git a/configs/stm32f746-disco_spl_defconfig > b/configs/stm32f746-disco_spl_defconfig > index 84aaec1e3390..50c2a36784af 100644 > --- a/configs/stm32f746-disco_spl_defconfig > +++ b/configs/stm32f746-disco_spl_defconfig > @@ -85,7 +85,7 @@ CONFIG_VIDEO=y > CONFIG_BACKLIGHT_GPIO=y > CONFIG_VIDEO_STM32=y > CONFIG_VIDEO_STM32_MAX_XRES=480 > -CONFIG_VIDEO_STM32_MAX_YRES=640 > +CONFIG_VIDEO_STM32_MAX_YRES=272 > CONFIG_SPLASH_SCREEN=y > CONFIG_SPLASH_SCREEN_ALIGN=y > CONFIG_VIDEO_BMP_RLE8=y Apply on stm32/next Thanks Patrice
Re: [PATCH 1/3] configs: stm32f746-disco: limit resolution to 480x272
Hi, On 8/20/23 18:24, Dario Binacchi wrote: The patch fixes the y-resolution, which was causing the creation of a framebuffer larger than actually needed, resulting in memory waste. Fixes: cc1b0e7b8e55b ("board: Add display to STM32F746 SoC discovery board") Signed-off-by: Dario Binacchi --- configs/stm32f746-disco_defconfig | 2 +- configs/stm32f746-disco_spl_defconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configs/stm32f746-disco_defconfig b/configs/stm32f746-disco_defconfig index bb98ee307a6e..8403679d7fa6 100644 --- a/configs/stm32f746-disco_defconfig +++ b/configs/stm32f746-disco_defconfig @@ -59,7 +59,7 @@ CONFIG_VIDEO=y CONFIG_BACKLIGHT_GPIO=y CONFIG_VIDEO_STM32=y CONFIG_VIDEO_STM32_MAX_XRES=480 -CONFIG_VIDEO_STM32_MAX_YRES=640 +CONFIG_VIDEO_STM32_MAX_YRES=272 CONFIG_SPLASH_SCREEN=y CONFIG_SPLASH_SCREEN_ALIGN=y CONFIG_VIDEO_BMP_RLE8=y diff --git a/configs/stm32f746-disco_spl_defconfig b/configs/stm32f746-disco_spl_defconfig index 84aaec1e3390..50c2a36784af 100644 --- a/configs/stm32f746-disco_spl_defconfig +++ b/configs/stm32f746-disco_spl_defconfig @@ -85,7 +85,7 @@ CONFIG_VIDEO=y CONFIG_BACKLIGHT_GPIO=y CONFIG_VIDEO_STM32=y CONFIG_VIDEO_STM32_MAX_XRES=480 -CONFIG_VIDEO_STM32_MAX_YRES=640 +CONFIG_VIDEO_STM32_MAX_YRES=272 CONFIG_SPLASH_SCREEN=y CONFIG_SPLASH_SCREEN_ALIGN=y CONFIG_VIDEO_BMP_RLE8=y Reviewed-by: Patrick Delaunay Thanks Patrick
Re: [PATCH 1/3] configs: stm32f746-disco: limit resolution to 480x272
On 8/20/23 18:24, Dario Binacchi wrote: > The patch fixes the y-resolution, which was causing the creation of a > framebuffer larger than actually needed, resulting in memory waste. > > Fixes: cc1b0e7b8e55b ("board: Add display to STM32F746 SoC discovery board") > Signed-off-by: Dario Binacchi > --- > > configs/stm32f746-disco_defconfig | 2 +- > configs/stm32f746-disco_spl_defconfig | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configs/stm32f746-disco_defconfig > b/configs/stm32f746-disco_defconfig > index bb98ee307a6e..8403679d7fa6 100644 > --- a/configs/stm32f746-disco_defconfig > +++ b/configs/stm32f746-disco_defconfig > @@ -59,7 +59,7 @@ CONFIG_VIDEO=y > CONFIG_BACKLIGHT_GPIO=y > CONFIG_VIDEO_STM32=y > CONFIG_VIDEO_STM32_MAX_XRES=480 > -CONFIG_VIDEO_STM32_MAX_YRES=640 > +CONFIG_VIDEO_STM32_MAX_YRES=272 > CONFIG_SPLASH_SCREEN=y > CONFIG_SPLASH_SCREEN_ALIGN=y > CONFIG_VIDEO_BMP_RLE8=y > diff --git a/configs/stm32f746-disco_spl_defconfig > b/configs/stm32f746-disco_spl_defconfig > index 84aaec1e3390..50c2a36784af 100644 > --- a/configs/stm32f746-disco_spl_defconfig > +++ b/configs/stm32f746-disco_spl_defconfig > @@ -85,7 +85,7 @@ CONFIG_VIDEO=y > CONFIG_BACKLIGHT_GPIO=y > CONFIG_VIDEO_STM32=y > CONFIG_VIDEO_STM32_MAX_XRES=480 > -CONFIG_VIDEO_STM32_MAX_YRES=640 > +CONFIG_VIDEO_STM32_MAX_YRES=272 > CONFIG_SPLASH_SCREEN=y > CONFIG_SPLASH_SCREEN_ALIGN=y > CONFIG_VIDEO_BMP_RLE8=y Reviewed-by: Patrice Chotard Thanks Patrice
[PATCH 1/3] configs: stm32f746-disco: limit resolution to 480x272
The patch fixes the y-resolution, which was causing the creation of a framebuffer larger than actually needed, resulting in memory waste. Fixes: cc1b0e7b8e55b ("board: Add display to STM32F746 SoC discovery board") Signed-off-by: Dario Binacchi --- configs/stm32f746-disco_defconfig | 2 +- configs/stm32f746-disco_spl_defconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configs/stm32f746-disco_defconfig b/configs/stm32f746-disco_defconfig index bb98ee307a6e..8403679d7fa6 100644 --- a/configs/stm32f746-disco_defconfig +++ b/configs/stm32f746-disco_defconfig @@ -59,7 +59,7 @@ CONFIG_VIDEO=y CONFIG_BACKLIGHT_GPIO=y CONFIG_VIDEO_STM32=y CONFIG_VIDEO_STM32_MAX_XRES=480 -CONFIG_VIDEO_STM32_MAX_YRES=640 +CONFIG_VIDEO_STM32_MAX_YRES=272 CONFIG_SPLASH_SCREEN=y CONFIG_SPLASH_SCREEN_ALIGN=y CONFIG_VIDEO_BMP_RLE8=y diff --git a/configs/stm32f746-disco_spl_defconfig b/configs/stm32f746-disco_spl_defconfig index 84aaec1e3390..50c2a36784af 100644 --- a/configs/stm32f746-disco_spl_defconfig +++ b/configs/stm32f746-disco_spl_defconfig @@ -85,7 +85,7 @@ CONFIG_VIDEO=y CONFIG_BACKLIGHT_GPIO=y CONFIG_VIDEO_STM32=y CONFIG_VIDEO_STM32_MAX_XRES=480 -CONFIG_VIDEO_STM32_MAX_YRES=640 +CONFIG_VIDEO_STM32_MAX_YRES=272 CONFIG_SPLASH_SCREEN=y CONFIG_SPLASH_SCREEN_ALIGN=y CONFIG_VIDEO_BMP_RLE8=y -- 2.34.1