Re: [PATCH 1/5] smbios: correct definition of gd_smbios_start() macro

2023-12-26 Thread Simon Glass
Hi Heinrich,

On Sat, Dec 23, 2023 at 12:44 AM Heinrich Schuchardt  wrote:
>
> gd_smbios_start() currently points to a non-existent field.
> It should return the field written by gd_set_smbios_start().
>
> Fixes: 50834884a815 ("Record the position of the SMBIOS tables")
> Signed-off-by: Heinrich Schuchardt 
> ---
>  include/asm-generic/global_data.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

See:

https://patchwork.ozlabs.org/project/uboot/patch/20231015024511.3995580-5-...@chromium.org/

> diff --git a/include/asm-generic/global_data.h 
> b/include/asm-generic/global_data.h
> index e8c6412e3f..c1f7818817 100644
> --- a/include/asm-generic/global_data.h
> +++ b/include/asm-generic/global_data.h
> @@ -553,7 +553,7 @@ static_assert(sizeof(struct global_data) == GD_SIZE);
>  #endif
>
>  #ifdef CONFIG_SMBIOS
> -#define gd_smbios_start()  gd->smbios_start
> +#define gd_smbios_start()  gd->arch.smbios_start
>  #define gd_set_smbios_start(addr)  gd->arch.smbios_start = addr
>  #else
>  #define gd_smbios_start()  0UL
> --
> 2.43.0
>

Regards,
SImon


[PATCH 1/5] smbios: correct definition of gd_smbios_start() macro

2023-12-22 Thread Heinrich Schuchardt
gd_smbios_start() currently points to a non-existent field.
It should return the field written by gd_set_smbios_start().

Fixes: 50834884a815 ("Record the position of the SMBIOS tables")
Signed-off-by: Heinrich Schuchardt 
---
 include/asm-generic/global_data.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/asm-generic/global_data.h 
b/include/asm-generic/global_data.h
index e8c6412e3f..c1f7818817 100644
--- a/include/asm-generic/global_data.h
+++ b/include/asm-generic/global_data.h
@@ -553,7 +553,7 @@ static_assert(sizeof(struct global_data) == GD_SIZE);
 #endif

 #ifdef CONFIG_SMBIOS
-#define gd_smbios_start()  gd->smbios_start
+#define gd_smbios_start()  gd->arch.smbios_start
 #define gd_set_smbios_start(addr)  gd->arch.smbios_start = addr
 #else
 #define gd_smbios_start()  0UL
--
2.43.0