Re: [PATCH 1/7] board: rockchip: Add rk3588 evb board support

[Jagan Teki]

On Wed, 25 Jan 2023 at 21:14, "瘦橘猫" <19983723...@189.cn> wrote:
>
> Hi
>
> The board configuration file for the rk3588 evb does not contain atf, or even 
> tpl and spl. What I am going to do now is add some configuration items for 
> rk3588s based on rk3588, if successful, to verify that the ATF is available. 
> Thank  you for your comments

For your information, ATF can be part of rkbin and export BL31 in
u-boot in order to build as part of it. are you checking this step?

Jagan.

Re: [PATCH 1/7] board: rockchip: Add rk3588 evb board support

[Jagan Teki]

On Wed, 25 Jan 2023 at 00:47,  wrote:
>
> From: Joseph Chen 
>
> Add support for rk3588 evaluation board.
>
> Signed-off-by: Joseph Chen 
> ---

Does it boot with BL31 (bin/rk35/rk3588_bl31_v1.27.elf) from rkbin
master branch? I have tried with some information provided to Kever
the BL31 seems not working from my side. Can you confirm which BL31 is
working?

Thanks,
Jagan.

[PATCH 1/7] board: rockchip: Add rk3588 evb board support

[fatorangecat]

From: Joseph Chen 

Add support for rk3588 evaluation board.

Signed-off-by: Joseph Chen 
---
 board/rockchip/evb_rk3588/Kconfig  | 15 ++
 board/rockchip/evb_rk3588/MAINTAINERS  |  6 +++
 board/rockchip/evb_rk3588/Makefile |  7 +++
 board/rockchip/evb_rk3588/evb_rk3588.c |  4 ++
 configs/evb-rk3588_defconfig   | 69 ++
 include/configs/evb_rk3588.h   | 15 ++
 6 files changed, 116 insertions(+)
 create mode 100644 board/rockchip/evb_rk3588/Kconfig
 create mode 100644 board/rockchip/evb_rk3588/MAINTAINERS
 create mode 100644 board/rockchip/evb_rk3588/Makefile
 create mode 100644 board/rockchip/evb_rk3588/evb_rk3588.c
 create mode 100644 configs/evb-rk3588_defconfig
 create mode 100644 include/configs/evb_rk3588.h

diff --git a/board/rockchip/evb_rk3588/Kconfig 
b/board/rockchip/evb_rk3588/Kconfig
new file mode 100644
index 00..d38efe61d8
--- /dev/null
+++ b/board/rockchip/evb_rk3588/Kconfig
@@ -0,0 +1,15 @@
+if TARGET_EVB_RK3588
+
+config SYS_BOARD
+   default "evb_rk3588"
+
+config SYS_VENDOR
+   default "rockchip"
+
+config SYS_CONFIG_NAME
+   default "evb_rk3588"
+
+config BOARD_SPECIFIC_OPTIONS # dummy
+   def_bool y
+
+endif
diff --git a/board/rockchip/evb_rk3588/MAINTAINERS 
b/board/rockchip/evb_rk3588/MAINTAINERS
new file mode 100644
index 00..1a9695458d
--- /dev/null
+++ b/board/rockchip/evb_rk3588/MAINTAINERS
@@ -0,0 +1,6 @@
+EVB-RK3568
+M:  Joseph Chen 
+S:  Maintained
+F:  board/rockchip/evb_rk3588
+F:  include/configs/evb_rk3588.h
+F:  configs/evb-rk3588_defconfig
diff --git a/board/rockchip/evb_rk3588/Makefile 
b/board/rockchip/evb_rk3588/Makefile
new file mode 100644
index 00..3946c3565e
--- /dev/null
+++ b/board/rockchip/evb_rk3588/Makefile
@@ -0,0 +1,7 @@
+#
+# SPDX-License-Identifier: GPL-2.0+
+#
+# Copyright (c) 2021 Rockchip Electronics Co., Ltd
+#
+
+obj-y  += evb_rk3588.o
diff --git a/board/rockchip/evb_rk3588/evb_rk3588.c 
b/board/rockchip/evb_rk3588/evb_rk3588.c
new file mode 100644
index 00..c2fdf95d9a
--- /dev/null
+++ b/board/rockchip/evb_rk3588/evb_rk3588.c
@@ -0,0 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * (C) Copyright 2021 Rockchip Electronics Co., Ltd
+ */
diff --git a/configs/evb-rk3588_defconfig b/configs/evb-rk3588_defconfig
new file mode 100644
index 00..83cddcf2b0
--- /dev/null
+++ b/configs/evb-rk3588_defconfig
@@ -0,0 +1,69 @@
+CONFIG_ARM=y
+CONFIG_SKIP_LOWLEVEL_INIT=y
+CONFIG_COUNTER_FREQUENCY=2400
+CONFIG_ARCH_ROCKCHIP=y
+CONFIG_TEXT_BASE=0x0020
+CONFIG_SPL_LIBCOMMON_SUPPORT=y
+CONFIG_SPL_LIBGENERIC_SUPPORT=y
+CONFIG_NR_DRAM_BANKS=2
+CONFIG_DEFAULT_DEVICE_TREE="rk3588-evb"
+CONFIG_ROCKCHIP_RK3588=y
+CONFIG_SPL_ROCKCHIP_BACK_TO_BROM=y
+CONFIG_SPL_ROCKCHIP_COMMON_BOARD=y
+CONFIG_SPL_MMC=y
+CONFIG_SPL_SERIAL=y
+CONFIG_SPL_STACK_R_ADDR=0x60
+CONFIG_TARGET_EVB_RK3588=y
+CONFIG_DEBUG_UART_BASE=0xFEB5
+CONFIG_DEBUG_UART_CLOCK=2400
+CONFIG_SYS_LOAD_ADDR=0x400800
+CONFIG_DEBUG_UART=y
+CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
+CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x40
+CONFIG_FIT=y
+CONFIG_FIT_VERBOSE=y
+CONFIG_SPL_LOAD_FIT=y
+CONFIG_DEFAULT_FDT_FILE="rockchip/rk3588-evb.dtb"
+# CONFIG_DISPLAY_CPUINFO is not set
+CONFIG_DISPLAY_BOARDINFO_LATE=y
+CONFIG_SPL_MAX_SIZE=0x2
+CONFIG_SPL_PAD_TO=0x7f8000
+CONFIG_SPL_HAS_BSS_LINKER_SECTION=y
+CONFIG_SPL_BSS_START_ADDR=0x400
+CONFIG_SPL_BSS_MAX_SIZE=0x4000
+# CONFIG_SPL_RAW_IMAGE_SUPPORT is not set
+# CONFIG_SPL_SHARES_INIT_SP_ADDR is not set
+CONFIG_SPL_STACK=0x40
+CONFIG_SPL_STACK_R=y
+CONFIG_SPL_ATF=y
+CONFIG_CMD_GPT=y
+CONFIG_CMD_MMC=y
+# CONFIG_CMD_SETEXPR is not set
+# CONFIG_SPL_DOS_PARTITION is not set
+CONFIG_SPL_OF_CONTROL=y
+CONFIG_OF_LIVE=y
+CONFIG_NET_RANDOM_ETHADDR=y
+CONFIG_SPL_REGMAP=y
+CONFIG_SPL_SYSCON=y
+CONFIG_SPL_CLK=y
+CONFIG_ROCKCHIP_GPIO=y
+CONFIG_SYS_I2C_ROCKCHIP=y
+CONFIG_MISC=y
+CONFIG_SUPPORT_EMMC_RPMB=y
+CONFIG_MMC_DW=y
+CONFIG_MMC_DW_ROCKCHIP=y
+CONFIG_MMC_SDHCI=y
+CONFIG_MMC_SDHCI_SDMA=y
+CONFIG_MMC_SDHCI_ROCKCHIP=y
+CONFIG_ETH_DESIGNWARE=y
+CONFIG_GMAC_ROCKCHIP=y
+CONFIG_REGULATOR_PWM=y
+CONFIG_PWM_ROCKCHIP=y
+CONFIG_SPL_RAM=y
+CONFIG_DM_RESET=y
+CONFIG_BAUDRATE=150
+CONFIG_DEBUG_UART_SHIFT=2
+CONFIG_SYS_NS16550_MEM32=y
+CONFIG_SYSRESET=y
+# CONFIG_BINMAN_FDT is not set
+CONFIG_ERRNO_STR=y
diff --git a/include/configs/evb_rk3588.h b/include/configs/evb_rk3588.h
new file mode 100644
index 00..13411c9609
--- /dev/null
+++ b/include/configs/evb_rk3588.h
@@ -0,0 +1,15 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * (C) Copyright 2016 Rockchip Electronics Co., Ltd
+ */
+
+#ifndef __CONFIGS_RK3588_EVB_H
+#define __CONFIGS_RK3588_EVB_H
+
+#include 
+
+#define ROCKCHIP_DEVICE_SETTINGS \
+   "stdout=serial,vidconsole\0" \
+   "stderr=serial,vidconsole\0"
+
+#endif
-- 
2.39.1