Re: [PATCH 1/8] sunxi: Fix write to H616 DRAM CR register

[Andre Przywara]

On Sun, 11 Dec 2022 17:32:06 +0100
Jernej Skrabec  wrote:

> Vendor DRAM code actually writes to whole CR register and not just sets
> bit 31 in mctl_ctrl_init().
> 
> Just to be safe, do that here too.
> 
> Signed-off-by: Jernej Skrabec 

Can't really verify this, but it seems to work (TM):

Acked-by: Andre Przywara 

Cheers,
Andre

> ---
>  arch/arm/mach-sunxi/dram_sun50i_h616.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-sunxi/dram_sun50i_h616.c 
> b/arch/arm/mach-sunxi/dram_sun50i_h616.c
> index 454c845a0010..039e76224367 100644
> --- a/arch/arm/mach-sunxi/dram_sun50i_h616.c
> +++ b/arch/arm/mach-sunxi/dram_sun50i_h616.c
> @@ -873,7 +873,7 @@ static bool mctl_ctrl_init(struct dram_para *para)
>   writel(0x06000400, _ctl->unk_0x3240);
>   writel(0x06000400, _ctl->unk_0x4240);
>  
> - setbits_le32(_com->cr, BIT(31));
> + writel(BIT(31), _com->cr);
>  
>   mctl_set_addrmap(para);
>  

[PATCH 1/8] sunxi: Fix write to H616 DRAM CR register

[Jernej Skrabec]

Vendor DRAM code actually writes to whole CR register and not just sets
bit 31 in mctl_ctrl_init().

Just to be safe, do that here too.

Signed-off-by: Jernej Skrabec 
---
 arch/arm/mach-sunxi/dram_sun50i_h616.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-sunxi/dram_sun50i_h616.c 
b/arch/arm/mach-sunxi/dram_sun50i_h616.c
index 454c845a0010..039e76224367 100644
--- a/arch/arm/mach-sunxi/dram_sun50i_h616.c
+++ b/arch/arm/mach-sunxi/dram_sun50i_h616.c
@@ -873,7 +873,7 @@ static bool mctl_ctrl_init(struct dram_para *para)
writel(0x06000400, _ctl->unk_0x3240);
writel(0x06000400, _ctl->unk_0x4240);
 
-   setbits_le32(_com->cr, BIT(31));
+   writel(BIT(31), _com->cr);
 
mctl_set_addrmap(para);
 
-- 
2.38.1