Re: [PATCH 11/17] imx: imx8mn_smm_s2: clean up board watchdog code

2022-05-04 Thread Ariel D'Alessandro
Hi Peng,

On 5/3/22 09:24, Peng Fan (OSS) wrote:
> From: Peng Fan 
> 
> pinctrl_wdog already marked u-boot,dm-spl, so clean up board code.
> set_wdog_reset function could be handled by imx_watchdog.c driver.
> 
> Signed-off-by: Peng Fan 
> ---
>  board/bsh/imx8mn_smm_s2/spl.c | 11 ---
>  1 file changed, 11 deletions(-)

Tested on i.MX8MN BSH SMM S2 PRO board.

Tested-by: Ariel D'Alessandro 

Thanks!


[PATCH 11/17] imx: imx8mn_smm_s2: clean up board watchdog code

2022-05-03 Thread Peng Fan (OSS)
From: Peng Fan 

pinctrl_wdog already marked u-boot,dm-spl, so clean up board code.
set_wdog_reset function could be handled by imx_watchdog.c driver.

Signed-off-by: Peng Fan 
---
 board/bsh/imx8mn_smm_s2/spl.c | 11 ---
 1 file changed, 11 deletions(-)

diff --git a/board/bsh/imx8mn_smm_s2/spl.c b/board/bsh/imx8mn_smm_s2/spl.c
index 0f61acc6302..4ccee7c31a8 100644
--- a/board/bsh/imx8mn_smm_s2/spl.c
+++ b/board/bsh/imx8mn_smm_s2/spl.c
@@ -40,19 +40,8 @@ void spl_board_init(void)
puts("Failed to find clock node. Check device tree\n");
 }
 
-#define WDOG_PAD_CTRL  (PAD_CTL_DSE6 | PAD_CTL_ODE | PAD_CTL_PUE | PAD_CTL_PE)
-
-static const iomux_v3_cfg_t wdog_pads[] = {
-   IMX8MN_PAD_GPIO1_IO02__WDOG1_WDOG_B | MUX_PAD_CTRL(WDOG_PAD_CTRL),
-};
-
 int board_early_init_f(void)
 {
-   struct wdog_regs *wdog = (struct wdog_regs *)WDOG1_BASE_ADDR;
-
-   imx_iomux_v3_setup_multiple_pads(wdog_pads, ARRAY_SIZE(wdog_pads));
-   set_wdog_reset(wdog);
-
init_uart_clk(3);
 
if (IS_ENABLED(CONFIG_NAND_MXS)) {
-- 
2.36.0