RE: [PATCH 2/2] pinctrl: stmfx: update pin name
Hi, > From: Patrick DELAUNAY > Sent: mercredi 28 octobre 2020 10:52 > > Update pin name to avoid duplicated name with SOC GPIO > gpio0...gpio15 / agpio0agpio7: add a stmfx prefix. > > This pin name can be used in pinmux command. > > Signed-off-by: Patrick Delaunay > --- > > drivers/pinctrl/pinctrl-stmfx.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > Applied to u-boot-stm/master, thanks! Regards Patrick
Re: [PATCH 2/2] pinctrl: stmfx: update pin name
Hi Patrick On 10/28/20 10:51 AM, Patrick Delaunay wrote: > Update pin name to avoid duplicated name with SOC GPIO > gpio0...gpio15 / agpio0agpio7: add a stmfx prefix. > > This pin name can be used in pinmux command. > > Signed-off-by: Patrick Delaunay > --- > > drivers/pinctrl/pinctrl-stmfx.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-stmfx.c b/drivers/pinctrl/pinctrl-stmfx.c > index b789f3686c..a62be44d2d 100644 > --- a/drivers/pinctrl/pinctrl-stmfx.c > +++ b/drivers/pinctrl/pinctrl-stmfx.c > @@ -343,8 +343,8 @@ static int stmfx_pinctrl_get_pins_count(struct udevice > *dev) > } > > /* > - * STMFX pins[15:0] are called "gpio[15:0]" > - * and STMFX pins[23:16] are called "agpio[7:0]" > + * STMFX pins[15:0] are called "stmfx_gpio[15:0]" > + * and STMFX pins[23:16] are called "stmfx_agpio[7:0]" > */ > #define MAX_PIN_NAME_LEN 7 > static char pin_name[MAX_PIN_NAME_LEN]; > @@ -352,9 +352,9 @@ static const char *stmfx_pinctrl_get_pin_name(struct > udevice *dev, > unsigned int selector) > { > if (selector < STMFX_MAX_GPIO) > - snprintf(pin_name, MAX_PIN_NAME_LEN, "gpio%u", selector); > + snprintf(pin_name, MAX_PIN_NAME_LEN, "stmfx_gpio%u", selector); > else > - snprintf(pin_name, MAX_PIN_NAME_LEN, "agpio%u", selector - 16); > + snprintf(pin_name, MAX_PIN_NAME_LEN, "stmfx_agpio%u", selector > - 16); > return pin_name; > } > Reviewed-by: Patrice Chotard Thanks Patrice
[PATCH 2/2] pinctrl: stmfx: update pin name
Update pin name to avoid duplicated name with SOC GPIO gpio0...gpio15 / agpio0agpio7: add a stmfx prefix. This pin name can be used in pinmux command. Signed-off-by: Patrick Delaunay --- drivers/pinctrl/pinctrl-stmfx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/pinctrl-stmfx.c b/drivers/pinctrl/pinctrl-stmfx.c index b789f3686c..a62be44d2d 100644 --- a/drivers/pinctrl/pinctrl-stmfx.c +++ b/drivers/pinctrl/pinctrl-stmfx.c @@ -343,8 +343,8 @@ static int stmfx_pinctrl_get_pins_count(struct udevice *dev) } /* - * STMFX pins[15:0] are called "gpio[15:0]" - * and STMFX pins[23:16] are called "agpio[7:0]" + * STMFX pins[15:0] are called "stmfx_gpio[15:0]" + * and STMFX pins[23:16] are called "stmfx_agpio[7:0]" */ #define MAX_PIN_NAME_LEN 7 static char pin_name[MAX_PIN_NAME_LEN]; @@ -352,9 +352,9 @@ static const char *stmfx_pinctrl_get_pin_name(struct udevice *dev, unsigned int selector) { if (selector < STMFX_MAX_GPIO) - snprintf(pin_name, MAX_PIN_NAME_LEN, "gpio%u", selector); + snprintf(pin_name, MAX_PIN_NAME_LEN, "stmfx_gpio%u", selector); else - snprintf(pin_name, MAX_PIN_NAME_LEN, "agpio%u", selector - 16); + snprintf(pin_name, MAX_PIN_NAME_LEN, "stmfx_agpio%u", selector - 16); return pin_name; } -- 2.17.1