Re: [PATCH 2/2] udoo: neo: Do not print the Model information
On Wed, Jan 05, 2022 at 10:10:03PM +0100, Tommaso Merciai wrote: > On Wed, Jan 05, 2022 at 05:52:23PM -0300, Fabio Estevam wrote: > > Hi Tommaso, > > > > On Wed, Jan 5, 2022 at 5:47 PM Tommaso Merciai > > wrote: > > > > > Hi Fabio, > > > Thanks, I test your patch on basic and extended model. Below some logs > > > seems all work properly. I hope I helped the cause :) > > > > Yes, thanks a lot! It's a pleasure, nice team work :) Tommaso > > > > > - BASIC log: > > > - > > > U-Boot 2022.01-rc4-00034-g19f31e718f-dirty (Jan 05 2022 - 21:38:32 +0100) > > > > > > CPU: Freescale i.MX6SX rev1.2 996 MHz (running at 792 MHz) > > > CPU: Extended Commercial temperature grade (-20C to 105C) at 32C > > > Reset cause: POR > > > Model: UDOO Neo Basic > > > > I assume you have only applied 1/2 and not 2/2. > > > > With 2/2 applied the Model line should not be printed. > > > > Thanks > > Yes, Fabio. Sorry, I forgot. Below test with 2/2. > > U-Boot 2022.01-rc4-00034-g19f31e718f-dirty (Jan 05 2022 - 22:07:22 +0100) > > CPU: Freescale i.MX6SX rev1.2 996 MHz (running at 792 MHz) > CPU: Extended Commercial temperature grade (-20C to 105C) at 45C > Reset cause: POR > Board: UDOO Neo BASIC > I2C: ready > DRAM: 512 MiB > PMIC: PFUZE3000 DEV_ID=0x30 REV_ID=0x11 > MMC: FSL_SDHC: 1, FSL_SDHC: 2 > Loading Environment from MMC... OK > In:serial > Out: serial > Err: serial > Net: eth0: ethernet@2188000 > Hit any key to stop autoboot: 0 > > > U-Boot 2022.01-rc4-00034-g19f31e718f-dirty (Jan 05 2022 - 22:07:22 +0100) > > CPU: Freescale i.MX6SX rev1.2 996 MHz (running at 792 MHz) > CPU: Extended Commercial temperature grade (-20C to 105C) at 35C > Reset cause: POR > Board: UDOO Neo EXTENDED > I2C: ready > DRAM: 1 GiB > PMIC: PFUZE3000 DEV_ID=0x30 REV_ID=0x11 > MMC: FSL_SDHC: 1, FSL_SDHC: 2 > Loading Environment from MMC... OK > In:serial > Out: serial > Err: serial > Net: > Error: ethernet@2188000 address not set. > No ethernet found. > > Hit any key to stop autoboot: 0 > > Thanks, > Tommaso
Re: [PATCH 2/2] udoo: neo: Do not print the Model information
On Mon, Jan 03, 2022 at 12:15:12PM -0300, Fabio Estevam wrote: > By default the Model information from DT is printed: > > CPU: Freescale i.MX6SX rev1.2 996 MHz (running at 792 MHz) > CPU: Extended Commercial temperature grade (-20C to 105C) at 63C > Reset cause: POR > Model: UDOO Neo Basic > Board: UDOO Neo FULL > I2C: ready > > As the udoo basic DT is used, such output may be confusing. > > Improve it by only printing the Board model instead, which is > read from the board identification GPIOs. > > Signed-off-by: Fabio Estevam > Acked-by: Tommaso Merciai > Tested-by: Tommaso Merciai Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature
Re: [PATCH 2/2] udoo: neo: Do not print the Model information
On Wed, Jan 05, 2022 at 05:52:23PM -0300, Fabio Estevam wrote: > Hi Tommaso, > > On Wed, Jan 5, 2022 at 5:47 PM Tommaso Merciai wrote: > > > Hi Fabio, > > Thanks, I test your patch on basic and extended model. Below some logs > > seems all work properly. I hope I helped the cause :) > > Yes, thanks a lot! > > > - BASIC log: > > - > > U-Boot 2022.01-rc4-00034-g19f31e718f-dirty (Jan 05 2022 - 21:38:32 +0100) > > > > CPU: Freescale i.MX6SX rev1.2 996 MHz (running at 792 MHz) > > CPU: Extended Commercial temperature grade (-20C to 105C) at 32C > > Reset cause: POR > > Model: UDOO Neo Basic > > I assume you have only applied 1/2 and not 2/2. > > With 2/2 applied the Model line should not be printed. > > Thanks Yes, Fabio. Sorry, I forgot. Below test with 2/2. U-Boot 2022.01-rc4-00034-g19f31e718f-dirty (Jan 05 2022 - 22:07:22 +0100) CPU: Freescale i.MX6SX rev1.2 996 MHz (running at 792 MHz) CPU: Extended Commercial temperature grade (-20C to 105C) at 45C Reset cause: POR Board: UDOO Neo BASIC I2C: ready DRAM: 512 MiB PMIC: PFUZE3000 DEV_ID=0x30 REV_ID=0x11 MMC: FSL_SDHC: 1, FSL_SDHC: 2 Loading Environment from MMC... OK In:serial Out: serial Err: serial Net: eth0: ethernet@2188000 Hit any key to stop autoboot: 0 U-Boot 2022.01-rc4-00034-g19f31e718f-dirty (Jan 05 2022 - 22:07:22 +0100) CPU: Freescale i.MX6SX rev1.2 996 MHz (running at 792 MHz) CPU: Extended Commercial temperature grade (-20C to 105C) at 35C Reset cause: POR Board: UDOO Neo EXTENDED I2C: ready DRAM: 1 GiB PMIC: PFUZE3000 DEV_ID=0x30 REV_ID=0x11 MMC: FSL_SDHC: 1, FSL_SDHC: 2 Loading Environment from MMC... OK In:serial Out: serial Err: serial Net: Error: ethernet@2188000 address not set. No ethernet found. Hit any key to stop autoboot: 0 Thanks, Tommaso
Re: [PATCH 2/2] udoo: neo: Do not print the Model information
Hi Tommaso, On Wed, Jan 5, 2022 at 5:47 PM Tommaso Merciai wrote: > Hi Fabio, > Thanks, I test your patch on basic and extended model. Below some logs > seems all work properly. I hope I helped the cause :) Yes, thanks a lot! > - BASIC log: > - > U-Boot 2022.01-rc4-00034-g19f31e718f-dirty (Jan 05 2022 - 21:38:32 +0100) > > CPU: Freescale i.MX6SX rev1.2 996 MHz (running at 792 MHz) > CPU: Extended Commercial temperature grade (-20C to 105C) at 32C > Reset cause: POR > Model: UDOO Neo Basic I assume you have only applied 1/2 and not 2/2. With 2/2 applied the Model line should not be printed. Thanks
Re: [PATCH 2/2] udoo: neo: Do not print the Model information
On Mon, Jan 03, 2022 at 12:15:12PM -0300, Fabio Estevam wrote:
> By default the Model information from DT is printed:
>
> CPU: Freescale i.MX6SX rev1.2 996 MHz (running at 792 MHz)
> CPU: Extended Commercial temperature grade (-20C to 105C) at 63C
> Reset cause: POR
> Model: UDOO Neo Basic
> Board: UDOO Neo FULL
> I2C: ready
>
> As the udoo basic DT is used, such output may be confusing.
>
> Improve it by only printing the Board model instead, which is
> read from the board identification GPIOs.
Hi Fabio,
Thanks, I test your patch on basic and extended model. Below some logs
seems all work properly. I hope I helped the cause :)
- BASIC log:
-
U-Boot 2022.01-rc4-00034-g19f31e718f-dirty (Jan 05 2022 - 21:38:32 +0100)
CPU: Freescale i.MX6SX rev1.2 996 MHz (running at 792 MHz)
CPU: Extended Commercial temperature grade (-20C to 105C) at 32C
Reset cause: POR
Model: UDOO Neo Basic
Board: UDOO Neo BASIC
I2C: ready
DRAM: 512 MiB
PMIC: PFUZE3000 DEV_ID=0x30 REV_ID=0x11
MMC: FSL_SDHC: 1, FSL_SDHC: 2
Loading Environment from MMC... OK
In:serial
Out: serial
Err: serial
Net: eth0: ethernet@2188000 [PRIME]
Hit
--
- EXTENDED LOG:
--
U-Boot 2022.01-rc4-00034-g19f31e718f-dirty (Jan 05 2022 - 21:38:32 +0100)
CPU: Freescale i.MX6SX rev1.2 996 MHz (running at 792 MHz)
CPU: Extended Commercial temperature grade (-20C to 105C) at 42C
Reset cause: POR
Model: UDOO Neo Basic
Board: UDOO Neo EXTENDED
I2C: ready
DRAM: 1 GiB
PMIC: PFUZE3000 DEV_ID=0x30 REV_ID=0x11
MMC: FSL_SDHC: 1, FSL_SDHC: 2
Loading Environment from MMC... OK
In:serial
Out: serial
Err: serial
Net:
Error: ethernet@2188000 address not set.
No ethernet found.
Hit any key to stop autoboot: 0
Acked-by: Tommaso Merciai
Tested-by: Tommaso Merciai
Tommaso
>
> Signed-off-by: Fabio Estevam
> ---
> This applies on top of Peter's series:
> https://lore.kernel.org/all/20211221123249.455347-1-pbrobin...@gmail.com/T
>
> board/udoo/neo/neo.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/board/udoo/neo/neo.c b/board/udoo/neo/neo.c
> index 0c0d3f615d18..da6a0b4e9247 100644
> --- a/board/udoo/neo/neo.c
> +++ b/board/udoo/neo/neo.c
> @@ -350,7 +350,8 @@ static char *board_string(int type)
> return "UNDEFINED";
> }
>
> -int checkboard(void)
> +/* Override the default implementation, DT model is not accurate */
> +int show_board_info(void)
> {
> int *board_type = (int *)OCRAM_START;
>
> --
> 2.25.1
>
[PATCH 2/2] udoo: neo: Do not print the Model information
By default the Model information from DT is printed:
CPU: Freescale i.MX6SX rev1.2 996 MHz (running at 792 MHz)
CPU: Extended Commercial temperature grade (-20C to 105C) at 63C
Reset cause: POR
Model: UDOO Neo Basic
Board: UDOO Neo FULL
I2C: ready
As the udoo basic DT is used, such output may be confusing.
Improve it by only printing the Board model instead, which is
read from the board identification GPIOs.
Signed-off-by: Fabio Estevam
---
This applies on top of Peter's series:
https://lore.kernel.org/all/20211221123249.455347-1-pbrobin...@gmail.com/T
board/udoo/neo/neo.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/board/udoo/neo/neo.c b/board/udoo/neo/neo.c
index 0c0d3f615d18..da6a0b4e9247 100644
--- a/board/udoo/neo/neo.c
+++ b/board/udoo/neo/neo.c
@@ -350,7 +350,8 @@ static char *board_string(int type)
return "UNDEFINED";
}
-int checkboard(void)
+/* Override the default implementation, DT model is not accurate */
+int show_board_info(void)
{
int *board_type = (int *)OCRAM_START;
--
2.25.1
