Re: [PATCH 28/81] fastboot: Remove and add needed includes

2024-05-02 Thread Mattijs Korpershoek
Hi Tom,

Thank you for the patch.

On mer., mai 01, 2024 at 19:30, Tom Rini  wrote:

> Remove  from this driver directory and when needed
> add missing include files directly.
>
> Signed-off-by: Tom Rini 

Reviewed-by: Mattijs Korpershoek 

> ---
> Cc: Mattijs Korpershoek 
> Cc: Tom Rini 
> ---
>  drivers/fastboot/fb_command.c | 2 +-
>  drivers/fastboot/fb_common.c  | 2 +-
>  drivers/fastboot/fb_getvar.c  | 2 +-
>  drivers/fastboot/fb_mmc.c | 1 -
>  drivers/fastboot/fb_nand.c| 1 -
>  5 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/fastboot/fb_command.c b/drivers/fastboot/fb_command.c
> index 01443c5d39e2..e4484d65aca5 100644
> --- a/drivers/fastboot/fb_command.c
> +++ b/drivers/fastboot/fb_command.c
> @@ -3,7 +3,6 @@
>   * Copyright (C) 2016 The Android Open Source Project
>   */
>  
> -#include 
>  #include 
>  #include 
>  #include 
> @@ -13,6 +12,7 @@
>  #include 
>  #include 
>  #include 
> +#include 
>  #include 
>  
>  /**
> diff --git a/drivers/fastboot/fb_common.c b/drivers/fastboot/fb_common.c
> index 3576b0677299..12ffb463deb9 100644
> --- a/drivers/fastboot/fb_common.c
> +++ b/drivers/fastboot/fb_common.c
> @@ -11,11 +11,11 @@
>   */
>  
>  #include 
> -#include 
>  #include 
>  #include 
>  #include 
>  #include 
> +#include 
>  
>  /**
>   * fastboot_buf_addr - base address of the fastboot download buffer
> diff --git a/drivers/fastboot/fb_getvar.c b/drivers/fastboot/fb_getvar.c
> index f65519c57b47..93cbd598e024 100644
> --- a/drivers/fastboot/fb_getvar.c
> +++ b/drivers/fastboot/fb_getvar.c
> @@ -3,7 +3,6 @@
>   * Copyright (C) 2016 The Android Open Source Project
>   */
>  
> -#include 
>  #include 
>  #include 
>  #include 
> @@ -12,6 +11,7 @@
>  #include 
>  #include 
>  #include 
> +#include 
>  #include 
>  
>  static void getvar_version(char *var_parameter, char *response);
> diff --git a/drivers/fastboot/fb_mmc.c b/drivers/fastboot/fb_mmc.c
> index 060918e49109..f11eb66761b1 100644
> --- a/drivers/fastboot/fb_mmc.c
> +++ b/drivers/fastboot/fb_mmc.c
> @@ -4,7 +4,6 @@
>   */
>  
>  #include 
> -#include 
>  #include 
>  #include 
>  #include 
> diff --git a/drivers/fastboot/fb_nand.c b/drivers/fastboot/fb_nand.c
> index bbe26ddcc9be..afc64fd52807 100644
> --- a/drivers/fastboot/fb_nand.c
> +++ b/drivers/fastboot/fb_nand.c
> @@ -5,7 +5,6 @@
>   */
>  
>  #include 
> -#include 
>  #include 
>  
>  #include 
> -- 
> 2.34.1


[PATCH 28/81] fastboot: Remove and add needed includes

2024-05-01 Thread Tom Rini
Remove  from this driver directory and when needed
add missing include files directly.

Signed-off-by: Tom Rini 
---
Cc: Mattijs Korpershoek 
Cc: Tom Rini 
---
 drivers/fastboot/fb_command.c | 2 +-
 drivers/fastboot/fb_common.c  | 2 +-
 drivers/fastboot/fb_getvar.c  | 2 +-
 drivers/fastboot/fb_mmc.c | 1 -
 drivers/fastboot/fb_nand.c| 1 -
 5 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/fastboot/fb_command.c b/drivers/fastboot/fb_command.c
index 01443c5d39e2..e4484d65aca5 100644
--- a/drivers/fastboot/fb_command.c
+++ b/drivers/fastboot/fb_command.c
@@ -3,7 +3,6 @@
  * Copyright (C) 2016 The Android Open Source Project
  */
 
-#include 
 #include 
 #include 
 #include 
@@ -13,6 +12,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 /**
diff --git a/drivers/fastboot/fb_common.c b/drivers/fastboot/fb_common.c
index 3576b0677299..12ffb463deb9 100644
--- a/drivers/fastboot/fb_common.c
+++ b/drivers/fastboot/fb_common.c
@@ -11,11 +11,11 @@
  */
 
 #include 
-#include 
 #include 
 #include 
 #include 
 #include 
+#include 
 
 /**
  * fastboot_buf_addr - base address of the fastboot download buffer
diff --git a/drivers/fastboot/fb_getvar.c b/drivers/fastboot/fb_getvar.c
index f65519c57b47..93cbd598e024 100644
--- a/drivers/fastboot/fb_getvar.c
+++ b/drivers/fastboot/fb_getvar.c
@@ -3,7 +3,6 @@
  * Copyright (C) 2016 The Android Open Source Project
  */
 
-#include 
 #include 
 #include 
 #include 
@@ -12,6 +11,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 
 static void getvar_version(char *var_parameter, char *response);
diff --git a/drivers/fastboot/fb_mmc.c b/drivers/fastboot/fb_mmc.c
index 060918e49109..f11eb66761b1 100644
--- a/drivers/fastboot/fb_mmc.c
+++ b/drivers/fastboot/fb_mmc.c
@@ -4,7 +4,6 @@
  */
 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/drivers/fastboot/fb_nand.c b/drivers/fastboot/fb_nand.c
index bbe26ddcc9be..afc64fd52807 100644
--- a/drivers/fastboot/fb_nand.c
+++ b/drivers/fastboot/fb_nand.c
@@ -5,7 +5,6 @@
  */
 
 #include 
-#include 
 #include 
 
 #include 
-- 
2.34.1