Re: [PATCH 3/4] arm: dts: k3-am625-beagleplay-u-boot: drop duplicate bootph-nodes

[Nishanth Menon]

On 09:03-20231114, Dhruva Gole wrote:
[...]

> >  #ifdef CONFIG_TARGET_AM625_A53_EVM
> >  
> >  #define SPL_AM625_BEAGLEPLAY_DTB "spl/dts/k3-am625-beagleplay.dtb"
> 
> You didn't talk about this in the commit message?

There is nothing changing in this patch here.


-- 
Regards,
Nishanth Menonh
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 
849D 1736 249D

Re: [PATCH 3/4] arm: dts: k3-am625-beagleplay-u-boot: drop duplicate bootph-nodes

[Dhruva Gole]

On Nov 13, 2023 at 08:59:18 -0600, Nishanth Menon wrote:
> Kernel dts import now provides bootph-all and bootph-pre-ram properties
> for the properties we have been overriding so far. Drop the same.
> 
> Signed-off-by: Nishanth Menon 
> ---
>  arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 56 
>  1 file changed, 56 deletions(-)
> 
> diff --git a/arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi 
> b/arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi
> index 6f3a31558b20..7f8468f298f0 100644
> --- a/arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi
> +++ b/arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi
> @@ -13,36 +13,26 @@
>   tick-timer = _timer0;
>   };
>  
> - memory@8000 {
> - bootph-all;
> - };
> -
>   /* Keep the LEDs on by default to indicate life */
>   leds {
> - bootph-all;
>   led-0 {
>   default-state = "on";
> - bootph-all;
>   };
>  
>   led-1 {
>   default-state = "on";
> - bootph-all;
>   };
>  
>   led-2 {
>   default-state = "on";
> - bootph-all;
>   };
>  
>   led-3 {
>   default-state = "on";
> - bootph-all;
>   };
>  
>   led-4 {
>   default-state = "on";
> - bootph-all;
>   };
>   };
>  };
> @@ -58,45 +48,7 @@
>   };
>  };
>  
> -_uart0 {
> - bootph-all;
> -};
> -
> -_pins_default {
> - bootph-all;
> -};
> -
> -_i2c0 {
> - bootph-all;
> -};
> -
> -_i2c_pins_default {
> - bootph-all;
> -};
> -
> -_pins_default {
> - bootph-all;
> -};
> -
> -_gpio0 {
> - bootph-all;
> -};
> -
> -_gpio1 {
> - bootph-all;
> -};
> -
> - {
> - /* EMMC */
> - bootph-all;
> -};
> -
> -_pins_default {
> - bootph-all;
> -};
> -
>  _pins_default {
> - bootph-all;
>   /* Force to use SDCD card detect pin */
>   pinctrl-single,pins = <
>   AM62X_IOPAD(0x023c, PIN_INPUT, 0) /* (A21) MMC1_CMD */
> @@ -109,14 +61,6 @@
>   >;
>  };
>  
> - {
> - bootph-all;
> -};
> -
> - {
> - bootph-all;
> -};
> -
>  #ifdef CONFIG_TARGET_AM625_A53_EVM
>  
>  #define SPL_AM625_BEAGLEPLAY_DTB "spl/dts/k3-am625-beagleplay.dtb"

You didn't talk about this in the commit message?

> -- 
> 2.40.0
> 
> 


Rest looks ok,

Reviewed-by: Dhruva Gole 

-- 
Best regards,
Dhruva Gole 

[PATCH 3/4] arm: dts: k3-am625-beagleplay-u-boot: drop duplicate bootph-nodes

[Nishanth Menon]

Kernel dts import now provides bootph-all and bootph-pre-ram properties
for the properties we have been overriding so far. Drop the same.

Signed-off-by: Nishanth Menon 
---
 arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 56 
 1 file changed, 56 deletions(-)

diff --git a/arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi 
b/arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi
index 6f3a31558b20..7f8468f298f0 100644
--- a/arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi
+++ b/arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi
@@ -13,36 +13,26 @@
tick-timer = _timer0;
};
 
-   memory@8000 {
-   bootph-all;
-   };
-
/* Keep the LEDs on by default to indicate life */
leds {
-   bootph-all;
led-0 {
default-state = "on";
-   bootph-all;
};
 
led-1 {
default-state = "on";
-   bootph-all;
};
 
led-2 {
default-state = "on";
-   bootph-all;
};
 
led-3 {
default-state = "on";
-   bootph-all;
};
 
led-4 {
default-state = "on";
-   bootph-all;
};
};
 };
@@ -58,45 +48,7 @@
};
 };
 
-_uart0 {
-   bootph-all;
-};
-
-_pins_default {
-   bootph-all;
-};
-
-_i2c0 {
-   bootph-all;
-};
-
-_i2c_pins_default {
-   bootph-all;
-};
-
-_pins_default {
-   bootph-all;
-};
-
-_gpio0 {
-   bootph-all;
-};
-
-_gpio1 {
-   bootph-all;
-};
-
- {
-   /* EMMC */
-   bootph-all;
-};
-
-_pins_default {
-   bootph-all;
-};
-
 _pins_default {
-   bootph-all;
/* Force to use SDCD card detect pin */
pinctrl-single,pins = <
AM62X_IOPAD(0x023c, PIN_INPUT, 0) /* (A21) MMC1_CMD */
@@ -109,14 +61,6 @@
>;
 };
 
- {
-   bootph-all;
-};
-
- {
-   bootph-all;
-};
-
 #ifdef CONFIG_TARGET_AM625_A53_EVM
 
 #define SPL_AM625_BEAGLEPLAY_DTB "spl/dts/k3-am625-beagleplay.dtb"
-- 
2.40.0