Re: [PATCH 3/5] m68k: dts: add watchdog node
On Tue, 18 Jul 2023 at 08:00, Angelo Dureghello wrote: > > Hi Stefan, > > On 18/07/23 2:26 PM, Stefan Roese wrote: > > On 6/25/23 21:35, Angelo Dureghello wrote: > >> Add watchdog node for the implemented mcf_wdt driver. > >> > >> Signed-off-by: Angelo Dureghello > >> --- > >> arch/m68k/dts/M5208EVBE.dts | 5 + > >> arch/m68k/dts/mcf5208.dtsi | 7 +++ > >> arch/m68k/dts/mcf523x.dtsi | 7 +++ > >> arch/m68k/dts/mcf5271.dtsi | 7 +++ > >> arch/m68k/dts/mcf5275.dtsi | 7 +++ > >> arch/m68k/dts/mcf5282.dtsi | 7 +++ > >> arch/m68k/dts/mcf5329.dtsi | 7 +++ > >> arch/m68k/dts/mcf537x.dtsi | 7 +++ > >> 8 files changed, 54 insertions(+) Reviewed-by: Simon Glass
Re: [PATCH 3/5] m68k: dts: add watchdog node
Hi Angelo,
On 7/18/23 15:58, Angelo Dureghello wrote:
Hi Stefan,
On 18/07/23 2:26 PM, Stefan Roese wrote:
On 6/25/23 21:35, Angelo Dureghello wrote:
Add watchdog node for the implemented mcf_wdt driver.
Signed-off-by: Angelo Dureghello
---
arch/m68k/dts/M5208EVBE.dts | 5 +
arch/m68k/dts/mcf5208.dtsi | 7 +++
arch/m68k/dts/mcf523x.dtsi | 7 +++
arch/m68k/dts/mcf5271.dtsi | 7 +++
arch/m68k/dts/mcf5275.dtsi | 7 +++
arch/m68k/dts/mcf5282.dtsi | 7 +++
arch/m68k/dts/mcf5329.dtsi | 7 +++
arch/m68k/dts/mcf537x.dtsi | 7 +++
8 files changed, 54 insertions(+)
diff --git a/arch/m68k/dts/M5208EVBE.dts b/arch/m68k/dts/M5208EVBE.dts
index 1c32718af4..ec203e8b69 100644
--- a/arch/m68k/dts/M5208EVBE.dts
+++ b/arch/m68k/dts/M5208EVBE.dts
@@ -15,6 +15,11 @@
};
};
+&wdog0 {
+ timeout-sec = <32>;
+ status = "okay";
+};
+
&uart0 {
bootph-all;
status = "okay";
diff --git a/arch/m68k/dts/mcf5208.dtsi b/arch/m68k/dts/mcf5208.dtsi
index 9392facfa8..b06dc4bb26 100644
--- a/arch/m68k/dts/mcf5208.dtsi
+++ b/arch/m68k/dts/mcf5208.dtsi
@@ -16,6 +16,13 @@
#address-cells = <1>;
#size-cells = <1>;
+ wdog0: watchdog@fc08c000 {
+ compatible = "fsl,mcf5208-wdt";
+ reg = <0xfc08c000 0x10>;
+ big-endian;
+ status = "disabled";
+ };
I was not able to find this compatible property in the Linux Kernel
source tree. Is this the official version of the Coldfire WDT DT node?
Just checking..
there is no fdt support for m68k in Linux, after discussing the need in
u-boot, i implemented fdt here the best i could.
Ok, I see. BTW: Is "big-endian" necessary here?
Thanks,
Stefan
Thanks,
Stefan
+
uart0: uart@fc06 {
compatible = "fsl,mcf-uart";
reg = <0xfc06 0x40>;
diff --git a/arch/m68k/dts/mcf523x.dtsi b/arch/m68k/dts/mcf523x.dtsi
index 41c7b9b2d1..fb5a4cdc21 100644
--- a/arch/m68k/dts/mcf523x.dtsi
+++ b/arch/m68k/dts/mcf523x.dtsi
@@ -23,6 +23,13 @@
ranges = <0x 0x4000 0x4000>;
reg = <0x4000 0x4000>;
+ wdog0: watchdog@14 {
+ compatible = "fsl,mcf5208-wdt";
+ reg = <0x14 0x10>;
+ big-endian;
+ status = "disabled";
+ };
+
uart0: uart@200 {
compatible = "fsl,mcf-uart";
reg = <0x200 0x40>;
diff --git a/arch/m68k/dts/mcf5271.dtsi b/arch/m68k/dts/mcf5271.dtsi
index fc82bd3c24..0884c13ab1 100644
--- a/arch/m68k/dts/mcf5271.dtsi
+++ b/arch/m68k/dts/mcf5271.dtsi
@@ -23,6 +23,13 @@
ranges = <0x 0x4000 0x4000>;
reg = <0x4000 0x4000>;
+ wdog0: watchdog@14 {
+ compatible = "fsl,mcf5208-wdt";
+ reg = <0x14 0x10>;
+ big-endian;
+ status = "disabled";
+ };
+
uart0: uart@200 {
compatible = "fsl,mcf-uart";
reg = <0x200 0x40>;
diff --git a/arch/m68k/dts/mcf5275.dtsi b/arch/m68k/dts/mcf5275.dtsi
index 402517cdec..78210569da 100644
--- a/arch/m68k/dts/mcf5275.dtsi
+++ b/arch/m68k/dts/mcf5275.dtsi
@@ -24,6 +24,13 @@
ranges = <0x 0x4000 0x4000>;
reg = <0x4000 0x4000>;
+ wdog0: watchdog@14 {
+ compatible = "fsl,mcf5208-wdt";
+ reg = <0x14 0x10>;
+ big-endian;
+ status = "disabled";
+ };
+
uart0: uart@200 {
compatible = "fsl,mcf-uart";
reg = <0x200 0x40>;
diff --git a/arch/m68k/dts/mcf5282.dtsi b/arch/m68k/dts/mcf5282.dtsi
index 883c0d0324..40704c5202 100644
--- a/arch/m68k/dts/mcf5282.dtsi
+++ b/arch/m68k/dts/mcf5282.dtsi
@@ -23,6 +23,13 @@
ranges = <0x 0x4000 0x4000>;
reg = <0x4000 0x4000>;
+ wdog0: watchdog@14 {
+ compatible = "fsl,mcf5282-wdt";
+ reg = <0x14 0x10>;
+ big-endian;
+ status = "disabled";
+ };
+
uart0: uart@200 {
compatible = "fsl,mcf-uart";
reg = <0x200 0x40>;
diff --git a/arch/m68k/dts/mcf5329.dtsi b/arch/m68k/dts/mcf5329.dtsi
index 7501cc4b01..50ff73bca7 100644
--- a/arch/m68k/dts/mcf5329.dtsi
+++ b/arch/m68k/dts/mcf5329.dtsi
@@ -16,6 +16,13 @@
#address-cells = <1>;
#size-cells = <1>;
+ wdog0: watchdog@fc098000 {
+ compatible = "fsl,mcf5208-wdt";
+ reg = <0xfc08c000 0x10>;
+ big-endian;
+ status = "disabled";
+ };
+
uart0: uart@fc06 {
compatible = "fsl,mcf-uart";
reg = <0xfc06 0x40>;
diff --git a/arch/m68k/dts/mcf537x.dtsi b/arch/m68k/dts/mcf537x.dtsi
index 338b8b4
Re: [PATCH 3/5] m68k: dts: add watchdog node
Hi Stefan,
On 18/07/23 2:26 PM, Stefan Roese wrote:
On 6/25/23 21:35, Angelo Dureghello wrote:
Add watchdog node for the implemented mcf_wdt driver.
Signed-off-by: Angelo Dureghello
---
arch/m68k/dts/M5208EVBE.dts | 5 +
arch/m68k/dts/mcf5208.dtsi | 7 +++
arch/m68k/dts/mcf523x.dtsi | 7 +++
arch/m68k/dts/mcf5271.dtsi | 7 +++
arch/m68k/dts/mcf5275.dtsi | 7 +++
arch/m68k/dts/mcf5282.dtsi | 7 +++
arch/m68k/dts/mcf5329.dtsi | 7 +++
arch/m68k/dts/mcf537x.dtsi | 7 +++
8 files changed, 54 insertions(+)
diff --git a/arch/m68k/dts/M5208EVBE.dts b/arch/m68k/dts/M5208EVBE.dts
index 1c32718af4..ec203e8b69 100644
--- a/arch/m68k/dts/M5208EVBE.dts
+++ b/arch/m68k/dts/M5208EVBE.dts
@@ -15,6 +15,11 @@
};
};
+&wdog0 {
+ timeout-sec = <32>;
+ status = "okay";
+};
+
&uart0 {
bootph-all;
status = "okay";
diff --git a/arch/m68k/dts/mcf5208.dtsi b/arch/m68k/dts/mcf5208.dtsi
index 9392facfa8..b06dc4bb26 100644
--- a/arch/m68k/dts/mcf5208.dtsi
+++ b/arch/m68k/dts/mcf5208.dtsi
@@ -16,6 +16,13 @@
#address-cells = <1>;
#size-cells = <1>;
+ wdog0: watchdog@fc08c000 {
+ compatible = "fsl,mcf5208-wdt";
+ reg = <0xfc08c000 0x10>;
+ big-endian;
+ status = "disabled";
+ };
I was not able to find this compatible property in the Linux Kernel
source tree. Is this the official version of the Coldfire WDT DT node?
Just checking..
there is no fdt support for m68k in Linux, after discussing the need in
u-boot, i implemented fdt here the best i could.
Thanks,
Stefan
+
uart0: uart@fc06 {
compatible = "fsl,mcf-uart";
reg = <0xfc06 0x40>;
diff --git a/arch/m68k/dts/mcf523x.dtsi b/arch/m68k/dts/mcf523x.dtsi
index 41c7b9b2d1..fb5a4cdc21 100644
--- a/arch/m68k/dts/mcf523x.dtsi
+++ b/arch/m68k/dts/mcf523x.dtsi
@@ -23,6 +23,13 @@
ranges = <0x 0x4000 0x4000>;
reg = <0x4000 0x4000>;
+ wdog0: watchdog@14 {
+ compatible = "fsl,mcf5208-wdt";
+ reg = <0x14 0x10>;
+ big-endian;
+ status = "disabled";
+ };
+
uart0: uart@200 {
compatible = "fsl,mcf-uart";
reg = <0x200 0x40>;
diff --git a/arch/m68k/dts/mcf5271.dtsi b/arch/m68k/dts/mcf5271.dtsi
index fc82bd3c24..0884c13ab1 100644
--- a/arch/m68k/dts/mcf5271.dtsi
+++ b/arch/m68k/dts/mcf5271.dtsi
@@ -23,6 +23,13 @@
ranges = <0x 0x4000 0x4000>;
reg = <0x4000 0x4000>;
+ wdog0: watchdog@14 {
+ compatible = "fsl,mcf5208-wdt";
+ reg = <0x14 0x10>;
+ big-endian;
+ status = "disabled";
+ };
+
uart0: uart@200 {
compatible = "fsl,mcf-uart";
reg = <0x200 0x40>;
diff --git a/arch/m68k/dts/mcf5275.dtsi b/arch/m68k/dts/mcf5275.dtsi
index 402517cdec..78210569da 100644
--- a/arch/m68k/dts/mcf5275.dtsi
+++ b/arch/m68k/dts/mcf5275.dtsi
@@ -24,6 +24,13 @@
ranges = <0x 0x4000 0x4000>;
reg = <0x4000 0x4000>;
+ wdog0: watchdog@14 {
+ compatible = "fsl,mcf5208-wdt";
+ reg = <0x14 0x10>;
+ big-endian;
+ status = "disabled";
+ };
+
uart0: uart@200 {
compatible = "fsl,mcf-uart";
reg = <0x200 0x40>;
diff --git a/arch/m68k/dts/mcf5282.dtsi b/arch/m68k/dts/mcf5282.dtsi
index 883c0d0324..40704c5202 100644
--- a/arch/m68k/dts/mcf5282.dtsi
+++ b/arch/m68k/dts/mcf5282.dtsi
@@ -23,6 +23,13 @@
ranges = <0x 0x4000 0x4000>;
reg = <0x4000 0x4000>;
+ wdog0: watchdog@14 {
+ compatible = "fsl,mcf5282-wdt";
+ reg = <0x14 0x10>;
+ big-endian;
+ status = "disabled";
+ };
+
uart0: uart@200 {
compatible = "fsl,mcf-uart";
reg = <0x200 0x40>;
diff --git a/arch/m68k/dts/mcf5329.dtsi b/arch/m68k/dts/mcf5329.dtsi
index 7501cc4b01..50ff73bca7 100644
--- a/arch/m68k/dts/mcf5329.dtsi
+++ b/arch/m68k/dts/mcf5329.dtsi
@@ -16,6 +16,13 @@
#address-cells = <1>;
#size-cells = <1>;
+ wdog0: watchdog@fc098000 {
+ compatible = "fsl,mcf5208-wdt";
+ reg = <0xfc08c000 0x10>;
+ big-endian;
+ status = "disabled";
+ };
+
uart0: uart@fc06 {
compatible = "fsl,mcf-uart";
reg = <0xfc06 0x40>;
diff --git a/arch/m68k/dts/mcf537x.dtsi b/arch/m68k/dts/mcf537x.dtsi
index 338b8b4583..23c3754df0 100644
--- a/arch/m68k/dts/mcf537x.dtsi
+++ b/arch/m68k/dts/mcf537x.dtsi
@@ -16,6 +16,13 @@
#ad
Re: [PATCH 3/5] m68k: dts: add watchdog node
On 6/25/23 21:35, Angelo Dureghello wrote:
Add watchdog node for the implemented mcf_wdt driver.
Signed-off-by: Angelo Dureghello
---
arch/m68k/dts/M5208EVBE.dts | 5 +
arch/m68k/dts/mcf5208.dtsi | 7 +++
arch/m68k/dts/mcf523x.dtsi | 7 +++
arch/m68k/dts/mcf5271.dtsi | 7 +++
arch/m68k/dts/mcf5275.dtsi | 7 +++
arch/m68k/dts/mcf5282.dtsi | 7 +++
arch/m68k/dts/mcf5329.dtsi | 7 +++
arch/m68k/dts/mcf537x.dtsi | 7 +++
8 files changed, 54 insertions(+)
diff --git a/arch/m68k/dts/M5208EVBE.dts b/arch/m68k/dts/M5208EVBE.dts
index 1c32718af4..ec203e8b69 100644
--- a/arch/m68k/dts/M5208EVBE.dts
+++ b/arch/m68k/dts/M5208EVBE.dts
@@ -15,6 +15,11 @@
};
};
+&wdog0 {
+ timeout-sec = <32>;
+ status = "okay";
+};
+
&uart0 {
bootph-all;
status = "okay";
diff --git a/arch/m68k/dts/mcf5208.dtsi b/arch/m68k/dts/mcf5208.dtsi
index 9392facfa8..b06dc4bb26 100644
--- a/arch/m68k/dts/mcf5208.dtsi
+++ b/arch/m68k/dts/mcf5208.dtsi
@@ -16,6 +16,13 @@
#address-cells = <1>;
#size-cells = <1>;
+ wdog0: watchdog@fc08c000 {
+ compatible = "fsl,mcf5208-wdt";
+ reg = <0xfc08c000 0x10>;
+ big-endian;
+ status = "disabled";
+ };
I was not able to find this compatible property in the Linux Kernel
source tree. Is this the official version of the Coldfire WDT DT node?
Just checking..
Thanks,
Stefan
+
uart0: uart@fc06 {
compatible = "fsl,mcf-uart";
reg = <0xfc06 0x40>;
diff --git a/arch/m68k/dts/mcf523x.dtsi b/arch/m68k/dts/mcf523x.dtsi
index 41c7b9b2d1..fb5a4cdc21 100644
--- a/arch/m68k/dts/mcf523x.dtsi
+++ b/arch/m68k/dts/mcf523x.dtsi
@@ -23,6 +23,13 @@
ranges = <0x 0x4000 0x4000>;
reg = <0x4000 0x4000>;
+ wdog0: watchdog@14 {
+ compatible = "fsl,mcf5208-wdt";
+ reg = <0x14 0x10>;
+ big-endian;
+ status = "disabled";
+ };
+
uart0: uart@200 {
compatible = "fsl,mcf-uart";
reg = <0x200 0x40>;
diff --git a/arch/m68k/dts/mcf5271.dtsi b/arch/m68k/dts/mcf5271.dtsi
index fc82bd3c24..0884c13ab1 100644
--- a/arch/m68k/dts/mcf5271.dtsi
+++ b/arch/m68k/dts/mcf5271.dtsi
@@ -23,6 +23,13 @@
ranges = <0x 0x4000 0x4000>;
reg = <0x4000 0x4000>;
+ wdog0: watchdog@14 {
+ compatible = "fsl,mcf5208-wdt";
+ reg = <0x14 0x10>;
+ big-endian;
+ status = "disabled";
+ };
+
uart0: uart@200 {
compatible = "fsl,mcf-uart";
reg = <0x200 0x40>;
diff --git a/arch/m68k/dts/mcf5275.dtsi b/arch/m68k/dts/mcf5275.dtsi
index 402517cdec..78210569da 100644
--- a/arch/m68k/dts/mcf5275.dtsi
+++ b/arch/m68k/dts/mcf5275.dtsi
@@ -24,6 +24,13 @@
ranges = <0x 0x4000 0x4000>;
reg = <0x4000 0x4000>;
+ wdog0: watchdog@14 {
+ compatible = "fsl,mcf5208-wdt";
+ reg = <0x14 0x10>;
+ big-endian;
+ status = "disabled";
+ };
+
uart0: uart@200 {
compatible = "fsl,mcf-uart";
reg = <0x200 0x40>;
diff --git a/arch/m68k/dts/mcf5282.dtsi b/arch/m68k/dts/mcf5282.dtsi
index 883c0d0324..40704c5202 100644
--- a/arch/m68k/dts/mcf5282.dtsi
+++ b/arch/m68k/dts/mcf5282.dtsi
@@ -23,6 +23,13 @@
ranges = <0x 0x4000 0x4000>;
reg = <0x4000 0x4000>;
+ wdog0: watchdog@14 {
+ compatible = "fsl,mcf5282-wdt";
+ reg = <0x14 0x10>;
+ big-endian;
+ status = "disabled";
+ };
+
uart0: uart@200 {
compatible = "fsl,mcf-uart";
reg = <0x200 0x40>;
diff --git a/arch/m68k/dts/mcf5329.dtsi b/arch/m68k/dts/mcf5329.dtsi
index 7501cc4b01..50ff73bca7 100644
--- a/arch/m68k/dts/mcf5329.dtsi
+++ b/arch/m68k/dts/mcf5329.dtsi
@@ -16,6 +16,13 @@
#address-cells = <1>;
#size-cells = <1>;
+ wdog0: watchdog@fc098000 {
+ compatible = "fsl,mcf5
[PATCH 3/5] m68k: dts: add watchdog node
Add watchdog node for the implemented mcf_wdt driver.
Signed-off-by: Angelo Dureghello
---
arch/m68k/dts/M5208EVBE.dts | 5 +
arch/m68k/dts/mcf5208.dtsi | 7 +++
arch/m68k/dts/mcf523x.dtsi | 7 +++
arch/m68k/dts/mcf5271.dtsi | 7 +++
arch/m68k/dts/mcf5275.dtsi | 7 +++
arch/m68k/dts/mcf5282.dtsi | 7 +++
arch/m68k/dts/mcf5329.dtsi | 7 +++
arch/m68k/dts/mcf537x.dtsi | 7 +++
8 files changed, 54 insertions(+)
diff --git a/arch/m68k/dts/M5208EVBE.dts b/arch/m68k/dts/M5208EVBE.dts
index 1c32718af4..ec203e8b69 100644
--- a/arch/m68k/dts/M5208EVBE.dts
+++ b/arch/m68k/dts/M5208EVBE.dts
@@ -15,6 +15,11 @@
};
};
+&wdog0 {
+ timeout-sec = <32>;
+ status = "okay";
+};
+
&uart0 {
bootph-all;
status = "okay";
diff --git a/arch/m68k/dts/mcf5208.dtsi b/arch/m68k/dts/mcf5208.dtsi
index 9392facfa8..b06dc4bb26 100644
--- a/arch/m68k/dts/mcf5208.dtsi
+++ b/arch/m68k/dts/mcf5208.dtsi
@@ -16,6 +16,13 @@
#address-cells = <1>;
#size-cells = <1>;
+ wdog0: watchdog@fc08c000 {
+ compatible = "fsl,mcf5208-wdt";
+ reg = <0xfc08c000 0x10>;
+ big-endian;
+ status = "disabled";
+ };
+
uart0: uart@fc06 {
compatible = "fsl,mcf-uart";
reg = <0xfc06 0x40>;
diff --git a/arch/m68k/dts/mcf523x.dtsi b/arch/m68k/dts/mcf523x.dtsi
index 41c7b9b2d1..fb5a4cdc21 100644
--- a/arch/m68k/dts/mcf523x.dtsi
+++ b/arch/m68k/dts/mcf523x.dtsi
@@ -23,6 +23,13 @@
ranges = <0x 0x4000 0x4000>;
reg = <0x4000 0x4000>;
+ wdog0: watchdog@14 {
+ compatible = "fsl,mcf5208-wdt";
+ reg = <0x14 0x10>;
+ big-endian;
+ status = "disabled";
+ };
+
uart0: uart@200 {
compatible = "fsl,mcf-uart";
reg = <0x200 0x40>;
diff --git a/arch/m68k/dts/mcf5271.dtsi b/arch/m68k/dts/mcf5271.dtsi
index fc82bd3c24..0884c13ab1 100644
--- a/arch/m68k/dts/mcf5271.dtsi
+++ b/arch/m68k/dts/mcf5271.dtsi
@@ -23,6 +23,13 @@
ranges = <0x 0x4000 0x4000>;
reg = <0x4000 0x4000>;
+ wdog0: watchdog@14 {
+ compatible = "fsl,mcf5208-wdt";
+ reg = <0x14 0x10>;
+ big-endian;
+ status = "disabled";
+ };
+
uart0: uart@200 {
compatible = "fsl,mcf-uart";
reg = <0x200 0x40>;
diff --git a/arch/m68k/dts/mcf5275.dtsi b/arch/m68k/dts/mcf5275.dtsi
index 402517cdec..78210569da 100644
--- a/arch/m68k/dts/mcf5275.dtsi
+++ b/arch/m68k/dts/mcf5275.dtsi
@@ -24,6 +24,13 @@
ranges = <0x 0x4000 0x4000>;
reg = <0x4000 0x4000>;
+ wdog0: watchdog@14 {
+ compatible = "fsl,mcf5208-wdt";
+ reg = <0x14 0x10>;
+ big-endian;
+ status = "disabled";
+ };
+
uart0: uart@200 {
compatible = "fsl,mcf-uart";
reg = <0x200 0x40>;
diff --git a/arch/m68k/dts/mcf5282.dtsi b/arch/m68k/dts/mcf5282.dtsi
index 883c0d0324..40704c5202 100644
--- a/arch/m68k/dts/mcf5282.dtsi
+++ b/arch/m68k/dts/mcf5282.dtsi
@@ -23,6 +23,13 @@
ranges = <0x 0x4000 0x4000>;
reg = <0x4000 0x4000>;
+ wdog0: watchdog@14 {
+ compatible = "fsl,mcf5282-wdt";
+ reg = <0x14 0x10>;
+ big-endian;
+ status = "disabled";
+ };
+
uart0: uart@200 {
compatible = "fsl,mcf-uart";
reg = <0x200 0x40>;
diff --git a/arch/m68k/dts/mcf5329.dtsi b/arch/m68k/dts/mcf5329.dtsi
index 7501cc4b01..50ff73bca7 100644
--- a/arch/m68k/dts/mcf5329.dtsi
+++ b/arch/m68k/dts/mcf5329.dtsi
@@ -16,6 +16,13 @@
#address-cells = <1>;
#size-cells = <1>;
+ wdog0: watchdog@fc098000 {
+ compatible = "fsl,mcf5208-wdt";
+ reg = <0xfc08c000 0x10>;
+ big-endian;
+ status = "disabled";
