Re: [PATCH 4/4] CI: Drop some jobs we didn't really utilize

2023-09-06 Thread Tom Rini
On Sun, Aug 20, 2023 at 01:31:29PM -0400, Tom Rini wrote:

> - We have added more TODO/etc comments since this task was created and
>   never focused on removing them.
> - The output of sloccount isn't preserved or looked at, and if desired
>   should be in the release stats pages instead somehow.
> - The results of cppcheck aren't investigated and require modeling work
>   to be useful to start with.
> 
> Signed-off-by: Tom Rini 
> Reviewed-by: Simon Glass 

Applied to u-boot/next, thanks!

-- 
Tom


signature.asc
Description: PGP signature


Re: [PATCH 4/4] CI: Drop some jobs we didn't really utilize

2023-08-21 Thread Simon Glass
On Sun, 20 Aug 2023 at 11:32, Tom Rini  wrote:
>
> - We have added more TODO/etc comments since this task was created and
>   never focused on removing them.
> - The output of sloccount isn't preserved or looked at, and if desired
>   should be in the release stats pages instead somehow.
> - The results of cppcheck aren't investigated and require modeling work
>   to be useful to start with.
>
> Signed-off-by: Tom Rini 
> ---
>  .azure-pipelines.yml| 32 
>  .gitlab-ci.yml  | 22 --
>  tools/docker/Dockerfile |  2 --
>  3 files changed, 56 deletions(-)

Reviewed-by: Simon Glass 


[PATCH 4/4] CI: Drop some jobs we didn't really utilize

2023-08-20 Thread Tom Rini
- We have added more TODO/etc comments since this task was created and
  never focused on removing them.
- The output of sloccount isn't preserved or looked at, and if desired
  should be in the release stats pages instead somehow.
- The results of cppcheck aren't investigated and require modeling work
  to be useful to start with.

Signed-off-by: Tom Rini 
---
 .azure-pipelines.yml| 32 
 .gitlab-ci.yml  | 22 --
 tools/docker/Dockerfile |  2 --
 3 files changed, 56 deletions(-)

diff --git a/.azure-pipelines.yml b/.azure-pipelines.yml
index e0ac7166d653..ad04f43b4339 100644
--- a/.azure-pipelines.yml
+++ b/.azure-pipelines.yml
@@ -67,16 +67,6 @@ stages:
   :^doc/ :^arch/arm/dts/ :^scripts/kconfig/lkc.h
   :^include/linux/kconfig.h :^tools/ && exit 1 || exit 0
 
-  - job: cppcheck
-displayName: 'Static code analysis with cppcheck'
-pool:
-  vmImage: $(ubuntu_vm)
-container:
-  image: $(ci_runner_image)
-  options: $(container_option)
-steps:
-  - script: cppcheck -j$(nproc) --force --quiet --inline-suppr .
-
   - job: docs
 displayName: 'Build documentation'
 pool:
@@ -92,28 +82,6 @@ stages:
   make htmldocs KDOC_WERROR=1
   make infodocs
 
-  - job: todo
-displayName: 'Search for TODO within source tree'
-pool:
-  vmImage: $(ubuntu_vm)
-container:
-  image: $(ci_runner_image)
-  options: $(container_option)
-steps:
-  - script: grep -r TODO .
-  - script: grep -r FIXME .
-  - script: grep -r HACK . | grep -v HACKKIT
-
-  - job: sloccount
-displayName: 'Some statistics about the code base'
-pool:
-  vmImage: $(ubuntu_vm)
-container:
-  image: $(ci_runner_image)
-  options: $(container_option)
-steps:
-  - script: sloccount .
-
   - job: maintainers
 displayName: 'Ensure all configs have MAINTAINERS entries'
 pool:
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 7400d1225d9e..7f3ad40eae8d 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -151,22 +151,6 @@ check for new CONFIG symbols outside Kconfig:
 :^doc/ :^arch/arm/dts/ :^scripts/kconfig/lkc.h
 :^include/linux/kconfig.h :^tools/ && exit 1 || exit 0
 
-# QA jobs for code analytics
-# static code analysis with cppcheck (we can add --enable=all later)
-cppcheck:
-  stage: testsuites
-  script:
-- cppcheck -j$(nproc) --force --quiet --inline-suppr .
-
-# search for TODO within source tree
-grep TODO/FIXME/HACK:
-  stage: testsuites
-  script:
-- grep -r TODO .
-- grep -r FIXME .
-# search for HACK within source tree and ignore HACKKIT board
-- grep -r HACK . | grep -v HACKKIT
-
 # build documentation
 docs:
   stage: testsuites
@@ -177,12 +161,6 @@ docs:
 - make htmldocs KDOC_WERROR=1
 - make infodocs
 
-# some statistics about the code base
-sloccount:
-  stage: testsuites
-  script:
-- sloccount .
-
 # ensure all configs have MAINTAINERS entries
 Check for configs without MAINTAINERS entry:
   stage: testsuites
diff --git a/tools/docker/Dockerfile b/tools/docker/Dockerfile
index 3d2b64a355f3..4d496700f1fd 100644
--- a/tools/docker/Dockerfile
+++ b/tools/docker/Dockerfile
@@ -42,7 +42,6 @@ RUN apt-get update && apt-get install -y \
clang-16 \
coreutils \
cpio \
-   cppcheck \
curl \
device-tree-compiler \
dosfstools \
@@ -104,7 +103,6 @@ RUN apt-get update && apt-get install -y \
python3-virtualenv \
rpm2cpio \
sbsigntool \
-   sloccount \
socat \
softhsm2 \
sparse \
-- 
2.34.1