Re: [PATCH 5/5] Add initial support for the Pinebook Pro laptop from Pine64.

2020-04-28 Thread Kever Yang 



On 2020/4/21 上午3:27, Peter Robinson wrote:

Specification:
- Rockchip RK3399
- 4GB Dual-Channel LPDDR4
- eMMC socket
- mSD card slot
- 128Mbit (16Mb) SPI Flash
- AP6256 for 11AC WiFi + BT5
- 14 inch 1920*1080 eDP MiPi display
- Camera
- USB 3.0, 2.0 ports
- Type-C port with alt-mode display (DP 1.2) and 15W charge
- DC 5V/3A
- optional PCIe slot for NVMe SSD drive

Signed-off-by: Peter Robinson 



Reviewed-by: Kever Yang 

Thanks,
- Kever

---
  arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi  | 43 ++
  arch/arm/mach-rockchip/rk3399/Kconfig |  8 ++
  board/pine64/pinebook-pro-rk3399/Kconfig  | 15 
  board/pine64/pinebook-pro-rk3399/MAINTAINERS  |  8 ++
  board/pine64/pinebook-pro-rk3399/Makefile |  1 +
  .../pinebook-pro-rk3399/pinebook-pro-rk3399.c | 76 +
  configs/pinebook-pro-rk3399_defconfig | 84 +++
  include/configs/pinebook-pro-rk3399.h | 29 +++
  8 files changed, 264 insertions(+)
  create mode 100644 arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
  create mode 100644 board/pine64/pinebook-pro-rk3399/Kconfig
  create mode 100644 board/pine64/pinebook-pro-rk3399/MAINTAINERS
  create mode 100644 board/pine64/pinebook-pro-rk3399/Makefile
  create mode 100644 board/pine64/pinebook-pro-rk3399/pinebook-pro-rk3399.c
  create mode 100644 configs/pinebook-pro-rk3399_defconfig
  create mode 100644 include/configs/pinebook-pro-rk3399.h

diff --git a/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi 
b/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
new file mode 100644
index 00..1a2e24d3ef
--- /dev/null
+++ b/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
@@ -0,0 +1,43 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2019 Peter Robinson 
+ */
+
+#include "rk3399-u-boot.dtsi"
+#include "rk3399-sdram-lpddr4-100.dtsi"
+
+/ {
+   aliases {
+   spi0 = &spi1;
+   };
+
+   chosen {
+   u-boot,spl-boot-order = "same-as-spl", &sdhci, &sdmmc;
+   };
+};
+
+&i2c0 {
+   u-boot,dm-pre-reloc;
+};
+
+&rk808 {
+   u-boot,dm-pre-reloc;
+};
+
+&sdhci {
+   max-frequency = <2500>;
+   u-boot,dm-pre-reloc;
+};
+
+&sdmmc {
+   max-frequency = <2000>;
+   u-boot,dm-pre-reloc;
+};
+
+&spiflash {
+   u-boot,dm-pre-reloc;
+};
+
+&vdd_log {
+   regulator-init-microvolt = <95>;
+};
diff --git a/arch/arm/mach-rockchip/rk3399/Kconfig 
b/arch/arm/mach-rockchip/rk3399/Kconfig
index 927bb62a9f..254b9c5b4d 100644
--- a/arch/arm/mach-rockchip/rk3399/Kconfig
+++ b/arch/arm/mach-rockchip/rk3399/Kconfig
@@ -19,6 +19,13 @@ config TARGET_EVB_RK3399
  with full function and physical connectors support like Type-C ports,
  USB.0 host ports, LVDS, JTAG, MAC, SD card, HDMI, USB-to-serial...
  
+config TARGET_PINEBOOK_PRO_RK3399

+   bool "Pinebook Pro"
+   help
+ Pinebook Pro is a laptop based on the Rockchip rk3399 SoC
+ with 4Gb RAM, onboard eMMC, USB-C, a USB3 and USB2 port,
+ 1920*1080 screen and all the usual laptop features.
+
  config TARGET_PUMA_RK3399
bool "Theobroma Systems RK3399-Q7 (Puma)"
help
@@ -144,6 +151,7 @@ endif # BOOTCOUNT_LIMIT
  
  source "board/firefly/roc-pc-rk3399/Kconfig"

  source "board/google/gru/Kconfig"
+source "board/pine64/pinebook-pro-rk3399/Kconfig"
  source "board/pine64/rockpro64_rk3399/Kconfig"
  source "board/rockchip/evb_rk3399/Kconfig"
  source "board/theobroma-systems/puma_rk3399/Kconfig"
diff --git a/board/pine64/pinebook-pro-rk3399/Kconfig 
b/board/pine64/pinebook-pro-rk3399/Kconfig
new file mode 100644
index 00..3bb7ca448e
--- /dev/null
+++ b/board/pine64/pinebook-pro-rk3399/Kconfig
@@ -0,0 +1,15 @@
+if TARGET_PINEBOOK_PRO_RK3399
+
+config SYS_BOARD
+   default "pinebook-pro-rk3399"
+
+config SYS_VENDOR
+   default "pine64"
+
+config SYS_CONFIG_NAME
+   default "pinebook-pro-rk3399"
+
+config BOARD_SPECIFIC_OPTIONS
+   def_bool y
+
+endif
diff --git a/board/pine64/pinebook-pro-rk3399/MAINTAINERS 
b/board/pine64/pinebook-pro-rk3399/MAINTAINERS
new file mode 100644
index 00..7153eaf2e0
--- /dev/null
+++ b/board/pine64/pinebook-pro-rk3399/MAINTAINERS
@@ -0,0 +1,8 @@
+PINEBOOK_PRO
+M: Peter Robinson 
+S: Maintained
+F: board/pine64/rk3399-pinebook-pro/
+F: include/configs/rk3399-pinebook-pro.h
+F: arch/arm/dts/rk3399-pinebook-pro.dts
+F: arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
+F: configs/pinebook-pro-rk3399_defconfig
diff --git a/board/pine64/pinebook-pro-rk3399/Makefile 
b/board/pine64/pinebook-pro-rk3399/Makefile
new file mode 100644
index 00..2f692a12a6
--- /dev/null
+++ b/board/pine64/pinebook-pro-rk3399/Makefile
@@ -0,0 +1 @@
+obj-y  += pinebook-pro-rk3399.o
diff --git a/board/pine64/pinebook-pro-rk3399/pinebook-pro-rk3399.c 
b/board/pine64/pinebook-pro-rk3399/pinebook-pro-rk3399.c
new file mode 100644
index 00..01421cbac2
--- /dev/null
+++ b/board/pine64/pinebook-pro-rk3399/pinebook-pro-rk

Re: [PATCH 5/5] Add initial support for the Pinebook Pro laptop from Pine64.

2020-04-22 Thread Rtp 
Hi,

> diff --git a/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi 
> b/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
> new file mode 100644
> index 00..1a2e24d3ef
> --- /dev/null
> +++ b/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
> @@ -0,0 +1,43 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2019 Peter Robinson 
> + */
> +
> +#include "rk3399-u-boot.dtsi"
> +#include "rk3399-sdram-lpddr4-100.dtsi"
> +
> +/ {
> +   aliases {
> +   spi0 = &spi1;
> +   };
> +
> +   chosen {
> +   u-boot,spl-boot-order = "same-as-spl", &sdhci, &sdmmc;
> +   };
> +};
> +
> +&i2c0 {
> +   u-boot,dm-pre-reloc;
> +};
> +
> +&rk808 {
> +   u-boot,dm-pre-reloc;
> +};

This one makes the SPL rather unhappy on my system:

U-Boot TPL 2020.04-00522-g1bf65142b3-dirty (Apr 22 2020 - 15:22:59)
Channel 0: LPDDR4, 50MHz
BW=32 Col=10 Bk=8 CS0 Row=15 CS1 Row=15 CS=2 Die BW=16 Size=2048MB
Channel 1: LPDDR4, 50MHz
BW=32 Col=10 Bk=8 CS0 Row=15 CS1 Row=15 CS=2 Die BW=16 Size=2048MB
256B stride
256B stride
lpddr4_set_rate: change freq to 4 mhz 0, 1
lpddr4_set_rate: change freq to 8 mhz 1, 0
Trying to boot from BOOTROM
Returning to boot ROM...
spl_early_init() failed: -6
### ERROR ### Please RESET the board ###

Any idea ? Configuration issue ?

Arnaud

Re: [PATCH 5/5] Add initial support for the Pinebook Pro laptop from Pine64.

2020-04-20 Thread Vagrant Cascadian 
On 2020-04-20, Peter Robinson wrote:
> Specification:
> - Rockchip RK3399
> - 4GB Dual-Channel LPDDR4
> - eMMC socket
> - mSD card slot
> - 128Mbit (16Mb) SPI Flash
> - AP6256 for 11AC WiFi + BT5
> - 14 inch 1920*1080 eDP MiPi display
> - Camera
> - USB 3.0, 2.0 ports
> - Type-C port with alt-mode display (DP 1.2) and 15W charge
> - DC 5V/3A
> - optional PCIe slot for NVMe SSD drive
>
> Signed-off-by: Peter Robinson 

Thanks!

Works when applied on v2020.04 with the patch from:

https://lists.denx.de/pipermail/u-boot/2020-April/407652.html

Built and boot tested on Debian and GNU Guix on a Pinebook Pro, so (for
the whole series):

Tested-by: Vagrant Cascadian 


live well,
  vagrant

> ---
>  arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi  | 43 ++
>  arch/arm/mach-rockchip/rk3399/Kconfig |  8 ++
>  board/pine64/pinebook-pro-rk3399/Kconfig  | 15 
>  board/pine64/pinebook-pro-rk3399/MAINTAINERS  |  8 ++
>  board/pine64/pinebook-pro-rk3399/Makefile |  1 +
>  .../pinebook-pro-rk3399/pinebook-pro-rk3399.c | 76 +
>  configs/pinebook-pro-rk3399_defconfig | 84 +++
>  include/configs/pinebook-pro-rk3399.h | 29 +++
>  8 files changed, 264 insertions(+)
>  create mode 100644 arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
>  create mode 100644 board/pine64/pinebook-pro-rk3399/Kconfig
>  create mode 100644 board/pine64/pinebook-pro-rk3399/MAINTAINERS
>  create mode 100644 board/pine64/pinebook-pro-rk3399/Makefile
>  create mode 100644 board/pine64/pinebook-pro-rk3399/pinebook-pro-rk3399.c
>  create mode 100644 configs/pinebook-pro-rk3399_defconfig
>  create mode 100644 include/configs/pinebook-pro-rk3399.h
>
> diff --git a/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi 
> b/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
> new file mode 100644
> index 00..1a2e24d3ef
> --- /dev/null
> +++ b/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
> @@ -0,0 +1,43 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2019 Peter Robinson 
> + */
> +
> +#include "rk3399-u-boot.dtsi"
> +#include "rk3399-sdram-lpddr4-100.dtsi"
> +
> +/ {
> + aliases {
> + spi0 = &spi1;
> + };
> +
> + chosen {
> + u-boot,spl-boot-order = "same-as-spl", &sdhci, &sdmmc;
> + };
> +};
> +
> +&i2c0 {
> + u-boot,dm-pre-reloc;
> +};
> +
> +&rk808 {
> + u-boot,dm-pre-reloc;
> +};
> +
> +&sdhci {
> + max-frequency = <2500>;
> + u-boot,dm-pre-reloc;
> +};
> +
> +&sdmmc {
> + max-frequency = <2000>;
> + u-boot,dm-pre-reloc;
> +};
> +
> +&spiflash {
> + u-boot,dm-pre-reloc;
> +};
> +
> +&vdd_log {
> + regulator-init-microvolt = <95>;
> +};
> diff --git a/arch/arm/mach-rockchip/rk3399/Kconfig 
> b/arch/arm/mach-rockchip/rk3399/Kconfig
> index 927bb62a9f..254b9c5b4d 100644
> --- a/arch/arm/mach-rockchip/rk3399/Kconfig
> +++ b/arch/arm/mach-rockchip/rk3399/Kconfig
> @@ -19,6 +19,13 @@ config TARGET_EVB_RK3399
> with full function and physical connectors support like Type-C ports,
> USB.0 host ports, LVDS, JTAG, MAC, SD card, HDMI, USB-to-serial...
>  
> +config TARGET_PINEBOOK_PRO_RK3399
> + bool "Pinebook Pro"
> + help
> +   Pinebook Pro is a laptop based on the Rockchip rk3399 SoC
> +   with 4Gb RAM, onboard eMMC, USB-C, a USB3 and USB2 port,
> +   1920*1080 screen and all the usual laptop features.
> +
>  config TARGET_PUMA_RK3399
>   bool "Theobroma Systems RK3399-Q7 (Puma)"
>   help
> @@ -144,6 +151,7 @@ endif # BOOTCOUNT_LIMIT
>  
>  source "board/firefly/roc-pc-rk3399/Kconfig"
>  source "board/google/gru/Kconfig"
> +source "board/pine64/pinebook-pro-rk3399/Kconfig"
>  source "board/pine64/rockpro64_rk3399/Kconfig"
>  source "board/rockchip/evb_rk3399/Kconfig"
>  source "board/theobroma-systems/puma_rk3399/Kconfig"
> diff --git a/board/pine64/pinebook-pro-rk3399/Kconfig 
> b/board/pine64/pinebook-pro-rk3399/Kconfig
> new file mode 100644
> index 00..3bb7ca448e
> --- /dev/null
> +++ b/board/pine64/pinebook-pro-rk3399/Kconfig
> @@ -0,0 +1,15 @@
> +if TARGET_PINEBOOK_PRO_RK3399
> +
> +config SYS_BOARD
> + default "pinebook-pro-rk3399"
> +
> +config SYS_VENDOR
> + default "pine64"
> +
> +config SYS_CONFIG_NAME
> + default "pinebook-pro-rk3399"
> +
> +config BOARD_SPECIFIC_OPTIONS
> + def_bool y
> +
> +endif
> diff --git a/board/pine64/pinebook-pro-rk3399/MAINTAINERS 
> b/board/pine64/pinebook-pro-rk3399/MAINTAINERS
> new file mode 100644
> index 00..7153eaf2e0
> --- /dev/null
> +++ b/board/pine64/pinebook-pro-rk3399/MAINTAINERS
> @@ -0,0 +1,8 @@
> +PINEBOOK_PRO
> +M:   Peter Robinson 
> +S:   Maintained
> +F:   board/pine64/rk3399-pinebook-pro/
> +F:   include/configs/rk3399-pinebook-pro.h
> +F:   arch/arm/dts/rk3399-pinebook-pro.dts
> +F:   arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
> +F:   configs/pinebook-pro-rk3399_defconfig
> diff --git a/board/pine64/pinebook-pro-rk3399/Makefile 
> b/board/pine64/pinebook-pro-r

[PATCH 5/5] Add initial support for the Pinebook Pro laptop from Pine64.

2020-04-20 Thread Peter Robinson 
Specification:
- Rockchip RK3399
- 4GB Dual-Channel LPDDR4
- eMMC socket
- mSD card slot
- 128Mbit (16Mb) SPI Flash
- AP6256 for 11AC WiFi + BT5
- 14 inch 1920*1080 eDP MiPi display
- Camera
- USB 3.0, 2.0 ports
- Type-C port with alt-mode display (DP 1.2) and 15W charge
- DC 5V/3A
- optional PCIe slot for NVMe SSD drive

Signed-off-by: Peter Robinson 
---
 arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi  | 43 ++
 arch/arm/mach-rockchip/rk3399/Kconfig |  8 ++
 board/pine64/pinebook-pro-rk3399/Kconfig  | 15 
 board/pine64/pinebook-pro-rk3399/MAINTAINERS  |  8 ++
 board/pine64/pinebook-pro-rk3399/Makefile |  1 +
 .../pinebook-pro-rk3399/pinebook-pro-rk3399.c | 76 +
 configs/pinebook-pro-rk3399_defconfig | 84 +++
 include/configs/pinebook-pro-rk3399.h | 29 +++
 8 files changed, 264 insertions(+)
 create mode 100644 arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
 create mode 100644 board/pine64/pinebook-pro-rk3399/Kconfig
 create mode 100644 board/pine64/pinebook-pro-rk3399/MAINTAINERS
 create mode 100644 board/pine64/pinebook-pro-rk3399/Makefile
 create mode 100644 board/pine64/pinebook-pro-rk3399/pinebook-pro-rk3399.c
 create mode 100644 configs/pinebook-pro-rk3399_defconfig
 create mode 100644 include/configs/pinebook-pro-rk3399.h

diff --git a/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi 
b/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
new file mode 100644
index 00..1a2e24d3ef
--- /dev/null
+++ b/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
@@ -0,0 +1,43 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2019 Peter Robinson 
+ */
+
+#include "rk3399-u-boot.dtsi"
+#include "rk3399-sdram-lpddr4-100.dtsi"
+
+/ {
+   aliases {
+   spi0 = &spi1;
+   };
+
+   chosen {
+   u-boot,spl-boot-order = "same-as-spl", &sdhci, &sdmmc;
+   };
+};
+
+&i2c0 {
+   u-boot,dm-pre-reloc;
+};
+
+&rk808 {
+   u-boot,dm-pre-reloc;
+};
+
+&sdhci {
+   max-frequency = <2500>;
+   u-boot,dm-pre-reloc;
+};
+
+&sdmmc {
+   max-frequency = <2000>;
+   u-boot,dm-pre-reloc;
+};
+
+&spiflash {
+   u-boot,dm-pre-reloc;
+};
+
+&vdd_log {
+   regulator-init-microvolt = <95>;
+};
diff --git a/arch/arm/mach-rockchip/rk3399/Kconfig 
b/arch/arm/mach-rockchip/rk3399/Kconfig
index 927bb62a9f..254b9c5b4d 100644
--- a/arch/arm/mach-rockchip/rk3399/Kconfig
+++ b/arch/arm/mach-rockchip/rk3399/Kconfig
@@ -19,6 +19,13 @@ config TARGET_EVB_RK3399
  with full function and physical connectors support like Type-C ports,
  USB.0 host ports, LVDS, JTAG, MAC, SD card, HDMI, USB-to-serial...
 
+config TARGET_PINEBOOK_PRO_RK3399
+   bool "Pinebook Pro"
+   help
+ Pinebook Pro is a laptop based on the Rockchip rk3399 SoC
+ with 4Gb RAM, onboard eMMC, USB-C, a USB3 and USB2 port,
+ 1920*1080 screen and all the usual laptop features.
+
 config TARGET_PUMA_RK3399
bool "Theobroma Systems RK3399-Q7 (Puma)"
help
@@ -144,6 +151,7 @@ endif # BOOTCOUNT_LIMIT
 
 source "board/firefly/roc-pc-rk3399/Kconfig"
 source "board/google/gru/Kconfig"
+source "board/pine64/pinebook-pro-rk3399/Kconfig"
 source "board/pine64/rockpro64_rk3399/Kconfig"
 source "board/rockchip/evb_rk3399/Kconfig"
 source "board/theobroma-systems/puma_rk3399/Kconfig"
diff --git a/board/pine64/pinebook-pro-rk3399/Kconfig 
b/board/pine64/pinebook-pro-rk3399/Kconfig
new file mode 100644
index 00..3bb7ca448e
--- /dev/null
+++ b/board/pine64/pinebook-pro-rk3399/Kconfig
@@ -0,0 +1,15 @@
+if TARGET_PINEBOOK_PRO_RK3399
+
+config SYS_BOARD
+   default "pinebook-pro-rk3399"
+
+config SYS_VENDOR
+   default "pine64"
+
+config SYS_CONFIG_NAME
+   default "pinebook-pro-rk3399"
+
+config BOARD_SPECIFIC_OPTIONS
+   def_bool y
+
+endif
diff --git a/board/pine64/pinebook-pro-rk3399/MAINTAINERS 
b/board/pine64/pinebook-pro-rk3399/MAINTAINERS
new file mode 100644
index 00..7153eaf2e0
--- /dev/null
+++ b/board/pine64/pinebook-pro-rk3399/MAINTAINERS
@@ -0,0 +1,8 @@
+PINEBOOK_PRO
+M: Peter Robinson 
+S: Maintained
+F: board/pine64/rk3399-pinebook-pro/
+F: include/configs/rk3399-pinebook-pro.h
+F: arch/arm/dts/rk3399-pinebook-pro.dts
+F: arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
+F: configs/pinebook-pro-rk3399_defconfig
diff --git a/board/pine64/pinebook-pro-rk3399/Makefile 
b/board/pine64/pinebook-pro-rk3399/Makefile
new file mode 100644
index 00..2f692a12a6
--- /dev/null
+++ b/board/pine64/pinebook-pro-rk3399/Makefile
@@ -0,0 +1 @@
+obj-y  += pinebook-pro-rk3399.o
diff --git a/board/pine64/pinebook-pro-rk3399/pinebook-pro-rk3399.c 
b/board/pine64/pinebook-pro-rk3399/pinebook-pro-rk3399.c
new file mode 100644
index 00..01421cbac2
--- /dev/null
+++ b/board/pine64/pinebook-pro-rk3399/pinebook-pro-rk3399.c
@@ -0,0 +1,76 @@
+/*
+ * (C) Copyright 2016 Rockchip Electronics Co., Ltd
+ * (C) Copyright 2020 Peter Robinson