Re: [PATCH 5/5] video console: remove unused 4x6 font

2023-02-09 Thread Andre Przywara
On Wed, 11 Jan 2023 20:05:11 +0300
Dzmitry Sankouski  wrote:

> ok
> 
> пт, 30 дек. 2022 г. в 01:40, Simon Glass :
> >
> > Hi Dzmitry,
> >
> > On Mon, 26 Dec 2022 at 13:50, Dzmitry Sankouski  
> > wrote:  
> > >
> > > Remove video_font_4x6.h file because it's unused.
> > >
> > > Signed-off-by: Dzmitry Sankouski 
> > > ---
> > >  drivers/video/Kconfig|6 -
> > >  include/video_font.h |4 +-
> > >  include/video_font_4x6.h | 2155 --
> > >  3 files changed, 1 insertion(+), 2164 deletions(-)
> > >  delete mode 100644 include/video_font_4x6.h
> > >  
> >
> > I do think this is useful, e.g. on small displays. How about adding a
> > Kconfig for it instead?

You can cherry-pick this patch for the conversion:
https://patchwork.ozlabs.org/project/uboot/patch/20220110005638.21599-4-andre.przyw...@arm.com/

Cheers,
Andre


Re: [PATCH 5/5] video console: remove unused 4x6 font

2023-01-11 Thread Dzmitry Sankouski
ok

пт, 30 дек. 2022 г. в 01:40, Simon Glass :
>
> Hi Dzmitry,
>
> On Mon, 26 Dec 2022 at 13:50, Dzmitry Sankouski  wrote:
> >
> > Remove video_font_4x6.h file because it's unused.
> >
> > Signed-off-by: Dzmitry Sankouski 
> > ---
> >  drivers/video/Kconfig|6 -
> >  include/video_font.h |4 +-
> >  include/video_font_4x6.h | 2155 --
> >  3 files changed, 1 insertion(+), 2164 deletions(-)
> >  delete mode 100644 include/video_font_4x6.h
> >
>
> I do think this is useful, e.g. on small displays. How about adding a
> Kconfig for it instead?
>
> Regards,
> Simon


Re: [PATCH 5/5] video console: remove unused 4x6 font

2022-12-29 Thread Simon Glass
Hi Dzmitry,

On Mon, 26 Dec 2022 at 13:50, Dzmitry Sankouski  wrote:
>
> Remove video_font_4x6.h file because it's unused.
>
> Signed-off-by: Dzmitry Sankouski 
> ---
>  drivers/video/Kconfig|6 -
>  include/video_font.h |4 +-
>  include/video_font_4x6.h | 2155 --
>  3 files changed, 1 insertion(+), 2164 deletions(-)
>  delete mode 100644 include/video_font_4x6.h
>

I do think this is useful, e.g. on small displays. How about adding a
Kconfig for it instead?

Regards,
Simon


[PATCH 5/5] video console: remove unused 4x6 font

2022-12-26 Thread Dzmitry Sankouski
Remove video_font_4x6.h file because it's unused.

Signed-off-by: Dzmitry Sankouski 
---
 drivers/video/Kconfig|6 -
 include/video_font.h |4 +-
 include/video_font_4x6.h | 2155 --
 3 files changed, 1 insertion(+), 2164 deletions(-)
 delete mode 100644 include/video_font_4x6.h

diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 3d531e69dc..b6a9934243 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -19,12 +19,6 @@ choice
prompt "Video font size"
default VIDEO_FONT_8x16
 
-config VIDEO_FONT_4X6
-   bool "4 x 6 font size"
-   help
- Font for video console driver, 4 x 6 pixels.
- Provides character bitmap data in header file.
-
 config VIDEO_FONT_8x16
bool "8 x 16 font size"
help
diff --git a/include/video_font.h b/include/video_font.h
index 86685bfaf1..05a9fc288f 100644
--- a/include/video_font.h
+++ b/include/video_font.h
@@ -7,9 +7,7 @@
 #ifndef _VIDEO_FONT_
 #define _VIDEO_FONT_
 
-#if defined(CONFIG_VIDEO_FONT_4X6)
-#include 
-#elif defined(CONFIG_VIDEO_FONT_8x16)
+#if defined(CONFIG_VIDEO_FONT_8x16)
 #include 
 #elif defined(CONFIG_VIDEO_FONT_16x32)
 #include 
diff --git a/include/video_font_4x6.h b/include/video_font_4x6.h
deleted file mode 100644
index f1eb2af861..00
--- a/include/video_font_4x6.h
+++ /dev/null
@@ -1,2155 +0,0 @@
-/* Hand composed "Minuscule" 4x6 font for code page 437, with binary data
- * generated using Perl stub.
- *
- * Use 'perl -x mini_4x6.c < mini_4x6.c > new_version.c' to regenerate
- * binary data.
- *
- * Created by Kenneth Albanowski.
- * No rights reserved, released to the public domain.
- *
- * Version 1.0
- */
-
-/*
-
-#!/usr/bin/perl -pn
-
-s{((0x)?[0-9a-fA-F]+)(.*\[([\*\ ]{4})\])}{
-
-   ($num,$pat,$bits) = ($1,$3,$4);
-
-   $bits =~ s/([^\s0])|(.)/ defined($1) + 0 /ge;
-
-   $num = ord(pack("B8", $bits));
-   $num |= $num >> 4;
-   $num = sprintf("0x%.2x", $num);
-
-   #print "$num,$pat,$bits\n";
-
-   $num . $pat;
-}ge;
-
-__END__;
-*/
-
-/* Note: binary data consists of one byte for each row of each character top
-   to bottom, character 0 to character 255, six bytes per character. Each
-   byte contains the same four character bits in both nybbles.
-   MSBit to LSBit = left to right.
- */
-
-#ifndef _VIDEO_FONT_DATA_
-#define _VIDEO_FONT_DATA_
-
-#define VIDEO_FONT_CHARS   256
-#define VIDEO_FONT_WIDTH   4
-#define VIDEO_FONT_BYTE_WIDTH  VIDEO_FONT_WIDTH / 8 + (VIDEO_FONT_WIDTH % 8 > 
0)
-#define VIDEO_FONT_HEIGHT  6
-#define VIDEO_FONT_CHAR_PIXEL_DATA_SIZEVIDEO_FONT_HEIGHT * 
VIDEO_FONT_BYTE_WIDTH
-#define VIDEO_FONT_SIZE(VIDEO_FONT_CHARS * VIDEO_FONT_HEIGHT)
-
-static unsigned char video_fontdata[VIDEO_FONT_SIZE] = {
-
-   /*{*/
-   /*   Char 0: ' '  */
-   0xee,   /*=  [*** ]   */
-   0xee,   /*=  [*** ]   */
-   0xee,   /*=  [*** ]   */
-   0xee,   /*=  [*** ]   */
-   0xee,   /*=  [*** ]   */
-   0x00,   /*=  []   */
-   /*}*/
-   /*{*/
-   /*   Char 1: ' '  */
-   0xee,   /*=  [*** ]   */
-   0xee,   /*=  [*** ]   */
-   0xee,   /*=  [*** ]   */
-   0xee,   /*=  [*** ]   */
-   0xee,   /*=  [*** ]   */
-   0x00,   /*=  []   */
-   /*}*/
-   /*{*/
-   /*   Char 2: ' '  */
-   0xee,   /*=  [*** ]   */
-   0xee,   /*=  [*** ]   */
-   0xee,   /*=  [*** ]   */
-   0xee,   /*=  [*** ]   */
-   0xee,   /*=  [*** ]   */
-   0x00,   /*=  []   */
-   /*}*/
-   /*{*/
-   /*   Char 3: ' '  */
-   0xee,   /*=  [*** ]   */
-   0xee,   /*=  [*** ]   */
-   0xee,   /*=  [*** ]   */
-   0xee,   /*=  [*** ]   */
-   0xee,   /*=  [*** ]   */
-   0x00,   /*=  []   */
-   /*}*/
-   /*{*/
-   /*   Char 4: ' '  */
-   0xee,   /*=  [*** ]   */
-   0xee,   /*=  [*** ]   */
-   0xee,   /*=  [*** ]   */
-   0xee,   /*=  [*** ]   */
-   0xee,   /*=  [*** ]   */
-   0x00,   /*=  []   */
-   /*}*/
-   /*{*/
-   /*   Char 5: ' '  */
-   0xee,   /*=  [*** ]   */
-   0xee,   /*=  [*** ]   */
-   0xee,   /*=  [*** ]   */
-   0xee,   /*=  [*** ]   */
-   0xee,   /*=  [*** ]   */
-   0x00,   /*=  []   */
-   /*}*/
-   /*{*/
-   /*   Char 6: ' '  */
-   0xee,   /*=  [*** ]   */
-   0xee,   /*=  [*** ]   */
-   0xee,   /*=  [*** ]   */
-   0xee,   /*=  [*** ]   */
-   0xee,   /*=  [*** ]   */
-   0x00,   /*=  []   */
-   /*}*/
-   /*{*/
-   /*   Char 7: ' '  */
-   0xee,   /*=  [*** ]   */
-   0xee,   /*=  [*** ]   */
-   0xee,   /*=  [*** ]   */
-