Re: [PATCH 5/6] arm: zynq: Pass the missing argument type in function definition

[Michal Simek]

On 6/9/23 11:22, Ashok Reddy Soma wrote:

From: Algapally Santosh Sagar 

Pass missing argument type in the function definition to fix the
sparse warning, warning: old-style function definition
[-Wold-style-definition]

Signed-off-by: Algapally Santosh Sagar 
Signed-off-by: Ashok Reddy Soma 
---

  board/xilinx/zynq/zynq-zc706/ps7_init_gpl.c | 4 ++--


I see the same thing also

board/xilinx/zynq/zynq-microzed/ps7_init_gpl.c:12430:ps7_init()
board/xilinx/zynq/zynq-zc702/ps7_init_gpl.c:12763:ps7_init()
board/xilinx/zynq/zynq-zc706/ps7_init_gpl.c:12670:ps7_init()
board/xilinx/zynq/zynq-zed/ps7_init_gpl.c:12328:ps7_init()

board/xilinx/zynq/zynq-microzed/ps7_init_gpl.c:12411:ps7_post_config()
board/xilinx/zynq/zynq-zc702/ps7_init_gpl.c:12744:ps7_post_config()
board/xilinx/zynq/zynq-zc706/ps7_init_gpl.c:12651:ps7_post_config()
board/xilinx/zynq/zynq-zed/ps7_init_gpl.c:12309:ps7_post_config()

Thanks,
Michal

[PATCH 5/6] arm: zynq: Pass the missing argument type in function definition

[Ashok Reddy Soma]

From: Algapally Santosh Sagar 

Pass missing argument type in the function definition to fix the
sparse warning, warning: old-style function definition
[-Wold-style-definition]

Signed-off-by: Algapally Santosh Sagar 
Signed-off-by: Ashok Reddy Soma 
---

 board/xilinx/zynq/zynq-zc706/ps7_init_gpl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/xilinx/zynq/zynq-zc706/ps7_init_gpl.c 
b/board/xilinx/zynq/zynq-zc706/ps7_init_gpl.c
index 796e5b0c5f..6b153aa379 100644
--- a/board/xilinx/zynq/zynq-zc706/ps7_init_gpl.c
+++ b/board/xilinx/zynq/zynq-zc706/ps7_init_gpl.c
@@ -12648,7 +12648,7 @@ unsigned long *ps7_ddr_init_data = 
ps7_ddr_init_data_3_0;
 unsigned long *ps7_peripherals_init_data = ps7_peripherals_init_data_3_0;
 
 int
-ps7_post_config()
+ps7_post_config(void)
 {
   // Get the PS_VERSION on run time
   unsigned long si_ver = ps7GetSiliconVersion ();
@@ -12667,7 +12667,7 @@ ps7_post_config()
 }
 
 int
-ps7_init()
+ps7_init(void)
 {
   // Get the PS_VERSION on run time
   unsigned long si_ver = ps7GetSiliconVersion ();
-- 
2.17.1