Re: [PATCH 73/81] usb: Remove and add needed includes
On Sat, May 04, 2024 at 10:09:52AM -0700, E Shattow wrote: > On Wed, May 1, 2024 at 7:00 PM Tom Rini wrote: > > > > Remove from this driver directory and when needed > > add missing include files directly. > > > > Signed-off-by: Tom Rini > > --- > > Cc: Marek Vasut > > Cc: Tom Rini > > Cc: Neil Armstrong > > Cc: Lukasz Majewski > > Cc: Mattijs Korpershoek > > Cc: Eddie Cai > > Cc: Patrice Chotard > > Cc: Caleb Connolly > > Cc: Sumit Garg > > Cc: Michal Simek > > Cc: Bin Meng > > Cc: Ryder Lee > > Cc: Weijie Gao > > Cc: Chunfeng Yun > > Cc: GSS_MTK_Uboot_upstream > > Cc: Nobuhiro Iwamatsu > > Cc: Stephan Gerhold > > Cc: Linus Walleij > > Cc: Simon Glass > > Cc: Philipp Tomsich > > Cc: Kever Yang > > Cc: Nishanth Menon > > Cc: Igor Prusov > > Cc: Roger Quadros > > Cc: Svyatoslav Ryhel > > Cc: Jonas Karlman > > Cc: Jagan Teki > > Cc: Venkatesh Yadav Abbarapu > > Cc: Peter Korsgaard > > Cc: Oleksandr Suvorov > > Cc: Alexey Romanov > > Cc: Sean Anderson > > Cc: Miquel Raynal > > Cc: Teik Heng Chong > > Cc: Tim Harvey > > Cc: Mathieu Othacehe > > Cc: Fabio Estevam > > Cc: Johan Jonker > > Cc: Xavier Drudis Ferran > > Cc: Fabrice Gasnier > > Cc: Patrick Delaunay > > Cc: Sam Edwards > > Cc: Andre Przywara > > --- > > drivers/usb/cdns3/cdns3-ti.c | 1 - > > drivers/usb/cdns3/core.c | 1 - > > drivers/usb/common/common.c| 1 - > > drivers/usb/common/fsl-dt-fixup.c | 1 - > > drivers/usb/common/fsl-errata.c| 1 - > > drivers/usb/dwc3/core.c| 1 - > > drivers/usb/dwc3/dwc3-generic.c| 1 - > > drivers/usb/dwc3/dwc3-layerscape.c | 1 - > > drivers/usb/dwc3/dwc3-meson-g12a.c | 1 - > > drivers/usb/dwc3/dwc3-meson-gxl.c | 1 - > > drivers/usb/dwc3/dwc3-omap.c | 1 - > > drivers/usb/dwc3/ep0.c | 1 - > > drivers/usb/dwc3/gadget.c | 1 - > > drivers/usb/dwc3/samsung_usb_phy.c | 2 +- > > drivers/usb/dwc3/ti_usb_phy.c | 1 - > > drivers/usb/emul/sandbox_flash.c | 1 - > > drivers/usb/emul/sandbox_hub.c | 1 - > > drivers/usb/emul/sandbox_keyb.c| 1 - > > drivers/usb/emul/usb-emul-uclass.c | 1 - > > drivers/usb/eth/asix.c | 1 - > > drivers/usb/eth/asix88179.c| 1 - > > drivers/usb/eth/mcs7830.c | 1 - > > drivers/usb/eth/r8152.c| 1 - > > drivers/usb/eth/r8152_fw.c | 1 - > > drivers/usb/eth/smsc95xx.c | 1 - > > drivers/usb/eth/usb_ether.c| 1 - > > drivers/usb/gadget/at91_udc.c | 1 - > > drivers/usb/gadget/atmel_usba_udc.c| 1 - > > drivers/usb/gadget/bcm_udc_otg_phy.c | 1 - > > drivers/usb/gadget/ci_udc.c| 1 - > > drivers/usb/gadget/config.c| 1 - > > drivers/usb/gadget/dwc2_udc_otg.c | 1 - > > drivers/usb/gadget/dwc2_udc_otg_phy.c | 1 - > > drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c | 1 - > > drivers/usb/gadget/ep0.c | 1 - > > drivers/usb/gadget/epautoconf.c| 1 - > > drivers/usb/gadget/ether.c | 1 - > > drivers/usb/gadget/f_acm.c | 1 - > > drivers/usb/gadget/f_dfu.c | 1 - > > drivers/usb/gadget/f_fastboot.c| 1 - > > drivers/usb/gadget/f_mass_storage.c| 1 - > > drivers/usb/gadget/f_rockusb.c | 1 - > > drivers/usb/gadget/f_sdp.c | 1 - > > drivers/usb/gadget/f_thor.c| 1 - > > drivers/usb/gadget/g_dnl.c | 1 - > > drivers/usb/gadget/max3420_udc.c | 1 - > > drivers/usb/gadget/rndis.c | 1 - > > drivers/usb/gadget/udc/udc-core.c | 1 - > > drivers/usb/gadget/udc/udc-uclass.c| 1 - > > drivers/usb/gadget/usbstring.c | 1 - > > drivers/usb/host/dwc2.c| 1 - > > drivers/usb/host/dwc3-of-simple.c | 1 - > > drivers/usb/host/dwc3-sti-glue.c | 1 - > > drivers/usb/host/ehci-atmel.c | 1 - > > drivers/usb/host/ehci-exynos.c | 1 - > > drivers/usb/host/ehci-fsl.c| 1 - > > drivers/usb/host/ehci-generic.c| 1 - > > drivers/usb/host/ehci-hcd.c| 1 - > > drivers/usb/host/ehci-marvell.c| 1 - > > drivers/usb/host/ehci-msm.c| 1 - > > drivers/usb/host/ehci-mx5.c| 1 - > > drivers/usb/host/ehci-mx6.c| 1 - > > drivers/usb/host/ehci-mxs.c| 1 - > > drivers/usb/host/ehci-npcm.c | 1 - > > drivers/usb/host/ehci-omap.c | 2 +- > > drivers/usb/host/ehci-pci.c| 1 - > > drivers/usb/host/ehci-tegra.c | 1 - > > drivers/usb/host/ehci-vf.c | 1 - > > drivers/usb/host/ehci-zynq.c | 1 -
Re: [PATCH 73/81] usb: Remove and add needed includes
On Wed, May 1, 2024 at 7:00 PM Tom Rini wrote: > > Remove from this driver directory and when needed > add missing include files directly. > > Signed-off-by: Tom Rini > --- > Cc: Marek Vasut > Cc: Tom Rini > Cc: Neil Armstrong > Cc: Lukasz Majewski > Cc: Mattijs Korpershoek > Cc: Eddie Cai > Cc: Patrice Chotard > Cc: Caleb Connolly > Cc: Sumit Garg > Cc: Michal Simek > Cc: Bin Meng > Cc: Ryder Lee > Cc: Weijie Gao > Cc: Chunfeng Yun > Cc: GSS_MTK_Uboot_upstream > Cc: Nobuhiro Iwamatsu > Cc: Stephan Gerhold > Cc: Linus Walleij > Cc: Simon Glass > Cc: Philipp Tomsich > Cc: Kever Yang > Cc: Nishanth Menon > Cc: Igor Prusov > Cc: Roger Quadros > Cc: Svyatoslav Ryhel > Cc: Jonas Karlman > Cc: Jagan Teki > Cc: Venkatesh Yadav Abbarapu > Cc: Peter Korsgaard > Cc: Oleksandr Suvorov > Cc: Alexey Romanov > Cc: Sean Anderson > Cc: Miquel Raynal > Cc: Teik Heng Chong > Cc: Tim Harvey > Cc: Mathieu Othacehe > Cc: Fabio Estevam > Cc: Johan Jonker > Cc: Xavier Drudis Ferran > Cc: Fabrice Gasnier > Cc: Patrick Delaunay > Cc: Sam Edwards > Cc: Andre Przywara > --- > drivers/usb/cdns3/cdns3-ti.c | 1 - > drivers/usb/cdns3/core.c | 1 - > drivers/usb/common/common.c| 1 - > drivers/usb/common/fsl-dt-fixup.c | 1 - > drivers/usb/common/fsl-errata.c| 1 - > drivers/usb/dwc3/core.c| 1 - > drivers/usb/dwc3/dwc3-generic.c| 1 - > drivers/usb/dwc3/dwc3-layerscape.c | 1 - > drivers/usb/dwc3/dwc3-meson-g12a.c | 1 - > drivers/usb/dwc3/dwc3-meson-gxl.c | 1 - > drivers/usb/dwc3/dwc3-omap.c | 1 - > drivers/usb/dwc3/ep0.c | 1 - > drivers/usb/dwc3/gadget.c | 1 - > drivers/usb/dwc3/samsung_usb_phy.c | 2 +- > drivers/usb/dwc3/ti_usb_phy.c | 1 - > drivers/usb/emul/sandbox_flash.c | 1 - > drivers/usb/emul/sandbox_hub.c | 1 - > drivers/usb/emul/sandbox_keyb.c| 1 - > drivers/usb/emul/usb-emul-uclass.c | 1 - > drivers/usb/eth/asix.c | 1 - > drivers/usb/eth/asix88179.c| 1 - > drivers/usb/eth/mcs7830.c | 1 - > drivers/usb/eth/r8152.c| 1 - > drivers/usb/eth/r8152_fw.c | 1 - > drivers/usb/eth/smsc95xx.c | 1 - > drivers/usb/eth/usb_ether.c| 1 - > drivers/usb/gadget/at91_udc.c | 1 - > drivers/usb/gadget/atmel_usba_udc.c| 1 - > drivers/usb/gadget/bcm_udc_otg_phy.c | 1 - > drivers/usb/gadget/ci_udc.c| 1 - > drivers/usb/gadget/config.c| 1 - > drivers/usb/gadget/dwc2_udc_otg.c | 1 - > drivers/usb/gadget/dwc2_udc_otg_phy.c | 1 - > drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c | 1 - > drivers/usb/gadget/ep0.c | 1 - > drivers/usb/gadget/epautoconf.c| 1 - > drivers/usb/gadget/ether.c | 1 - > drivers/usb/gadget/f_acm.c | 1 - > drivers/usb/gadget/f_dfu.c | 1 - > drivers/usb/gadget/f_fastboot.c| 1 - > drivers/usb/gadget/f_mass_storage.c| 1 - > drivers/usb/gadget/f_rockusb.c | 1 - > drivers/usb/gadget/f_sdp.c | 1 - > drivers/usb/gadget/f_thor.c| 1 - > drivers/usb/gadget/g_dnl.c | 1 - > drivers/usb/gadget/max3420_udc.c | 1 - > drivers/usb/gadget/rndis.c | 1 - > drivers/usb/gadget/udc/udc-core.c | 1 - > drivers/usb/gadget/udc/udc-uclass.c| 1 - > drivers/usb/gadget/usbstring.c | 1 - > drivers/usb/host/dwc2.c| 1 - > drivers/usb/host/dwc3-of-simple.c | 1 - > drivers/usb/host/dwc3-sti-glue.c | 1 - > drivers/usb/host/ehci-atmel.c | 1 - > drivers/usb/host/ehci-exynos.c | 1 - > drivers/usb/host/ehci-fsl.c| 1 - > drivers/usb/host/ehci-generic.c| 1 - > drivers/usb/host/ehci-hcd.c| 1 - > drivers/usb/host/ehci-marvell.c| 1 - > drivers/usb/host/ehci-msm.c| 1 - > drivers/usb/host/ehci-mx5.c| 1 - > drivers/usb/host/ehci-mx6.c| 1 - > drivers/usb/host/ehci-mxs.c| 1 - > drivers/usb/host/ehci-npcm.c | 1 - > drivers/usb/host/ehci-omap.c | 2 +- > drivers/usb/host/ehci-pci.c| 1 - > drivers/usb/host/ehci-tegra.c | 1 - > drivers/usb/host/ehci-vf.c | 1 - > drivers/usb/host/ehci-zynq.c | 1 - > drivers/usb/host/ohci-at91.c | 1 - > drivers/usb/host/ohci-da8xx.c | 1 - > drivers/usb/host/ohci-generic.c| 1 - > drivers/usb/host/ohci-hcd.c| 2 +- > drivers/usb/host/ohci-lpc32xx.c| 1 - > drivers/usb/host/ohci-npcm.c
Re: [PATCH 73/81] usb: Remove and add needed includes
Hi Tom, On jeu., mai 02, 2024 at 08:51, Tom Rini wrote: > On Thu, May 02, 2024 at 09:40:52AM +0200, Mattijs Korpershoek wrote: >> Hi Tom, >> >> Thank you for the patch >> >> On mer., mai 01, 2024 at 19:31, Tom Rini wrote: >> >> > Remove from this driver directory and when needed >> > add missing include files directly. >> > >> > Signed-off-by: Tom Rini >> >> [...] >> >> > diff --git a/drivers/usb/host/xhci-rcar.c b/drivers/usb/host/xhci-rcar.c >> > index fedcf7869295..38c5928faed5 100644 >> > --- a/drivers/usb/host/xhci-rcar.c >> > +++ b/drivers/usb/host/xhci-rcar.c >> > @@ -5,7 +5,6 @@ >> > * Renesas RCar USB HOST xHCI Controller >> > */ >> > >> > -#include >> > #include >> > #include >> > #include >> > diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c >> > index 910c5f3352b8..1360a5940fa0 100644 >> > --- a/drivers/usb/host/xhci-ring.c >> > +++ b/drivers/usb/host/xhci-ring.c >> > @@ -13,7 +13,6 @@ >> > *Vikas Sajjan >> > */ >> > >> > -#include >> >> This generates the following build warning with >> khadas-vim3_android_defconfig: >> >> drivers/usb/host/xhci-ring.c: In function 'xhci_wait_for_event': >> drivers/usb/host/xhci-ring.c:464:28: warning: implicit declaration of >> function 'get_timer'; did you mean 'get_mem'? >> [-Wimplicit-function-declaration] >> 464 | unsigned long ts = get_timer(0); >> |^ >> |get_mem >> >> Adding: "#include " fixes the warning. >> >> With the above fix included: >> >> Reviewed-by: Mattijs Korpershoek > > Did you have the full series applied? I don't see the warning here (nor > in CI) and I suspect that: > https://patchwork.ozlabs.org/project/uboot/patch/20240502013138.2383421-9-tr...@konsulko.com/ > is what resolves this warning. No, I did not apply the full series. I had some conflicts on both: - master: ff0de1f0557e ("Merge patch series "Update PHYTEC SOM Detection"") - next: bc39e0677816 ("Subtree merge tag 'v6.8-dts' of devicetree-rebasing repo [1] into dts/upstream") The above patch resolves the warning, indeed! Thanks > > -- > Tom
Re: [PATCH 73/81] usb: Remove and add needed includes
On Thu, May 02, 2024 at 09:40:52AM +0200, Mattijs Korpershoek wrote: > Hi Tom, > > Thank you for the patch > > On mer., mai 01, 2024 at 19:31, Tom Rini wrote: > > > Remove from this driver directory and when needed > > add missing include files directly. > > > > Signed-off-by: Tom Rini > > [...] > > > diff --git a/drivers/usb/host/xhci-rcar.c b/drivers/usb/host/xhci-rcar.c > > index fedcf7869295..38c5928faed5 100644 > > --- a/drivers/usb/host/xhci-rcar.c > > +++ b/drivers/usb/host/xhci-rcar.c > > @@ -5,7 +5,6 @@ > > * Renesas RCar USB HOST xHCI Controller > > */ > > > > -#include > > #include > > #include > > #include > > diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c > > index 910c5f3352b8..1360a5940fa0 100644 > > --- a/drivers/usb/host/xhci-ring.c > > +++ b/drivers/usb/host/xhci-ring.c > > @@ -13,7 +13,6 @@ > > * Vikas Sajjan > > */ > > > > -#include > > This generates the following build warning with > khadas-vim3_android_defconfig: > > drivers/usb/host/xhci-ring.c: In function 'xhci_wait_for_event': > drivers/usb/host/xhci-ring.c:464:28: warning: implicit declaration of > function 'get_timer'; did you mean 'get_mem'? > [-Wimplicit-function-declaration] > 464 | unsigned long ts = get_timer(0); > |^ > |get_mem > > Adding: "#include " fixes the warning. > > With the above fix included: > > Reviewed-by: Mattijs Korpershoek Did you have the full series applied? I don't see the warning here (nor in CI) and I suspect that: https://patchwork.ozlabs.org/project/uboot/patch/20240502013138.2383421-9-tr...@konsulko.com/ is what resolves this warning. -- Tom signature.asc Description: PGP signature
Re: [PATCH 73/81] usb: Remove and add needed includes
Hi Tom, Thank you for the patch On mer., mai 01, 2024 at 19:31, Tom Rini wrote: > Remove from this driver directory and when needed > add missing include files directly. > > Signed-off-by: Tom Rini [...] > diff --git a/drivers/usb/host/xhci-rcar.c b/drivers/usb/host/xhci-rcar.c > index fedcf7869295..38c5928faed5 100644 > --- a/drivers/usb/host/xhci-rcar.c > +++ b/drivers/usb/host/xhci-rcar.c > @@ -5,7 +5,6 @@ > * Renesas RCar USB HOST xHCI Controller > */ > > -#include > #include > #include > #include > diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c > index 910c5f3352b8..1360a5940fa0 100644 > --- a/drivers/usb/host/xhci-ring.c > +++ b/drivers/usb/host/xhci-ring.c > @@ -13,7 +13,6 @@ > * Vikas Sajjan > */ > > -#include This generates the following build warning with khadas-vim3_android_defconfig: drivers/usb/host/xhci-ring.c: In function 'xhci_wait_for_event': drivers/usb/host/xhci-ring.c:464:28: warning: implicit declaration of function 'get_timer'; did you mean 'get_mem'? [-Wimplicit-function-declaration] 464 | unsigned long ts = get_timer(0); |^ |get_mem Adding: "#include " fixes the warning. With the above fix included: Reviewed-by: Mattijs Korpershoek > #include > #include > #include > diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c > index 741e186ee05b..d30725d3fcaa 100644 > --- a/drivers/usb/host/xhci.c > +++ b/drivers/usb/host/xhci.c > @@ -19,7 +19,6 @@ > * The quirk devices support hasn't been given yet. > */ > > -#include > #include > #include > #include [...]
[PATCH 73/81] usb: Remove and add needed includes
Remove from this driver directory and when needed add missing include files directly. Signed-off-by: Tom Rini --- Cc: Marek Vasut Cc: Tom Rini Cc: Neil Armstrong Cc: Lukasz Majewski Cc: Mattijs Korpershoek Cc: Eddie Cai Cc: Patrice Chotard Cc: Caleb Connolly Cc: Sumit Garg Cc: Michal Simek Cc: Bin Meng Cc: Ryder Lee Cc: Weijie Gao Cc: Chunfeng Yun Cc: GSS_MTK_Uboot_upstream Cc: Nobuhiro Iwamatsu Cc: Stephan Gerhold Cc: Linus Walleij Cc: Simon Glass Cc: Philipp Tomsich Cc: Kever Yang Cc: Nishanth Menon Cc: Igor Prusov Cc: Roger Quadros Cc: Svyatoslav Ryhel Cc: Jonas Karlman Cc: Jagan Teki Cc: Venkatesh Yadav Abbarapu Cc: Peter Korsgaard Cc: Oleksandr Suvorov Cc: Alexey Romanov Cc: Sean Anderson Cc: Miquel Raynal Cc: Teik Heng Chong Cc: Tim Harvey Cc: Mathieu Othacehe Cc: Fabio Estevam Cc: Johan Jonker Cc: Xavier Drudis Ferran Cc: Fabrice Gasnier Cc: Patrick Delaunay Cc: Sam Edwards Cc: Andre Przywara --- drivers/usb/cdns3/cdns3-ti.c | 1 - drivers/usb/cdns3/core.c | 1 - drivers/usb/common/common.c| 1 - drivers/usb/common/fsl-dt-fixup.c | 1 - drivers/usb/common/fsl-errata.c| 1 - drivers/usb/dwc3/core.c| 1 - drivers/usb/dwc3/dwc3-generic.c| 1 - drivers/usb/dwc3/dwc3-layerscape.c | 1 - drivers/usb/dwc3/dwc3-meson-g12a.c | 1 - drivers/usb/dwc3/dwc3-meson-gxl.c | 1 - drivers/usb/dwc3/dwc3-omap.c | 1 - drivers/usb/dwc3/ep0.c | 1 - drivers/usb/dwc3/gadget.c | 1 - drivers/usb/dwc3/samsung_usb_phy.c | 2 +- drivers/usb/dwc3/ti_usb_phy.c | 1 - drivers/usb/emul/sandbox_flash.c | 1 - drivers/usb/emul/sandbox_hub.c | 1 - drivers/usb/emul/sandbox_keyb.c| 1 - drivers/usb/emul/usb-emul-uclass.c | 1 - drivers/usb/eth/asix.c | 1 - drivers/usb/eth/asix88179.c| 1 - drivers/usb/eth/mcs7830.c | 1 - drivers/usb/eth/r8152.c| 1 - drivers/usb/eth/r8152_fw.c | 1 - drivers/usb/eth/smsc95xx.c | 1 - drivers/usb/eth/usb_ether.c| 1 - drivers/usb/gadget/at91_udc.c | 1 - drivers/usb/gadget/atmel_usba_udc.c| 1 - drivers/usb/gadget/bcm_udc_otg_phy.c | 1 - drivers/usb/gadget/ci_udc.c| 1 - drivers/usb/gadget/config.c| 1 - drivers/usb/gadget/dwc2_udc_otg.c | 1 - drivers/usb/gadget/dwc2_udc_otg_phy.c | 1 - drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c | 1 - drivers/usb/gadget/ep0.c | 1 - drivers/usb/gadget/epautoconf.c| 1 - drivers/usb/gadget/ether.c | 1 - drivers/usb/gadget/f_acm.c | 1 - drivers/usb/gadget/f_dfu.c | 1 - drivers/usb/gadget/f_fastboot.c| 1 - drivers/usb/gadget/f_mass_storage.c| 1 - drivers/usb/gadget/f_rockusb.c | 1 - drivers/usb/gadget/f_sdp.c | 1 - drivers/usb/gadget/f_thor.c| 1 - drivers/usb/gadget/g_dnl.c | 1 - drivers/usb/gadget/max3420_udc.c | 1 - drivers/usb/gadget/rndis.c | 1 - drivers/usb/gadget/udc/udc-core.c | 1 - drivers/usb/gadget/udc/udc-uclass.c| 1 - drivers/usb/gadget/usbstring.c | 1 - drivers/usb/host/dwc2.c| 1 - drivers/usb/host/dwc3-of-simple.c | 1 - drivers/usb/host/dwc3-sti-glue.c | 1 - drivers/usb/host/ehci-atmel.c | 1 - drivers/usb/host/ehci-exynos.c | 1 - drivers/usb/host/ehci-fsl.c| 1 - drivers/usb/host/ehci-generic.c| 1 - drivers/usb/host/ehci-hcd.c| 1 - drivers/usb/host/ehci-marvell.c| 1 - drivers/usb/host/ehci-msm.c| 1 - drivers/usb/host/ehci-mx5.c| 1 - drivers/usb/host/ehci-mx6.c| 1 - drivers/usb/host/ehci-mxs.c| 1 - drivers/usb/host/ehci-npcm.c | 1 - drivers/usb/host/ehci-omap.c | 2 +- drivers/usb/host/ehci-pci.c| 1 - drivers/usb/host/ehci-tegra.c | 1 - drivers/usb/host/ehci-vf.c | 1 - drivers/usb/host/ehci-zynq.c | 1 - drivers/usb/host/ohci-at91.c | 1 - drivers/usb/host/ohci-da8xx.c | 1 - drivers/usb/host/ohci-generic.c| 1 - drivers/usb/host/ohci-hcd.c| 2 +- drivers/usb/host/ohci-lpc32xx.c| 1 - drivers/usb/host/ohci-npcm.c | 1 - drivers/usb/host/ohci-pci.c| 1 - drivers/usb/host/r8a66597-hcd.c| 1 - drivers/usb/host/usb-sandbox.c | 1 - drivers/usb/host/usb-uclass.c | 1 - drivers/usb/host/usb_bootdev.c | 1 - drivers/usb/host/xhci-brcm.c