Re: [PATCH V2] riscv: binman: fix the load field format

2023-11-16 Thread Simon Glass
On Thu, 16 Nov 2023 at 03:18, Randolph  wrote:
>
> Using /bits/64 prefix for 64bits address
>
> Signed-off-by: Randolph 
> ---
>  arch/riscv/dts/binman.dtsi | 14 --
>  1 file changed, 4 insertions(+), 10 deletions(-)
>

Reviewed-by: Simon Glass 

It is normally written '/bits/ 64' i.e. with a space.


> diff --git a/arch/riscv/dts/binman.dtsi b/arch/riscv/dts/binman.dtsi
> index 6b4eb8dc7b..777b1309d0 100644
> --- a/arch/riscv/dts/binman.dtsi
> +++ b/arch/riscv/dts/binman.dtsi
> @@ -5,9 +5,6 @@
>
>  #include 
>
> -#define U64_TO_U32_H(addr) (((addr) >> 32) & 0x)
> -#define U64_TO_U32_L(addr) ((addr) & 0x)
> -
>  / {
> binman: binman {
> multiple-images;
> @@ -36,8 +33,7 @@
> os = "U-Boot";
> arch = "riscv";
> compression = "none";
> -   load =  -   
> U64_TO_U32_L(CONFIG_TEXT_BASE)>;
> +   load = /bits/64 ;
>
> uboot_blob: blob-ext {
> filename = "u-boot-nodtb.bin";
> @@ -50,7 +46,7 @@
> os = "Linux";
> arch = "riscv";
> compression = "none";
> -   load = ;
> +   load = /bits/64 ;
>
> linux_blob: blob-ext {
> filename = "Image";
> @@ -64,10 +60,8 @@
> os = "opensbi";
> arch = "riscv";
> compression = "none";
> -   load = 
>  -   
> U64_TO_U32_L(CONFIG_SPL_OPENSBI_LOAD_ADDR)>;
> -   entry = 
>  -   
> U64_TO_U32_L(CONFIG_SPL_OPENSBI_LOAD_ADDR)>;
> +   load = /bits/64 
> ;
> +   entry = /bits/64 
> ;
>
> opensbi_blob: opensbi {
> filename = "fw_dynamic.bin";
> --
> 2.34.1
>


[PATCH V2] riscv: binman: fix the load field format

2023-11-16 Thread Randolph
Using /bits/64 prefix for 64bits address

Signed-off-by: Randolph 
---
 arch/riscv/dts/binman.dtsi | 14 --
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/arch/riscv/dts/binman.dtsi b/arch/riscv/dts/binman.dtsi
index 6b4eb8dc7b..777b1309d0 100644
--- a/arch/riscv/dts/binman.dtsi
+++ b/arch/riscv/dts/binman.dtsi
@@ -5,9 +5,6 @@
 
 #include 
 
-#define U64_TO_U32_H(addr) (((addr) >> 32) & 0x)
-#define U64_TO_U32_L(addr) ((addr) & 0x)
-
 / {
binman: binman {
multiple-images;
@@ -36,8 +33,7 @@
os = "U-Boot";
arch = "riscv";
compression = "none";
-   load = ;
+   load = /bits/64 ;
 
uboot_blob: blob-ext {
filename = "u-boot-nodtb.bin";
@@ -50,7 +46,7 @@
os = "Linux";
arch = "riscv";
compression = "none";
-   load = ;
+   load = /bits/64 ;
 
linux_blob: blob-ext {
filename = "Image";
@@ -64,10 +60,8 @@
os = "opensbi";
arch = "riscv";
compression = "none";
-   load = 
;
-   entry = 
;
+   load = /bits/64 
;
+   entry = /bits/64 
;
 
opensbi_blob: opensbi {
filename = "fw_dynamic.bin";
-- 
2.34.1