Re: [PATCH V2 1/6] ARM: rmobile: Enable board detection when FIT is enabled

[Adam Ford]

On Tue, Oct 5, 2021 at 7:35 AM Adam Ford  wrote:
>
> On Mon, Sep 20, 2021 at 11:14 AM Adam Ford  wrote:
> >
> > There are three boards from Beacon, RZ/G2 M/N/H which all
> > use the same board file, but different device trees.
> > Add code to automatically select the proper device tree
> > based on the CPU type.
> >
> > Signed-off-by: Adam Ford 
>
> Marek,
>
> You previously asked me to remind you after 2 weeks, so it doesn't get
> too stale.  I rebased at the time I did the V2.  Can you give
> feedback?

Marek,

Ping #2.  It's been three weeks since my last ping, and I was hoping
you might have some feedback and/or be able to apply this.

thank you,

adam
>
> thank you,
>
> adam
> > ---
> >  board/beacon/beacon-rzg2m/beacon-rzg2m.c | 16 
> >  1 file changed, 16 insertions(+)
> >
> > diff --git a/board/beacon/beacon-rzg2m/beacon-rzg2m.c 
> > b/board/beacon/beacon-rzg2m/beacon-rzg2m.c
> > index c12ff77fb2..b3521fcbc1 100644
> > --- a/board/beacon/beacon-rzg2m/beacon-rzg2m.c
> > +++ b/board/beacon/beacon-rzg2m/beacon-rzg2m.c
> > @@ -36,3 +36,19 @@ void reset_cpu(void)
> >  {
> > writel(RST_CODE, RST_CA57RESCNT);
> >  }
> > +
> > +#if IS_ENABLED(CONFIG_MULTI_DTB_FIT)
> > +int board_fit_config_name_match(const char *name)
> > +{
> > +   if (!strcmp(rzg_get_cpu_name(), "R8A774A1") && !strcmp(name, 
> > "r8a774a1-beacon-rzg2m-kit"))
> > +   return 0;
> > +
> > +   if (!strcmp(rzg_get_cpu_name(), "R8A774B1") && !strcmp(name, 
> > "r8a774b1-beacon-rzg2n-kit"))
> > +   return 0;
> > +
> > +   if (!strcmp(rzg_get_cpu_name(), "R8A774E1") && !strcmp(name, 
> > "r8a774e1-beacon-rzg2h-kit"))
> > +   return 0;
> > +
> > +   return -1;
> > +}
> > +#endif
> > --
> > 2.25.1
> >

Re: [PATCH V2 1/6] ARM: rmobile: Enable board detection when FIT is enabled

[Adam Ford]

On Mon, Sep 20, 2021 at 11:14 AM Adam Ford  wrote:
>
> There are three boards from Beacon, RZ/G2 M/N/H which all
> use the same board file, but different device trees.
> Add code to automatically select the proper device tree
> based on the CPU type.
>
> Signed-off-by: Adam Ford 

Marek,

You previously asked me to remind you after 2 weeks, so it doesn't get
too stale.  I rebased at the time I did the V2.  Can you give
feedback?

thank you,

adam
> ---
>  board/beacon/beacon-rzg2m/beacon-rzg2m.c | 16 
>  1 file changed, 16 insertions(+)
>
> diff --git a/board/beacon/beacon-rzg2m/beacon-rzg2m.c 
> b/board/beacon/beacon-rzg2m/beacon-rzg2m.c
> index c12ff77fb2..b3521fcbc1 100644
> --- a/board/beacon/beacon-rzg2m/beacon-rzg2m.c
> +++ b/board/beacon/beacon-rzg2m/beacon-rzg2m.c
> @@ -36,3 +36,19 @@ void reset_cpu(void)
>  {
> writel(RST_CODE, RST_CA57RESCNT);
>  }
> +
> +#if IS_ENABLED(CONFIG_MULTI_DTB_FIT)
> +int board_fit_config_name_match(const char *name)
> +{
> +   if (!strcmp(rzg_get_cpu_name(), "R8A774A1") && !strcmp(name, 
> "r8a774a1-beacon-rzg2m-kit"))
> +   return 0;
> +
> +   if (!strcmp(rzg_get_cpu_name(), "R8A774B1") && !strcmp(name, 
> "r8a774b1-beacon-rzg2n-kit"))
> +   return 0;
> +
> +   if (!strcmp(rzg_get_cpu_name(), "R8A774E1") && !strcmp(name, 
> "r8a774e1-beacon-rzg2h-kit"))
> +   return 0;
> +
> +   return -1;
> +}
> +#endif
> --
> 2.25.1
>

[PATCH V2 1/6] ARM: rmobile: Enable board detection when FIT is enabled

[Adam Ford]

There are three boards from Beacon, RZ/G2 M/N/H which all
use the same board file, but different device trees.
Add code to automatically select the proper device tree
based on the CPU type.

Signed-off-by: Adam Ford 
---
 board/beacon/beacon-rzg2m/beacon-rzg2m.c | 16 
 1 file changed, 16 insertions(+)

diff --git a/board/beacon/beacon-rzg2m/beacon-rzg2m.c 
b/board/beacon/beacon-rzg2m/beacon-rzg2m.c
index c12ff77fb2..b3521fcbc1 100644
--- a/board/beacon/beacon-rzg2m/beacon-rzg2m.c
+++ b/board/beacon/beacon-rzg2m/beacon-rzg2m.c
@@ -36,3 +36,19 @@ void reset_cpu(void)
 {
writel(RST_CODE, RST_CA57RESCNT);
 }
+
+#if IS_ENABLED(CONFIG_MULTI_DTB_FIT)
+int board_fit_config_name_match(const char *name)
+{
+   if (!strcmp(rzg_get_cpu_name(), "R8A774A1") && !strcmp(name, 
"r8a774a1-beacon-rzg2m-kit"))
+   return 0;
+
+   if (!strcmp(rzg_get_cpu_name(), "R8A774B1") && !strcmp(name, 
"r8a774b1-beacon-rzg2n-kit"))
+   return 0;
+
+   if (!strcmp(rzg_get_cpu_name(), "R8A774E1") && !strcmp(name, 
"r8a774e1-beacon-rzg2h-kit"))
+   return 0;
+
+   return -1;
+}
+#endif
-- 
2.25.1