Re: [PATCH V2 5/7] spl: riscv: add os type for next booting stage

2023-10-12 Thread Simon Glass
On Wed, 11 Oct 2023 at 23:44, Randolph  wrote:
>
> If SPL_LOAD_FIT_OPENSBI_OS_BOOT is enabled, the function
> spl_invoke_opensbi should change the target OS type to IH_OS_LINUX.
> OpenSBI will load the Linux image as the next boot stage.
> The os_takes_devicetree function returns a value of true or false
> depending on whether or not SPL_LOAD_FIT_OPENSBI_OS_BOOT is enabled.
>
> Signed-off-by: Randolph 
> ---
>  common/spl/spl_fit.c | 3 ++-
>  common/spl/spl_opensbi.c | 9 +++--
>  2 files changed, 9 insertions(+), 3 deletions(-)

Reviewed-by: Simon Glass 


[PATCH V2 5/7] spl: riscv: add os type for next booting stage

2023-10-12 Thread Randolph
If SPL_LOAD_FIT_OPENSBI_OS_BOOT is enabled, the function
spl_invoke_opensbi should change the target OS type to IH_OS_LINUX.
OpenSBI will load the Linux image as the next boot stage.
The os_takes_devicetree function returns a value of true or false
depending on whether or not SPL_LOAD_FIT_OPENSBI_OS_BOOT is enabled.

Signed-off-by: Randolph 
---
 common/spl/spl_fit.c | 3 ++-
 common/spl/spl_opensbi.c | 9 +++--
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/common/spl/spl_fit.c b/common/spl/spl_fit.c
index ce6b8aa370..e9126f07f7 100644
--- a/common/spl/spl_fit.c
+++ b/common/spl/spl_fit.c
@@ -366,7 +366,8 @@ static bool os_takes_devicetree(uint8_t os)
case IH_OS_U_BOOT:
return true;
case IH_OS_LINUX:
-   return IS_ENABLED(CONFIG_SPL_OS_BOOT);
+   return IS_ENABLED(CONFIG_SPL_OS_BOOT) ||
+  IS_ENABLED(CONFIG_SPL_OPENSBI);
default:
return false;
}
diff --git a/common/spl/spl_opensbi.c b/common/spl/spl_opensbi.c
index 6583b31953..9801d38c0b 100644
--- a/common/spl/spl_opensbi.c
+++ b/common/spl/spl_opensbi.c
@@ -59,9 +59,14 @@ void __noreturn spl_invoke_opensbi(struct spl_image_info 
*spl_image)
 
/*
 * Find next os image in /fit-images
-* The next os image default is u-boot proper
+* The next os image default is u-boot proper, once enable
+* OpenSBI OS boot mode, the OS image should be linux.
 */
-   os_type = IH_OS_U_BOOT;
+   if (CONFIG_IS_ENABLED(LOAD_FIT_OPENSBI_OS_BOOT))
+   os_type = IH_OS_LINUX;
+   else
+   os_type = IH_OS_U_BOOT;
+
ret = spl_opensbi_find_os_node(spl_image->fdt_addr, _node, os_type);
if (ret) {
pr_err("Can't find %s node for opensbi, %d\n",
-- 
2.34.1