Re: [PATCH next 2/2] rockchip: remove support for Theobroma Systems RK3368 Lion
Hi Quentin,
On 2024/7/16 10:17, Kever Yang wrote:
On 2024/6/20 18:24, Quentin Schulz wrote:
From: Quentin Schulz
No meaningful changes were made to this SoM since February 2021. Nobody
from Theobroma has booted anything recent on that product since July
2021 at the latest. The product isn't available to buy anymore and
disappeared from our website.
This product is therefore unmaintained and it would be disingenuous to
say the opposite, so drop support for RK3368 Lion.
If you're a user of Lion, feel free to revert this patch or contact our
sales/support department.
Signed-off-by: Quentin Schulz
Reviewed-by: Kever Yang
Thanks,
- Kever
---
arch/arm/dts/rk3368-lion-haikou-u-boot.dtsi | 119 -
arch/arm/dts/rk3368-lion-haikou.dts | 144 ---
arch/arm/dts/rk3368-lion.dtsi | 318
I think you forgot to remove rk3368-lion-haikou.dtb in Makefile.
Thanks,
- Kever
arch/arm/mach-rockchip/rk3368/Kconfig | 22 --
board/theobroma-systems/lion_rk3368/Kconfig | 18 --
board/theobroma-systems/lion_rk3368/MAINTAINERS | 10 -
board/theobroma-systems/lion_rk3368/README | 78 --
configs/lion-rk3368_defconfig | 110
doc/board/rockchip/rockchip.rst | 1 -
include/configs/lion_rk3368.h | 16 --
10 files changed, 836 deletions(-)
diff --git a/arch/arm/dts/rk3368-lion-haikou-u-boot.dtsi
b/arch/arm/dts/rk3368-lion-haikou-u-boot.dtsi
deleted file mode 100644
index a3c2b707e9a..000
--- a/arch/arm/dts/rk3368-lion-haikou-u-boot.dtsi
+++ /dev/null
@@ -1,119 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0+ OR X11
-/*
- * (C) Copyright 2017 Theobroma Systems Design und Consulting GmbH
- */
-
-#include "rk3368-u-boot.dtsi"
-
-/ {
- config {
- u-boot,spl-payload-offset = <0x4>; /* @ 256KB */
- u-boot,mmc-env-offset = <0x4000>; /* @ 16KB */
- };
-
- chosen {
- stdout-path = "serial0:115200n8";
- u-boot,spl-boot-order = &emmc, &sdmmc;
- };
-
- smbios {
- compatible = "u-boot,sysinfo-smbios";
-
- smbios {
- system {
- manufacturer = "rockchip";
- product = "sheep_rk3368";
- };
-
- baseboard {
- manufacturer = "rockchip";
- product = "sheep_rk3368";
- };
-
- chassis {
- manufacturer = "rockchip";
- product = "sheep_rk3368";
- };
- };
- };
-};
-
-&gpio2 {
- bootph-all;
-};
-
-&pinctrl {
- bootph-all;
-};
-
-&service_msch {
- bootph-all;
-};
-
-&dmc {
- bootph-all;
-
- /*
- * Validation of throughput using SPEC2000 shows the following
- * relative performance for the different memory schedules:
- * - CBDR: 30.1
- * - CBRD: 29.8
- * - CRBD: 29.9
- * Note that the best performance for any given application
workload
- * may vary from the default configured here (e.g. 164.gzip is
fastest
- * with CBRD, whereas 252.eon and 186.crafty are fastest with
CRBD).
- *
- * See doc/device-tree-bindings/clock/rockchip,rk3368-dmc.txt for
- * details on the 'rockchip,memory-schedule' property and how it
- * affects the physical-address to device-address mapping.
- */
- rockchip,memory-schedule = ;
- rockchip,ddr-frequency = <8>;
- rockchip,ddr-speed-bin = ;
-
- status = "okay";
-};
-
-&pmugrf {
- bootph-all;
-};
-
-&sgrf {
- bootph-all;
-};
-
-&cru {
- bootph-all;
-};
-
-&grf {
- bootph-all;
-};
-
-&uart0 {
- bootph-all;
-};
-
-&emmc {
- bootph-pre-ram;
-};
-
-&sdmmc {
- bootph-pre-ram;
-};
-
-&spi1 {
- bootph-pre-ram;
-
- spiflash: w25q32dw@0 {
- bootph-pre-ram;
- };
-};
-
-&timer0 {
- bootph-all;
- clock-frequency = <2400>;
- status = "okay";
-};
-
-
diff --git a/arch/arm/dts/rk3368-lion-haikou.dts
b/arch/arm/dts/rk3368-lion-haikou.dts
deleted file mode 100644
index cae01d35b93..000
--- a/arch/arm/dts/rk3368-lion-haikou.dts
+++ /dev/null
@@ -1,144 +0,0 @@
-// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
-/*
- * Copyright (c) 2018 Theobroma Systems Design und Consulting GmbH
- */
-
-/dts-v1/;
-#include "rk3368-lion.dtsi"
-
-/ {
- model = "Theobroma Systems RK3368-uQ7 Baseboard";
- compatible = "tsd,rk3368-lion-haikou", "rockchip,rk3368";
-
- aliases {
- mmc1 = &sdmmc;
- };
-
- chosen {
- stdout-path = "serial0:115200n8";
- };
-
- i2cmux2 {
- i2c@0 {
- eeprom: eeprom@50 {
- compatible = "atmel,24c01";
- pagesize = <8>;
- reg = <0x50>;
- };
- };
- };
-
- leds {
- pinctrl-0 = <&module_led_pins>, <&sd_card_led_pin>;
-
- sd_card_led: led-3 {
- label = "sd_card_led";
- gpios = <&gpio0 RK_PD2 GPIO_ACTIVE_HIGH>;
- linux,default-tr
Re: [PATCH next 2/2] rockchip: remove support for Theobroma Systems RK3368 Lion
On 2024/6/20 18:24, Quentin Schulz wrote:
From: Quentin Schulz
No meaningful changes were made to this SoM since February 2021. Nobody
from Theobroma has booted anything recent on that product since July
2021 at the latest. The product isn't available to buy anymore and
disappeared from our website.
This product is therefore unmaintained and it would be disingenuous to
say the opposite, so drop support for RK3368 Lion.
If you're a user of Lion, feel free to revert this patch or contact our
sales/support department.
Signed-off-by: Quentin Schulz
Reviewed-by: Kever Yang
Thanks,
- Kever
---
arch/arm/dts/rk3368-lion-haikou-u-boot.dtsi | 119 -
arch/arm/dts/rk3368-lion-haikou.dts | 144 ---
arch/arm/dts/rk3368-lion.dtsi | 318
arch/arm/mach-rockchip/rk3368/Kconfig | 22 --
board/theobroma-systems/lion_rk3368/Kconfig | 18 --
board/theobroma-systems/lion_rk3368/MAINTAINERS | 10 -
board/theobroma-systems/lion_rk3368/README | 78 --
configs/lion-rk3368_defconfig | 110
doc/board/rockchip/rockchip.rst | 1 -
include/configs/lion_rk3368.h | 16 --
10 files changed, 836 deletions(-)
diff --git a/arch/arm/dts/rk3368-lion-haikou-u-boot.dtsi
b/arch/arm/dts/rk3368-lion-haikou-u-boot.dtsi
deleted file mode 100644
index a3c2b707e9a..000
--- a/arch/arm/dts/rk3368-lion-haikou-u-boot.dtsi
+++ /dev/null
@@ -1,119 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0+ OR X11
-/*
- * (C) Copyright 2017 Theobroma Systems Design und Consulting GmbH
- */
-
-#include "rk3368-u-boot.dtsi"
-
-/ {
- config {
- u-boot,spl-payload-offset = <0x4>; /* @ 256KB */
- u-boot,mmc-env-offset = <0x4000>; /* @ 16KB */
- };
-
- chosen {
- stdout-path = "serial0:115200n8";
- u-boot,spl-boot-order = &emmc, &sdmmc;
- };
-
- smbios {
- compatible = "u-boot,sysinfo-smbios";
-
- smbios {
- system {
- manufacturer = "rockchip";
- product = "sheep_rk3368";
- };
-
- baseboard {
- manufacturer = "rockchip";
- product = "sheep_rk3368";
- };
-
- chassis {
- manufacturer = "rockchip";
- product = "sheep_rk3368";
- };
- };
- };
-};
-
-&gpio2 {
- bootph-all;
-};
-
-&pinctrl {
- bootph-all;
-};
-
-&service_msch {
- bootph-all;
-};
-
-&dmc {
- bootph-all;
-
- /*
-* Validation of throughput using SPEC2000 shows the following
-* relative performance for the different memory schedules:
-* - CBDR: 30.1
-* - CBRD: 29.8
-* - CRBD: 29.9
-* Note that the best performance for any given application workload
-* may vary from the default configured here (e.g. 164.gzip is fastest
-* with CBRD, whereas 252.eon and 186.crafty are fastest with CRBD).
-*
-* See doc/device-tree-bindings/clock/rockchip,rk3368-dmc.txt for
-* details on the 'rockchip,memory-schedule' property and how it
-* affects the physical-address to device-address mapping.
-*/
- rockchip,memory-schedule = ;
- rockchip,ddr-frequency = <8>;
- rockchip,ddr-speed-bin = ;
-
- status = "okay";
-};
-
-&pmugrf {
- bootph-all;
-};
-
-&sgrf {
- bootph-all;
-};
-
-&cru {
- bootph-all;
-};
-
-&grf {
- bootph-all;
-};
-
-&uart0 {
- bootph-all;
-};
-
-&emmc {
- bootph-pre-ram;
-};
-
-&sdmmc {
- bootph-pre-ram;
-};
-
-&spi1 {
- bootph-pre-ram;
-
- spiflash: w25q32dw@0 {
- bootph-pre-ram;
- };
-};
-
-&timer0 {
- bootph-all;
- clock-frequency = <2400>;
- status = "okay";
-};
-
-
diff --git a/arch/arm/dts/rk3368-lion-haikou.dts
b/arch/arm/dts/rk3368-lion-haikou.dts
deleted file mode 100644
index cae01d35b93..000
--- a/arch/arm/dts/rk3368-lion-haikou.dts
+++ /dev/null
@@ -1,144 +0,0 @@
-// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
-/*
- * Copyright (c) 2018 Theobroma Systems Design und Consulting GmbH
- */
-
-/dts-v1/;
-#include "rk3368-lion.dtsi"
-
-/ {
- model = "Theobroma Systems RK3368-uQ7 Baseboard";
- compatible = "tsd,rk3368-lion-haikou", "rockchip,rk3368";
-
- aliases {
- mmc1 = &sdmmc;
- };
-
- chosen {
- stdout-path = "serial0:115200n8";
- };
-
- i2cmux2 {
- i2c@0 {
- eeprom: eeprom@50 {
- compatible = "atmel,24c01";
- pagesize = <8>;
-
Re: [PATCH next 2/2] rockchip: remove support for Theobroma Systems RK3368 Lion
On Thu, 20 Jun 2024 at 18:41, Alex Bee wrote: > > > Am 20.06.24 um 19:08 schrieb Tom Rini: > > On Thu, Jun 20, 2024 at 07:03:26PM +0200, Alex Bee wrote: > >> Am 20.06.24 um 12:24 schrieb Quentin Schulz: > >>> From: Quentin Schulz > >>> > >>> No meaningful changes were made to this SoM since February 2021. Nobody > >>> from Theobroma has booted anything recent on that product since July > >>> 2021 at the latest. The product isn't available to buy anymore and > >>> disappeared from our website. > >>> > >>> This product is therefore unmaintained and it would be disingenuous to > >>> say the opposite, so drop support for RK3368 Lion. > >>> > >>> If you're a user of Lion, feel free to revert this patch or contact our > >>> sales/support department. > >> That's a pretty interesting support-strategy. While I really don't care for > >> this board, please don't go ahead and remove the whole TPL-/SPL-part for > >> RK3368 in yet another pointless "cleanup" only because lion was one the of > >> last/only user. Even if EOL RK3368 is getting finally interesting in > >> regards of display pipeline as we are finally getting a OSS gpu driver [0]. > >> I'm planning to add a board which uses TPL/SPL soonish (when my rare spare > >> time allows). > > Please update the MAINTAINERS file for the relevant to your future > > platform, or even better possibly get a skeleton of this platform > > posted. Thanks. > > > I don't think the whole platform would get removed as it has several users > (and is maintained) - I just was a bit worried that TPL/SPL support could > get removed, but now noticed there is one more user: evb-px5. So: sorry for > noise. > So I will go the usual way via upstream DT (linux tree) addition and so > forth. It's easy enough to bring back the pieces from git, I have a geekbox somewhere I've always meant to take a closer look at.
Re: [PATCH next 2/2] rockchip: remove support for Theobroma Systems RK3368 Lion
Am 20.06.24 um 19:08 schrieb Tom Rini: On Thu, Jun 20, 2024 at 07:03:26PM +0200, Alex Bee wrote: Am 20.06.24 um 12:24 schrieb Quentin Schulz: From: Quentin Schulz No meaningful changes were made to this SoM since February 2021. Nobody from Theobroma has booted anything recent on that product since July 2021 at the latest. The product isn't available to buy anymore and disappeared from our website. This product is therefore unmaintained and it would be disingenuous to say the opposite, so drop support for RK3368 Lion. If you're a user of Lion, feel free to revert this patch or contact our sales/support department. That's a pretty interesting support-strategy. While I really don't care for this board, please don't go ahead and remove the whole TPL-/SPL-part for RK3368 in yet another pointless "cleanup" only because lion was one the of last/only user. Even if EOL RK3368 is getting finally interesting in regards of display pipeline as we are finally getting a OSS gpu driver [0]. I'm planning to add a board which uses TPL/SPL soonish (when my rare spare time allows). Please update the MAINTAINERS file for the relevant to your future platform, or even better possibly get a skeleton of this platform posted. Thanks. I don't think the whole platform would get removed as it has several users (and is maintained) - I just was a bit worried that TPL/SPL support could get removed, but now noticed there is one more user: evb-px5. So: sorry for noise. So I will go the usual way via upstream DT (linux tree) addition and so forth.
Re: [PATCH next 2/2] rockchip: remove support for Theobroma Systems RK3368 Lion
On Thu, Jun 20, 2024 at 07:03:26PM +0200, Alex Bee wrote: > Am 20.06.24 um 12:24 schrieb Quentin Schulz: > > From: Quentin Schulz > > > > No meaningful changes were made to this SoM since February 2021. Nobody > > from Theobroma has booted anything recent on that product since July > > 2021 at the latest. The product isn't available to buy anymore and > > disappeared from our website. > > > > This product is therefore unmaintained and it would be disingenuous to > > say the opposite, so drop support for RK3368 Lion. > > > > If you're a user of Lion, feel free to revert this patch or contact our > > sales/support department. > That's a pretty interesting support-strategy. While I really don't care for > this board, please don't go ahead and remove the whole TPL-/SPL-part for > RK3368 in yet another pointless "cleanup" only because lion was one the of > last/only user. Even if EOL RK3368 is getting finally interesting in > regards of display pipeline as we are finally getting a OSS gpu driver [0]. > I'm planning to add a board which uses TPL/SPL soonish (when my rare spare > time allows). Please update the MAINTAINERS file for the relevant to your future platform, or even better possibly get a skeleton of this platform posted. Thanks. -- Tom signature.asc Description: PGP signature
Re: [PATCH next 2/2] rockchip: remove support for Theobroma Systems RK3368 Lion
Am 20.06.24 um 12:24 schrieb Quentin Schulz: From: Quentin Schulz No meaningful changes were made to this SoM since February 2021. Nobody from Theobroma has booted anything recent on that product since July 2021 at the latest. The product isn't available to buy anymore and disappeared from our website. This product is therefore unmaintained and it would be disingenuous to say the opposite, so drop support for RK3368 Lion. If you're a user of Lion, feel free to revert this patch or contact our sales/support department. That's a pretty interesting support-strategy. While I really don't care for this board, please don't go ahead and remove the whole TPL-/SPL-part for RK3368 in yet another pointless "cleanup" only because lion was one the of last/only user. Even if EOL RK3368 is getting finally interesting in regards of display pipeline as we are finally getting a OSS gpu driver [0]. I'm planning to add a board which uses TPL/SPL soonish (when my rare spare time allows). Alex [0] https://gitlab.freedesktop.org/frankbinns/linux-firmware/-/issues/1
Re: [PATCH next 2/2] rockchip: remove support for Theobroma Systems RK3368 Lion
Am Donnerstag, 20. Juni 2024, 12:24:51 CEST schrieb Quentin Schulz: > From: Quentin Schulz > > No meaningful changes were made to this SoM since February 2021. Nobody > from Theobroma has booted anything recent on that product since July > 2021 at the latest. The product isn't available to buy anymore and > disappeared from our website. > > This product is therefore unmaintained and it would be disingenuous to > say the opposite, so drop support for RK3368 Lion. > > If you're a user of Lion, feel free to revert this patch or contact our > sales/support department. > > Signed-off-by: Quentin Schulz I think any meaningful work on rk3368 in general has pretty much stalled at this point. Acked-by: Heiko Stuebner
[PATCH next 2/2] rockchip: remove support for Theobroma Systems RK3368 Lion
From: Quentin Schulz
No meaningful changes were made to this SoM since February 2021. Nobody
from Theobroma has booted anything recent on that product since July
2021 at the latest. The product isn't available to buy anymore and
disappeared from our website.
This product is therefore unmaintained and it would be disingenuous to
say the opposite, so drop support for RK3368 Lion.
If you're a user of Lion, feel free to revert this patch or contact our
sales/support department.
Signed-off-by: Quentin Schulz
---
arch/arm/dts/rk3368-lion-haikou-u-boot.dtsi | 119 -
arch/arm/dts/rk3368-lion-haikou.dts | 144 ---
arch/arm/dts/rk3368-lion.dtsi | 318
arch/arm/mach-rockchip/rk3368/Kconfig | 22 --
board/theobroma-systems/lion_rk3368/Kconfig | 18 --
board/theobroma-systems/lion_rk3368/MAINTAINERS | 10 -
board/theobroma-systems/lion_rk3368/README | 78 --
configs/lion-rk3368_defconfig | 110
doc/board/rockchip/rockchip.rst | 1 -
include/configs/lion_rk3368.h | 16 --
10 files changed, 836 deletions(-)
diff --git a/arch/arm/dts/rk3368-lion-haikou-u-boot.dtsi
b/arch/arm/dts/rk3368-lion-haikou-u-boot.dtsi
deleted file mode 100644
index a3c2b707e9a..000
--- a/arch/arm/dts/rk3368-lion-haikou-u-boot.dtsi
+++ /dev/null
@@ -1,119 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0+ OR X11
-/*
- * (C) Copyright 2017 Theobroma Systems Design und Consulting GmbH
- */
-
-#include "rk3368-u-boot.dtsi"
-
-/ {
- config {
- u-boot,spl-payload-offset = <0x4>; /* @ 256KB */
- u-boot,mmc-env-offset = <0x4000>; /* @ 16KB */
- };
-
- chosen {
- stdout-path = "serial0:115200n8";
- u-boot,spl-boot-order = &emmc, &sdmmc;
- };
-
- smbios {
- compatible = "u-boot,sysinfo-smbios";
-
- smbios {
- system {
- manufacturer = "rockchip";
- product = "sheep_rk3368";
- };
-
- baseboard {
- manufacturer = "rockchip";
- product = "sheep_rk3368";
- };
-
- chassis {
- manufacturer = "rockchip";
- product = "sheep_rk3368";
- };
- };
- };
-};
-
-&gpio2 {
- bootph-all;
-};
-
-&pinctrl {
- bootph-all;
-};
-
-&service_msch {
- bootph-all;
-};
-
-&dmc {
- bootph-all;
-
- /*
-* Validation of throughput using SPEC2000 shows the following
-* relative performance for the different memory schedules:
-* - CBDR: 30.1
-* - CBRD: 29.8
-* - CRBD: 29.9
-* Note that the best performance for any given application workload
-* may vary from the default configured here (e.g. 164.gzip is fastest
-* with CBRD, whereas 252.eon and 186.crafty are fastest with CRBD).
-*
-* See doc/device-tree-bindings/clock/rockchip,rk3368-dmc.txt for
-* details on the 'rockchip,memory-schedule' property and how it
-* affects the physical-address to device-address mapping.
-*/
- rockchip,memory-schedule = ;
- rockchip,ddr-frequency = <8>;
- rockchip,ddr-speed-bin = ;
-
- status = "okay";
-};
-
-&pmugrf {
- bootph-all;
-};
-
-&sgrf {
- bootph-all;
-};
-
-&cru {
- bootph-all;
-};
-
-&grf {
- bootph-all;
-};
-
-&uart0 {
- bootph-all;
-};
-
-&emmc {
- bootph-pre-ram;
-};
-
-&sdmmc {
- bootph-pre-ram;
-};
-
-&spi1 {
- bootph-pre-ram;
-
- spiflash: w25q32dw@0 {
- bootph-pre-ram;
- };
-};
-
-&timer0 {
- bootph-all;
- clock-frequency = <2400>;
- status = "okay";
-};
-
-
diff --git a/arch/arm/dts/rk3368-lion-haikou.dts
b/arch/arm/dts/rk3368-lion-haikou.dts
deleted file mode 100644
index cae01d35b93..000
--- a/arch/arm/dts/rk3368-lion-haikou.dts
+++ /dev/null
@@ -1,144 +0,0 @@
-// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
-/*
- * Copyright (c) 2018 Theobroma Systems Design und Consulting GmbH
- */
-
-/dts-v1/;
-#include "rk3368-lion.dtsi"
-
-/ {
- model = "Theobroma Systems RK3368-uQ7 Baseboard";
- compatible = "tsd,rk3368-lion-haikou", "rockchip,rk3368";
-
- aliases {
- mmc1 = &sdmmc;
- };
-
- chosen {
- stdout-path = "serial0:115200n8";
- };
-
- i2cmux2 {
- i2c@0 {
- eeprom: eeprom@50 {
- compatible = "atmel,24c01";
- pagesize = <8>;
- reg = <0x50>;
- };
- };
- };
-
- leds {
