Re: [PATCH u-boot-marvell 00/18] Upgrade A38x DDR3 training to version 14.0.0
Hi Pavol, On 24.02.21 15:28, Pavol Rohár wrote: On Friday 19 February 2021 17:37:00 Stefan Roese wrote: Hi Marek, On 19.02.21 17:13, Marek Behún wrote: On Fri, 19 Feb 2021 08:38:48 +0100 Stefan Roese wrote: Hi Marek, On 18.02.21 20:56, Marek Behun wrote: Chris put his Tested-by on this series and noone else replyied to it. What do you think about this? How about the issue of size increase in the SPL? IIRC, then one patch resulted in a too big image for one of the MVEBU boards. The only thing that may be problematic is that this series does not preserve original commit authors (the ones who authored these commitsin mv-ddr) in the From header, only in the first Signed-off-by's. It's because I forgot to add correct From: tags. Shall I fix this and resend it? Yes, please do. This will help me a bit. Thanks, Stefan I have sent v2 with From headers now containing original authors. Thanks. As for SPL, I have just tested these for all A38x boards, the results are in the cover letter. In short for those boards where SPL is too big, it is too big even before this series. Okay. I'll queue this patchset for the upcoming merge window, or will commit into next soon. Thanks, Stefan Hello Stefan! Please let me know when you queue this patchset. I will check if Marvell mv-ddr codebase is after merge fully synced in U-Boot. I'm a bit behind right now, sorry. I'll try to answer tomorrow or latest over the weekend. Thanks, Stefan
Re: [PATCH u-boot-marvell 00/18] Upgrade A38x DDR3 training to version 14.0.0
On Friday 19 February 2021 17:37:00 Stefan Roese wrote: > Hi Marek, > > On 19.02.21 17:13, Marek Behún wrote: > > On Fri, 19 Feb 2021 08:38:48 +0100 > > Stefan Roese wrote: > > > > > Hi Marek, > > > > > > On 18.02.21 20:56, Marek Behun wrote: > > > > Chris put his Tested-by on this series and noone else replyied to > > > > it. What do you think about this? > > > > > > How about the issue of size increase in the SPL? IIRC, then one patch > > > resulted in a too big image for one of the MVEBU boards. > > > > > > > The only thing that may be problematic is that this series does not > > > > preserve original commit authors (the ones who authored these > > > > commitsin mv-ddr) in the From header, only in the first > > > > Signed-off-by's. It's because I forgot to add correct From: tags. > > > > > > > > Shall I fix this and resend it? > > > > > > Yes, please do. This will help me a bit. > > > > > > Thanks, > > > Stefan > > > > I have sent v2 with From headers now containing original authors. > > Thanks. > > > As for SPL, I have just tested these for all A38x boards, the results > > are in the cover letter. In short for those boards where SPL is too > > big, it is too big even before this series. > > Okay. I'll queue this patchset for the upcoming merge window, or will > commit into next soon. > > Thanks, > Stefan Hello Stefan! Please let me know when you queue this patchset. I will check if Marvell mv-ddr codebase is after merge fully synced in U-Boot.
Re: [PATCH u-boot-marvell 00/18] Upgrade A38x DDR3 training to version 14.0.0
Hi Marek, On 19.02.21 17:13, Marek Behún wrote: On Fri, 19 Feb 2021 08:38:48 +0100 Stefan Roese wrote: Hi Marek, On 18.02.21 20:56, Marek Behun wrote: Chris put his Tested-by on this series and noone else replyied to it. What do you think about this? How about the issue of size increase in the SPL? IIRC, then one patch resulted in a too big image for one of the MVEBU boards. The only thing that may be problematic is that this series does not preserve original commit authors (the ones who authored these commitsin mv-ddr) in the From header, only in the first Signed-off-by's. It's because I forgot to add correct From: tags. Shall I fix this and resend it? Yes, please do. This will help me a bit. Thanks, Stefan I have sent v2 with From headers now containing original authors. Thanks. As for SPL, I have just tested these for all A38x boards, the results are in the cover letter. In short for those boards where SPL is too big, it is too big even before this series. Okay. I'll queue this patchset for the upcoming merge window, or will commit into next soon. Thanks, Stefan
Re: [PATCH u-boot-marvell 00/18] Upgrade A38x DDR3 training to version 14.0.0
On Fri, 19 Feb 2021 08:38:48 +0100 Stefan Roese wrote: > Hi Marek, > > On 18.02.21 20:56, Marek Behun wrote: > > Chris put his Tested-by on this series and noone else replyied to > > it. What do you think about this? > > How about the issue of size increase in the SPL? IIRC, then one patch > resulted in a too big image for one of the MVEBU boards. > > > The only thing that may be problematic is that this series does not > > preserve original commit authors (the ones who authored these > > commitsin mv-ddr) in the From header, only in the first > > Signed-off-by's. It's because I forgot to add correct From: tags. > > > > Shall I fix this and resend it? > > Yes, please do. This will help me a bit. > > Thanks, > Stefan I have sent v2 with From headers now containing original authors. As for SPL, I have just tested these for all A38x boards, the results are in the cover letter. In short for those boards where SPL is too big, it is too big even before this series. Marek
Re: [PATCH u-boot-marvell 00/18] Upgrade A38x DDR3 training to version 14.0.0
Hi Marek, On 18.02.21 20:56, Marek Behun wrote: Chris put his Tested-by on this series and noone else replyied to it. What do you think about this? How about the issue of size increase in the SPL? IIRC, then one patch resulted in a too big image for one of the MVEBU boards. The only thing that may be problematic is that this series does not preserve original commit authors (the ones who authored these commitsin mv-ddr) in the From header, only in the first Signed-off-by's. It's because I forgot to add correct From: tags. Shall I fix this and resend it? Yes, please do. This will help me a bit. Thanks, Stefan
Re: [PATCH u-boot-marvell 00/18] Upgrade A38x DDR3 training to version 14.0.0
Hi Stefan, Chris put his Tested-by on this series and noone else replyied to it. What do you think about this? The only thing that may be problematic is that this series does not preserve original commit authors (the ones who authored these commitsin mv-ddr) in the From header, only in the first Signed-off-by's. It's because I forgot to add correct From: tags. Shall I fix this and resend it? Marek
Re: [PATCH u-boot-marvell 00/18] Upgrade A38x DDR3 training to version 14.0.0
On 9/02/21 7:34 am, Marek Behún wrote: > This syncs drivers/ddr/marvell/a38x/ with the mv-ddr-devel branch > of https://github.com/MarvellEmbeddedProcessors/mv-ddr-marvell.git. > > There are some commits regarding DDR3 on top of version 14.0.0 in the > mv-ddr-marvell repository (from Chris Packham), but these changes > already are in U-Boot. For this series, on the db-88f6820-amc and x530 Tested-by: Chris Packham (I normally post to the mailing list from judge.pack...@gmail.com so I'm not sure if you want to use that in the Tested-by instead. I try to do work stuff under alliedtelesis and free-time stuff under gmail but this in particular blurs the line). > Marek > > Marek Behún (18): >ddr: marvell: a38x: fix write leveling suplementary algo >ddr: marvell: a38x: import header change from upstream >ddr: marvell: a38x: add ddr32 support >ddr: marvell: a38x: add ddr 32bit ECC support >ddr: marvell: a38x: import header change from upstream >ddr: marvell: a38x: fix 32bit >ddr: marvell: a38x: fix memory size calculation using 32bit bus width >ddr: marvell: a38x: import header change from upstream >ddr: marvell: a38x: allow board specific ODT configuration >ddr: marvell: a38x: add 16Gbit memory devices support >ddr: marvell: a38x: add support for twin-die combined memory device >ddr: marvell: a38x: disable WL phase correction stage in case of > bus_width=16bit >ddr: marvell: a38x: import header change from upstream >ddr: marvell: a38x: fix memory cs size function >ddr: marvell: a38x: import code change from upstream >ddr: marvell: a38x: enum mv_ddr_twin_die: change order >ddr: marvell: a38x: bump version to 14.0.0 >ddr: marvell: a38x: fix comment in conditional macro > > board/CZ.NIC/turris_omnia/turris_omnia.c | 2 ++ > board/Marvell/db-88f6820-amc/db-88f6820-amc.c | 1 + > board/Marvell/db-88f6820-gp/db-88f6820-gp.c | 1 + > board/alliedtelesis/x530/x530.c | 1 + > board/gdsys/a38x/controlcenterdc.c| 1 + > board/kobol/helios4/helios4.c | 1 + > board/solidrun/clearfog/clearfog.c| 1 + > drivers/ddr/marvell/a38x/ddr3_init.c | 5 > drivers/ddr/marvell/a38x/ddr3_training.c | 5 +++- > drivers/ddr/marvell/a38x/ddr3_training_db.c | 3 +++ > .../ddr/marvell/a38x/ddr3_training_ip_def.h | 2 ++ > .../marvell/a38x/ddr3_training_ip_engine.c| 5 +++- > drivers/ddr/marvell/a38x/ddr_topology_def.h | 23 ++- > .../ddr/marvell/a38x/mv_ddr_build_message.c | 2 +- > drivers/ddr/marvell/a38x/mv_ddr_plat.c| 9 ++-- > drivers/ddr/marvell/a38x/mv_ddr_topology.c| 14 --- > drivers/ddr/marvell/a38x/mv_ddr_topology.h| 2 ++ > drivers/ddr/marvell/a38x/xor.c| 6 ++--- > 18 files changed, 72 insertions(+), 12 deletions(-) >
Re: [PATCH u-boot-marvell 00/18] Upgrade A38x DDR3 training to version 14.0.0
On 10/02/21 2:15 am, Marek Behun wrote: > On Tue, 9 Feb 2021 06:50:35 + > Chris Packham wrote: > >> On 9/02/21 3:07 pm, Marek Behun wrote: >>> On Tue, 9 Feb 2021 01:08:54 + >>> Chris Packham wrote: >>> On 9/02/21 1:16 pm, Chris Packham wrote: > On 9/02/21 9:18 am, Marek Behun wrote: >> On Mon, 8 Feb 2021 20:11:06 + >> Chris Packham wrote: >> >>> Hi Marek, >>> >>> Do you have this in a repo I can pull from? I've got a couple of boards >>> I can give this a spin on. >> https://gitlab.nic.cz/turris/turris-omnia-uboot/ >> branch v2021.04-rc-mv-ddr-14.0.0 >> >> also please test branch v2021.04-rc-mv-ddr-14.0.0-samsung-ddr-fix, that >> one contains one more commit that is needed for Omnia with Samsung DDR >> chips. > I've tested the dm-88f6820-amc board. Training completed without > issue, as does memtester running from Linux. > > Hit a bit of a snag on the x530 because the changes pushed it over the > SPL size (it was already pretty close). I'll look to see if there's > anything I can drop out or maybe bump the SPL size (I never did get a > clear answer from Marvell as to what the size limit actually is). I can temporarily work around the size issue by disabling watchdog support in SPL (I really don't want that to be the long term solution). But then I encounter an odd problem. When I "reset" the board gets through the DDR training but never makes it to u-boot proper, but if I power cycle it boots through to the u-boot prompt. This doesn't happen on the db-88f6820-amc board. One difference between the x530 and the amc board is that the x530 has ECC so maybe something is going into the weeds if ECC has already been enabled by a previous boot. >>> Could you bisect which commit causes this? >> Seems to be the last one (ddr: marvell: a38x: fix SPLIT_OUT_MIX state >> decision) not entirely sure what the problem is. So I guess you can >> consider the upstream update good, the fix SPLIT_OUT_MIX not so much it >> happens to be the thing that causes the issue and the straw that tips >> the build size over the limit. > That's bad, because that is the one commit that is needed for Omnias > with Samsung chips. Could you try to apply this last commit without the > previous 18 ones? It should apply. > > If it does not work, could you please send me your board ddr topology > definition? I will try to update the patch. With just the one patch I see the hang (and the size blow out). The board topology is all upstream (board/alliedtelesis/x530/x530.c).
Re: [PATCH u-boot-marvell 00/18] Upgrade A38x DDR3 training to version 14.0.0
On 9/02/21 10:15 pm, Pali Rohár wrote: > On Tuesday 09 February 2021 01:08:54 Chris Packham wrote: >> On 9/02/21 1:16 pm, Chris Packham wrote: >>> On 9/02/21 9:18 am, Marek Behun wrote: On Mon, 8 Feb 2021 20:11:06 + Chris Packham wrote: > Hi Marek, > > Do you have this in a repo I can pull from? I've got a couple of boards > I can give this a spin on. https://gitlab.nic.cz/turris/turris-omnia-uboot/ branch v2021.04-rc-mv-ddr-14.0.0 also please test branch v2021.04-rc-mv-ddr-14.0.0-samsung-ddr-fix, that one contains one more commit that is needed for Omnia with Samsung DDR chips. >>> I've tested the dm-88f6820-amc board. Training completed without >>> issue, as does memtester running from Linux. >>> >>> Hit a bit of a snag on the x530 because the changes pushed it over the >>> SPL size (it was already pretty close). I'll look to see if there's >>> anything I can drop out or maybe bump the SPL size (I never did get a >>> clear answer from Marvell as to what the size limit actually is). >> I can temporarily work around the size issue by disabling watchdog >> support in SPL (I really don't want that to be the long term solution). > If you need to decrease size of U-Boot binary, can you try enabling > following two options? Technically it's the size of the spl not u-boot proper. > CONFIG_CC_OPTIMIZE_FOR_SIZE=y This is already set it's default y. > CONFIG_OPTIMIZE_INLINING=y Setting both CONFIG_OPTIMIZE_INLINING=y and CONFIG_SPL_OPTIMIZE_INLINING=y don't help (they actually make the SPL a tiny bit bigger).
Re: [PATCH u-boot-marvell 00/18] Upgrade A38x DDR3 training to version 14.0.0
On Tue, 9 Feb 2021 06:50:35 + Chris Packham wrote: > On 9/02/21 3:07 pm, Marek Behun wrote: > > On Tue, 9 Feb 2021 01:08:54 + > > Chris Packham wrote: > > > >> On 9/02/21 1:16 pm, Chris Packham wrote: > >>> On 9/02/21 9:18 am, Marek Behun wrote: > On Mon, 8 Feb 2021 20:11:06 + > Chris Packham wrote: > > > Hi Marek, > > > > Do you have this in a repo I can pull from? I've got a couple of boards > > I can give this a spin on. > https://gitlab.nic.cz/turris/turris-omnia-uboot/ > branch v2021.04-rc-mv-ddr-14.0.0 > > also please test branch v2021.04-rc-mv-ddr-14.0.0-samsung-ddr-fix, that > one contains one more commit that is needed for Omnia with Samsung DDR > chips. > >>> I've tested the dm-88f6820-amc board. Training completed without > >>> issue, as does memtester running from Linux. > >>> > >>> Hit a bit of a snag on the x530 because the changes pushed it over the > >>> SPL size (it was already pretty close). I'll look to see if there's > >>> anything I can drop out or maybe bump the SPL size (I never did get a > >>> clear answer from Marvell as to what the size limit actually is). > >> I can temporarily work around the size issue by disabling watchdog > >> support in SPL (I really don't want that to be the long term solution). > >> > >> But then I encounter an odd problem. When I "reset" the board gets > >> through the DDR training but never makes it to u-boot proper, but if I > >> power cycle it boots through to the u-boot prompt. This doesn't happen > >> on the db-88f6820-amc board. One difference between the x530 and the amc > >> board is that the x530 has ECC so maybe something is going into the > >> weeds if ECC has already been enabled by a previous boot. > >> > > Could you bisect which commit causes this? > Seems to be the last one (ddr: marvell: a38x: fix SPLIT_OUT_MIX state > decision) not entirely sure what the problem is. So I guess you can > consider the upstream update good, the fix SPLIT_OUT_MIX not so much it > happens to be the thing that causes the issue and the straw that tips > the build size over the limit. BTW Chris if the first 18 patches are working for your devices, could you please give Tested-by? Thanks. Marek
Re: [PATCH u-boot-marvell 00/18] Upgrade A38x DDR3 training to version 14.0.0
On Tue, 9 Feb 2021 06:50:35 + Chris Packham wrote: > On 9/02/21 3:07 pm, Marek Behun wrote: > > On Tue, 9 Feb 2021 01:08:54 + > > Chris Packham wrote: > > > >> On 9/02/21 1:16 pm, Chris Packham wrote: > >>> On 9/02/21 9:18 am, Marek Behun wrote: > On Mon, 8 Feb 2021 20:11:06 + > Chris Packham wrote: > > > Hi Marek, > > > > Do you have this in a repo I can pull from? I've got a couple of boards > > I can give this a spin on. > https://gitlab.nic.cz/turris/turris-omnia-uboot/ > branch v2021.04-rc-mv-ddr-14.0.0 > > also please test branch v2021.04-rc-mv-ddr-14.0.0-samsung-ddr-fix, that > one contains one more commit that is needed for Omnia with Samsung DDR > chips. > >>> I've tested the dm-88f6820-amc board. Training completed without > >>> issue, as does memtester running from Linux. > >>> > >>> Hit a bit of a snag on the x530 because the changes pushed it over the > >>> SPL size (it was already pretty close). I'll look to see if there's > >>> anything I can drop out or maybe bump the SPL size (I never did get a > >>> clear answer from Marvell as to what the size limit actually is). > >> I can temporarily work around the size issue by disabling watchdog > >> support in SPL (I really don't want that to be the long term solution). > >> > >> But then I encounter an odd problem. When I "reset" the board gets > >> through the DDR training but never makes it to u-boot proper, but if I > >> power cycle it boots through to the u-boot prompt. This doesn't happen > >> on the db-88f6820-amc board. One difference between the x530 and the amc > >> board is that the x530 has ECC so maybe something is going into the > >> weeds if ECC has already been enabled by a previous boot. > >> > > Could you bisect which commit causes this? > Seems to be the last one (ddr: marvell: a38x: fix SPLIT_OUT_MIX state > decision) not entirely sure what the problem is. So I guess you can > consider the upstream update good, the fix SPLIT_OUT_MIX not so much it > happens to be the thing that causes the issue and the straw that tips > the build size over the limit. That's bad, because that is the one commit that is needed for Omnias with Samsung chips. Could you try to apply this last commit without the previous 18 ones? It should apply. If it does not work, could you please send me your board ddr topology definition? I will try to update the patch. Marek
Re: [PATCH u-boot-marvell 00/18] Upgrade A38x DDR3 training to version 14.0.0
On Tuesday 09 February 2021 01:08:54 Chris Packham wrote: > On 9/02/21 1:16 pm, Chris Packham wrote: > > On 9/02/21 9:18 am, Marek Behun wrote: > >> On Mon, 8 Feb 2021 20:11:06 + > >> Chris Packham wrote: > >> > >>> Hi Marek, > >>> > >>> Do you have this in a repo I can pull from? I've got a couple of boards > >>> I can give this a spin on. > >> https://gitlab.nic.cz/turris/turris-omnia-uboot/ > >> branch v2021.04-rc-mv-ddr-14.0.0 > >> > >> also please test branch v2021.04-rc-mv-ddr-14.0.0-samsung-ddr-fix, that > >> one contains one more commit that is needed for Omnia with Samsung DDR > >> chips. > > > > I've tested the dm-88f6820-amc board. Training completed without > > issue, as does memtester running from Linux. > > > > Hit a bit of a snag on the x530 because the changes pushed it over the > > SPL size (it was already pretty close). I'll look to see if there's > > anything I can drop out or maybe bump the SPL size (I never did get a > > clear answer from Marvell as to what the size limit actually is). > > I can temporarily work around the size issue by disabling watchdog > support in SPL (I really don't want that to be the long term solution). If you need to decrease size of U-Boot binary, can you try enabling following two options? CONFIG_CC_OPTIMIZE_FOR_SIZE=y CONFIG_OPTIMIZE_INLINING=y
Re: [PATCH u-boot-marvell 00/18] Upgrade A38x DDR3 training to version 14.0.0
On 9/02/21 3:07 pm, Marek Behun wrote: > On Tue, 9 Feb 2021 01:08:54 + > Chris Packham wrote: > >> On 9/02/21 1:16 pm, Chris Packham wrote: >>> On 9/02/21 9:18 am, Marek Behun wrote: On Mon, 8 Feb 2021 20:11:06 + Chris Packham wrote: > Hi Marek, > > Do you have this in a repo I can pull from? I've got a couple of boards > I can give this a spin on. https://gitlab.nic.cz/turris/turris-omnia-uboot/ branch v2021.04-rc-mv-ddr-14.0.0 also please test branch v2021.04-rc-mv-ddr-14.0.0-samsung-ddr-fix, that one contains one more commit that is needed for Omnia with Samsung DDR chips. >>> I've tested the dm-88f6820-amc board. Training completed without >>> issue, as does memtester running from Linux. >>> >>> Hit a bit of a snag on the x530 because the changes pushed it over the >>> SPL size (it was already pretty close). I'll look to see if there's >>> anything I can drop out or maybe bump the SPL size (I never did get a >>> clear answer from Marvell as to what the size limit actually is). >> I can temporarily work around the size issue by disabling watchdog >> support in SPL (I really don't want that to be the long term solution). >> >> But then I encounter an odd problem. When I "reset" the board gets >> through the DDR training but never makes it to u-boot proper, but if I >> power cycle it boots through to the u-boot prompt. This doesn't happen >> on the db-88f6820-amc board. One difference between the x530 and the amc >> board is that the x530 has ECC so maybe something is going into the >> weeds if ECC has already been enabled by a previous boot. >> > Could you bisect which commit causes this? Seems to be the last one (ddr: marvell: a38x: fix SPLIT_OUT_MIX state decision) not entirely sure what the problem is. So I guess you can consider the upstream update good, the fix SPLIT_OUT_MIX not so much it happens to be the thing that causes the issue and the straw that tips the build size over the limit.
Re: [PATCH u-boot-marvell 00/18] Upgrade A38x DDR3 training to version 14.0.0
On 9/02/21 3:07 pm, Marek Behun wrote: > On Tue, 9 Feb 2021 01:08:54 + > Chris Packham wrote: > >> On 9/02/21 1:16 pm, Chris Packham wrote: >>> On 9/02/21 9:18 am, Marek Behun wrote: On Mon, 8 Feb 2021 20:11:06 + Chris Packham wrote: > Hi Marek, > > Do you have this in a repo I can pull from? I've got a couple of boards > I can give this a spin on. https://gitlab.nic.cz/turris/turris-omnia-uboot/ branch v2021.04-rc-mv-ddr-14.0.0 also please test branch v2021.04-rc-mv-ddr-14.0.0-samsung-ddr-fix, that one contains one more commit that is needed for Omnia with Samsung DDR chips. >>> I've tested the dm-88f6820-amc board. Training completed without >>> issue, as does memtester running from Linux. >>> >>> Hit a bit of a snag on the x530 because the changes pushed it over the >>> SPL size (it was already pretty close). I'll look to see if there's >>> anything I can drop out or maybe bump the SPL size (I never did get a >>> clear answer from Marvell as to what the size limit actually is). >> I can temporarily work around the size issue by disabling watchdog >> support in SPL (I really don't want that to be the long term solution). >> >> But then I encounter an odd problem. When I "reset" the board gets >> through the DDR training but never makes it to u-boot proper, but if I >> power cycle it boots through to the u-boot prompt. This doesn't happen >> on the db-88f6820-amc board. One difference between the x530 and the amc >> board is that the x530 has ECC so maybe something is going into the >> weeds if ECC has already been enabled by a previous boot. >> > Could you bisect which commit causes this? I'll give it a try. I've kind of done my dash for u-boot stuff for today but I'll try and get to it later tonight.
Re: [PATCH u-boot-marvell 00/18] Upgrade A38x DDR3 training to version 14.0.0
On Tue, 9 Feb 2021 01:08:54 + Chris Packham wrote: > On 9/02/21 1:16 pm, Chris Packham wrote: > > On 9/02/21 9:18 am, Marek Behun wrote: > >> On Mon, 8 Feb 2021 20:11:06 + > >> Chris Packham wrote: > >> > >>> Hi Marek, > >>> > >>> Do you have this in a repo I can pull from? I've got a couple of boards > >>> I can give this a spin on. > >> https://gitlab.nic.cz/turris/turris-omnia-uboot/ > >> branch v2021.04-rc-mv-ddr-14.0.0 > >> > >> also please test branch v2021.04-rc-mv-ddr-14.0.0-samsung-ddr-fix, that > >> one contains one more commit that is needed for Omnia with Samsung DDR > >> chips. > > > > I've tested the dm-88f6820-amc board. Training completed without > > issue, as does memtester running from Linux. > > > > Hit a bit of a snag on the x530 because the changes pushed it over the > > SPL size (it was already pretty close). I'll look to see if there's > > anything I can drop out or maybe bump the SPL size (I never did get a > > clear answer from Marvell as to what the size limit actually is). > > I can temporarily work around the size issue by disabling watchdog > support in SPL (I really don't want that to be the long term solution). > > But then I encounter an odd problem. When I "reset" the board gets > through the DDR training but never makes it to u-boot proper, but if I > power cycle it boots through to the u-boot prompt. This doesn't happen > on the db-88f6820-amc board. One difference between the x530 and the amc > board is that the x530 has ECC so maybe something is going into the > weeds if ECC has already been enabled by a previous boot. > Could you bisect which commit causes this? Marek
Re: [PATCH u-boot-marvell 00/18] Upgrade A38x DDR3 training to version 14.0.0
On 9/02/21 1:16 pm, Chris Packham wrote: > On 9/02/21 9:18 am, Marek Behun wrote: >> On Mon, 8 Feb 2021 20:11:06 + >> Chris Packham wrote: >> >>> Hi Marek, >>> >>> Do you have this in a repo I can pull from? I've got a couple of boards >>> I can give this a spin on. >> https://gitlab.nic.cz/turris/turris-omnia-uboot/ >> branch v2021.04-rc-mv-ddr-14.0.0 >> >> also please test branch v2021.04-rc-mv-ddr-14.0.0-samsung-ddr-fix, that >> one contains one more commit that is needed for Omnia with Samsung DDR >> chips. > > I've tested the dm-88f6820-amc board. Training completed without > issue, as does memtester running from Linux. > > Hit a bit of a snag on the x530 because the changes pushed it over the > SPL size (it was already pretty close). I'll look to see if there's > anything I can drop out or maybe bump the SPL size (I never did get a > clear answer from Marvell as to what the size limit actually is). I can temporarily work around the size issue by disabling watchdog support in SPL (I really don't want that to be the long term solution). But then I encounter an odd problem. When I "reset" the board gets through the DDR training but never makes it to u-boot proper, but if I power cycle it boots through to the u-boot prompt. This doesn't happen on the db-88f6820-amc board. One difference between the x530 and the amc board is that the x530 has ECC so maybe something is going into the weeds if ECC has already been enabled by a previous boot.
Re: [PATCH u-boot-marvell 00/18] Upgrade A38x DDR3 training to version 14.0.0
On 9/02/21 9:18 am, Marek Behun wrote: > On Mon, 8 Feb 2021 20:11:06 + > Chris Packham wrote: > >> Hi Marek, >> >> Do you have this in a repo I can pull from? I've got a couple of boards >> I can give this a spin on. > https://gitlab.nic.cz/turris/turris-omnia-uboot/ > branch v2021.04-rc-mv-ddr-14.0.0 > > also please test branch v2021.04-rc-mv-ddr-14.0.0-samsung-ddr-fix, that > one contains one more commit that is needed for Omnia with Samsung DDR > chips. I've tested the dm-88f6820-amc board. Training completed without issue, as does memtester running from Linux. Hit a bit of a snag on the x530 because the changes pushed it over the SPL size (it was already pretty close). I'll look to see if there's anything I can drop out or maybe bump the SPL size (I never did get a clear answer from Marvell as to what the size limit actually is).
Re: [PATCH u-boot-marvell 00/18] Upgrade A38x DDR3 training to version 14.0.0
Stefan, these patches should probably have a different From: - i.e. the original authors should be preserved (from the first Signed-off-by tags), for example: motib Baruch Siach heaterC But some of these are not full names, so I don't know whether I should resend this or not. What do you think? Marek
Re: [PATCH u-boot-marvell 00/18] Upgrade A38x DDR3 training to version 14.0.0
On Mon, 8 Feb 2021 20:11:06 + Chris Packham wrote: > Hi Marek, > > Do you have this in a repo I can pull from? I've got a couple of boards > I can give this a spin on. https://gitlab.nic.cz/turris/turris-omnia-uboot/ branch v2021.04-rc-mv-ddr-14.0.0 also please test branch v2021.04-rc-mv-ddr-14.0.0-samsung-ddr-fix, that one contains one more commit that is needed for Omnia with Samsung DDR chips. Marek
Re: [PATCH u-boot-marvell 00/18] Upgrade A38x DDR3 training to version 14.0.0
Hi Marek, On 9/02/21 7:34 am, Marek Behún wrote: > This syncs drivers/ddr/marvell/a38x/ with the mv-ddr-devel branch > of https://github.com/MarvellEmbeddedProcessors/mv-ddr-marvell.git. > > There are some commits regarding DDR3 on top of version 14.0.0 in the > mv-ddr-marvell repository (from Chris Packham), but these changes > already are in U-Boot. Do you have this in a repo I can pull from? I've got a couple of boards I can give this a spin on. > Marek > > Marek Behún (18): >ddr: marvell: a38x: fix write leveling suplementary algo >ddr: marvell: a38x: import header change from upstream >ddr: marvell: a38x: add ddr32 support >ddr: marvell: a38x: add ddr 32bit ECC support >ddr: marvell: a38x: import header change from upstream >ddr: marvell: a38x: fix 32bit >ddr: marvell: a38x: fix memory size calculation using 32bit bus width >ddr: marvell: a38x: import header change from upstream >ddr: marvell: a38x: allow board specific ODT configuration >ddr: marvell: a38x: add 16Gbit memory devices support >ddr: marvell: a38x: add support for twin-die combined memory device >ddr: marvell: a38x: disable WL phase correction stage in case of > bus_width=16bit >ddr: marvell: a38x: import header change from upstream >ddr: marvell: a38x: fix memory cs size function >ddr: marvell: a38x: import code change from upstream >ddr: marvell: a38x: enum mv_ddr_twin_die: change order >ddr: marvell: a38x: bump version to 14.0.0 >ddr: marvell: a38x: fix comment in conditional macro > > board/CZ.NIC/turris_omnia/turris_omnia.c | 2 ++ > board/Marvell/db-88f6820-amc/db-88f6820-amc.c | 1 + > board/Marvell/db-88f6820-gp/db-88f6820-gp.c | 1 + > board/alliedtelesis/x530/x530.c | 1 + > board/gdsys/a38x/controlcenterdc.c| 1 + > board/kobol/helios4/helios4.c | 1 + > board/solidrun/clearfog/clearfog.c| 1 + > drivers/ddr/marvell/a38x/ddr3_init.c | 5 > drivers/ddr/marvell/a38x/ddr3_training.c | 5 +++- > drivers/ddr/marvell/a38x/ddr3_training_db.c | 3 +++ > .../ddr/marvell/a38x/ddr3_training_ip_def.h | 2 ++ > .../marvell/a38x/ddr3_training_ip_engine.c| 5 +++- > drivers/ddr/marvell/a38x/ddr_topology_def.h | 23 ++- > .../ddr/marvell/a38x/mv_ddr_build_message.c | 2 +- > drivers/ddr/marvell/a38x/mv_ddr_plat.c| 9 ++-- > drivers/ddr/marvell/a38x/mv_ddr_topology.c| 14 --- > drivers/ddr/marvell/a38x/mv_ddr_topology.h| 2 ++ > drivers/ddr/marvell/a38x/xor.c| 6 ++--- > 18 files changed, 72 insertions(+), 12 deletions(-) >
Re: [PATCH u-boot-marvell 00/18] Upgrade A38x DDR3 training to version 14.0.0
btw tested on Turris Omnia
[PATCH u-boot-marvell 00/18] Upgrade A38x DDR3 training to version 14.0.0
This syncs drivers/ddr/marvell/a38x/ with the mv-ddr-devel branch of https://github.com/MarvellEmbeddedProcessors/mv-ddr-marvell.git. There are some commits regarding DDR3 on top of version 14.0.0 in the mv-ddr-marvell repository (from Chris Packham), but these changes already are in U-Boot. Marek Marek Behún (18): ddr: marvell: a38x: fix write leveling suplementary algo ddr: marvell: a38x: import header change from upstream ddr: marvell: a38x: add ddr32 support ddr: marvell: a38x: add ddr 32bit ECC support ddr: marvell: a38x: import header change from upstream ddr: marvell: a38x: fix 32bit ddr: marvell: a38x: fix memory size calculation using 32bit bus width ddr: marvell: a38x: import header change from upstream ddr: marvell: a38x: allow board specific ODT configuration ddr: marvell: a38x: add 16Gbit memory devices support ddr: marvell: a38x: add support for twin-die combined memory device ddr: marvell: a38x: disable WL phase correction stage in case of bus_width=16bit ddr: marvell: a38x: import header change from upstream ddr: marvell: a38x: fix memory cs size function ddr: marvell: a38x: import code change from upstream ddr: marvell: a38x: enum mv_ddr_twin_die: change order ddr: marvell: a38x: bump version to 14.0.0 ddr: marvell: a38x: fix comment in conditional macro board/CZ.NIC/turris_omnia/turris_omnia.c | 2 ++ board/Marvell/db-88f6820-amc/db-88f6820-amc.c | 1 + board/Marvell/db-88f6820-gp/db-88f6820-gp.c | 1 + board/alliedtelesis/x530/x530.c | 1 + board/gdsys/a38x/controlcenterdc.c| 1 + board/kobol/helios4/helios4.c | 1 + board/solidrun/clearfog/clearfog.c| 1 + drivers/ddr/marvell/a38x/ddr3_init.c | 5 drivers/ddr/marvell/a38x/ddr3_training.c | 5 +++- drivers/ddr/marvell/a38x/ddr3_training_db.c | 3 +++ .../ddr/marvell/a38x/ddr3_training_ip_def.h | 2 ++ .../marvell/a38x/ddr3_training_ip_engine.c| 5 +++- drivers/ddr/marvell/a38x/ddr_topology_def.h | 23 ++- .../ddr/marvell/a38x/mv_ddr_build_message.c | 2 +- drivers/ddr/marvell/a38x/mv_ddr_plat.c| 9 ++-- drivers/ddr/marvell/a38x/mv_ddr_topology.c| 14 --- drivers/ddr/marvell/a38x/mv_ddr_topology.h| 2 ++ drivers/ddr/marvell/a38x/xor.c| 6 ++--- 18 files changed, 72 insertions(+), 12 deletions(-) -- 2.26.2
