[PATCH u-boot 0/3] pci: mpc85xx: Fixes for PCI config space
This patch series contains small fixes for mpc85xx old PCI Local Bus driver. Heiko: Are you able to test these changes? Has your Socrates board available old PCI Local Bus support? Pali Rohár (3): pci: mpc85xx: Add missing sync() after writing to PCI config space pci: mpc85xx: Allow 8/16-bit access to PCI config space pci: mpc85xx: Do not try to access extended PCIe registers drivers/pci/pci_mpc85xx.c | 39 +++ 1 file changed, 35 insertions(+), 4 deletions(-) -- 2.20.1
Re: [PATCH u-boot 0/3] pci: mpc85xx: Fixes for PCI config space
Hello Pali, On 13.04.23 22:41, Pali Rohár wrote: > This patch series contains small fixes for mpc85xx old PCI Local Bus driver. > > Heiko: Are you able to test these changes? Has your Socrates board > available old PCI Local Bus support? > > Pali Rohár (3): > pci: mpc85xx: Add missing sync() after writing to PCI config space > pci: mpc85xx: Allow 8/16-bit access to PCI config space > pci: mpc85xx: Do not try to access extended PCIe registers > > drivers/pci/pci_mpc85xx.c | 39 +++ > 1 file changed, 35 insertions(+), 4 deletions(-) I have to look, try your patches soon, thanks! bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: h...@denx.de
Re: [PATCH u-boot 0/3] pci: mpc85xx: Fixes for PCI config space
Hello Pali, On 13.04.23 22:41, Pali Rohár wrote: > This patch series contains small fixes for mpc85xx old PCI Local Bus driver. > > Heiko: Are you able to test these changes? Has your Socrates board > available old PCI Local Bus support? > > Pali Rohár (3): > pci: mpc85xx: Add missing sync() after writing to PCI config space > pci: mpc85xx: Allow 8/16-bit access to PCI config space > pci: mpc85xx: Do not try to access extended PCIe registers > > drivers/pci/pci_mpc85xx.c | 39 +++ > 1 file changed, 35 insertions(+), 4 deletions(-) I just applied your patches to my U-Boot (based on 2023.04) running on the socrates board. I see no problems. I have there: => pci BusDevFun VendorId DeviceId Device Class Sub-Class _ 00.00.00 0x1957 0x0033 Processor 0x20 00.11.00 0x1131 0x1561 Serial bus controller 0x03 00.11.01 0x1131 0x1561 Serial bus controller 0x03 00.11.02 0x1131 0x1562 Serial bus controller 0x03 00.12.00 0x1131 0x1561 Serial bus controller 0x03 00.12.01 0x1131 0x1561 Serial bus controller 0x03 00.12.02 0x1131 0x1562 Serial bus controller 0x03 => => usb start starting USB... Bus ohci_pci: USB OHCI 1.0 Bus ohci_pci: USB OHCI 1.0 Bus ohci_pci: USB OHCI 1.0 Bus ohci_pci: USB OHCI 1.0 scanning bus ohci_pci for devices... 1 USB Device(s) found scanning bus ohci_pci for devices... 1 USB Device(s) found scanning bus ohci_pci for devices... 1 USB Device(s) found scanning bus ohci_pci for devices... 2 USB Device(s) found scanning usb for storage devices... 1 Storage Device(s) found => usb storage Device 0: Vendor: Mass Rev: 1.00 Prod: Storage Device Type: Removable Hard Disk Capacity: 30424.5 MB = 29.7 GB (62309376 x 512) => So, I see no problems with your patches. bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: h...@denx.de
Re: [PATCH u-boot 0/3] pci: mpc85xx: Fixes for PCI config space
On Monday 17 April 2023 07:12:16 Heiko Schocher wrote: > Hello Pali, > > On 13.04.23 22:41, Pali Rohár wrote: > > This patch series contains small fixes for mpc85xx old PCI Local Bus driver. > > > > Heiko: Are you able to test these changes? Has your Socrates board > > available old PCI Local Bus support? > > > > Pali Rohár (3): > > pci: mpc85xx: Add missing sync() after writing to PCI config space > > pci: mpc85xx: Allow 8/16-bit access to PCI config space > > pci: mpc85xx: Do not try to access extended PCIe registers > > > > drivers/pci/pci_mpc85xx.c | 39 +++ > > 1 file changed, 35 insertions(+), 4 deletions(-) > > I just applied your patches to my U-Boot (based on 2023.04) running > on the socrates board. I see no problems. > > I have there: > > => pci > BusDevFun VendorId DeviceId Device Class Sub-Class > _ > 00.00.00 0x1957 0x0033 Processor 0x20 > 00.11.00 0x1131 0x1561 Serial bus controller 0x03 > 00.11.01 0x1131 0x1561 Serial bus controller 0x03 > 00.11.02 0x1131 0x1562 Serial bus controller 0x03 > 00.12.00 0x1131 0x1561 Serial bus controller 0x03 > 00.12.01 0x1131 0x1561 Serial bus controller 0x03 > 00.12.02 0x1131 0x1562 Serial bus controller 0x03 > => > > => usb start > starting USB... > Bus ohci_pci: USB OHCI 1.0 > Bus ohci_pci: USB OHCI 1.0 > Bus ohci_pci: USB OHCI 1.0 > Bus ohci_pci: USB OHCI 1.0 > scanning bus ohci_pci for devices... 1 USB Device(s) found > scanning bus ohci_pci for devices... 1 USB Device(s) found > scanning bus ohci_pci for devices... 1 USB Device(s) found > scanning bus ohci_pci for devices... 2 USB Device(s) found >scanning usb for storage devices... 1 Storage Device(s) found > => usb storage > Device 0: Vendor: Mass Rev: 1.00 Prod: Storage Device > Type: Removable Hard Disk > Capacity: 30424.5 MB = 29.7 GB (62309376 x 512) > => > > So, I see no problems with your patches. Thanks for testing! Could you send me dump of the PCI config space from u-boot and also from Linux? So I could compare it if U-Boot is doing everything correctly. In U-Boot for first two devices: => pci display.b 00.00.00 0x0 0x1000 => pci display.b 00.11.00 0x0 0x1000 And in Linux for all devices: # lspci - -nn > bye, > Heiko > -- > DENX Software Engineering GmbH, Managing Director: Erika Unter > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: h...@denx.de
Re: [PATCH u-boot 0/3] pci: mpc85xx: Fixes for PCI config space
On Thursday 13 April 2023 22:41:43 Pali Rohár wrote: > This patch series contains small fixes for mpc85xx old PCI Local Bus driver. > > Heiko: Are you able to test these changes? Has your Socrates board > available old PCI Local Bus support? > > Pali Rohár (3): > pci: mpc85xx: Add missing sync() after writing to PCI config space > pci: mpc85xx: Allow 8/16-bit access to PCI config space > pci: mpc85xx: Do not try to access extended PCIe registers > > drivers/pci/pci_mpc85xx.c | 39 +++ > 1 file changed, 35 insertions(+), 4 deletions(-) > > -- > 2.20.1 > Anything more here? Remaining issues are handled by the other patch series on the list.
Re: [PATCH u-boot 0/3] pci: mpc85xx: Fixes for PCI config space
Hello Pali, On 29.04.23 13:10, Pali Rohár wrote: > On Thursday 13 April 2023 22:41:43 Pali Rohár wrote: >> This patch series contains small fixes for mpc85xx old PCI Local Bus driver. >> >> Heiko: Are you able to test these changes? Has your Socrates board >> available old PCI Local Bus support? >> >> Pali Rohár (3): >> pci: mpc85xx: Add missing sync() after writing to PCI config space >> pci: mpc85xx: Allow 8/16-bit access to PCI config space >> pci: mpc85xx: Do not try to access extended PCIe registers >> >> drivers/pci/pci_mpc85xx.c | 39 +++ >> 1 file changed, 35 insertions(+), 4 deletions(-) >> >> -- >> 2.20.1 >> > > Anything more here? > > Remaining issues are handled by the other patch series on the list. I see no more issues on my hardware, thanks! bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: h...@denx.de
