Re: [PATCH v1] board: toradex: imx: Remove not needed env variables

2024-04-20 Thread Fabio Estevam
On Thu, Apr 18, 2024 at 10:12 AM Francesco Dolcini  wrote:
>
> From: Francesco Dolcini 
>
> Remove not needed variables from environment and include config files.
>
>  - setup variable used to be executed from some bootscript, however
>it's not required and there is no point on having this small helper
>here
>  - boot_file, kernel_file, ip_dyn variables are not used anywhere
>  - fdt_fixup variable is just set empty
>  - defargs, vidargs variables used to be used from some bootscript,
>however there is no point on having it here and even old legacy
>bootscript can work without them
>  - removed CONFIG_ENABLE_DDR_TRAINING_DEBUG, this is a leftover from
>some copy/paste
>
> On colibri imx6ull/imx7 NAND module, remove consoleblank=0, this is
> already the Linux kernel default therefore useless.
>
> Various Linux Kernel command line options removed are not-existing
> left-over that applied to some old NXP i.MX downstream branch
>
> Signed-off-by: Francesco Dolcini 

Applied, thanks.


[PATCH v1] board: toradex: imx: Remove not needed env variables

2024-04-18 Thread Francesco Dolcini
From: Francesco Dolcini 

Remove not needed variables from environment and include config files.

 - setup variable used to be executed from some bootscript, however
   it's not required and there is no point on having this small helper
   here
 - boot_file, kernel_file, ip_dyn variables are not used anywhere
 - fdt_fixup variable is just set empty
 - defargs, vidargs variables used to be used from some bootscript,
   however there is no point on having it here and even old legacy
   bootscript can work without them
 - removed CONFIG_ENABLE_DDR_TRAINING_DEBUG, this is a leftover from
   some copy/paste

On colibri imx6ull/imx7 NAND module, remove consoleblank=0, this is
already the Linux kernel default therefore useless.

Various Linux Kernel command line options removed are not-existing
left-over that applied to some old NXP i.MX downstream branch

Signed-off-by: Francesco Dolcini 
---
 include/configs/apalis-imx8.h |  2 --
 include/configs/apalis_imx6.h |  9 +
 include/configs/colibri-imx6ull.h | 10 +++---
 include/configs/colibri-imx8x.h   |  2 --
 include/configs/colibri_imx6.h|  9 +
 include/configs/colibri_imx7.h| 11 +++
 include/configs/verdin-imx8mm.h   |  3 ---
 include/configs/verdin-imx8mp.h   |  5 -
 8 files changed, 8 insertions(+), 43 deletions(-)

diff --git a/include/configs/apalis-imx8.h b/include/configs/apalis-imx8.h
index 845705c86db2..c8ec034fc979 100644
--- a/include/configs/apalis-imx8.h
+++ b/include/configs/apalis-imx8.h
@@ -46,8 +46,6 @@
"fdt_board=eval\0" \
"initrd_addr=0x8380\0" \
"initrd_high=0x\0" \
-   "setup=setenv setupargs console=tty1 console=${console},${baudrate} " \
-   "consoleblank=0 earlycon\0" \
"update_uboot=askenv confirm Did you load flash.bin resp. 
u-boot-dtb.imx (y/N)?; " \
"if test \"$confirm\" = \"y\"; then " \
"setexpr blkcnt ${filesize} + 0x1ff && setexpr blkcnt " \
diff --git a/include/configs/apalis_imx6.h b/include/configs/apalis_imx6.h
index 8a9f3ef75a7d..0df3917e2009 100644
--- a/include/configs/apalis_imx6.h
+++ b/include/configs/apalis_imx6.h
@@ -64,12 +64,9 @@
 
 #define CFG_EXTRA_ENV_SETTINGS \
BOOTENV \
-   "boot_file=zImage\0" \
"boot_script_dhcp=boot.scr\0" \
"console=ttymxc0\0" \
-   "defargs=enable_wait_mode=off vmalloc=400M\0" \
"fdt_board=eval\0" \
-   "fdt_fixup=;\0" \
MEM_LAYOUT_ENV_SETTINGS \
UBOOT_UPDATE \
"setethupdate=if env exists ethaddr; then; else setenv ethaddr " \
@@ -80,16 +77,12 @@
"|| setenv drive 2; mmc rescan; load ${interface} ${drive}:1" \
" ${loadaddr} flash_blk.img && " \
"source ${loadaddr}\0" \
-   "setup=setenv setupargs fec_mac=${ethaddr} " \
-   "consoleblank=0 no_console_suspend=1 console=tty1 " \
-   "console=${console},${baudrate}n8\0 " \
"setupdate=run setsdupdate || run setusbupdate || run setethupdate\0" \
"setusbupdate=usb start && setenv interface usb; setenv drive 0; " \
"load ${interface} ${drive}:1 ${loadaddr} flash_blk.img && " \
"source ${loadaddr}\0" \
"splashpos=m,m\0" \
-   "splashimage=" __stringify(CONFIG_SYS_LOAD_ADDR) "\0" \
-   "vidargs=mxc_hdmi.only_cea=1 fbmem=32M\0"
+   "splashimage=" __stringify(CONFIG_SYS_LOAD_ADDR) "\0"
 
 /* Miscellaneous configurable options */
 
diff --git a/include/configs/colibri-imx6ull.h 
b/include/configs/colibri-imx6ull.h
index 561a61ebc03c..7c9d633b68d9 100644
--- a/include/configs/colibri-imx6ull.h
+++ b/include/configs/colibri-imx6ull.h
@@ -48,8 +48,8 @@
"ubiargs=ubi.mtd=ubi root=ubi0:rootfs rw rootfstype=ubifs " \
"ubi.fm_autoconvert=1\0" \
"ubiboot=run setup; " \
-   "setenv bootargs ${defargs} ${ubiargs} " \
-   "${setupargs} ${vidargs} ${tdxargs}; echo Booting from NAND...; 
" \
+   "setenv bootargs ${ubiargs} " \
+   "${setupargs} ${tdxargs}; echo Booting from NAND...; " \
"ubi part ubi &&" \
"ubi read ${kernel_addr_r} kernel && " \
"ubi read ${fdt_addr_r} dtb && " \
@@ -86,11 +86,7 @@
UBOOT_UPDATE \
"boot_script_dhcp=boot.scr\0" \
"console=ttymxc0\0" \
-   "defargs=user_debug=30\0" \
"fdt_board=eval-v3\0" \
-   "fdt_fixup=;\0" \
-   "ip_dyn=yes\0" \
-   "kernel_file=zImage\0" \
"setethupdate=if env exists ethaddr; then; else setenv ethaddr " \
"00:14:2d:00:00:00; fi; tftpboot ${loadaddr} " \
"${board}/flash_eth.img && source ${loadaddr}\0" \
@@ -99,7 +95,7 @@
"${board}/flash_blk.img && source ${loadaddr}\0" \
"setup=setenv setupargs " \
"console=tty1 console=${console}" \
-   ",${baudrate}n8 ${memargs} ${mtdparts} consoleblank=0\0" \
+