Re: [PATCH v1 10/15] x86: intel: crownbay: Remove dead code

2020-08-15 Thread Simon Glass
On Thu, 6 Aug 2020 at 08:54, Andy Shevchenko
 wrote:
>
> start.S does nothing and can be safely removed. Makefile is still being used
> by the build system, so simply drop the rule from it.
>
> Signed-off-by: Andy Shevchenko 
> ---
>  board/intel/crownbay/Makefile | 2 +-
>  board/intel/crownbay/start.S  | 8 
>  2 files changed, 1 insertion(+), 9 deletions(-)
>  delete mode 100644 board/intel/crownbay/start.S
>

Reviewed-by: Simon Glass 


[PATCH v1 10/15] x86: intel: crownbay: Remove dead code

2020-08-06 Thread Andy Shevchenko
start.S does nothing and can be safely removed. Makefile is still being used
by the build system, so simply drop the rule from it.

Signed-off-by: Andy Shevchenko 
---
 board/intel/crownbay/Makefile | 2 +-
 board/intel/crownbay/start.S  | 8 
 2 files changed, 1 insertion(+), 9 deletions(-)
 delete mode 100644 board/intel/crownbay/start.S

diff --git a/board/intel/crownbay/Makefile b/board/intel/crownbay/Makefile
index b52c69aeaa1b..6abd3eeb5540 100644
--- a/board/intel/crownbay/Makefile
+++ b/board/intel/crownbay/Makefile
@@ -2,4 +2,4 @@
 #
 # Copyright (C) 2014, Bin Meng 
 
-obj-y  += crownbay.o start.o
+obj-y  += crownbay.o
diff --git a/board/intel/crownbay/start.S b/board/intel/crownbay/start.S
deleted file mode 100644
index 7faa7d05fae4..
--- a/board/intel/crownbay/start.S
+++ /dev/null
@@ -1,8 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * Copyright (C) 2014, Bin Meng 
- */
-
-.globl early_board_init
-early_board_init:
-   jmp early_board_init_ret
-- 
2.27.0