Re: [PATCH v1 15/15] x86: qemu: Remove dead code

[Simon Glass]

On Thu, 6 Aug 2020 at 08:54, Andy Shevchenko
 wrote:
>
> start.S does nothing and can be safely removed. Makefile is still being used
> by the build system, so simply drop the rule from it.
>
> Signed-off-by: Andy Shevchenko 
> ---
>  board/emulation/qemu-x86/Makefile | 2 --
>  board/emulation/qemu-x86/start.S  | 8 
>  2 files changed, 10 deletions(-)
>  delete mode 100644 board/emulation/qemu-x86/start.S

Reviewed-by: Simon Glass 

[PATCH v1 15/15] x86: qemu: Remove dead code

[Andy Shevchenko]

start.S does nothing and can be safely removed. Makefile is still being used
by the build system, so simply drop the rule from it.

Signed-off-by: Andy Shevchenko 
---
 board/emulation/qemu-x86/Makefile | 2 --
 board/emulation/qemu-x86/start.S  | 8 
 2 files changed, 10 deletions(-)
 delete mode 100644 board/emulation/qemu-x86/start.S

diff --git a/board/emulation/qemu-x86/Makefile 
b/board/emulation/qemu-x86/Makefile
index 782e298b74ce..5af8d31d5840 100644
--- a/board/emulation/qemu-x86/Makefile
+++ b/board/emulation/qemu-x86/Makefile
@@ -1,5 +1,3 @@
 # SPDX-License-Identifier: GPL-2.0+
 #
 # Copyright (C) 2015, Bin Meng 
-
-obj-y  += start.o
diff --git a/board/emulation/qemu-x86/start.S b/board/emulation/qemu-x86/start.S
deleted file mode 100644
index e4bde561b20d..
--- a/board/emulation/qemu-x86/start.S
+++ /dev/null
@@ -1,8 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * Copyright (C) 2015, Bin Meng 
- */
-
-.globl early_board_init
-early_board_init:
-   jmp early_board_init_ret
-- 
2.27.0