Re: [PATCH v1 2/2] board: microchip: icicle: make both ethernets optional

2024-05-29 Thread Leo Liang
On Wed, May 15, 2024 at 04:04:31PM +0100, Conor Dooley wrote:
> From: Conor Dooley 
> 
> A given AMP configuration for a board may make either one, or neither
> of, the ethernet ports available to U-Boot. The Icicle's init code will
> fail if mac1 is not present, so move it to the optional approach taken
> for mac0.
> 
> Signed-off-by: Conor Dooley 
> ---
>  board/microchip/mpfs_icicle/mpfs_icicle.c | 23 +++
>  1 file changed, 7 insertions(+), 16 deletions(-)

Reviewed-by: Leo Yu-Chi Liang 


[PATCH v1 2/2] board: microchip: icicle: make both ethernets optional

2024-05-15 Thread Conor Dooley
From: Conor Dooley 

A given AMP configuration for a board may make either one, or neither
of, the ethernet ports available to U-Boot. The Icicle's init code will
fail if mac1 is not present, so move it to the optional approach taken
for mac0.

Signed-off-by: Conor Dooley 
---
 board/microchip/mpfs_icicle/mpfs_icicle.c | 23 +++
 1 file changed, 7 insertions(+), 16 deletions(-)

diff --git a/board/microchip/mpfs_icicle/mpfs_icicle.c 
b/board/microchip/mpfs_icicle/mpfs_icicle.c
index 5fd0ec66a9..4d7d843dfa 100644
--- a/board/microchip/mpfs_icicle/mpfs_icicle.c
+++ b/board/microchip/mpfs_icicle/mpfs_icicle.c
@@ -79,18 +79,6 @@ int board_late_init(void)
char icicle_mac_addr[20];
void *blob = (void *)gd->fdt_blob;
 
-   node = fdt_path_offset(blob, "/soc/ethernet@20112000");
-   if (node < 0) {
-   printf("No ethernet0 path offset\n");
-   return -ENODEV;
-   }
-
-   ret = fdtdec_get_byte_array(blob, node, "local-mac-address", mac_addr, 
6);
-   if (ret) {
-   printf("No local-mac-address property for ethernet@20112000\n");
-   return -EINVAL;
-   }
-
read_device_serial_number(device_serial_number, 16);
 
/* Update MAC address with device serial number */
@@ -101,10 +89,13 @@ int board_late_init(void)
mac_addr[4] = device_serial_number[1];
mac_addr[5] = device_serial_number[0];
 
-   ret = fdt_setprop(blob, node, "local-mac-address", mac_addr, 6);
-   if (ret) {
-   printf("Error setting local-mac-address property for 
ethernet@20112000\n");
-   return -ENODEV;
+   node = fdt_path_offset(blob, "/soc/ethernet@20112000");
+   if (node >= 0) {
+   ret = fdt_setprop(blob, node, "local-mac-address", mac_addr, 6);
+   if (ret) {
+   printf("Error setting local-mac-address property for 
ethernet@20112000\n");
+   return -ENODEV;
+   }
}
 
icicle_mac_addr[0] = '[';
-- 
2.43.0