Re: [PATCH v1 2/3] board: sifive: Call spl_dram_init() for DRAM initialization

[E Shattow]

On Mon, Apr 22, 2024 at 6:16 AM  wrote:
>
> From: Lukas Funke 
>
> Call spl_dram_init() since this is commonly used for dram initialization
> in u-boot.
>
> Signed-off-by: Lukas Funke 
> ---
>
>  board/sifive/unleashed/spl.c | 4 ++--
>  board/sifive/unmatched/spl.c | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/board/sifive/unleashed/spl.c b/board/sifive/unleashed/spl.c
> index fe27316b2d..d6725a0e0e 100644
> --- a/board/sifive/unleashed/spl.c
> +++ b/board/sifive/unleashed/spl.c
> @@ -27,9 +27,9 @@ int spl_board_init_f(void)
>  {
> int ret;
>
> -   ret = spl_soc_init();
> +   ret = spl_dram_init();
> if (ret) {
> -   debug("FU540 SPL init failed: %d\n", ret);
> +   debug("FU540 dram init failed: %d\n", ret);
> return ret;
> }
>
> diff --git a/board/sifive/unmatched/spl.c b/board/sifive/unmatched/spl.c
> index e69bed9d99..500f484844 100644
> --- a/board/sifive/unmatched/spl.c
> +++ b/board/sifive/unmatched/spl.c
> @@ -134,9 +134,9 @@ int spl_board_init_f(void)
>  {
> int ret;
>
> -   ret = spl_soc_init();
> +   ret = spl_dram_init();
> if (ret) {
> -   debug("HiFive Unmatched FU740 SPL init failed: %d\n", ret);
> +   debug("HiFive Unmatched FU740 dram init failed: %d\n", ret);
> goto end;
> }
>
> --
> 2.30.2
>

Acronym DRAM should be all capitalized letters in strings.

-E

[PATCH v1 2/3] board: sifive: Call spl_dram_init() for DRAM initialization

[lukas . funke-oss]

From: Lukas Funke 

Call spl_dram_init() since this is commonly used for dram initialization
in u-boot.

Signed-off-by: Lukas Funke 
---

 board/sifive/unleashed/spl.c | 4 ++--
 board/sifive/unmatched/spl.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/board/sifive/unleashed/spl.c b/board/sifive/unleashed/spl.c
index fe27316b2d..d6725a0e0e 100644
--- a/board/sifive/unleashed/spl.c
+++ b/board/sifive/unleashed/spl.c
@@ -27,9 +27,9 @@ int spl_board_init_f(void)
 {
int ret;
 
-   ret = spl_soc_init();
+   ret = spl_dram_init();
if (ret) {
-   debug("FU540 SPL init failed: %d\n", ret);
+   debug("FU540 dram init failed: %d\n", ret);
return ret;
}
 
diff --git a/board/sifive/unmatched/spl.c b/board/sifive/unmatched/spl.c
index e69bed9d99..500f484844 100644
--- a/board/sifive/unmatched/spl.c
+++ b/board/sifive/unmatched/spl.c
@@ -134,9 +134,9 @@ int spl_board_init_f(void)
 {
int ret;
 
-   ret = spl_soc_init();
+   ret = spl_dram_init();
if (ret) {
-   debug("HiFive Unmatched FU740 SPL init failed: %d\n", ret);
+   debug("HiFive Unmatched FU740 dram init failed: %d\n", ret);
goto end;
}
 
-- 
2.30.2