Re: [PATCH v1 39/43] x86: Update the comment about booting for FSP2

[Bin Meng]

On Mon, Jun 15, 2020 at 11:58 AM Simon Glass  wrote:
>
> The comment here applies only to FSP1, so update it.
>
> Signed-off-by: Simon Glass 
> ---
>
>  arch/x86/cpu/start.S | 1 +
>  1 file changed, 1 insertion(+)
>

Reviewed-by: Bin Meng 

Re: [PATCH v1 39/43] x86: Update the comment about booting for FSP2

[Wolfgang Wallner]

Hi Simon,

-"Simon Glass"  schrieb: -
> Betreff: [PATCH v1 39/43] x86: Update the comment about booting for FSP2
> 
> The comment here applies only to FSP1, so update it.
> 
> Signed-off-by: Simon Glass 
> ---
> 
>  arch/x86/cpu/start.S | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/cpu/start.S b/arch/x86/cpu/start.S
> index 01524635e9..4ad515ce08 100644
> --- a/arch/x86/cpu/start.S
> +++ b/arch/x86/cpu/start.S
> @@ -124,6 +124,7 @@ car_init_ret:
>  #endif
>  #else
>   /*
> +  * Instructions for FSP1, but not FSP2:
>* U-Boot enters here twice. For the first time it comes from
>* car_init_done() with esp points to a temporary stack and esi
>* set to zero. For the second time it comes from fsp_init_done()
> -- 
> 2.27.0.290.gba653c62da-goog

Reviewed-by: Wolfgang Wallner 

[PATCH v1 39/43] x86: Update the comment about booting for FSP2

[Simon Glass]

The comment here applies only to FSP1, so update it.

Signed-off-by: Simon Glass 
---

 arch/x86/cpu/start.S | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/cpu/start.S b/arch/x86/cpu/start.S
index 01524635e9..4ad515ce08 100644
--- a/arch/x86/cpu/start.S
+++ b/arch/x86/cpu/start.S
@@ -124,6 +124,7 @@ car_init_ret:
 #endif
 #else
/*
+* Instructions for FSP1, but not FSP2:
 * U-Boot enters here twice. For the first time it comes from
 * car_init_done() with esp points to a temporary stack and esi
 * set to zero. For the second time it comes from fsp_init_done()
-- 
2.27.0.290.gba653c62da-goog