Re: [PATCH v1 5/6] video: tegra: add DC based PWM backlight driver

2023-04-19 Thread Simon Glass
On Wed, 19 Apr 2023 at 13:18, Svyatoslav Ryhel  wrote:
>
> DC based PWM backlight is found on some T20 and T30 devices
> (HTC One X). This backlight is controlled by Tegra DC and
> is adjustable by the DC PM0 or PM1 signal.
>
> Tested-by: Andreas Westman Dorcsak  # HTC One X T30
> Tested-by: Svyatoslav Ryhel  # HTC One X T30
> Signed-off-by: Svyatoslav Ryhel 
> ---
>  drivers/video/tegra20/Kconfig   |   7 +
>  drivers/video/tegra20/Makefile  |   1 +
>  drivers/video/tegra20/tegra-pwm-backlight.c | 155 
>  3 files changed, 163 insertions(+)
>  create mode 100644 drivers/video/tegra20/tegra-pwm-backlight.c

Reviewed-by: Simon Glass 


[PATCH v1 5/6] video: tegra: add DC based PWM backlight driver

2023-04-19 Thread Svyatoslav Ryhel
DC based PWM backlight is found on some T20 and T30 devices
(HTC One X). This backlight is controlled by Tegra DC and
is adjustable by the DC PM0 or PM1 signal.

Tested-by: Andreas Westman Dorcsak  # HTC One X T30
Tested-by: Svyatoslav Ryhel  # HTC One X T30
Signed-off-by: Svyatoslav Ryhel 
---
 drivers/video/tegra20/Kconfig   |   7 +
 drivers/video/tegra20/Makefile  |   1 +
 drivers/video/tegra20/tegra-pwm-backlight.c | 155 
 3 files changed, 163 insertions(+)
 create mode 100644 drivers/video/tegra20/tegra-pwm-backlight.c

diff --git a/drivers/video/tegra20/Kconfig b/drivers/video/tegra20/Kconfig
index 5b1dfbfbbe..f5c4843e11 100644
--- a/drivers/video/tegra20/Kconfig
+++ b/drivers/video/tegra20/Kconfig
@@ -15,3 +15,10 @@ config VIDEO_DSI_TEGRA30
help
   T30 has native support for DSI panels. This option enables support
   for such panels which can be used on endeavoru and tf600t.
+
+config TEGRA_BACKLIGHT_PWM
+   bool "Enable Tegra DC PWM backlight support"
+   depends on BACKLIGHT
+   select VIDEO_TEGRA20
+   help
+  Tegra DC dependent backlight.
diff --git a/drivers/video/tegra20/Makefile b/drivers/video/tegra20/Makefile
index e82ee96962..f0b534c579 100644
--- a/drivers/video/tegra20/Makefile
+++ b/drivers/video/tegra20/Makefile
@@ -2,3 +2,4 @@
 
 obj-$(CONFIG_VIDEO_TEGRA20) += tegra-dc.o
 obj-$(CONFIG_VIDEO_DSI_TEGRA30) += tegra-dsi.o mipi-phy.o
+obj-$(CONFIG_TEGRA_BACKLIGHT_PWM) += tegra-pwm-backlight.o
diff --git a/drivers/video/tegra20/tegra-pwm-backlight.c 
b/drivers/video/tegra20/tegra-pwm-backlight.c
new file mode 100644
index 00..409304b0e0
--- /dev/null
+++ b/drivers/video/tegra20/tegra-pwm-backlight.c
@@ -0,0 +1,155 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (c) 2022 Svyatoslav Ryhel 
+ */
+
+#define LOG_CATEGORY UCLASS_PANEL_BACKLIGHT
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+
+#define TEGRA_DISPLAY_A_BASE   0x5420
+#define TEGRA_DISPLAY_B_BASE   0x5424
+
+#define TEGRA_PWM_BL_MIN_BRIGHTNESS0x10
+#define TEGRA_PWM_BL_MAX_BRIGHTNESS0xFF
+
+#define TEGRA_PWM_BL_PERIOD0xFF
+#define TEGRA_PWM_BL_CLK_DIV   0x14
+#define TEGRA_PWM_BL_CLK_SELECT0x00
+
+#define PM_PERIOD_SHIFT 18
+#define PM_CLK_DIVIDER_SHIFT   4
+
+#define TEGRA_PWM_PM0  0
+#define TEGRA_PWM_PM1  1
+
+struct tegra_pwm_backlight_priv {
+   struct dc_ctlr *dc; /* Display controller regmap */
+
+   u32 pwm_source;
+   u32 period;
+   u32 clk_div;
+   u32 clk_select;
+   u32 dft_brightness;
+};
+
+static int tegra_pwm_backlight_set_brightness(struct udevice *dev, int percent)
+{
+   struct tegra_pwm_backlight_priv *priv = dev_get_priv(dev);
+   struct dc_cmd_reg *cmd = >dc->cmd;
+   struct dc_com_reg *com = >dc->com;
+   unsigned int ctrl;
+   unsigned long out_sel;
+   unsigned long cmd_state;
+
+   if (percent == BACKLIGHT_DEFAULT)
+   percent = priv->dft_brightness;
+
+   if (percent < TEGRA_PWM_BL_MIN_BRIGHTNESS)
+   percent = TEGRA_PWM_BL_MIN_BRIGHTNESS;
+
+   if (percent > TEGRA_PWM_BL_MAX_BRIGHTNESS)
+   percent = TEGRA_PWM_BL_MAX_BRIGHTNESS;
+
+   ctrl = ((priv->period << PM_PERIOD_SHIFT) |
+   (priv->clk_div << PM_CLK_DIVIDER_SHIFT) |
+priv->clk_select);
+
+   /* The new value should be effected immediately */
+   cmd_state = readl(>state_access);
+   writel((cmd_state | (1 << 2)), >state_access);
+
+   switch (priv->pwm_source) {
+   case TEGRA_PWM_PM0:
+   /* Select the LM0 on PM0 */
+   out_sel = readl(>pin_output_sel[5]);
+   out_sel &= ~(7 << 0);
+   out_sel |= (3 << 0);
+   writel(out_sel, >pin_output_sel[5]);
+   writel(ctrl, >pm0_ctrl);
+   writel(percent, >pm0_duty_cycle);
+   break;
+   case TEGRA_PWM_PM1:
+   /* Select the LM1 on PM1 */
+   out_sel = readl(>pin_output_sel[5]);
+   out_sel &= ~(7 << 4);
+   out_sel |= (3 << 4);
+   writel(out_sel, >pin_output_sel[5]);
+   writel(ctrl, >pm1_ctrl);
+   writel(percent, >pm1_duty_cycle);
+   break;
+   default:
+   break;
+   }
+
+   writel(cmd_state, >state_access);
+   return 0;
+}
+
+static int tegra_pwm_backlight_enable(struct udevice *dev)
+{
+   struct tegra_pwm_backlight_priv *priv = dev_get_priv(dev);
+   return tegra_pwm_backlight_set_brightness(dev, priv->dft_brightness);
+}
+
+static int tegra_pwm_backlight_probe(struct udevice *dev)
+{
+   struct tegra_pwm_backlight_priv *priv = dev_get_priv(dev);
+
+   if (dev_read_bool(dev, "nvidia,display-b-base"))
+