Re: [PATCH v13 00/24] Modernize U-Boot shell
On Thu, Jan 18, 2024 at 08:05:15AM +0100, Patrice CHOTARD wrote:
>
>
> On 1/17/24 18:39, Francesco Dolcini wrote:
> > On Thu, Jan 18, 2024 at 12:30:42AM +0700, Francis Laniel wrote:
> >> Le mercredi 17 janvier 2024, 17:05:28 +07 Patrice CHOTARD a écrit :
> >>> On 1/16/24 18:25, Francis Laniel wrote:
> Le mardi 16 janvier 2024, 00:34:24 +07 Patrice CHOTARD a écrit :
> > On 1/11/24 18:04, Francesco Dolcini wrote:
> >> On Fri, Dec 29, 2023 at 07:55:37PM +0100, Francis Laniel wrote:
> >>> Le jeudi 28 décembre 2023, 21:58:59 CET Tom Rini a écrit :
> On Fri, 22 Dec 2023 22:02:20 +0100, Francis Laniel wrote:
> > During 2021 summer, Sean Anderson wrote a contribution to add a new
> > shell,
> > based on LIL, to U-Boot [1, 2].
> > While one of the goals of this contribution was to address the fact
> > actual
> > U-Boot shell, which is based on Busybox hush, is old there was a
> > discussion
> > about adding a new shell versus updating the actual one [3, 4].
> >
> > So, in this series, with Harald Seiler, we updated the actual U-Boot
> > shell
> > to reflect what is currently in Busybox source code.
> > Basically, this contribution is about taking a snapshot of Busybox
> > shell/hush.c file (as it exists in commit 37460f5da) and adapt it to
> > suit
> > U-Boot needs.
> >
> > [...]
>
> Applied to u-boot/next, thanks!
> >>>
> >>> Thank you for the merge!
> >>> If there is any problem, do not hesitate to mail me and I will take
> >>> care
> >>> of
> >>> it!
> >>
> >> This change, specifically setting the modern hush shell as default, is
> >> breaking our boot script, just noticed since the current U-Boot master
> >> has a regression for us.
> >>
> >> We still need to figure out the exact details, here [1] you can find
> >> the
> >> boot script (that has some placeholder that is replaced during build).
> >>
> >> and the error is something like:
> >>
> >> ```
> >> ## Executing script at 9028
> >> Loading DeviceTree: k3-am625-verdin-nonwifi-dev.dtb
> >> 69025 bytes read in 11 ms (6 MiB/s)
> >> 82 bytes read in 9 ms (8.8 KiB/s)
> >> Working FDT set to 9020
> >> syntax error at 'done'HUSH died!
> >> resetting ...
> >> ```
> >>
> >> that I _assume_ comes from this line
> >>
> >> env set set_apply_overlays 'env set apply_overlays "for
> >> overlay_file
> >> in \\${fdt_overlays}; do echo Applying Overlay: \\${overlay_file}
> >> &&
> >> ${load_cmd} \\${loadaddr} \\${overlays_prefix}\\${overlay_file} &&
> >> fdt apply \\${loadaddr}; env set overlay_file; done; true"'>
> >>
> >> [1]
> >> https://git.toradex.com/cgit/meta-toradex-bsp-common.git/tree/recipes-bs
> >> p
> >> /u-boot/u-boot-distro-boot/boot.cmd.in
> >>
> >> Francesco
> >
> > Hi all
> >
> > I observed a similar issue with STM32MP157c-DK2 board.
> > Since commit 78912cfde281 ("cmd: Set modern hush as default shell")
> > U-Boot
> > crashes :
> >
> >
> > U-Boot 2024.01-00486-g697758e7c81-dirty (Jan 15 2024 - 18:23:52 +0100)
> >
> > CPU: STM32MP157CAC Rev.B
> > Model: STMicroelectronics STM32MP157C-DK2 Discovery Board
> > Board: stm32mp1 in trusted mode (st,stm32mp157c-dk2)
> > Board: MB1272 Var2.0 Rev.C-01
> > DRAM: 512 MiB
> > Clocks:
> > - MPU : 650 MHz
> > - MCU : 208.878 MHz
> > - AXI : 266.500 MHz
> > - PER : 24 MHz
> > - DDR : 533 MHz
> > optee optee: OP-TEE: revision 4.0 (e92de4ca)
> > I/TC: Reserved shared memory is disabled
> > I/TC: Dynamic shared memory is enabled
> > I/TC: Normal World virtualization support is disabled
> > I/TC: Asynchronous notifications are disabled
> > Core: 311 devices, 40 uclasses, devicetree: board
> > WDT: Started watchdog@5a002000 with servicing every 1000ms (32s
> > timeout)
> > NAND: 0 MiB
> > MMC: STM32 SD/MMC: 0
> > Loading Environment from MMC... OK
> > In:No input devices available!
> > Out: No output devices available!
> > Err: No error devices available!
> > Net: eth0: ethernet@5800a000
> > Hit any key to stop autoboot: 0
> > Boot over mmc0!
> > switch to partitions #0, OK
> > mmc0 is current device
> > Scanning mmc 0:8...
> > data abort
> > pc : [] lr : []
> > reloc pc : []lr : []
> > sp : dbafc848 ip : ddbfc578 fp : ddbedf18
> > r10: r9 : dbb15e70 r8 :
> > r7 : dbb5bf98 r6 : dbb5de10 r5 : dbb5bf98 r4 : ddbeda78
> > r3 : dbb5dc08 r2 : 33f8 r1 : 0071 r0 : ddbede00
> > Flags: nzcv IRQs off FIQs off Mode SVC_32 (T)
> > Code: 3138 1c48 f854 0030 (eb04) 05c1
> > Resett
Re: [PATCH v13 00/24] Modernize U-Boot shell
On 1/17/24 18:39, Francesco Dolcini wrote:
> On Thu, Jan 18, 2024 at 12:30:42AM +0700, Francis Laniel wrote:
>> Le mercredi 17 janvier 2024, 17:05:28 +07 Patrice CHOTARD a écrit :
>>> On 1/16/24 18:25, Francis Laniel wrote:
Le mardi 16 janvier 2024, 00:34:24 +07 Patrice CHOTARD a écrit :
> On 1/11/24 18:04, Francesco Dolcini wrote:
>> On Fri, Dec 29, 2023 at 07:55:37PM +0100, Francis Laniel wrote:
>>> Le jeudi 28 décembre 2023, 21:58:59 CET Tom Rini a écrit :
On Fri, 22 Dec 2023 22:02:20 +0100, Francis Laniel wrote:
> During 2021 summer, Sean Anderson wrote a contribution to add a new
> shell,
> based on LIL, to U-Boot [1, 2].
> While one of the goals of this contribution was to address the fact
> actual
> U-Boot shell, which is based on Busybox hush, is old there was a
> discussion
> about adding a new shell versus updating the actual one [3, 4].
>
> So, in this series, with Harald Seiler, we updated the actual U-Boot
> shell
> to reflect what is currently in Busybox source code.
> Basically, this contribution is about taking a snapshot of Busybox
> shell/hush.c file (as it exists in commit 37460f5da) and adapt it to
> suit
> U-Boot needs.
>
> [...]
Applied to u-boot/next, thanks!
>>>
>>> Thank you for the merge!
>>> If there is any problem, do not hesitate to mail me and I will take
>>> care
>>> of
>>> it!
>>
>> This change, specifically setting the modern hush shell as default, is
>> breaking our boot script, just noticed since the current U-Boot master
>> has a regression for us.
>>
>> We still need to figure out the exact details, here [1] you can find the
>> boot script (that has some placeholder that is replaced during build).
>>
>> and the error is something like:
>>
>> ```
>> ## Executing script at 9028
>> Loading DeviceTree: k3-am625-verdin-nonwifi-dev.dtb
>> 69025 bytes read in 11 ms (6 MiB/s)
>> 82 bytes read in 9 ms (8.8 KiB/s)
>> Working FDT set to 9020
>> syntax error at 'done'HUSH died!
>> resetting ...
>> ```
>>
>> that I _assume_ comes from this line
>>
>> env set set_apply_overlays 'env set apply_overlays "for overlay_file
>> in \\${fdt_overlays}; do echo Applying Overlay: \\${overlay_file} &&
>> ${load_cmd} \\${loadaddr} \\${overlays_prefix}\\${overlay_file} &&
>> fdt apply \\${loadaddr}; env set overlay_file; done; true"'>
>>
>> [1]
>> https://git.toradex.com/cgit/meta-toradex-bsp-common.git/tree/recipes-bs
>> p
>> /u-boot/u-boot-distro-boot/boot.cmd.in
>>
>> Francesco
>
> Hi all
>
> I observed a similar issue with STM32MP157c-DK2 board.
> Since commit 78912cfde281 ("cmd: Set modern hush as default shell")
> U-Boot
> crashes :
>
>
> U-Boot 2024.01-00486-g697758e7c81-dirty (Jan 15 2024 - 18:23:52 +0100)
>
> CPU: STM32MP157CAC Rev.B
> Model: STMicroelectronics STM32MP157C-DK2 Discovery Board
> Board: stm32mp1 in trusted mode (st,stm32mp157c-dk2)
> Board: MB1272 Var2.0 Rev.C-01
> DRAM: 512 MiB
> Clocks:
> - MPU : 650 MHz
> - MCU : 208.878 MHz
> - AXI : 266.500 MHz
> - PER : 24 MHz
> - DDR : 533 MHz
> optee optee: OP-TEE: revision 4.0 (e92de4ca)
> I/TC: Reserved shared memory is disabled
> I/TC: Dynamic shared memory is enabled
> I/TC: Normal World virtualization support is disabled
> I/TC: Asynchronous notifications are disabled
> Core: 311 devices, 40 uclasses, devicetree: board
> WDT: Started watchdog@5a002000 with servicing every 1000ms (32s
> timeout)
> NAND: 0 MiB
> MMC: STM32 SD/MMC: 0
> Loading Environment from MMC... OK
> In:No input devices available!
> Out: No output devices available!
> Err: No error devices available!
> Net: eth0: ethernet@5800a000
> Hit any key to stop autoboot: 0
> Boot over mmc0!
> switch to partitions #0, OK
> mmc0 is current device
> Scanning mmc 0:8...
> data abort
> pc : [] lr : []
> reloc pc : []lr : []
> sp : dbafc848 ip : ddbfc578 fp : ddbedf18
> r10: r9 : dbb15e70 r8 :
> r7 : dbb5bf98 r6 : dbb5de10 r5 : dbb5bf98 r4 : ddbeda78
> r3 : dbb5dc08 r2 : 33f8 r1 : 0071 r0 : ddbede00
> Flags: nzcv IRQs off FIQs off Mode SVC_32 (T)
> Code: 3138 1c48 f854 0030 (eb04) 05c1
> Resetting CPU ...
>>
>> I will take a look at the issue, trying to reproduce it and understand the
>> root cause.
>> I cannot give you any ETA for the fix, so for now I can only advise you to
>> stick with the old parser.
>
> Should we revert the change that set the modern hush shell as default
> till this is fixed?
>
> This is preventing
Re: [PATCH v13 00/24] Modernize U-Boot shell
On Thu, Jan 18, 2024 at 12:30:42AM +0700, Francis Laniel wrote:
> Le mercredi 17 janvier 2024, 17:05:28 +07 Patrice CHOTARD a écrit :
> > On 1/16/24 18:25, Francis Laniel wrote:
> > > Le mardi 16 janvier 2024, 00:34:24 +07 Patrice CHOTARD a écrit :
> > >> On 1/11/24 18:04, Francesco Dolcini wrote:
> > >>> On Fri, Dec 29, 2023 at 07:55:37PM +0100, Francis Laniel wrote:
> > Le jeudi 28 décembre 2023, 21:58:59 CET Tom Rini a écrit :
> > > On Fri, 22 Dec 2023 22:02:20 +0100, Francis Laniel wrote:
> > >> During 2021 summer, Sean Anderson wrote a contribution to add a new
> > >> shell,
> > >> based on LIL, to U-Boot [1, 2].
> > >> While one of the goals of this contribution was to address the fact
> > >> actual
> > >> U-Boot shell, which is based on Busybox hush, is old there was a
> > >> discussion
> > >> about adding a new shell versus updating the actual one [3, 4].
> > >>
> > >> So, in this series, with Harald Seiler, we updated the actual U-Boot
> > >> shell
> > >> to reflect what is currently in Busybox source code.
> > >> Basically, this contribution is about taking a snapshot of Busybox
> > >> shell/hush.c file (as it exists in commit 37460f5da) and adapt it to
> > >> suit
> > >> U-Boot needs.
> > >>
> > >> [...]
> > >
> > > Applied to u-boot/next, thanks!
> >
> > Thank you for the merge!
> > If there is any problem, do not hesitate to mail me and I will take
> > care
> > of
> > it!
> > >>>
> > >>> This change, specifically setting the modern hush shell as default, is
> > >>> breaking our boot script, just noticed since the current U-Boot master
> > >>> has a regression for us.
> > >>>
> > >>> We still need to figure out the exact details, here [1] you can find the
> > >>> boot script (that has some placeholder that is replaced during build).
> > >>>
> > >>> and the error is something like:
> > >>>
> > >>> ```
> > >>> ## Executing script at 9028
> > >>> Loading DeviceTree: k3-am625-verdin-nonwifi-dev.dtb
> > >>> 69025 bytes read in 11 ms (6 MiB/s)
> > >>> 82 bytes read in 9 ms (8.8 KiB/s)
> > >>> Working FDT set to 9020
> > >>> syntax error at 'done'HUSH died!
> > >>> resetting ...
> > >>> ```
> > >>>
> > >>> that I _assume_ comes from this line
> > >>>
> > >>> env set set_apply_overlays 'env set apply_overlays "for overlay_file
> > >>> in \\${fdt_overlays}; do echo Applying Overlay: \\${overlay_file} &&
> > >>> ${load_cmd} \\${loadaddr} \\${overlays_prefix}\\${overlay_file} &&
> > >>> fdt apply \\${loadaddr}; env set overlay_file; done; true"'>
> > >>>
> > >>> [1]
> > >>> https://git.toradex.com/cgit/meta-toradex-bsp-common.git/tree/recipes-bs
> > >>> p
> > >>> /u-boot/u-boot-distro-boot/boot.cmd.in
> > >>>
> > >>> Francesco
> > >>
> > >> Hi all
> > >>
> > >> I observed a similar issue with STM32MP157c-DK2 board.
> > >> Since commit 78912cfde281 ("cmd: Set modern hush as default shell")
> > >> U-Boot
> > >> crashes :
> > >>
> > >>
> > >> U-Boot 2024.01-00486-g697758e7c81-dirty (Jan 15 2024 - 18:23:52 +0100)
> > >>
> > >> CPU: STM32MP157CAC Rev.B
> > >> Model: STMicroelectronics STM32MP157C-DK2 Discovery Board
> > >> Board: stm32mp1 in trusted mode (st,stm32mp157c-dk2)
> > >> Board: MB1272 Var2.0 Rev.C-01
> > >> DRAM: 512 MiB
> > >> Clocks:
> > >> - MPU : 650 MHz
> > >> - MCU : 208.878 MHz
> > >> - AXI : 266.500 MHz
> > >> - PER : 24 MHz
> > >> - DDR : 533 MHz
> > >> optee optee: OP-TEE: revision 4.0 (e92de4ca)
> > >> I/TC: Reserved shared memory is disabled
> > >> I/TC: Dynamic shared memory is enabled
> > >> I/TC: Normal World virtualization support is disabled
> > >> I/TC: Asynchronous notifications are disabled
> > >> Core: 311 devices, 40 uclasses, devicetree: board
> > >> WDT: Started watchdog@5a002000 with servicing every 1000ms (32s
> > >> timeout)
> > >> NAND: 0 MiB
> > >> MMC: STM32 SD/MMC: 0
> > >> Loading Environment from MMC... OK
> > >> In:No input devices available!
> > >> Out: No output devices available!
> > >> Err: No error devices available!
> > >> Net: eth0: ethernet@5800a000
> > >> Hit any key to stop autoboot: 0
> > >> Boot over mmc0!
> > >> switch to partitions #0, OK
> > >> mmc0 is current device
> > >> Scanning mmc 0:8...
> > >> data abort
> > >> pc : [] lr : []
> > >> reloc pc : []lr : []
> > >> sp : dbafc848 ip : ddbfc578 fp : ddbedf18
> > >> r10: r9 : dbb15e70 r8 :
> > >> r7 : dbb5bf98 r6 : dbb5de10 r5 : dbb5bf98 r4 : ddbeda78
> > >> r3 : dbb5dc08 r2 : 33f8 r1 : 0071 r0 : ddbede00
> > >> Flags: nzcv IRQs off FIQs off Mode SVC_32 (T)
> > >> Code: 3138 1c48 f854 0030 (eb04) 05c1
> > >> Resetting CPU ...
>
> I will take a look at the issue, trying to reproduce it and understand the
> root cause.
> I cannot give you any ETA for the fix, so for now I can only advise you to
> stick with the old parser.
Should we revert the change that set th
Re: [PATCH v13 00/24] Modernize U-Boot shell
Hi!
Le mercredi 17 janvier 2024, 17:05:28 +07 Patrice CHOTARD a écrit :
> On 1/16/24 18:25, Francis Laniel wrote:
> > Hi!
> >
> > Le mardi 16 janvier 2024, 00:34:24 +07 Patrice CHOTARD a écrit :
> >> On 1/11/24 18:04, Francesco Dolcini wrote:
> >>> Hello Tom, Francis
> >>>
> >>> On Fri, Dec 29, 2023 at 07:55:37PM +0100, Francis Laniel wrote:
> Le jeudi 28 décembre 2023, 21:58:59 CET Tom Rini a écrit :
> > On Fri, 22 Dec 2023 22:02:20 +0100, Francis Laniel wrote:
> >> During 2021 summer, Sean Anderson wrote a contribution to add a new
> >> shell,
> >> based on LIL, to U-Boot [1, 2].
> >> While one of the goals of this contribution was to address the fact
> >> actual
> >> U-Boot shell, which is based on Busybox hush, is old there was a
> >> discussion
> >> about adding a new shell versus updating the actual one [3, 4].
> >>
> >> So, in this series, with Harald Seiler, we updated the actual U-Boot
> >> shell
> >> to reflect what is currently in Busybox source code.
> >> Basically, this contribution is about taking a snapshot of Busybox
> >> shell/hush.c file (as it exists in commit 37460f5da) and adapt it to
> >> suit
> >> U-Boot needs.
> >>
> >> [...]
> >
> > Applied to u-boot/next, thanks!
>
> Thank you for the merge!
> If there is any problem, do not hesitate to mail me and I will take
> care
> of
> it!
> >>>
> >>> This change, specifically setting the modern hush shell as default, is
> >>> breaking our boot script, just noticed since the current U-Boot master
> >>> has a regression for us.
> >>>
> >>> We still need to figure out the exact details, here [1] you can find the
> >>> boot script (that has some placeholder that is replaced during build).
> >>>
> >>> and the error is something like:
> >>>
> >>> ```
> >>> ## Executing script at 9028
> >>> Loading DeviceTree: k3-am625-verdin-nonwifi-dev.dtb
> >>> 69025 bytes read in 11 ms (6 MiB/s)
> >>> 82 bytes read in 9 ms (8.8 KiB/s)
> >>> Working FDT set to 9020
> >>> syntax error at 'done'HUSH died!
> >>> resetting ...
> >>> ```
> >>>
> >>> that I _assume_ comes from this line
> >>>
> >>> env set set_apply_overlays 'env set apply_overlays "for overlay_file
> >>> in \\${fdt_overlays}; do echo Applying Overlay: \\${overlay_file} &&
> >>> ${load_cmd} \\${loadaddr} \\${overlays_prefix}\\${overlay_file} &&
> >>> fdt apply \\${loadaddr}; env set overlay_file; done; true"'>
> >>>
> >>> [1]
> >>> https://git.toradex.com/cgit/meta-toradex-bsp-common.git/tree/recipes-bs
> >>> p
> >>> /u-boot/u-boot-distro-boot/boot.cmd.in
> >>>
> >>> Francesco
> >>
> >> Hi all
> >>
> >> I observed a similar issue with STM32MP157c-DK2 board.
> >> Since commit 78912cfde281 ("cmd: Set modern hush as default shell")
> >> U-Boot
> >> crashes :
> >>
> >>
> >> U-Boot 2024.01-00486-g697758e7c81-dirty (Jan 15 2024 - 18:23:52 +0100)
> >>
> >> CPU: STM32MP157CAC Rev.B
> >> Model: STMicroelectronics STM32MP157C-DK2 Discovery Board
> >> Board: stm32mp1 in trusted mode (st,stm32mp157c-dk2)
> >> Board: MB1272 Var2.0 Rev.C-01
> >> DRAM: 512 MiB
> >> Clocks:
> >> - MPU : 650 MHz
> >> - MCU : 208.878 MHz
> >> - AXI : 266.500 MHz
> >> - PER : 24 MHz
> >> - DDR : 533 MHz
> >> optee optee: OP-TEE: revision 4.0 (e92de4ca)
> >> I/TC: Reserved shared memory is disabled
> >> I/TC: Dynamic shared memory is enabled
> >> I/TC: Normal World virtualization support is disabled
> >> I/TC: Asynchronous notifications are disabled
> >> Core: 311 devices, 40 uclasses, devicetree: board
> >> WDT: Started watchdog@5a002000 with servicing every 1000ms (32s
> >> timeout)
> >> NAND: 0 MiB
> >> MMC: STM32 SD/MMC: 0
> >> Loading Environment from MMC... OK
> >> In:No input devices available!
> >> Out: No output devices available!
> >> Err: No error devices available!
> >> Net: eth0: ethernet@5800a000
> >> Hit any key to stop autoboot: 0
> >> Boot over mmc0!
> >> switch to partitions #0, OK
> >> mmc0 is current device
> >> Scanning mmc 0:8...
> >> data abort
> >> pc : [] lr : []
> >> reloc pc : []lr : []
> >> sp : dbafc848 ip : ddbfc578 fp : ddbedf18
> >> r10: r9 : dbb15e70 r8 :
> >> r7 : dbb5bf98 r6 : dbb5de10 r5 : dbb5bf98 r4 : ddbeda78
> >> r3 : dbb5dc08 r2 : 33f8 r1 : 0071 r0 : ddbede00
> >> Flags: nzcv IRQs off FIQs off Mode SVC_32 (T)
> >> Code: 3138 1c48 f854 0030 (eb04) 05c1
> >> Resetting CPU ...
> >>
> >>
> >> It crashes in blkcache_fill() , i didn't investigate deeply into this
> >> issue
> >> yet, but i can reproduce this issue by stopping autoboot by pressing a
> >> key
> >> and running a environment command as shown below :
> >>
> >> U-Boot 2024.01-00486-g697758e7c81-dirty (Jan 15 2024 - 18:23:52 +0100)
> >>
> >> CPU: STM32MP157CAC Rev.B
> >> Model: STMicroelectronics STM32MP157C-DK2 Discovery Board
> >> Board: stm32mp1 in trusted mode (st,stm32mp157c-dk2)
> >> Board: M
Re: [PATCH v13 00/24] Modernize U-Boot shell
On 1/16/24 18:25, Francis Laniel wrote:
> Hi!
>
>
> Le mardi 16 janvier 2024, 00:34:24 +07 Patrice CHOTARD a écrit :
>> On 1/11/24 18:04, Francesco Dolcini wrote:
>>> Hello Tom, Francis
>>>
>>> On Fri, Dec 29, 2023 at 07:55:37PM +0100, Francis Laniel wrote:
Le jeudi 28 décembre 2023, 21:58:59 CET Tom Rini a écrit :
> On Fri, 22 Dec 2023 22:02:20 +0100, Francis Laniel wrote:
>> During 2021 summer, Sean Anderson wrote a contribution to add a new
>> shell,
>> based on LIL, to U-Boot [1, 2].
>> While one of the goals of this contribution was to address the fact
>> actual
>> U-Boot shell, which is based on Busybox hush, is old there was a
>> discussion
>> about adding a new shell versus updating the actual one [3, 4].
>>
>> So, in this series, with Harald Seiler, we updated the actual U-Boot
>> shell
>> to reflect what is currently in Busybox source code.
>> Basically, this contribution is about taking a snapshot of Busybox
>> shell/hush.c file (as it exists in commit 37460f5da) and adapt it to
>> suit
>> U-Boot needs.
>>
>> [...]
>
> Applied to u-boot/next, thanks!
Thank you for the merge!
If there is any problem, do not hesitate to mail me and I will take care
of
it!
>>>
>>> This change, specifically setting the modern hush shell as default, is
>>> breaking our boot script, just noticed since the current U-Boot master
>>> has a regression for us.
>>>
>>> We still need to figure out the exact details, here [1] you can find the
>>> boot script (that has some placeholder that is replaced during build).
>>>
>>> and the error is something like:
>>>
>>> ```
>>> ## Executing script at 9028
>>> Loading DeviceTree: k3-am625-verdin-nonwifi-dev.dtb
>>> 69025 bytes read in 11 ms (6 MiB/s)
>>> 82 bytes read in 9 ms (8.8 KiB/s)
>>> Working FDT set to 9020
>>> syntax error at 'done'HUSH died!
>>> resetting ...
>>> ```
>>>
>>> that I _assume_ comes from this line
>>>
>>> env set set_apply_overlays 'env set apply_overlays "for overlay_file
>>> in \\${fdt_overlays}; do echo Applying Overlay: \\${overlay_file} &&
>>> ${load_cmd} \\${loadaddr} \\${overlays_prefix}\\${overlay_file} &&
>>> fdt apply \\${loadaddr}; env set overlay_file; done; true"'>
>>> [1]
>>> https://git.toradex.com/cgit/meta-toradex-bsp-common.git/tree/recipes-bsp
>>> /u-boot/u-boot-distro-boot/boot.cmd.in
>>>
>>> Francesco
>>
>> Hi all
>>
>> I observed a similar issue with STM32MP157c-DK2 board.
>> Since commit 78912cfde281 ("cmd: Set modern hush as default shell") U-Boot
>> crashes :
>>
>>
>> U-Boot 2024.01-00486-g697758e7c81-dirty (Jan 15 2024 - 18:23:52 +0100)
>>
>> CPU: STM32MP157CAC Rev.B
>> Model: STMicroelectronics STM32MP157C-DK2 Discovery Board
>> Board: stm32mp1 in trusted mode (st,stm32mp157c-dk2)
>> Board: MB1272 Var2.0 Rev.C-01
>> DRAM: 512 MiB
>> Clocks:
>> - MPU : 650 MHz
>> - MCU : 208.878 MHz
>> - AXI : 266.500 MHz
>> - PER : 24 MHz
>> - DDR : 533 MHz
>> optee optee: OP-TEE: revision 4.0 (e92de4ca)
>> I/TC: Reserved shared memory is disabled
>> I/TC: Dynamic shared memory is enabled
>> I/TC: Normal World virtualization support is disabled
>> I/TC: Asynchronous notifications are disabled
>> Core: 311 devices, 40 uclasses, devicetree: board
>> WDT: Started watchdog@5a002000 with servicing every 1000ms (32s timeout)
>> NAND: 0 MiB
>> MMC: STM32 SD/MMC: 0
>> Loading Environment from MMC... OK
>> In:No input devices available!
>> Out: No output devices available!
>> Err: No error devices available!
>> Net: eth0: ethernet@5800a000
>> Hit any key to stop autoboot: 0
>> Boot over mmc0!
>> switch to partitions #0, OK
>> mmc0 is current device
>> Scanning mmc 0:8...
>> data abort
>> pc : [] lr : []
>> reloc pc : []lr : []
>> sp : dbafc848 ip : ddbfc578 fp : ddbedf18
>> r10: r9 : dbb15e70 r8 :
>> r7 : dbb5bf98 r6 : dbb5de10 r5 : dbb5bf98 r4 : ddbeda78
>> r3 : dbb5dc08 r2 : 33f8 r1 : 0071 r0 : ddbede00
>> Flags: nzcv IRQs off FIQs off Mode SVC_32 (T)
>> Code: 3138 1c48 f854 0030 (eb04) 05c1
>> Resetting CPU ...
>>
>>
>> It crashes in blkcache_fill() , i didn't investigate deeply into this issue
>> yet, but i can reproduce this issue by stopping autoboot by pressing a key
>> and running a environment command as shown below :
>>
>> U-Boot 2024.01-00486-g697758e7c81-dirty (Jan 15 2024 - 18:23:52 +0100)
>>
>> CPU: STM32MP157CAC Rev.B
>> Model: STMicroelectronics STM32MP157C-DK2 Discovery Board
>> Board: stm32mp1 in trusted mode (st,stm32mp157c-dk2)
>> Board: MB1272 Var2.0 Rev.C-01
>> DRAM: 512 MiB
>> Clocks:
>> - MPU : 650 MHz
>> - MCU : 208.878 MHz
>> - AXI : 266.500 MHz
>> - PER : 24 MHz
>> - DDR : 533 MHz
>> optee optee: OP-TEE: revision 4.0 (e92de4ca)
>> I/TC: Reserved shared memory is disabled
>> I/TC: Dynamic shared memory is enabled
>> I/TC: Normal World virtualization support is disabled
>> I/TC: Asynchronous notifications are d
Re: [PATCH v13 00/24] Modernize U-Boot shell
Hi!
Le mardi 16 janvier 2024, 00:34:24 +07 Patrice CHOTARD a écrit :
> On 1/11/24 18:04, Francesco Dolcini wrote:
> > Hello Tom, Francis
> >
> > On Fri, Dec 29, 2023 at 07:55:37PM +0100, Francis Laniel wrote:
> >> Le jeudi 28 décembre 2023, 21:58:59 CET Tom Rini a écrit :
> >>> On Fri, 22 Dec 2023 22:02:20 +0100, Francis Laniel wrote:
> During 2021 summer, Sean Anderson wrote a contribution to add a new
> shell,
> based on LIL, to U-Boot [1, 2].
> While one of the goals of this contribution was to address the fact
> actual
> U-Boot shell, which is based on Busybox hush, is old there was a
> discussion
> about adding a new shell versus updating the actual one [3, 4].
>
> So, in this series, with Harald Seiler, we updated the actual U-Boot
> shell
> to reflect what is currently in Busybox source code.
> Basically, this contribution is about taking a snapshot of Busybox
> shell/hush.c file (as it exists in commit 37460f5da) and adapt it to
> suit
> U-Boot needs.
>
> [...]
> >>>
> >>> Applied to u-boot/next, thanks!
> >>
> >> Thank you for the merge!
> >> If there is any problem, do not hesitate to mail me and I will take care
> >> of
> >> it!
> >
> > This change, specifically setting the modern hush shell as default, is
> > breaking our boot script, just noticed since the current U-Boot master
> > has a regression for us.
> >
> > We still need to figure out the exact details, here [1] you can find the
> > boot script (that has some placeholder that is replaced during build).
> >
> > and the error is something like:
> >
> > ```
> > ## Executing script at 9028
> > Loading DeviceTree: k3-am625-verdin-nonwifi-dev.dtb
> > 69025 bytes read in 11 ms (6 MiB/s)
> > 82 bytes read in 9 ms (8.8 KiB/s)
> > Working FDT set to 9020
> > syntax error at 'done'HUSH died!
> > resetting ...
> > ```
> >
> > that I _assume_ comes from this line
> >
> > env set set_apply_overlays 'env set apply_overlays "for overlay_file
> > in \\${fdt_overlays}; do echo Applying Overlay: \\${overlay_file} &&
> > ${load_cmd} \\${loadaddr} \\${overlays_prefix}\\${overlay_file} &&
> > fdt apply \\${loadaddr}; env set overlay_file; done; true"'>
> > [1]
> > https://git.toradex.com/cgit/meta-toradex-bsp-common.git/tree/recipes-bsp
> > /u-boot/u-boot-distro-boot/boot.cmd.in
> >
> > Francesco
>
> Hi all
>
> I observed a similar issue with STM32MP157c-DK2 board.
> Since commit 78912cfde281 ("cmd: Set modern hush as default shell") U-Boot
> crashes :
>
>
> U-Boot 2024.01-00486-g697758e7c81-dirty (Jan 15 2024 - 18:23:52 +0100)
>
> CPU: STM32MP157CAC Rev.B
> Model: STMicroelectronics STM32MP157C-DK2 Discovery Board
> Board: stm32mp1 in trusted mode (st,stm32mp157c-dk2)
> Board: MB1272 Var2.0 Rev.C-01
> DRAM: 512 MiB
> Clocks:
> - MPU : 650 MHz
> - MCU : 208.878 MHz
> - AXI : 266.500 MHz
> - PER : 24 MHz
> - DDR : 533 MHz
> optee optee: OP-TEE: revision 4.0 (e92de4ca)
> I/TC: Reserved shared memory is disabled
> I/TC: Dynamic shared memory is enabled
> I/TC: Normal World virtualization support is disabled
> I/TC: Asynchronous notifications are disabled
> Core: 311 devices, 40 uclasses, devicetree: board
> WDT: Started watchdog@5a002000 with servicing every 1000ms (32s timeout)
> NAND: 0 MiB
> MMC: STM32 SD/MMC: 0
> Loading Environment from MMC... OK
> In:No input devices available!
> Out: No output devices available!
> Err: No error devices available!
> Net: eth0: ethernet@5800a000
> Hit any key to stop autoboot: 0
> Boot over mmc0!
> switch to partitions #0, OK
> mmc0 is current device
> Scanning mmc 0:8...
> data abort
> pc : [] lr : []
> reloc pc : []lr : []
> sp : dbafc848 ip : ddbfc578 fp : ddbedf18
> r10: r9 : dbb15e70 r8 :
> r7 : dbb5bf98 r6 : dbb5de10 r5 : dbb5bf98 r4 : ddbeda78
> r3 : dbb5dc08 r2 : 33f8 r1 : 0071 r0 : ddbede00
> Flags: nzcv IRQs off FIQs off Mode SVC_32 (T)
> Code: 3138 1c48 f854 0030 (eb04) 05c1
> Resetting CPU ...
>
>
> It crashes in blkcache_fill() , i didn't investigate deeply into this issue
> yet, but i can reproduce this issue by stopping autoboot by pressing a key
> and running a environment command as shown below :
>
> U-Boot 2024.01-00486-g697758e7c81-dirty (Jan 15 2024 - 18:23:52 +0100)
>
> CPU: STM32MP157CAC Rev.B
> Model: STMicroelectronics STM32MP157C-DK2 Discovery Board
> Board: stm32mp1 in trusted mode (st,stm32mp157c-dk2)
> Board: MB1272 Var2.0 Rev.C-01
> DRAM: 512 MiB
> Clocks:
> - MPU : 650 MHz
> - MCU : 208.878 MHz
> - AXI : 266.500 MHz
> - PER : 24 MHz
> - DDR : 533 MHz
> optee optee: OP-TEE: revision 4.0 (e92de4ca)
> I/TC: Reserved shared memory is disabled
> I/TC: Dynamic shared memory is enabled
> I/TC: Normal World virtualization support is disabled
> I/TC: Asynchronous notifications are disabled
> Core: 311 devices, 40 uclasses, devicetree: board
> WDT: Started watchdog@5a002000 with serv
Re: [PATCH v13 00/24] Modernize U-Boot shell
Hi!
Le vendredi 12 janvier 2024, 00:04:18 +07 Francesco Dolcini a écrit :
> Hello Tom, Francis
>
> On Fri, Dec 29, 2023 at 07:55:37PM +0100, Francis Laniel wrote:
> > Le jeudi 28 décembre 2023, 21:58:59 CET Tom Rini a écrit :
> > > On Fri, 22 Dec 2023 22:02:20 +0100, Francis Laniel wrote:
> > > > During 2021 summer, Sean Anderson wrote a contribution to add a new
> > > > shell,
> > > > based on LIL, to U-Boot [1, 2].
> > > > While one of the goals of this contribution was to address the fact
> > > > actual
> > > > U-Boot shell, which is based on Busybox hush, is old there was a
> > > > discussion
> > > > about adding a new shell versus updating the actual one [3, 4].
> > > >
> > > > So, in this series, with Harald Seiler, we updated the actual U-Boot
> > > > shell
> > > > to reflect what is currently in Busybox source code.
> > > > Basically, this contribution is about taking a snapshot of Busybox
> > > > shell/hush.c file (as it exists in commit 37460f5da) and adapt it to
> > > > suit
> > > > U-Boot needs.
> > > >
> > > > [...]
> > >
> > > Applied to u-boot/next, thanks!
> >
> > Thank you for the merge!
> > If there is any problem, do not hesitate to mail me and I will take care
> > of
> > it!
>
> This change, specifically setting the modern hush shell as default, is
> breaking our boot script, just noticed since the current U-Boot master
> has a regression for us.
>
> We still need to figure out the exact details, here [1] you can find the
> boot script (that has some placeholder that is replaced during build).
>
> and the error is something like:
>
> ```
> ## Executing script at 9028
> Loading DeviceTree: k3-am625-verdin-nonwifi-dev.dtb
> 69025 bytes read in 11 ms (6 MiB/s)
> 82 bytes read in 9 ms (8.8 KiB/s)
> Working FDT set to 9020
> syntax error at 'done'HUSH died!
> resetting ...
> ```
>
> that I _assume_ comes from this line
>
> env set set_apply_overlays 'env set apply_overlays "for overlay_file in
> \\${fdt_overlays}; do echo Applying Overlay: \\${overlay_file} &&
> ${load_cmd} \\${loadaddr} \\${overlays_prefix}\\${overlay_file} && fdt
> apply \\${loadaddr}; env set overlay_file; done; true"'
Sorry for the inconvenience, I tried to reproduce on my side and noticed some
strange behavior.
For the moment, can you please try to only escape "$" with "\$ and not "\\$"?
I would like to confirm some insights I have.
> [1]
> https://git.toradex.com/cgit/meta-toradex-bsp-common.git/tree/recipes-bsp/u
> -boot/u-boot-distro-boot/boot.cmd.in
>
> Francesco
Best regards.
Re: [PATCH v13 00/24] Modernize U-Boot shell
On 1/16/24 01:46, Tom Rini wrote:
> On Mon, Jan 15, 2024 at 06:34:24PM +0100, Patrice CHOTARD wrote:
>>
>>
>> On 1/11/24 18:04, Francesco Dolcini wrote:
>>> Hello Tom, Francis
>>>
>>> On Fri, Dec 29, 2023 at 07:55:37PM +0100, Francis Laniel wrote:
Le jeudi 28 décembre 2023, 21:58:59 CET Tom Rini a écrit :
> On Fri, 22 Dec 2023 22:02:20 +0100, Francis Laniel wrote:
>> During 2021 summer, Sean Anderson wrote a contribution to add a new
>> shell,
>> based on LIL, to U-Boot [1, 2].
>> While one of the goals of this contribution was to address the fact
>> actual
>> U-Boot shell, which is based on Busybox hush, is old there was a
>> discussion
>> about adding a new shell versus updating the actual one [3, 4].
>>
>> So, in this series, with Harald Seiler, we updated the actual U-Boot
>> shell
>> to reflect what is currently in Busybox source code.
>> Basically, this contribution is about taking a snapshot of Busybox
>> shell/hush.c file (as it exists in commit 37460f5da) and adapt it to suit
>> U-Boot needs.
>>
>> [...]
>
> Applied to u-boot/next, thanks!
Thank you for the merge!
If there is any problem, do not hesitate to mail me and I will take care
of
it!
>>>
>>> This change, specifically setting the modern hush shell as default, is
>>> breaking our boot script, just noticed since the current U-Boot master
>>> has a regression for us.
>>>
>>> We still need to figure out the exact details, here [1] you can find the
>>> boot script (that has some placeholder that is replaced during build).
>>>
>>> and the error is something like:
>>>
>>> ```
>>> ## Executing script at 9028
>>> Loading DeviceTree: k3-am625-verdin-nonwifi-dev.dtb
>>> 69025 bytes read in 11 ms (6 MiB/s)
>>> 82 bytes read in 9 ms (8.8 KiB/s)
>>> Working FDT set to 9020
>>> syntax error at 'done'HUSH died!
>>> resetting ...
>>> ```
>>>
>>> that I _assume_ comes from this line
>>>
>>> env set set_apply_overlays 'env set apply_overlays "for overlay_file in
>>> \\${fdt_overlays}; do echo Applying Overlay: \\${overlay_file} &&
>>> ${load_cmd} \\${loadaddr} \\${overlays_prefix}\\${overlay_file} && fdt
>>> apply \\${loadaddr}; env set overlay_file; done; true"'
>>>
>>> [1]
>>> https://git.toradex.com/cgit/meta-toradex-bsp-common.git/tree/recipes-bsp/u-boot/u-boot-distro-boot/boot.cmd.in
>>>
>>> Francesco
>>>
>>
>>
>> Hi all
>>
>> I observed a similar issue with STM32MP157c-DK2 board.
>> Since commit 78912cfde281 ("cmd: Set modern hush as default shell") U-Boot
>> crashes :
>
> I wonder if:
> https://patchwork.ozlabs.org/project/uboot/patch/20240115134656.50917-1-heinrich.schucha...@canonical.com/
> is relevant to this problem or not.
>
Hi Tom
Unfortunately, it doesn't help :-(
Thanks
Patrice
Re: [PATCH v13 00/24] Modernize U-Boot shell
On Mon, Jan 15, 2024 at 06:34:24PM +0100, Patrice CHOTARD wrote:
>
>
> On 1/11/24 18:04, Francesco Dolcini wrote:
> > Hello Tom, Francis
> >
> > On Fri, Dec 29, 2023 at 07:55:37PM +0100, Francis Laniel wrote:
> >> Le jeudi 28 décembre 2023, 21:58:59 CET Tom Rini a écrit :
> >>> On Fri, 22 Dec 2023 22:02:20 +0100, Francis Laniel wrote:
> During 2021 summer, Sean Anderson wrote a contribution to add a new
> shell,
> based on LIL, to U-Boot [1, 2].
> While one of the goals of this contribution was to address the fact
> actual
> U-Boot shell, which is based on Busybox hush, is old there was a
> discussion
> about adding a new shell versus updating the actual one [3, 4].
>
> So, in this series, with Harald Seiler, we updated the actual U-Boot
> shell
> to reflect what is currently in Busybox source code.
> Basically, this contribution is about taking a snapshot of Busybox
> shell/hush.c file (as it exists in commit 37460f5da) and adapt it to suit
> U-Boot needs.
>
> [...]
> >>>
> >>> Applied to u-boot/next, thanks!
> >>
> >> Thank you for the merge!
> >> If there is any problem, do not hesitate to mail me and I will take care
> >> of
> >> it!
> >
> > This change, specifically setting the modern hush shell as default, is
> > breaking our boot script, just noticed since the current U-Boot master
> > has a regression for us.
> >
> > We still need to figure out the exact details, here [1] you can find the
> > boot script (that has some placeholder that is replaced during build).
> >
> > and the error is something like:
> >
> > ```
> > ## Executing script at 9028
> > Loading DeviceTree: k3-am625-verdin-nonwifi-dev.dtb
> > 69025 bytes read in 11 ms (6 MiB/s)
> > 82 bytes read in 9 ms (8.8 KiB/s)
> > Working FDT set to 9020
> > syntax error at 'done'HUSH died!
> > resetting ...
> > ```
> >
> > that I _assume_ comes from this line
> >
> > env set set_apply_overlays 'env set apply_overlays "for overlay_file in
> > \\${fdt_overlays}; do echo Applying Overlay: \\${overlay_file} &&
> > ${load_cmd} \\${loadaddr} \\${overlays_prefix}\\${overlay_file} && fdt
> > apply \\${loadaddr}; env set overlay_file; done; true"'
> >
> > [1]
> > https://git.toradex.com/cgit/meta-toradex-bsp-common.git/tree/recipes-bsp/u-boot/u-boot-distro-boot/boot.cmd.in
> >
> > Francesco
> >
>
>
> Hi all
>
> I observed a similar issue with STM32MP157c-DK2 board.
> Since commit 78912cfde281 ("cmd: Set modern hush as default shell") U-Boot
> crashes :
I wonder if:
https://patchwork.ozlabs.org/project/uboot/patch/20240115134656.50917-1-heinrich.schucha...@canonical.com/
is relevant to this problem or not.
--
Tom
signature.asc
Description: PGP signature
Re: [PATCH v13 00/24] Modernize U-Boot shell
On 1/11/24 18:04, Francesco Dolcini wrote:
> Hello Tom, Francis
>
> On Fri, Dec 29, 2023 at 07:55:37PM +0100, Francis Laniel wrote:
>> Le jeudi 28 décembre 2023, 21:58:59 CET Tom Rini a écrit :
>>> On Fri, 22 Dec 2023 22:02:20 +0100, Francis Laniel wrote:
During 2021 summer, Sean Anderson wrote a contribution to add a new shell,
based on LIL, to U-Boot [1, 2].
While one of the goals of this contribution was to address the fact actual
U-Boot shell, which is based on Busybox hush, is old there was a
discussion
about adding a new shell versus updating the actual one [3, 4].
So, in this series, with Harald Seiler, we updated the actual U-Boot shell
to reflect what is currently in Busybox source code.
Basically, this contribution is about taking a snapshot of Busybox
shell/hush.c file (as it exists in commit 37460f5da) and adapt it to suit
U-Boot needs.
[...]
>>>
>>> Applied to u-boot/next, thanks!
>>
>> Thank you for the merge!
>> If there is any problem, do not hesitate to mail me and I will take care of
>> it!
>
> This change, specifically setting the modern hush shell as default, is
> breaking our boot script, just noticed since the current U-Boot master
> has a regression for us.
>
> We still need to figure out the exact details, here [1] you can find the
> boot script (that has some placeholder that is replaced during build).
>
> and the error is something like:
>
> ```
> ## Executing script at 9028
> Loading DeviceTree: k3-am625-verdin-nonwifi-dev.dtb
> 69025 bytes read in 11 ms (6 MiB/s)
> 82 bytes read in 9 ms (8.8 KiB/s)
> Working FDT set to 9020
> syntax error at 'done'HUSH died!
> resetting ...
> ```
>
> that I _assume_ comes from this line
>
> env set set_apply_overlays 'env set apply_overlays "for overlay_file in
> \\${fdt_overlays}; do echo Applying Overlay: \\${overlay_file} && ${load_cmd}
> \\${loadaddr} \\${overlays_prefix}\\${overlay_file} && fdt apply
> \\${loadaddr}; env set overlay_file; done; true"'
>
> [1]
> https://git.toradex.com/cgit/meta-toradex-bsp-common.git/tree/recipes-bsp/u-boot/u-boot-distro-boot/boot.cmd.in
>
> Francesco
>
Hi all
I observed a similar issue with STM32MP157c-DK2 board.
Since commit 78912cfde281 ("cmd: Set modern hush as default shell") U-Boot
crashes :
U-Boot 2024.01-00486-g697758e7c81-dirty (Jan 15 2024 - 18:23:52 +0100)
CPU: STM32MP157CAC Rev.B
Model: STMicroelectronics STM32MP157C-DK2 Discovery Board
Board: stm32mp1 in trusted mode (st,stm32mp157c-dk2)
Board: MB1272 Var2.0 Rev.C-01
DRAM: 512 MiB
Clocks:
- MPU : 650 MHz
- MCU : 208.878 MHz
- AXI : 266.500 MHz
- PER : 24 MHz
- DDR : 533 MHz
optee optee: OP-TEE: revision 4.0 (e92de4ca)
I/TC: Reserved shared memory is disabled
I/TC: Dynamic shared memory is enabled
I/TC: Normal World virtualization support is disabled
I/TC: Asynchronous notifications are disabled
Core: 311 devices, 40 uclasses, devicetree: board
WDT: Started watchdog@5a002000 with servicing every 1000ms (32s timeout)
NAND: 0 MiB
MMC: STM32 SD/MMC: 0
Loading Environment from MMC... OK
In:No input devices available!
Out: No output devices available!
Err: No error devices available!
Net: eth0: ethernet@5800a000
Hit any key to stop autoboot: 0
Boot over mmc0!
switch to partitions #0, OK
mmc0 is current device
Scanning mmc 0:8...
data abort
pc : [] lr : []
reloc pc : []lr : []
sp : dbafc848 ip : ddbfc578 fp : ddbedf18
r10: r9 : dbb15e70 r8 :
r7 : dbb5bf98 r6 : dbb5de10 r5 : dbb5bf98 r4 : ddbeda78
r3 : dbb5dc08 r2 : 33f8 r1 : 0071 r0 : ddbede00
Flags: nzcv IRQs off FIQs off Mode SVC_32 (T)
Code: 3138 1c48 f854 0030 (eb04) 05c1
Resetting CPU ...
It crashes in blkcache_fill() , i didn't investigate deeply into this issue
yet, but i can reproduce this issue
by stopping autoboot by pressing a key and running a environment command as
shown below :
U-Boot 2024.01-00486-g697758e7c81-dirty (Jan 15 2024 - 18:23:52 +0100)
CPU: STM32MP157CAC Rev.B
Model: STMicroelectronics STM32MP157C-DK2 Discovery Board
Board: stm32mp1 in trusted mode (st,stm32mp157c-dk2)
Board: MB1272 Var2.0 Rev.C-01
DRAM: 512 MiB
Clocks:
- MPU : 650 MHz
- MCU : 208.878 MHz
- AXI : 266.500 MHz
- PER : 24 MHz
- DDR : 533 MHz
optee optee: OP-TEE: revision 4.0 (e92de4ca)
I/TC: Reserved shared memory is disabled
I/TC: Dynamic shared memory is enabled
I/TC: Normal World virtualization support is disabled
I/TC: Asynchronous notifications are disabled
Core: 311 devices, 40 uclasses, devicetree: board
WDT: Started watchdog@5a002000 with servicing every 1000ms (32s timeout)
NAND: 0 MiB
MMC: STM32 SD/MMC: 0
Loading Environment from MMC... OK
In:No input devices available!
Out: No output devices available!
Err: No error devices available!
Net: eth0: ethernet@5800a000
Hit any key to stop autoboot: 0
STM32MP>
STM32MP>
Then i run "printenv" :
STM32MP> printenv
arch=arm
autoload=0
baudrate=1
Re: [PATCH v13 00/24] Modernize U-Boot shell
Hello Tom, Francis
On Fri, Dec 29, 2023 at 07:55:37PM +0100, Francis Laniel wrote:
> Le jeudi 28 décembre 2023, 21:58:59 CET Tom Rini a écrit :
> > On Fri, 22 Dec 2023 22:02:20 +0100, Francis Laniel wrote:
> > > During 2021 summer, Sean Anderson wrote a contribution to add a new shell,
> > > based on LIL, to U-Boot [1, 2].
> > > While one of the goals of this contribution was to address the fact actual
> > > U-Boot shell, which is based on Busybox hush, is old there was a
> > > discussion
> > > about adding a new shell versus updating the actual one [3, 4].
> > >
> > > So, in this series, with Harald Seiler, we updated the actual U-Boot shell
> > > to reflect what is currently in Busybox source code.
> > > Basically, this contribution is about taking a snapshot of Busybox
> > > shell/hush.c file (as it exists in commit 37460f5da) and adapt it to suit
> > > U-Boot needs.
> > >
> > > [...]
> >
> > Applied to u-boot/next, thanks!
>
> Thank you for the merge!
> If there is any problem, do not hesitate to mail me and I will take care of
> it!
This change, specifically setting the modern hush shell as default, is
breaking our boot script, just noticed since the current U-Boot master
has a regression for us.
We still need to figure out the exact details, here [1] you can find the
boot script (that has some placeholder that is replaced during build).
and the error is something like:
```
## Executing script at 9028
Loading DeviceTree: k3-am625-verdin-nonwifi-dev.dtb
69025 bytes read in 11 ms (6 MiB/s)
82 bytes read in 9 ms (8.8 KiB/s)
Working FDT set to 9020
syntax error at 'done'HUSH died!
resetting ...
```
that I _assume_ comes from this line
env set set_apply_overlays 'env set apply_overlays "for overlay_file in
\\${fdt_overlays}; do echo Applying Overlay: \\${overlay_file} && ${load_cmd}
\\${loadaddr} \\${overlays_prefix}\\${overlay_file} && fdt apply \\${loadaddr};
env set overlay_file; done; true"'
[1]
https://git.toradex.com/cgit/meta-toradex-bsp-common.git/tree/recipes-bsp/u-boot/u-boot-distro-boot/boot.cmd.in
Francesco
Re: [PATCH v13 00/24] Modernize U-Boot shell
Le jeudi 28 décembre 2023, 21:58:59 CET Tom Rini a écrit : > On Fri, 22 Dec 2023 22:02:20 +0100, Francis Laniel wrote: > > During 2021 summer, Sean Anderson wrote a contribution to add a new shell, > > based on LIL, to U-Boot [1, 2]. > > While one of the goals of this contribution was to address the fact actual > > U-Boot shell, which is based on Busybox hush, is old there was a > > discussion > > about adding a new shell versus updating the actual one [3, 4]. > > > > So, in this series, with Harald Seiler, we updated the actual U-Boot shell > > to reflect what is currently in Busybox source code. > > Basically, this contribution is about taking a snapshot of Busybox > > shell/hush.c file (as it exists in commit 37460f5da) and adapt it to suit > > U-Boot needs. > > > > [...] > > Applied to u-boot/next, thanks! Thank you for the merge! If there is any problem, do not hesitate to mail me and I will take care of it!
Re: [PATCH v13 00/24] Modernize U-Boot shell
On Fri, 22 Dec 2023 22:02:20 +0100, Francis Laniel wrote: > During 2021 summer, Sean Anderson wrote a contribution to add a new shell, > based > on LIL, to U-Boot [1, 2]. > While one of the goals of this contribution was to address the fact actual > U-Boot shell, which is based on Busybox hush, is old there was a discussion > about adding a new shell versus updating the actual one [3, 4]. > > So, in this series, with Harald Seiler, we updated the actual U-Boot shell to > reflect what is currently in Busybox source code. > Basically, this contribution is about taking a snapshot of Busybox > shell/hush.c > file (as it exists in commit 37460f5da) and adapt it to suit U-Boot needs. > > [...] Applied to u-boot/next, thanks! -- Tom
[PATCH v13 00/24] Modernize U-Boot shell
Hi! During 2021 summer, Sean Anderson wrote a contribution to add a new shell, based on LIL, to U-Boot [1, 2]. While one of the goals of this contribution was to address the fact actual U-Boot shell, which is based on Busybox hush, is old there was a discussion about adding a new shell versus updating the actual one [3, 4]. So, in this series, with Harald Seiler, we updated the actual U-Boot shell to reflect what is currently in Busybox source code. Basically, this contribution is about taking a snapshot of Busybox shell/hush.c file (as it exists in commit 37460f5da) and adapt it to suit U-Boot needs. This contribution was written to be as backward-compatible as possible to avoid breaking the existing. So, the modern hush flavor offers the same as the actual, that is to say: 1. Variable expansion. 2. Instruction lists (;, && and ||). 3. If, then and else. 4. Loops (for, while and until). No new features offered by Busybox hush were implemented (e.g. functions). It is possible to change the parser at runtime using the "cli" command: => cli print old => cli set modern => cli print modern => cli set old The default parser is the old one. Note that to use both parser, you would need to set both CONFIG_HUSH_MODERN_PARSER and CONFIG_HUSH_OLD_PARSER. In terms of testing, new unit tests were added to ut to ensure the new behavior is the same as the old one and it does not add regression. Nonetheless, if old behavior was buggy and fixed upstream, the fix is then added to U-Boot [5]. In sandbox, all of these tests pass smoothly: => printenv board board=sandbox => ut hush Running 20 hush tests ... Failures: 0 => cli set modern => ut hush Running 20 hush tests ... Failures: 0 Thanks to the effort of Harald Seiler, I was successful booting a board: => printenv fdtfile fdtfile=amlogic/meson-gxl-s905x-libretech-cc.dtb => cli get old => boot ... root@lepotato:~# root@lepotato:~# reboot ... => cli set modern => cli get modern => printenv fdtfile fdtfile=amlogic/meson-gxl-s905x-libretech-cc.dtb => boot ... root@lepotato:~# This contribution indeed adds a lot of code and there were concern about its size [6, 7]. With regard to the amount of code added, the cli_hush_upstream.c is 13030 lines long but it seems a smaller subset is really used: gcc -D__U_BOOT__ -E common/cli_hush_upstream.c | wc -l 2870 Despite this, it is better to still have the whole upstream code for the sake of easing maintenance. With regard to memory size, I conducted some experiments for version 8 of this series and for a subset of arm64 boards and found the worst case to be 4K [8]. Tom Rini conducted more research on this and also found the increase to be acceptable [9]. If you want to review it - your review will really be appreciated - here are some information regarding the commits: * commits marked as "test:" deal with unit tests. * commit "cli: Add Busybox upstream hush.c file." copies Busybox shell/hush.c into U-Boot tree, this explain why this commit contains around 12000 additions. * commit "cli: Port Busybox 2021 hush to U-Boot." modifies previously added file to permit us to use this as new shell. The really good idea of #include'ing Busybox code into a wrapper file to define some particular functions while minimizing modifications to upstream code comes from Harald Seiler. * commit "cmd: Add new parser command" adds a new command which permits selecting parser at runtime. I am not really satisfied with the fact it calls cli_init() and cli_loop() each time the parser is set, so your reviews would be welcomed. * Other commits focus on enabling features we need (e.g. if). Changes since: v2: * Added a small fix to compile sandbox with NO_SDL=1. * Added a command to change parser at runtime. * Added 2021 parser function to all run_command*(). v3: * Various bug fixes pointed by the CI. * Added upstream busybox hush commits until 6th February 2022. v4: * Various cleaning. * Modified python test to accept failure output when the test are designed to fail. * Bumped upstream busybox hush commits until 24h March 2022. v5: * Bumped upstream busybox hush commits until 30th January 2023. * Fix how hush interprets '<' and '>', indeed we needed to escape them but I removed this behavior as tests are handled by test command and not hush itself. This permitted to have the ut fdt to pass. * Fix a problem with how exit was handled. This was reported by the ut exit test. v6: * There was no v6 and I got mixed up with version. v7: * Bumped upstream busybox hush commits until 9th May 2023. * Renamed parser command to change parser at runtime to cli and added documentation. * Added better separation of patches. * Removed code about __gnu_thumb1_case_si as it was merged in another series. * Various cleaning. v8: * Bumped upstream busybox hush commits until 25th May 2023. v9: * Bumped upstream busybox hush commits until 2nd October 2023. v10: * Fixed a build error in commit adding cli command. * Add
