From: Ilias Apalodimas <ilias.apalodi...@linaro.org>

efi_tcg2_get_active_pcr_banks doesn't immediately call the
EFI_ENTRY() wrapper once it enters the function. Move the call a
few lines above to cover the error cases properly as well.

Signed-off-by: Ilias Apalodimas <ilias.apalodi...@linaro.org>
---
 lib/efi_loader/efi_tcg2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/efi_loader/efi_tcg2.c b/lib/efi_loader/efi_tcg2.c
index b87c7900a8..2eaa12b83b 100644
--- a/lib/efi_loader/efi_tcg2.c
+++ b/lib/efi_loader/efi_tcg2.c
@@ -717,16 +717,16 @@ efi_tcg2_get_active_pcr_banks(struct efi_tcg2_protocol 
*this,
        struct udevice *dev;
        efi_status_t ret;
 
+       EFI_ENTRY("%p, %p", this, active_pcr_banks);
+
        if (!this || !active_pcr_banks) {
                ret = EFI_INVALID_PARAMETER;
                goto out;
        }
-
        ret = tcg2_platform_get_tpm2(&dev);
        if (ret != EFI_SUCCESS)
                goto out;
 
-       EFI_ENTRY("%p, %p", this, active_pcr_banks);
        ret = tcg2_get_active_pcr_banks(dev, active_pcr_banks);
 
 out:
-- 
2.39.3

Reply via email to