Re: [PATCH v2] binman: doc: fix reference tag placement for Logging section

2023-09-14 Thread Simon Glass 
On Wed, 13 Sept 2023 at 10:16, Massimo Pegorer
 wrote:
>
> Move BinmanLogging reference tag after section "Signing FIT container
> with private key in an image" and just before section "Logging".
> Remove meaningless line with incomplete sentence.
>
> Fixes: 0f40e23fd22 ("binman: add documentation for binman sign option")
> Signed-off-by: Massimo Pegorer 
> Reviewed-by: Heinrich Schuchardt 
> ---
> Changes in v2:
> - Removed incomplete sentence (confirmed by Simon)
>
>  tools/binman/binman.rst | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>

Reviewed-by: Simon Glass

[PATCH v2] binman: doc: fix reference tag placement for Logging section

2023-09-13 Thread Massimo Pegorer 
Move BinmanLogging reference tag after section "Signing FIT container
with private key in an image" and just before section "Logging".
Remove meaningless line with incomplete sentence.

Fixes: 0f40e23fd22 ("binman: add documentation for binman sign option")
Signed-off-by: Massimo Pegorer 
Reviewed-by: Heinrich Schuchardt 
---
Changes in v2:
- Removed incomplete sentence (confirmed by Simon)

 tools/binman/binman.rst | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/tools/binman/binman.rst b/tools/binman/binman.rst
index aeea33fddb..020988d955 100644
--- a/tools/binman/binman.rst
+++ b/tools/binman/binman.rst
@@ -1480,9 +1480,6 @@ as set in stone, so Binman will ensure it doesn't change. 
Without this feature,
 repacking an entry might cause it to disobey the original constraints provided
 when it was created.
 
- Repacking an image involves
-
-.. _`BinmanLogging`:
 
 Signing FIT container with private key in an image
 --
@@ -1501,6 +1498,7 @@ If you want to sign and replace FIT container in place::
 which will sign FIT container with private key and replace it immediately
 inside your image.
 
+.. _`BinmanLogging`:
 
 Logging
 ---
-- 
2.34.1