Re: [PATCH v2] riscv: ae350: Enable CCTL_SUEN

2023-01-31 Thread Leo Liang
On Tue, Jan 03, 2023 at 04:17:13PM +0800, Rick Chen wrote:
> CCTL operations are available to Supervisor/User-mode
> software under the control of the mcache_ctl.CCTL_SUEN
> control bit. Enable it to support Supervisor(and User)
> CCTL operations.
> 
> Signed-off-by: Rick Chen 
> ---
> 
> Changes in v2
>  - fix typo
>  - correct aligment
> 
> ---
> 
>  arch/riscv/cpu/ax25/cpu.c | 18 +++---
>  1 file changed, 11 insertions(+), 7 deletions(-)
> 
Reviewed-by: Leo Yu-Chi Liang 


[PATCH v2] riscv: ae350: Enable CCTL_SUEN

2023-01-03 Thread Rick Chen
CCTL operations are available to Supervisor/User-mode
software under the control of the mcache_ctl.CCTL_SUEN
control bit. Enable it to support Supervisor(and User)
CCTL operations.

Signed-off-by: Rick Chen 
---

Changes in v2
 - fix typo
 - correct aligment

---

 arch/riscv/cpu/ax25/cpu.c | 18 +++---
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/arch/riscv/cpu/ax25/cpu.c b/arch/riscv/cpu/ax25/cpu.c
index c4c2de2ef0..a46674f7c2 100644
--- a/arch/riscv/cpu/ax25/cpu.c
+++ b/arch/riscv/cpu/ax25/cpu.c
@@ -12,18 +12,20 @@
 #include 
 
 #define CSR_MCACHE_CTL 0x7ca
-#define CSR_MMISC_CTL  0x7d0
-#define CSR_MARCHID0xf12
+#define CSR_MMISC_CTL  0x7d0
+#define CSR_MARCHID0xf12
 
 #define V5_MCACHE_CTL_IC_EN_OFFSET  0
 #define V5_MCACHE_CTL_DC_EN_OFFSET  1
-#define V5_MCACHE_CTL_DC_COHEN_OFFSET  19
+#define V5_MCACHE_CTL_CCTL_SUEN_OFFSET 8
+#define V5_MCACHE_CTL_DC_COHEN_OFFSET  19
 #define V5_MCACHE_CTL_DC_COHSTA_OFFSET 20
 
-#define V5_MCACHE_CTL_IC_ENBIT(V5_MCACHE_CTL_IC_EN_OFFSET)
-#define V5_MCACHE_CTL_DC_EN
BIT(V5_MCACHE_CTL_DC_EN_OFFSET)
-#define V5_MCACHE_CTL_DC_COHEN_EN   BIT(V5_MCACHE_CTL_DC_COHEN_OFFSET)
-#define V5_MCACHE_CTL_DC_COHSTA_EN  BIT(V5_MCACHE_CTL_DC_COHSTA_OFFSET)
+#define V5_MCACHE_CTL_IC_EN
BIT(V5_MCACHE_CTL_IC_EN_OFFSET)
+#define V5_MCACHE_CTL_DC_EN
BIT(V5_MCACHE_CTL_DC_EN_OFFSET)
+#define V5_MCACHE_CTL_CCTL_SUEN
BIT(V5_MCACHE_CTL_CCTL_SUEN_OFFSET)
+#define V5_MCACHE_CTL_DC_COHEN_EN   BIT(V5_MCACHE_CTL_DC_COHEN_OFFSET)
+#define V5_MCACHE_CTL_DC_COHSTA_EN  BIT(V5_MCACHE_CTL_DC_COHSTA_OFFSET)
 
 
 /*
@@ -55,6 +57,8 @@ void harts_early_init(void)
mcache_ctl_val |= V5_MCACHE_CTL_IC_EN;
if (!(mcache_ctl_val & V5_MCACHE_CTL_DC_EN))
mcache_ctl_val |= V5_MCACHE_CTL_DC_EN;
+   if (!(mcache_ctl_val & V5_MCACHE_CTL_CCTL_SUEN))
+   mcache_ctl_val |= V5_MCACHE_CTL_CCTL_SUEN;
csr_write(CSR_MCACHE_CTL, mcache_ctl_val);
 
/*
-- 
2.17.1