Re: [PATCH v2 0/3] xilinx: board: Improve legacy format handling

2023-01-27 Thread Michal Simek




On 1/24/23 16:19, Michal Simek wrote:

Hi,

fix and improve legacy format handling to cover cases where eeprom content
is corrupted and random. Very likely detection algorithm can be improved -
for example check that mac address is valid, check all strings, etc. but
the aim of this series is to remove all non printable chars without mac
address and never copy more bytes than expected.

Thanks,
Michal

Changes in v2:
- Add +1 for strlcpy because only size -1 is used compare to strncpy.

Michal Simek (3):
   xilinx: board: Use ETH_ALEN macro for mac address size
   xilinx: board: Fix xilinx_eeprom_legacy_cleanup()
   xilinx: board: Update logic in xilinx_read_eeprom_legacy

  board/xilinx/common/board.c | 34 +-
  1 file changed, 21 insertions(+), 13 deletions(-)



Applied.
M


[PATCH v2 0/3] xilinx: board: Improve legacy format handling

2023-01-24 Thread Michal Simek
Hi,

fix and improve legacy format handling to cover cases where eeprom content
is corrupted and random. Very likely detection algorithm can be improved -
for example check that mac address is valid, check all strings, etc. but
the aim of this series is to remove all non printable chars without mac
address and never copy more bytes than expected.

Thanks,
Michal

Changes in v2:
- Add +1 for strlcpy because only size -1 is used compare to strncpy.

Michal Simek (3):
  xilinx: board: Use ETH_ALEN macro for mac address size
  xilinx: board: Fix xilinx_eeprom_legacy_cleanup()
  xilinx: board: Update logic in xilinx_read_eeprom_legacy

 board/xilinx/common/board.c | 34 +-
 1 file changed, 21 insertions(+), 13 deletions(-)

-- 
2.36.1