Re: [PATCH v2 0/4] Fix fdtfile for j722s and am62p
Hi Nishanth, On 10:23-20240702, Manorit Chawdhry wrote: > Hi Nishanth, > > On 10:28-20240701, Nishanth Menon wrote: > > On 10:48-20240701, Manorit Chawdhry wrote: > > > fdtfile wasn't being populated in these boards, add the code in evm.c > > > for the same. > > > > > > Signed-off-by: Manorit Chawdhry > > > --- > > > Changes in v2: > > > - Replace findfdt with fdtfile as that is what the series fixes. > > > (Nishanth) > > > - Drop findfdt as well for K3 platforms legacy support > > > - Link to v1: > > > https://lore.kernel.org/r/20240628-b4-upstream-streamline-platform-v1-0-17659af99...@ti.com > > > > > > --- > > > > > > Please explain in your patches the impact the changes have on all > > platforms - not just TI K3 platforms. that was already asked on previous > > reviews, please provide the explanations in commit message to prevent > > folks from having to guess. > > > > From my understanding, there should be no impact to any platform with > these changes, let me know if you notice any platform that is being > impacted by the following change? > > The way I see it is - > 1. It's adding support for populating fdtfile with ti_set_fdt_env for >j722s, am62p > 2. It's moving name_fdt change to fdtfile ( as name_fdt is not defined >anymore - and we need to move away from name_fdt as well due to >deprecation warning ) in ti/mmc.env. > 3. ti/mmc.env even though used in k2g devices along with K3, still have >their own override of the variable that am changing in the common >ti/mmc.env so should be no-impact. > 3. Since fdtfile is being set by ti_set_fdt_env for all K3 platforms ( >which are the only users of bootcmd_ti_mmc iiuc ) so we can remove >findfdt from bootcmd_ti_mmc ( which is still legacy support and not >used in the default BOOTCOMMAND ). > > Let me know if am understanding something incorrectly. With my current understanding, I have rolled a v3 with updated commit messages, let me know there if you feel am missing something. Regards, Manorit > > Regards, > Manorit > > > > Dhruva Gole (1): > > > include: env: ti_common: Remove findfdt > > > > > > Manorit Chawdhry (3): > > > include: env: ti: mmc: Change name_fdt usage to fdtfile > > > board: ti: am62p|j722s: Add ti_set_fdt_env for fdtfile > > > configs: am62p|j722s_a53: Add CONFIG_BOARD_LATE_INIT > > > > > > board/ti/am62px/evm.c| 9 + > > > board/ti/j722s/evm.c | 9 + > > > configs/am62px_evm_a53_defconfig | 1 + > > > configs/j722s_evm_a53_defconfig | 1 + > > > include/env/ti/mmc.env | 2 +- > > > include/env/ti/ti_common.env | 2 +- > > > 6 files changed, 22 insertions(+), 2 deletions(-) > > > --- > > > base-commit: 899b088674b6905710ce546f0a8848662904852a > > > change-id: 20240628-b4-upstream-streamline-platform-f0d7453637b2 > > > > > > Best regards, > > > -- > > > Manorit Chawdhry > > > > > > > -- > > Regards, > > Nishanth Menon > > Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 > > 849D 1736 249D
Re: [PATCH v2 0/4] Fix fdtfile for j722s and am62p
Hi Nishanth, On 10:28-20240701, Nishanth Menon wrote: > On 10:48-20240701, Manorit Chawdhry wrote: > > fdtfile wasn't being populated in these boards, add the code in evm.c > > for the same. > > > > Signed-off-by: Manorit Chawdhry > > --- > > Changes in v2: > > - Replace findfdt with fdtfile as that is what the series fixes. (Nishanth) > > - Drop findfdt as well for K3 platforms legacy support > > - Link to v1: > > https://lore.kernel.org/r/20240628-b4-upstream-streamline-platform-v1-0-17659af99...@ti.com > > > > --- > > > Please explain in your patches the impact the changes have on all > platforms - not just TI K3 platforms. that was already asked on previous > reviews, please provide the explanations in commit message to prevent > folks from having to guess. > >From my understanding, there should be no impact to any platform with these changes, let me know if you notice any platform that is being impacted by the following change? The way I see it is - 1. It's adding support for populating fdtfile with ti_set_fdt_env for j722s, am62p 2. It's moving name_fdt change to fdtfile ( as name_fdt is not defined anymore - and we need to move away from name_fdt as well due to deprecation warning ) in ti/mmc.env. 3. ti/mmc.env even though used in k2g devices along with K3, still have their own override of the variable that am changing in the common ti/mmc.env so should be no-impact. 3. Since fdtfile is being set by ti_set_fdt_env for all K3 platforms ( which are the only users of bootcmd_ti_mmc iiuc ) so we can remove findfdt from bootcmd_ti_mmc ( which is still legacy support and not used in the default BOOTCOMMAND ). Let me know if am understanding something incorrectly. Regards, Manorit > > Dhruva Gole (1): > > include: env: ti_common: Remove findfdt > > > > Manorit Chawdhry (3): > > include: env: ti: mmc: Change name_fdt usage to fdtfile > > board: ti: am62p|j722s: Add ti_set_fdt_env for fdtfile > > configs: am62p|j722s_a53: Add CONFIG_BOARD_LATE_INIT > > > > board/ti/am62px/evm.c| 9 + > > board/ti/j722s/evm.c | 9 + > > configs/am62px_evm_a53_defconfig | 1 + > > configs/j722s_evm_a53_defconfig | 1 + > > include/env/ti/mmc.env | 2 +- > > include/env/ti/ti_common.env | 2 +- > > 6 files changed, 22 insertions(+), 2 deletions(-) > > --- > > base-commit: 899b088674b6905710ce546f0a8848662904852a > > change-id: 20240628-b4-upstream-streamline-platform-f0d7453637b2 > > > > Best regards, > > -- > > Manorit Chawdhry > > > > -- > Regards, > Nishanth Menon > Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 > 849D 1736 249D
Re: [PATCH v2 0/4] Fix fdtfile for j722s and am62p
On 10:48-20240701, Manorit Chawdhry wrote: > fdtfile wasn't being populated in these boards, add the code in evm.c > for the same. > > Signed-off-by: Manorit Chawdhry > --- > Changes in v2: > - Replace findfdt with fdtfile as that is what the series fixes. (Nishanth) > - Drop findfdt as well for K3 platforms legacy support > - Link to v1: > https://lore.kernel.org/r/20240628-b4-upstream-streamline-platform-v1-0-17659af99...@ti.com > > --- Please explain in your patches the impact the changes have on all platforms - not just TI K3 platforms. that was already asked on previous reviews, please provide the explanations in commit message to prevent folks from having to guess. > Dhruva Gole (1): > include: env: ti_common: Remove findfdt > > Manorit Chawdhry (3): > include: env: ti: mmc: Change name_fdt usage to fdtfile > board: ti: am62p|j722s: Add ti_set_fdt_env for fdtfile > configs: am62p|j722s_a53: Add CONFIG_BOARD_LATE_INIT > > board/ti/am62px/evm.c| 9 + > board/ti/j722s/evm.c | 9 + > configs/am62px_evm_a53_defconfig | 1 + > configs/j722s_evm_a53_defconfig | 1 + > include/env/ti/mmc.env | 2 +- > include/env/ti/ti_common.env | 2 +- > 6 files changed, 22 insertions(+), 2 deletions(-) > --- > base-commit: 899b088674b6905710ce546f0a8848662904852a > change-id: 20240628-b4-upstream-streamline-platform-f0d7453637b2 > > Best regards, > -- > Manorit Chawdhry > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
[PATCH v2 0/4] Fix fdtfile for j722s and am62p
fdtfile wasn't being populated in these boards, add the code in evm.c for the same. Signed-off-by: Manorit Chawdhry --- Changes in v2: - Replace findfdt with fdtfile as that is what the series fixes. (Nishanth) - Drop findfdt as well for K3 platforms legacy support - Link to v1: https://lore.kernel.org/r/20240628-b4-upstream-streamline-platform-v1-0-17659af99...@ti.com --- Dhruva Gole (1): include: env: ti_common: Remove findfdt Manorit Chawdhry (3): include: env: ti: mmc: Change name_fdt usage to fdtfile board: ti: am62p|j722s: Add ti_set_fdt_env for fdtfile configs: am62p|j722s_a53: Add CONFIG_BOARD_LATE_INIT board/ti/am62px/evm.c| 9 + board/ti/j722s/evm.c | 9 + configs/am62px_evm_a53_defconfig | 1 + configs/j722s_evm_a53_defconfig | 1 + include/env/ti/mmc.env | 2 +- include/env/ti/ti_common.env | 2 +- 6 files changed, 22 insertions(+), 2 deletions(-) --- base-commit: 899b088674b6905710ce546f0a8848662904852a change-id: 20240628-b4-upstream-streamline-platform-f0d7453637b2 Best regards, -- Manorit Chawdhry
