Re: [PATCH v2 0/5] powerpc, mpc83xx: add DM_ETH support
Hello Rasmus,
just for your information...
I had the chance to test current next branch on the MPC8360
based kmcoge5ne board ... I hope to get this board into
my automated testsetup soon...
Here the logs:
U-Boot 2020.10-rc4-00088-gc428a44124-dirty (Sep 30 2020 - 12:06:01 +0200)
Reset Status:
CPU: e300c1, MPC8360A, Rev: 2.1 at 528 MHz, CSB: 264 MHz
Model: kmcoge5ne
Board: ABB kmcoge5ne with PIGGY.
I2C: ready
DRAM: 512 MiB (DDR2, 64-bit, ECC off, 264 MHz)
POST memory PASSED
Flash: 64 MiB
NAND: 128 MiB
Loading Environment from Flash... OK
In:serial@4500
Out: serial@4500
Err: serial@4500
Net: eth0: ucc@3200
Hit key to stop autoboot in 2s
=>
=> setenv serverip 192.168.1.2
=> setenv ipaddr 192.168.1.1
=> bd
boot_params = 0x
DRAM bank = 0x
-> start= 0x
-> size = 0x2000
flashstart = 0xf000
flashsize = 0x0400
flashoffset = 0x00073000
baudrate= 115200 bps
relocaddr = 0x1ff83000
reloc off = 0x2ff83000
Build = 32-bit
current eth = ucc@3200
ethaddr = 00:e0:df:6e:34:80
IP addr = 192.168.1.1
fdt_blob= 0x1fb7cea0
new_fdt = 0x1fb7cea0
fdt_size= 0x2000
lmb_dump_all:
memory.cnt = 0x1
memory.size= 0x0
memory.reg[0x0].base = 0x0
.size = 0x2000
reserved.cnt = 0x1
reserved.size = 0x0
reserved.reg[0x0].base = 0x1fb7bb90
.size = 0x484470
busfreq =264 MHz
bootflags = 0x
intfreq =528 MHz
=> dm tree
Class Index Probed DriverName
---
root 0 [ + ] root_driver root_driver
simple_bus0 [ + ] simple_bus|-- soc8360@e000
serial0 [ + ] ns16550_serial| |-- serial@4500
pinctrl 0 [ + ] par-io-pinctrl| |-- par_io@1400
simple_bus1 [ + ] simple_bus| `-- qe@10
bootcount 0 [ + ] bootcount-mem | |-- bootcount@0x1bff8
eth 0 [ + ] ucc_geth | |-- ucc@3200
mdio 0 [ + ] qe_uec_mdio | `-- mdio@3320
simple_bus2 [ ] simple_bus`-- localbus@e0005000
=> dm
dm - Driver model low level access
Usage:
dm tree Dump driver model tree ('*' = activated)
dm uclassDump list of instances for each uclass
dm devresDump list of device resources for each device
dm drivers Dump list of drivers with uclass and instances
dm compatDump list of drivers with compatibility strings
dm staticDump list of drivers with static platform data
=> dm uclass
uclass 0: root
0 * root_driver @ 1fb7f028, seq 0, (req -1)
uclass 23: bootcount
0 * bootcount@0x1bff8 @ 1fb7f2b0, seq 0, (req -1)
uclass 33: eth
0 * ucc@3200 @ 1fb7f338, seq 0, (req 0)
uclass 34: eth_phy_generic
uclass 51: mdio
0 * mdio@3320 @ 1fb7f3d0, seq 0, (req -1)
uclass 57: nop
uclass 69: pinctrl
0 * par_io@1400 @ 1fb7f1c0, seq 0, (req -1)
uclass 81: serial
0 * serial@4500 @ 1fb7f128, seq 0, (req 0)
uclass 82: simple_bus
0 * soc8360@e000 @ 1fb7f0a0, seq 0, (req -1)
1 * qe@10 @ 1fb7f228, seq 1, (req -1)
2 localbus@e0005000 @ 1fb7f428
=> dm devres
=> dm drivers
Driveruid uclass Devices
--
bootcount-mem 023 bootcountbootcount@0x1bff8
eth_phy_generic_drv 034 eth_phy_generic
ucc_geth 033 eth ucc@3200
qe_uec_mdio 051 mdio mdio@3320
ns16550_serial081 serial serial@4500
par-io-pinctrl069 pinctrl par_io@1400
root_driver 000 root root_driver
simple_bus082 simple_bus soc8360@e000
qe@10
localbus@e0005000
=> dm compat
DriverCompatible
bootcount-mem u-boot,bootcount
eth_phy_generic_drv
ucc_geth ucc_geth
qe_uec_mdio fsl,ucc-mdio
ns16550_serialns16550
ns16550a
ingenic,jz4780-uart
nvidia,tegra20-uart
snps,dw-apb-uart
par-io-pinctrlfsl,mpc8360-par_io
root_driver
simple_bussimple-bus
simple-mfd
=> dm static
DriverAddress
-
=> bd
boot_params = 0x
DRAM bank = 0x
-> start= 0x
-> size = 0x2000
flashstart = 0xf000
flashsize = 0x0400
flashoffset = 0x00073000
baudrate= 115200 bps
relocaddr = 0x1ff83000
reloc off = 0x2ff83000
Build = 32-bit
current eth = ucc@3200
ethaddr = 00:e0:df:6e:34:80
IP addr =
Re: [PATCH v2 0/5] powerpc, mpc83xx: add DM_ETH support
Hello Rasmus,
Am 24.09.2020 um 08:55 schrieb Rasmus Villemoes:
On 23/09/2020 07.02, Heiko Schocher wrote:
Hi Rasmus,
Am 22.09.2020 um 16:34 schrieb Rasmus Villemoes:
The board already used OF_CONTROL, so I've tried extending the
device-tree based partly on you changes for the km boards, partly from
our linux device tree - the two mostly agree:
+ qe: qe@e010 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ device_type = "qe";
+ compatible = "fsl,qe";
+ ranges = <0x0 0xe010 0x0010>;
+ reg = <0xe010 0x480>;
Does this work with linux? If so, it should be OK
I miss something like:
https://gitlab.denx.de/u-boot/u-boot/-/commit/7bdfe8592956439743cad3c2d3ff5f24c4dd5aa9#8fd63f1c0ee54bb5ed6e0446595997296ab56205
Important here:
&qe {
compatible = "fsl,qe", "simple-bus";
};
That helped, thanks. In our linux device tree we just have "fsl,qe",
which works because linux has an actual driver for that. Is there a
reason you didn't just include the "simple-bus" string in the .dtsi
files, instead of fixing it in each .dts that includes the .dtsi?
No, seems there is more room for optimizations :-)
The defconfig is updated with
CONFIG_MTD_UBI_FASTMAP_AUTOCONVERT=1
CONFIG_PHYLIB=y
CONFIG_PHY_MARVELL=y
+CONFIG_DM_ETH=y
+CONFIG_DM_MDIO=y
+CONFIG_DM_ETH_PHY=y
CONFIG_MII=y
+CONFIG_QE_UEC=y
Looks good...
So, I also added CONFIG_PHY_FIXED, and changed from the deprecated old-style
fixed-link = <1 1 100 0 0>;
(which I can't find any U-Boot code that would parse) to the new-style
fixed-link {
speed = <100>;
full-duplex;
};
Ok!
Perhaps I need to explain a little more about the board: It has a
marvell 88e6250 switch, the above fixed-link is from one of the cpu's
ethernet devices to the switch's cpu port. In order to get traffic
flowing, we used to manually do a few mii commands to instruct the
switch to open the cpu port and one specific outwards port, i.e. we have
something like
phy1_up=mii write 17 19 3100; mii write 17 18 9620; mii write 19 04 007F
cpu_up=mii write 1D 01 0033; mii write 1D 04 007F > prep_switch=mii device
UEC2; run phy1_up cpu_up ...
Why not adding this into a phy driver?
So I used to be able to do
=> run prep_switch
=> ping $serverip
UEC: PHY is Fixed PHY ()
UEC0: Full Duplex
UEC0: Speed 100BT
UEC0: Link is up
Using UEC0 device
host 192.168.174.2 is alive
Now, I've updated the prep_switch etc. commands to use "mdio write
mdio@2120 ...", and that part I think works - when I run the phy1_up,
the link LED does get lit, and using mdio read I can read back both the
registers I wrote as well as the switch's identification registers, so
I'm pretty sure I'm talking to the right thing. But when I then try the
ping command, nothing:
=> ping $serverip
ping failed; host 192.168.174.2 is not alive
Any hints?
So, you see that your ethernet and so also mdio driver is probed?
Can you post a "dm tree" output?
Without looking onto hardware it is hard to say ... you need to
debug into ethernet driver, may compare register setup with old
driver
May a problem with pinsetup? Or clock setup?
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: h...@denx.de
Re: [PATCH v2 0/5] powerpc, mpc83xx: add DM_ETH support
On 23/09/2020 07.02, Heiko Schocher wrote:
> Hi Rasmus,
>
> Am 22.09.2020 um 16:34 schrieb Rasmus Villemoes:
>> The board already used OF_CONTROL, so I've tried extending the
>> device-tree based partly on you changes for the km boards, partly from
>> our linux device tree - the two mostly agree:
>>
>> + qe: qe@e010 {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + device_type = "qe";
>> + compatible = "fsl,qe";
>> + ranges = <0x0 0xe010 0x0010>;
>> + reg = <0xe010 0x480>;
>
> Does this work with linux? If so, it should be OK
>
> I miss something like:
>
> https://gitlab.denx.de/u-boot/u-boot/-/commit/7bdfe8592956439743cad3c2d3ff5f24c4dd5aa9#8fd63f1c0ee54bb5ed6e0446595997296ab56205
>
> Important here:
>
> &qe {
> compatible = "fsl,qe", "simple-bus";
> };
That helped, thanks. In our linux device tree we just have "fsl,qe",
which works because linux has an actual driver for that. Is there a
reason you didn't just include the "simple-bus" string in the .dtsi
files, instead of fixing it in each .dts that includes the .dtsi?
>>
>> The defconfig is updated with
>>
>> CONFIG_MTD_UBI_FASTMAP_AUTOCONVERT=1
>> CONFIG_PHYLIB=y
>> CONFIG_PHY_MARVELL=y
>> +CONFIG_DM_ETH=y
>> +CONFIG_DM_MDIO=y
>> +CONFIG_DM_ETH_PHY=y
>> CONFIG_MII=y
>> +CONFIG_QE_UEC=y
>
> Looks good...
So, I also added CONFIG_PHY_FIXED, and changed from the deprecated old-style
fixed-link = <1 1 100 0 0>;
(which I can't find any U-Boot code that would parse) to the new-style
fixed-link {
speed = <100>;
full-duplex;
};
Perhaps I need to explain a little more about the board: It has a
marvell 88e6250 switch, the above fixed-link is from one of the cpu's
ethernet devices to the switch's cpu port. In order to get traffic
flowing, we used to manually do a few mii commands to instruct the
switch to open the cpu port and one specific outwards port, i.e. we have
something like
phy1_up=mii write 17 19 3100; mii write 17 18 9620; mii write 19 04 007F
cpu_up=mii write 1D 01 0033; mii write 1D 04 007F
prep_switch=mii device UEC2; run phy1_up cpu_up ...
So I used to be able to do
=> run prep_switch
=> ping $serverip
UEC: PHY is Fixed PHY ()
UEC0: Full Duplex
UEC0: Speed 100BT
UEC0: Link is up
Using UEC0 device
host 192.168.174.2 is alive
Now, I've updated the prep_switch etc. commands to use "mdio write
mdio@2120 ...", and that part I think works - when I run the phy1_up,
the link LED does get lit, and using mdio read I can read back both the
registers I wrote as well as the switch's identification registers, so
I'm pretty sure I'm talking to the right thing. But when I then try the
ping command, nothing:
=> ping $serverip
ping failed; host 192.168.174.2 is not alive
Any hints?
Thanks,
Rasmus
Re: [PATCH v2 0/5] powerpc, mpc83xx: add DM_ETH support
Hi Rasmus,
Am 22.09.2020 um 16:34 schrieb Rasmus Villemoes:
Hi Heiko
I'm struggling somewhat with getting our mpc8309-derived board converted
to DM_ETH. I just get
Net: No ethernet found.
where I used to get
Net: UEC0, UEC1, UEC2
:-(
Ok, I currently have no access to the hardware, I wait for the customer
to give me access, will take until next week ... so I can only review
currently code changes...
BTW: I hope to get daily access, so I can add at least one board to
my daily U-Boot tbot tests, see:
http://xeidos.ddns.net/ubtestresults/home
and there's no errors or other diagnostics printed (I've also tried
adding #define DEBUG 1 to the .c files under drivers/net/qe/, still
nothing).
The board already used OF_CONTROL, so I've tried extending the
device-tree based partly on you changes for the km boards, partly from
our linux device tree - the two mostly agree:
@@ -25,6 +25,8 @@
i2c0 = &i2c0;
i2c1 = &i2c1;
spi0 = &spi0;
+ ethernet0 = &enet0;
+ ethernet2 = &enet2;
};
chosen {
@@ -315,6 +317,95 @@
clocks = <&clocks MPC83XX_CLK_SDHC>;
clock-names = "per";
};
+
+ ipic: pic@700 {
+ compatible = "fsl,ipic";
+ interrupt-controller;
+ #address-cells = <0>;
+ #interrupt-cells = <2>;
+ reg = <0x700 0x100>;
+ device_type = "ipic";
+ };
};
-};
+ qe: qe@e010 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ device_type = "qe";
+ compatible = "fsl,qe";
+ ranges = <0x0 0xe010 0x0010>;
+ reg = <0xe010 0x480>;
+ brg-frequency = <0>;
+ bus-frequency = <39600>;
+
+ muram@1 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "fsl,qe-muram", "fsl,cpm-muram";
+ ranges = <0x0 0x0001 0x4000>;
+
+ data-only@0 {
+ compatible = "fsl,qe-muram-data",
+"fsl,cpm-muram-data";
+ reg = <0x0 0x4000>;
+ };
+ };
+
+ qeic: interrupt-controller@80 {
+ interrupt-controller;
+ compatible = "fsl,qe-ic";
+ #address-cells = <0>;
+ #interrupt-cells = <1>;
+ reg = <0x80 0x80>;
+ big-endian;
+ interrupts = <32 8 33 8>;
+ interrupt-parent = <&ipic>;
+ };
+
+ enet0: ethernet@2000 {
+ device_type = "network";
+ compatible = "ucc_geth";
+ cell-index = <1>;
+ reg = <0x2000 0x200>;
+ interrupts = <32>;
+ interrupt-parent = <&qeic>;
+ local-mac-address = [ 00 00 00 00 00 00 ];
+ rx-clock-name = "clk9";
+ tx-clock-name = "clk10";
+ fixed-link = <1 1 100 0 0>;
+ };
+
+ enet2: ethernet@2200 {
+ device_type = "network";
+ compatible = "ucc_geth";
+ cell-index = <3>;
+ reg = <0x2200 0x200>;
+ interrupts = <34>;
+ interrupt-parent = <&qeic>;
+ local-mac-address = [ 00 00 00 00 00 00 ];
+ rx-clock-name = "clk11";
+ tx-clock-name = "clk12";
+ phy-handle = <&phy1>;
+ phy-connection-type = "mii";
+ };
+
+ mdio0: mdio@2120 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0x2120 0x18>;
+ compatible = "fsl,ucc-mdio";
+
+ phy0: ethernet-phy@00 {
+ reg = <0x01>;
+ device_type = "ethernet-phy";
+ };
+ phy1: ethernet-phy@01 {
+ reg = <0x02>;
+ device_type = "ethernet-phy";
+ };
+ };
+
+
+ };
+
+};
Does this work with linux? If so, it should be OK
I miss something like:
https://gitlab.denx.de/u-boot/u-boot/-/commit/7bdfe8592956439743cad3c2d3ff5f24c4dd5aa9#8fd63f1c0ee54bb5ed6e0446595997296ab56205
Important here:
&qe {
compatible = "fsl,qe", "simple-bus";
};
The defcon
Re: [PATCH v2 0/5] powerpc, mpc83xx: add DM_ETH support
Hi Heiko
I'm struggling somewhat with getting our mpc8309-derived board converted
to DM_ETH. I just get
Net: No ethernet found.
where I used to get
Net: UEC0, UEC1, UEC2
and there's no errors or other diagnostics printed (I've also tried
adding #define DEBUG 1 to the .c files under drivers/net/qe/, still
nothing).
The board already used OF_CONTROL, so I've tried extending the
device-tree based partly on you changes for the km boards, partly from
our linux device tree - the two mostly agree:
@@ -25,6 +25,8 @@
i2c0 = &i2c0;
i2c1 = &i2c1;
spi0 = &spi0;
+ ethernet0 = &enet0;
+ ethernet2 = &enet2;
};
chosen {
@@ -315,6 +317,95 @@
clocks = <&clocks MPC83XX_CLK_SDHC>;
clock-names = "per";
};
+
+ ipic: pic@700 {
+ compatible = "fsl,ipic";
+ interrupt-controller;
+ #address-cells = <0>;
+ #interrupt-cells = <2>;
+ reg = <0x700 0x100>;
+ device_type = "ipic";
+ };
};
-};
+ qe: qe@e010 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ device_type = "qe";
+ compatible = "fsl,qe";
+ ranges = <0x0 0xe010 0x0010>;
+ reg = <0xe010 0x480>;
+ brg-frequency = <0>;
+ bus-frequency = <39600>;
+
+ muram@1 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "fsl,qe-muram", "fsl,cpm-muram";
+ ranges = <0x0 0x0001 0x4000>;
+
+ data-only@0 {
+ compatible = "fsl,qe-muram-data",
+"fsl,cpm-muram-data";
+ reg = <0x0 0x4000>;
+ };
+ };
+
+ qeic: interrupt-controller@80 {
+ interrupt-controller;
+ compatible = "fsl,qe-ic";
+ #address-cells = <0>;
+ #interrupt-cells = <1>;
+ reg = <0x80 0x80>;
+ big-endian;
+ interrupts = <32 8 33 8>;
+ interrupt-parent = <&ipic>;
+ };
+
+ enet0: ethernet@2000 {
+ device_type = "network";
+ compatible = "ucc_geth";
+ cell-index = <1>;
+ reg = <0x2000 0x200>;
+ interrupts = <32>;
+ interrupt-parent = <&qeic>;
+ local-mac-address = [ 00 00 00 00 00 00 ];
+ rx-clock-name = "clk9";
+ tx-clock-name = "clk10";
+ fixed-link = <1 1 100 0 0>;
+ };
+
+ enet2: ethernet@2200 {
+ device_type = "network";
+ compatible = "ucc_geth";
+ cell-index = <3>;
+ reg = <0x2200 0x200>;
+ interrupts = <34>;
+ interrupt-parent = <&qeic>;
+ local-mac-address = [ 00 00 00 00 00 00 ];
+ rx-clock-name = "clk11";
+ tx-clock-name = "clk12";
+ phy-handle = <&phy1>;
+ phy-connection-type = "mii";
+ };
+
+ mdio0: mdio@2120 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0x2120 0x18>;
+ compatible = "fsl,ucc-mdio";
+
+ phy0: ethernet-phy@00 {
+ reg = <0x01>;
+ device_type = "ethernet-phy";
+ };
+ phy1: ethernet-phy@01 {
+ reg = <0x02>;
+ device_type = "ethernet-phy";
+ };
+ };
+
+
+ };
+
+};
The defconfig is updated with
CONFIG_MTD_UBI_FASTMAP_AUTOCONVERT=1
CONFIG_PHYLIB=y
CONFIG_PHY_MARVELL=y
+CONFIG_DM_ETH=y
+CONFIG_DM_MDIO=y
+CONFIG_DM_ETH_PHY=y
CONFIG_MII=y
+CONFIG_QE_UEC=y
and finally I've removed the UEC_ETH definitions from the board config
header:
-/*
- * Ethernet setup
- */
-
-/* enable uec ethernet */
-#define CONFIG_UEC_ETH
-
-/* eth1 */
-#define CONFIG_UEC_ETH1
-#define CONFIG_SYS_UEC1_UCC_NUM0
-#define CONFIG_SYS_UEC1_RX_CLK QE_CLK9
-#define CONFIG_SYS_UEC1_TX_CLK QE_CLK10
-#define CONFIG_SYS_UEC1_ETH_TYPE FAST_ETH
-#define CONFIG_SYS_UEC1_PHY_ADDR 0x11
-#define CONFIG_SYS_UEC1_INTERFACE_TYPE
Re: [PATCH v2 0/5] powerpc, mpc83xx: add DM_ETH support
Hi Rasmus, Am 21.09.2020 um 10:40 schrieb Rasmus Villemoes: On 17/09/2020 06.24, Heiko Schocher wrote: Hello Rasmus, Am 16.09.2020 um 21:35 schrieb Rasmus Villemoes: We have a mpc8309-based board, currently using a U-Boot based on v2020.04. If you have a git tree I can pull these patches from I'll try to test them on our hardware. Pushed them (rebased to next) to: https://github.com/hsdenx/u-boot-test/tree/kmcoge5ne-dm-ethernet-devel started travis build for this branch: https://travis-ci.org/github/hsdenx/u-boot-test/builds/727904421 Thanks, it took me a bit longer rebasing our private patches to -next than I thought, but I'm starting to look at those now. The first thing I notice is this: - u32 pin_2bit_mask; - u32 pin_2bit_dir; - u32 pin_2bit_assign; - u32 pin_1bit_mask; + u32 2bit_mask; + u32 2bit_dir; + u32 2bit_assign; + u32 1bit_mask; That doesn't compile (can't start identifier with digit), but you fix it Autsch ... up later. Any chance you can make these patches bisectable? Especially a patch that claims to be about fixing coding style shouldn't introduce build errors. I am sorry about that, but Tom already pulled the patches into next... bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: h...@denx.de
Re: [PATCH v2 0/5] powerpc, mpc83xx: add DM_ETH support
On 17/09/2020 06.24, Heiko Schocher wrote: > Hello Rasmus, > > Am 16.09.2020 um 21:35 schrieb Rasmus Villemoes: >> >> We have a mpc8309-based board, currently using a U-Boot based on >> v2020.04. If you have a git tree I can pull these patches from I'll try >> to test them on our hardware. > > Pushed them (rebased to next) to: > > https://github.com/hsdenx/u-boot-test/tree/kmcoge5ne-dm-ethernet-devel > > started travis build for this branch: > https://travis-ci.org/github/hsdenx/u-boot-test/builds/727904421 Thanks, it took me a bit longer rebasing our private patches to -next than I thought, but I'm starting to look at those now. The first thing I notice is this: - u32 pin_2bit_mask; - u32 pin_2bit_dir; - u32 pin_2bit_assign; - u32 pin_1bit_mask; + u32 2bit_mask; + u32 2bit_dir; + u32 2bit_assign; + u32 1bit_mask; That doesn't compile (can't start identifier with digit), but you fix it up later. Any chance you can make these patches bisectable? Especially a patch that claims to be about fixing coding style shouldn't introduce build errors. Thanks, Rasmus
Re: [PATCH v2 0/5] powerpc, mpc83xx: add DM_ETH support
On Thu, Sep 17, 2020 at 03:03:28PM +0200, Heiko Schocher wrote: > Hello Tom, > > Am 17.09.2020 um 14:51 schrieb Tom Rini: > > On Thu, Sep 17, 2020 at 06:27:03AM +0200, Heiko Schocher wrote: > > > Hello Tom, > > > > > > Am 16.09.2020 um 21:01 schrieb Tom Rini: > > > > On Wed, Sep 16, 2020 at 07:04:57AM +0200, Heiko Schocher wrote: > > > > > Hello Mario, Tom, > > > > > > > > > > added Tom to cc ... > > > > > > > > > > Am 08.09.2020 um 07:59 schrieb Heiko Schocher: > > > > > > Hi Mario, > > > > > > > > > > > > Am 17.08.2020 um 07:23 schrieb Heiko Schocher: > > > > > > > Hello Mario, > > > > > > > > > > > > > > Am 27.05.2020 um 14:43 schrieb Heiko Schocher: > > > > > > > > > > > > > > > > This patch series adds DM ethernet support for mpc83xx based > > > > > > > > keymile boards. > > > > > > > > > > > > > > > > Travis build: > > > > > > > > https://travis-ci.org/github/hsdenx/u-boot-test/builds/691607214 > > > > > > > > > > > > > > > > > > > > > > > > Changes in v2: > > > > > > > > - new in v2 > > > > > > > > - remove RFC > > > > > > > > - fixed Codingstyle errors, therefore new patch > > > > > > > > powerpc, mpc83xx: fix codingstyle issues for qe_io.c > > > > > > > > - moved DM part to drivers/pinctrl > > > > > > > > - add comments from Qiang Zhao: > > > > > > > > - add device node documentation > > > > > > > > - I did not drop the dm_qe_uec_phy.c and use > > > > > > > > drivers/net/fsl_mdio.c > > > > > > > > because using drivers/net/fsl_mdio.c leads in none > > > > > > > > existent > > > > > > > > udevice mdio@3320 > > > > > > > > instead boards with DM ETH support should use now this > > > > > > > > driver. > > > > > > > > - remove RFC tag > > > > > > > > - add patch which fixes Codingstyle errors in drivers/qe > > > > > > > > - add patch which converts the mpc83xx based boards from > > > > > > > > keymile to DM_ETH > > > > > > > > > > > > > > > > Heiko Schocher (5): > > > > > > > > mpc83xx: remove unneeded extern declaration in cpu_init > > > > > > > > powerpc, qe: fix codingstyle issues for drivers/qe > > > > > > > > powerpc, qe: add DTS support for parallel I/O ports > > > > > > > > net, qe: add DM support for QE UEC ethernet > > > > > > > > mpc83xx, keymile boards: enable DM_ETH and add DTS > > > > > > > > > > > > > > > > arch/powerpc/cpu/mpc83xx/Kconfig | 8 + > > > > > > > > arch/powerpc/cpu/mpc83xx/Makefile | 2 + > > > > > > > > arch/powerpc/cpu/mpc83xx/cpu_init.c | 11 +- > > > > > > > > arch/powerpc/cpu/mpc83xx/qe_io.c | 98 +- > > > > > > > > arch/powerpc/dts/Makefile | 8 + > > > > > > > > arch/powerpc/dts/km8309-uboot.dtsi | 33 + > > > > > > > > arch/powerpc/dts/km8321-uboot.dtsi | 67 + > > > > > > > > arch/powerpc/dts/km8321.dtsi | 220 > > > > > > > > arch/powerpc/dts/km836x-uboot.dtsi | 61 + > > > > > > > > arch/powerpc/dts/km836x.dtsi | 182 +++ > > > > > > > > arch/powerpc/dts/kmcoge5ne-uboot.dtsi | 22 + > > > > > > > > arch/powerpc/dts/kmcoge5ne.dts | 320 + > > > > > > > > arch/powerpc/dts/kmeter1-uboot.dtsi | 42 + > > > > > > > > arch/powerpc/dts/kmeter1.dts | 480 +++ > > > > > > > > arch/powerpc/dts/kmopti2.dts | 161 +++ > > > > > > > > arch/powerpc/dts/kmsupc5.dts | 139 ++ > > > > > > > > arch/powerpc/dts/kmsupm5.dts | 129 ++ > > > > > > > > arch/powerpc/dts/kmtegr1.dts | 392 ++ > > > > > > > > arch/powerpc/dts/kmtepr2.dts | 142 ++ > > > > > > > > arch/powerpc/dts/kmtuge1.dts | 100 ++ > > > > > > > > arch/powerpc/dts/kmtuxa1.dts | 100 ++ > > > > > > > > board/keymile/km83xx/Kconfig | 17 + > > > > > > > > board/keymile/km83xx/MAINTAINERS | 23 +- > > > > > > > > board/keymile/km83xx/km83xx.c | 64 - > > > > > > > > configs/kmcoge5ne_defconfig | 11 +- > > > > > > > > configs/kmeter1_defconfig | 10 +- > > > > > > > > configs/kmopti2_defconfig | 11 +- > > > > > > > > configs/kmsupx5_defconfig | 10 +- > > > > > > > > configs/kmtegr1_defconfig | 12 +- > > > > > > > > configs/kmtepr2_defconfig | 10 +- > > > > > > > > configs/tuge1_defconfig | 10 +- > > > > > > > > configs/tuxx1_defconfig | 11 +- > > > > > > > > .../soc/fsl/cpm_qe/qe/ucc.txt | 53 + > > > > > > > > drivers/net/Kconfig | 2 + > > > > > > > > drivers/net/Makefile | 1
Re: [PATCH v2 0/5] powerpc, mpc83xx: add DM_ETH support
Hello Tom, Am 17.09.2020 um 14:51 schrieb Tom Rini: On Thu, Sep 17, 2020 at 06:27:03AM +0200, Heiko Schocher wrote: Hello Tom, Am 16.09.2020 um 21:01 schrieb Tom Rini: On Wed, Sep 16, 2020 at 07:04:57AM +0200, Heiko Schocher wrote: Hello Mario, Tom, added Tom to cc ... Am 08.09.2020 um 07:59 schrieb Heiko Schocher: Hi Mario, Am 17.08.2020 um 07:23 schrieb Heiko Schocher: Hello Mario, Am 27.05.2020 um 14:43 schrieb Heiko Schocher: This patch series adds DM ethernet support for mpc83xx based keymile boards. Travis build: https://travis-ci.org/github/hsdenx/u-boot-test/builds/691607214 Changes in v2: - new in v2 - remove RFC - fixed Codingstyle errors, therefore new patch powerpc, mpc83xx: fix codingstyle issues for qe_io.c - moved DM part to drivers/pinctrl - add comments from Qiang Zhao: - add device node documentation - I did not drop the dm_qe_uec_phy.c and use drivers/net/fsl_mdio.c because using drivers/net/fsl_mdio.c leads in none existent udevice mdio@3320 instead boards with DM ETH support should use now this driver. - remove RFC tag - add patch which fixes Codingstyle errors in drivers/qe - add patch which converts the mpc83xx based boards from keymile to DM_ETH Heiko Schocher (5): mpc83xx: remove unneeded extern declaration in cpu_init powerpc, qe: fix codingstyle issues for drivers/qe powerpc, qe: add DTS support for parallel I/O ports net, qe: add DM support for QE UEC ethernet mpc83xx, keymile boards: enable DM_ETH and add DTS arch/powerpc/cpu/mpc83xx/Kconfig | 8 + arch/powerpc/cpu/mpc83xx/Makefile | 2 + arch/powerpc/cpu/mpc83xx/cpu_init.c | 11 +- arch/powerpc/cpu/mpc83xx/qe_io.c | 98 +- arch/powerpc/dts/Makefile | 8 + arch/powerpc/dts/km8309-uboot.dtsi | 33 + arch/powerpc/dts/km8321-uboot.dtsi | 67 + arch/powerpc/dts/km8321.dtsi | 220 arch/powerpc/dts/km836x-uboot.dtsi | 61 + arch/powerpc/dts/km836x.dtsi | 182 +++ arch/powerpc/dts/kmcoge5ne-uboot.dtsi | 22 + arch/powerpc/dts/kmcoge5ne.dts | 320 + arch/powerpc/dts/kmeter1-uboot.dtsi | 42 + arch/powerpc/dts/kmeter1.dts | 480 +++ arch/powerpc/dts/kmopti2.dts | 161 +++ arch/powerpc/dts/kmsupc5.dts | 139 ++ arch/powerpc/dts/kmsupm5.dts | 129 ++ arch/powerpc/dts/kmtegr1.dts | 392 ++ arch/powerpc/dts/kmtepr2.dts | 142 ++ arch/powerpc/dts/kmtuge1.dts | 100 ++ arch/powerpc/dts/kmtuxa1.dts | 100 ++ board/keymile/km83xx/Kconfig | 17 + board/keymile/km83xx/MAINTAINERS | 23 +- board/keymile/km83xx/km83xx.c | 64 - configs/kmcoge5ne_defconfig | 11 +- configs/kmeter1_defconfig | 10 +- configs/kmopti2_defconfig | 11 +- configs/kmsupx5_defconfig | 10 +- configs/kmtegr1_defconfig | 12 +- configs/kmtepr2_defconfig | 10 +- configs/tuge1_defconfig | 10 +- configs/tuxx1_defconfig | 11 +- .../soc/fsl/cpm_qe/qe/ucc.txt | 53 + drivers/net/Kconfig | 2 + drivers/net/Makefile | 1 + drivers/net/qe/Kconfig | 9 + drivers/net/qe/Makefile | 5 + drivers/net/qe/dm_qe_uec.c | 1167 + drivers/net/qe/dm_qe_uec.h | 22 + drivers/net/qe/dm_qe_uec_phy.c | 163 +++ drivers/net/qe/uccf.c | 507 +++ drivers/net/qe/uccf.h | 119 ++ drivers/net/qe/uec.h | 693 ++ drivers/pinctrl/Kconfig | 7 + drivers/pinctrl/Makefile | 1 + drivers/pinctrl/pinctrl-qe-io.c | 255 drivers/qe/qe.c | 96 +- drivers/qe/uccf.c | 449 --- drivers/qe/uccf.h | 90 +- drivers/qe/uec.c | 598 - drivers/qe/uec.h | 381 +++--- drivers/qe/uec_phy.c | 334 ++--- drivers/qe/uec_phy.h | 71 +- include/configs/km/km-mpc832x.h | 14 - include/configs/km/km-mpc8360.h | 14 - include/configs/km/km-mpc83xx.h | 10 - include/fsl_qe.h
Re: [PATCH v2 0/5] powerpc, mpc83xx: add DM_ETH support
On Thu, Sep 17, 2020 at 06:27:03AM +0200, Heiko Schocher wrote: > Hello Tom, > > Am 16.09.2020 um 21:01 schrieb Tom Rini: > > On Wed, Sep 16, 2020 at 07:04:57AM +0200, Heiko Schocher wrote: > > > Hello Mario, Tom, > > > > > > added Tom to cc ... > > > > > > Am 08.09.2020 um 07:59 schrieb Heiko Schocher: > > > > Hi Mario, > > > > > > > > Am 17.08.2020 um 07:23 schrieb Heiko Schocher: > > > > > Hello Mario, > > > > > > > > > > Am 27.05.2020 um 14:43 schrieb Heiko Schocher: > > > > > > > > > > > > This patch series adds DM ethernet support for mpc83xx based > > > > > > keymile boards. > > > > > > > > > > > > Travis build: > > > > > > https://travis-ci.org/github/hsdenx/u-boot-test/builds/691607214 > > > > > > > > > > > > > > > > > > Changes in v2: > > > > > > - new in v2 > > > > > > - remove RFC > > > > > > - fixed Codingstyle errors, therefore new patch > > > > > > powerpc, mpc83xx: fix codingstyle issues for qe_io.c > > > > > > - moved DM part to drivers/pinctrl > > > > > > - add comments from Qiang Zhao: > > > > > > - add device node documentation > > > > > > - I did not drop the dm_qe_uec_phy.c and use > > > > > > drivers/net/fsl_mdio.c > > > > > > because using drivers/net/fsl_mdio.c leads in none existent > > > > > > udevice mdio@3320 > > > > > > instead boards with DM ETH support should use now this > > > > > > driver. > > > > > > - remove RFC tag > > > > > > - add patch which fixes Codingstyle errors in drivers/qe > > > > > > - add patch which converts the mpc83xx based boards from > > > > > > keymile to DM_ETH > > > > > > > > > > > > Heiko Schocher (5): > > > > > > mpc83xx: remove unneeded extern declaration in cpu_init > > > > > > powerpc, qe: fix codingstyle issues for drivers/qe > > > > > > powerpc, qe: add DTS support for parallel I/O ports > > > > > > net, qe: add DM support for QE UEC ethernet > > > > > > mpc83xx, keymile boards: enable DM_ETH and add DTS > > > > > > > > > > > > arch/powerpc/cpu/mpc83xx/Kconfig | 8 + > > > > > > arch/powerpc/cpu/mpc83xx/Makefile | 2 + > > > > > > arch/powerpc/cpu/mpc83xx/cpu_init.c | 11 +- > > > > > > arch/powerpc/cpu/mpc83xx/qe_io.c | 98 +- > > > > > > arch/powerpc/dts/Makefile | 8 + > > > > > > arch/powerpc/dts/km8309-uboot.dtsi | 33 + > > > > > > arch/powerpc/dts/km8321-uboot.dtsi | 67 + > > > > > > arch/powerpc/dts/km8321.dtsi | 220 > > > > > > arch/powerpc/dts/km836x-uboot.dtsi | 61 + > > > > > > arch/powerpc/dts/km836x.dtsi | 182 +++ > > > > > > arch/powerpc/dts/kmcoge5ne-uboot.dtsi | 22 + > > > > > > arch/powerpc/dts/kmcoge5ne.dts | 320 + > > > > > > arch/powerpc/dts/kmeter1-uboot.dtsi | 42 + > > > > > > arch/powerpc/dts/kmeter1.dts | 480 +++ > > > > > > arch/powerpc/dts/kmopti2.dts | 161 +++ > > > > > > arch/powerpc/dts/kmsupc5.dts | 139 ++ > > > > > > arch/powerpc/dts/kmsupm5.dts | 129 ++ > > > > > > arch/powerpc/dts/kmtegr1.dts | 392 ++ > > > > > > arch/powerpc/dts/kmtepr2.dts | 142 ++ > > > > > > arch/powerpc/dts/kmtuge1.dts | 100 ++ > > > > > > arch/powerpc/dts/kmtuxa1.dts | 100 ++ > > > > > > board/keymile/km83xx/Kconfig | 17 + > > > > > > board/keymile/km83xx/MAINTAINERS | 23 +- > > > > > > board/keymile/km83xx/km83xx.c | 64 - > > > > > > configs/kmcoge5ne_defconfig | 11 +- > > > > > > configs/kmeter1_defconfig | 10 +- > > > > > > configs/kmopti2_defconfig | 11 +- > > > > > > configs/kmsupx5_defconfig | 10 +- > > > > > > configs/kmtegr1_defconfig | 12 +- > > > > > > configs/kmtepr2_defconfig | 10 +- > > > > > > configs/tuge1_defconfig | 10 +- > > > > > > configs/tuxx1_defconfig | 11 +- > > > > > > .../soc/fsl/cpm_qe/qe/ucc.txt | 53 + > > > > > > drivers/net/Kconfig | 2 + > > > > > > drivers/net/Makefile | 1 + > > > > > > drivers/net/qe/Kconfig | 9 + > > > > > > drivers/net/qe/Makefile | 5 + > > > > > > drivers/net/qe/dm_qe_uec.c | 1167 > > > > > > + > > > > > > drivers/net/qe/dm_qe_uec.h | 22 + > > > > > > drivers/net/qe/dm_qe_uec_phy.c | 163 +++ > > > > > > drivers/net/qe/uccf.c | 507 +++ > > > > > > drivers/net/qe/uccf.h | 119 ++
Re: [PATCH v2 0/5] powerpc, mpc83xx: add DM_ETH support
Hello Tom, Am 16.09.2020 um 21:01 schrieb Tom Rini: On Wed, Sep 16, 2020 at 07:04:57AM +0200, Heiko Schocher wrote: Hello Mario, Tom, added Tom to cc ... Am 08.09.2020 um 07:59 schrieb Heiko Schocher: Hi Mario, Am 17.08.2020 um 07:23 schrieb Heiko Schocher: Hello Mario, Am 27.05.2020 um 14:43 schrieb Heiko Schocher: This patch series adds DM ethernet support for mpc83xx based keymile boards. Travis build: https://travis-ci.org/github/hsdenx/u-boot-test/builds/691607214 Changes in v2: - new in v2 - remove RFC - fixed Codingstyle errors, therefore new patch powerpc, mpc83xx: fix codingstyle issues for qe_io.c - moved DM part to drivers/pinctrl - add comments from Qiang Zhao: - add device node documentation - I did not drop the dm_qe_uec_phy.c and use drivers/net/fsl_mdio.c because using drivers/net/fsl_mdio.c leads in none existent udevice mdio@3320 instead boards with DM ETH support should use now this driver. - remove RFC tag - add patch which fixes Codingstyle errors in drivers/qe - add patch which converts the mpc83xx based boards from keymile to DM_ETH Heiko Schocher (5): mpc83xx: remove unneeded extern declaration in cpu_init powerpc, qe: fix codingstyle issues for drivers/qe powerpc, qe: add DTS support for parallel I/O ports net, qe: add DM support for QE UEC ethernet mpc83xx, keymile boards: enable DM_ETH and add DTS arch/powerpc/cpu/mpc83xx/Kconfig | 8 + arch/powerpc/cpu/mpc83xx/Makefile | 2 + arch/powerpc/cpu/mpc83xx/cpu_init.c | 11 +- arch/powerpc/cpu/mpc83xx/qe_io.c | 98 +- arch/powerpc/dts/Makefile | 8 + arch/powerpc/dts/km8309-uboot.dtsi | 33 + arch/powerpc/dts/km8321-uboot.dtsi | 67 + arch/powerpc/dts/km8321.dtsi | 220 arch/powerpc/dts/km836x-uboot.dtsi | 61 + arch/powerpc/dts/km836x.dtsi | 182 +++ arch/powerpc/dts/kmcoge5ne-uboot.dtsi | 22 + arch/powerpc/dts/kmcoge5ne.dts | 320 + arch/powerpc/dts/kmeter1-uboot.dtsi | 42 + arch/powerpc/dts/kmeter1.dts | 480 +++ arch/powerpc/dts/kmopti2.dts | 161 +++ arch/powerpc/dts/kmsupc5.dts | 139 ++ arch/powerpc/dts/kmsupm5.dts | 129 ++ arch/powerpc/dts/kmtegr1.dts | 392 ++ arch/powerpc/dts/kmtepr2.dts | 142 ++ arch/powerpc/dts/kmtuge1.dts | 100 ++ arch/powerpc/dts/kmtuxa1.dts | 100 ++ board/keymile/km83xx/Kconfig | 17 + board/keymile/km83xx/MAINTAINERS | 23 +- board/keymile/km83xx/km83xx.c | 64 - configs/kmcoge5ne_defconfig | 11 +- configs/kmeter1_defconfig | 10 +- configs/kmopti2_defconfig | 11 +- configs/kmsupx5_defconfig | 10 +- configs/kmtegr1_defconfig | 12 +- configs/kmtepr2_defconfig | 10 +- configs/tuge1_defconfig | 10 +- configs/tuxx1_defconfig | 11 +- .../soc/fsl/cpm_qe/qe/ucc.txt | 53 + drivers/net/Kconfig | 2 + drivers/net/Makefile | 1 + drivers/net/qe/Kconfig | 9 + drivers/net/qe/Makefile | 5 + drivers/net/qe/dm_qe_uec.c | 1167 + drivers/net/qe/dm_qe_uec.h | 22 + drivers/net/qe/dm_qe_uec_phy.c | 163 +++ drivers/net/qe/uccf.c | 507 +++ drivers/net/qe/uccf.h | 119 ++ drivers/net/qe/uec.h | 693 ++ drivers/pinctrl/Kconfig | 7 + drivers/pinctrl/Makefile | 1 + drivers/pinctrl/pinctrl-qe-io.c | 255 drivers/qe/qe.c | 96 +- drivers/qe/uccf.c | 449 --- drivers/qe/uccf.h | 90 +- drivers/qe/uec.c | 598 - drivers/qe/uec.h | 381 +++--- drivers/qe/uec_phy.c | 334 ++--- drivers/qe/uec_phy.h | 71 +- include/configs/km/km-mpc832x.h | 14 - include/configs/km/km-mpc8360.h | 14 - include/configs/km/km-mpc83xx.h | 10 - include/fsl_qe.h | 3 + 57 files changed, 6826 insertions(+), 1144 deletions(-) create mode 100644 arch/powerpc/dts/km8309-uboot.dtsi create mode 100644 arch/powerpc/dts/km8321-uboot.d
Re: [PATCH v2 0/5] powerpc, mpc83xx: add DM_ETH support
Hello Rasmus, Am 16.09.2020 um 21:35 schrieb Rasmus Villemoes: On 16/09/2020 07.04, Heiko Schocher wrote: Hello Mario, Tom, added Tom to cc ... Am 08.09.2020 um 07:59 schrieb Heiko Schocher: Hi Mario, Am 17.08.2020 um 07:23 schrieb Heiko Schocher: Hello Mario, Am 27.05.2020 um 14:43 schrieb Heiko Schocher: This patch series adds DM ethernet support for mpc83xx based keymile boards. ping? I have a rebased version in the meantime, but I would wait for any comments... gentle ping... @Tom: Mario seems to busy .. how to proceed here with this patches? We have a mpc8309-based board, currently using a U-Boot based on v2020.04. If you have a git tree I can pull these patches from I'll try to test them on our hardware. Pushed them (rebased to next) to: https://github.com/hsdenx/u-boot-test/tree/kmcoge5ne-dm-ethernet-devel started travis build for this branch: https://travis-ci.org/github/hsdenx/u-boot-test/builds/727904421 Thanks! bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: h...@denx.de
Re: [PATCH v2 0/5] powerpc, mpc83xx: add DM_ETH support
On 16/09/2020 07.04, Heiko Schocher wrote: > Hello Mario, Tom, > > added Tom to cc ... > > Am 08.09.2020 um 07:59 schrieb Heiko Schocher: >> Hi Mario, >> >> Am 17.08.2020 um 07:23 schrieb Heiko Schocher: >>> Hello Mario, >>> >>> Am 27.05.2020 um 14:43 schrieb Heiko Schocher: This patch series adds DM ethernet support for mpc83xx based keymile boards. >> ping? >> >> I have a rebased version in the meantime, but I would wait for >> any comments... > > gentle ping... > > @Tom: Mario seems to busy .. how to proceed here with this patches? We have a mpc8309-based board, currently using a U-Boot based on v2020.04. If you have a git tree I can pull these patches from I'll try to test them on our hardware. Rasmus
Re: [PATCH v2 0/5] powerpc, mpc83xx: add DM_ETH support
On Wed, Sep 16, 2020 at 07:04:57AM +0200, Heiko Schocher wrote: > Hello Mario, Tom, > > added Tom to cc ... > > Am 08.09.2020 um 07:59 schrieb Heiko Schocher: > > Hi Mario, > > > > Am 17.08.2020 um 07:23 schrieb Heiko Schocher: > > > Hello Mario, > > > > > > Am 27.05.2020 um 14:43 schrieb Heiko Schocher: > > > > > > > > This patch series adds DM ethernet support for mpc83xx based > > > > keymile boards. > > > > > > > > Travis build: > > > > https://travis-ci.org/github/hsdenx/u-boot-test/builds/691607214 > > > > > > > > > > > > Changes in v2: > > > > - new in v2 > > > > - remove RFC > > > > - fixed Codingstyle errors, therefore new patch > > > > powerpc, mpc83xx: fix codingstyle issues for qe_io.c > > > > - moved DM part to drivers/pinctrl > > > > - add comments from Qiang Zhao: > > > > - add device node documentation > > > > - I did not drop the dm_qe_uec_phy.c and use drivers/net/fsl_mdio.c > > > > because using drivers/net/fsl_mdio.c leads in none existent > > > > udevice mdio@3320 > > > > instead boards with DM ETH support should use now this > > > > driver. > > > > - remove RFC tag > > > > - add patch which fixes Codingstyle errors in drivers/qe > > > > - add patch which converts the mpc83xx based boards from > > > > keymile to DM_ETH > > > > > > > > Heiko Schocher (5): > > > > mpc83xx: remove unneeded extern declaration in cpu_init > > > > powerpc, qe: fix codingstyle issues for drivers/qe > > > > powerpc, qe: add DTS support for parallel I/O ports > > > > net, qe: add DM support for QE UEC ethernet > > > > mpc83xx, keymile boards: enable DM_ETH and add DTS > > > > > > > > arch/powerpc/cpu/mpc83xx/Kconfig | 8 + > > > > arch/powerpc/cpu/mpc83xx/Makefile | 2 + > > > > arch/powerpc/cpu/mpc83xx/cpu_init.c | 11 +- > > > > arch/powerpc/cpu/mpc83xx/qe_io.c | 98 +- > > > > arch/powerpc/dts/Makefile | 8 + > > > > arch/powerpc/dts/km8309-uboot.dtsi | 33 + > > > > arch/powerpc/dts/km8321-uboot.dtsi | 67 + > > > > arch/powerpc/dts/km8321.dtsi | 220 > > > > arch/powerpc/dts/km836x-uboot.dtsi | 61 + > > > > arch/powerpc/dts/km836x.dtsi | 182 +++ > > > > arch/powerpc/dts/kmcoge5ne-uboot.dtsi | 22 + > > > > arch/powerpc/dts/kmcoge5ne.dts | 320 + > > > > arch/powerpc/dts/kmeter1-uboot.dtsi | 42 + > > > > arch/powerpc/dts/kmeter1.dts | 480 +++ > > > > arch/powerpc/dts/kmopti2.dts | 161 +++ > > > > arch/powerpc/dts/kmsupc5.dts | 139 ++ > > > > arch/powerpc/dts/kmsupm5.dts | 129 ++ > > > > arch/powerpc/dts/kmtegr1.dts | 392 ++ > > > > arch/powerpc/dts/kmtepr2.dts | 142 ++ > > > > arch/powerpc/dts/kmtuge1.dts | 100 ++ > > > > arch/powerpc/dts/kmtuxa1.dts | 100 ++ > > > > board/keymile/km83xx/Kconfig | 17 + > > > > board/keymile/km83xx/MAINTAINERS | 23 +- > > > > board/keymile/km83xx/km83xx.c | 64 - > > > > configs/kmcoge5ne_defconfig | 11 +- > > > > configs/kmeter1_defconfig | 10 +- > > > > configs/kmopti2_defconfig | 11 +- > > > > configs/kmsupx5_defconfig | 10 +- > > > > configs/kmtegr1_defconfig | 12 +- > > > > configs/kmtepr2_defconfig | 10 +- > > > > configs/tuge1_defconfig | 10 +- > > > > configs/tuxx1_defconfig | 11 +- > > > > .../soc/fsl/cpm_qe/qe/ucc.txt | 53 + > > > > drivers/net/Kconfig | 2 + > > > > drivers/net/Makefile | 1 + > > > > drivers/net/qe/Kconfig | 9 + > > > > drivers/net/qe/Makefile | 5 + > > > > drivers/net/qe/dm_qe_uec.c | 1167 + > > > > drivers/net/qe/dm_qe_uec.h | 22 + > > > > drivers/net/qe/dm_qe_uec_phy.c | 163 +++ > > > > drivers/net/qe/uccf.c | 507 +++ > > > > drivers/net/qe/uccf.h | 119 ++ > > > > drivers/net/qe/uec.h | 693 ++ > > > > drivers/pinctrl/Kconfig | 7 + > > > > drivers/pinctrl/Makefile | 1 + > > > > drivers/pinctrl/pinctrl-qe-io.c | 255 > > > > drivers/qe/qe.c | 96 +- > > > > drivers/qe/uccf.c | 449 --- > > > > drivers/qe/uccf.h | 90 +- > > > > drivers/qe/uec.c | 598 - > >
Re: [PATCH v2 0/5] powerpc, mpc83xx: add DM_ETH support
Hello Mario, Tom, added Tom to cc ... Am 08.09.2020 um 07:59 schrieb Heiko Schocher: Hi Mario, Am 17.08.2020 um 07:23 schrieb Heiko Schocher: Hello Mario, Am 27.05.2020 um 14:43 schrieb Heiko Schocher: This patch series adds DM ethernet support for mpc83xx based keymile boards. Travis build: https://travis-ci.org/github/hsdenx/u-boot-test/builds/691607214 Changes in v2: - new in v2 - remove RFC - fixed Codingstyle errors, therefore new patch powerpc, mpc83xx: fix codingstyle issues for qe_io.c - moved DM part to drivers/pinctrl - add comments from Qiang Zhao: - add device node documentation - I did not drop the dm_qe_uec_phy.c and use drivers/net/fsl_mdio.c because using drivers/net/fsl_mdio.c leads in none existent udevice mdio@3320 instead boards with DM ETH support should use now this driver. - remove RFC tag - add patch which fixes Codingstyle errors in drivers/qe - add patch which converts the mpc83xx based boards from keymile to DM_ETH Heiko Schocher (5): mpc83xx: remove unneeded extern declaration in cpu_init powerpc, qe: fix codingstyle issues for drivers/qe powerpc, qe: add DTS support for parallel I/O ports net, qe: add DM support for QE UEC ethernet mpc83xx, keymile boards: enable DM_ETH and add DTS arch/powerpc/cpu/mpc83xx/Kconfig | 8 + arch/powerpc/cpu/mpc83xx/Makefile | 2 + arch/powerpc/cpu/mpc83xx/cpu_init.c | 11 +- arch/powerpc/cpu/mpc83xx/qe_io.c | 98 +- arch/powerpc/dts/Makefile | 8 + arch/powerpc/dts/km8309-uboot.dtsi | 33 + arch/powerpc/dts/km8321-uboot.dtsi | 67 + arch/powerpc/dts/km8321.dtsi | 220 arch/powerpc/dts/km836x-uboot.dtsi | 61 + arch/powerpc/dts/km836x.dtsi | 182 +++ arch/powerpc/dts/kmcoge5ne-uboot.dtsi | 22 + arch/powerpc/dts/kmcoge5ne.dts | 320 + arch/powerpc/dts/kmeter1-uboot.dtsi | 42 + arch/powerpc/dts/kmeter1.dts | 480 +++ arch/powerpc/dts/kmopti2.dts | 161 +++ arch/powerpc/dts/kmsupc5.dts | 139 ++ arch/powerpc/dts/kmsupm5.dts | 129 ++ arch/powerpc/dts/kmtegr1.dts | 392 ++ arch/powerpc/dts/kmtepr2.dts | 142 ++ arch/powerpc/dts/kmtuge1.dts | 100 ++ arch/powerpc/dts/kmtuxa1.dts | 100 ++ board/keymile/km83xx/Kconfig | 17 + board/keymile/km83xx/MAINTAINERS | 23 +- board/keymile/km83xx/km83xx.c | 64 - configs/kmcoge5ne_defconfig | 11 +- configs/kmeter1_defconfig | 10 +- configs/kmopti2_defconfig | 11 +- configs/kmsupx5_defconfig | 10 +- configs/kmtegr1_defconfig | 12 +- configs/kmtepr2_defconfig | 10 +- configs/tuge1_defconfig | 10 +- configs/tuxx1_defconfig | 11 +- .../soc/fsl/cpm_qe/qe/ucc.txt | 53 + drivers/net/Kconfig | 2 + drivers/net/Makefile | 1 + drivers/net/qe/Kconfig | 9 + drivers/net/qe/Makefile | 5 + drivers/net/qe/dm_qe_uec.c | 1167 + drivers/net/qe/dm_qe_uec.h | 22 + drivers/net/qe/dm_qe_uec_phy.c | 163 +++ drivers/net/qe/uccf.c | 507 +++ drivers/net/qe/uccf.h | 119 ++ drivers/net/qe/uec.h | 693 ++ drivers/pinctrl/Kconfig | 7 + drivers/pinctrl/Makefile | 1 + drivers/pinctrl/pinctrl-qe-io.c | 255 drivers/qe/qe.c | 96 +- drivers/qe/uccf.c | 449 --- drivers/qe/uccf.h | 90 +- drivers/qe/uec.c | 598 - drivers/qe/uec.h | 381 +++--- drivers/qe/uec_phy.c | 334 ++--- drivers/qe/uec_phy.h | 71 +- include/configs/km/km-mpc832x.h | 14 - include/configs/km/km-mpc8360.h | 14 - include/configs/km/km-mpc83xx.h | 10 - include/fsl_qe.h | 3 + 57 files changed, 6826 insertions(+), 1144 deletions(-) create mode 100644 arch/powerpc/dts/km8309-uboot.dtsi create mode 100644 arch/powerpc/dts/km8321-uboot.dtsi create mode 100644 arch/powerpc/dts/km8321.dtsi create mode 100644 arch/powerpc/dts/km836x-uboot.dtsi create mode 100644 arch/powerpc/dts/km836x.dtsi create mode 100644 arch/powerp
Re: [PATCH v2 0/5] powerpc, mpc83xx: add DM_ETH support
Hi Mario, Am 17.08.2020 um 07:23 schrieb Heiko Schocher: Hello Mario, Am 27.05.2020 um 14:43 schrieb Heiko Schocher: This patch series adds DM ethernet support for mpc83xx based keymile boards. Travis build: https://travis-ci.org/github/hsdenx/u-boot-test/builds/691607214 Changes in v2: - new in v2 - remove RFC - fixed Codingstyle errors, therefore new patch powerpc, mpc83xx: fix codingstyle issues for qe_io.c - moved DM part to drivers/pinctrl - add comments from Qiang Zhao: - add device node documentation - I did not drop the dm_qe_uec_phy.c and use drivers/net/fsl_mdio.c because using drivers/net/fsl_mdio.c leads in none existent udevice mdio@3320 instead boards with DM ETH support should use now this driver. - remove RFC tag - add patch which fixes Codingstyle errors in drivers/qe - add patch which converts the mpc83xx based boards from keymile to DM_ETH Heiko Schocher (5): mpc83xx: remove unneeded extern declaration in cpu_init powerpc, qe: fix codingstyle issues for drivers/qe powerpc, qe: add DTS support for parallel I/O ports net, qe: add DM support for QE UEC ethernet mpc83xx, keymile boards: enable DM_ETH and add DTS arch/powerpc/cpu/mpc83xx/Kconfig | 8 + arch/powerpc/cpu/mpc83xx/Makefile | 2 + arch/powerpc/cpu/mpc83xx/cpu_init.c | 11 +- arch/powerpc/cpu/mpc83xx/qe_io.c | 98 +- arch/powerpc/dts/Makefile | 8 + arch/powerpc/dts/km8309-uboot.dtsi | 33 + arch/powerpc/dts/km8321-uboot.dtsi | 67 + arch/powerpc/dts/km8321.dtsi | 220 arch/powerpc/dts/km836x-uboot.dtsi | 61 + arch/powerpc/dts/km836x.dtsi | 182 +++ arch/powerpc/dts/kmcoge5ne-uboot.dtsi | 22 + arch/powerpc/dts/kmcoge5ne.dts | 320 + arch/powerpc/dts/kmeter1-uboot.dtsi | 42 + arch/powerpc/dts/kmeter1.dts | 480 +++ arch/powerpc/dts/kmopti2.dts | 161 +++ arch/powerpc/dts/kmsupc5.dts | 139 ++ arch/powerpc/dts/kmsupm5.dts | 129 ++ arch/powerpc/dts/kmtegr1.dts | 392 ++ arch/powerpc/dts/kmtepr2.dts | 142 ++ arch/powerpc/dts/kmtuge1.dts | 100 ++ arch/powerpc/dts/kmtuxa1.dts | 100 ++ board/keymile/km83xx/Kconfig | 17 + board/keymile/km83xx/MAINTAINERS | 23 +- board/keymile/km83xx/km83xx.c | 64 - configs/kmcoge5ne_defconfig | 11 +- configs/kmeter1_defconfig | 10 +- configs/kmopti2_defconfig | 11 +- configs/kmsupx5_defconfig | 10 +- configs/kmtegr1_defconfig | 12 +- configs/kmtepr2_defconfig | 10 +- configs/tuge1_defconfig | 10 +- configs/tuxx1_defconfig | 11 +- .../soc/fsl/cpm_qe/qe/ucc.txt | 53 + drivers/net/Kconfig | 2 + drivers/net/Makefile | 1 + drivers/net/qe/Kconfig | 9 + drivers/net/qe/Makefile | 5 + drivers/net/qe/dm_qe_uec.c | 1167 + drivers/net/qe/dm_qe_uec.h | 22 + drivers/net/qe/dm_qe_uec_phy.c | 163 +++ drivers/net/qe/uccf.c | 507 +++ drivers/net/qe/uccf.h | 119 ++ drivers/net/qe/uec.h | 693 ++ drivers/pinctrl/Kconfig | 7 + drivers/pinctrl/Makefile | 1 + drivers/pinctrl/pinctrl-qe-io.c | 255 drivers/qe/qe.c | 96 +- drivers/qe/uccf.c | 449 --- drivers/qe/uccf.h | 90 +- drivers/qe/uec.c | 598 - drivers/qe/uec.h | 381 +++--- drivers/qe/uec_phy.c | 334 ++--- drivers/qe/uec_phy.h | 71 +- include/configs/km/km-mpc832x.h | 14 - include/configs/km/km-mpc8360.h | 14 - include/configs/km/km-mpc83xx.h | 10 - include/fsl_qe.h | 3 + 57 files changed, 6826 insertions(+), 1144 deletions(-) create mode 100644 arch/powerpc/dts/km8309-uboot.dtsi create mode 100644 arch/powerpc/dts/km8321-uboot.dtsi create mode 100644 arch/powerpc/dts/km8321.dtsi create mode 100644 arch/powerpc/dts/km836x-uboot.dtsi create mode 100644 arch/powerpc/dts/km836x.dtsi create mode 100644 arch/powerpc/dts/kmcoge5ne-uboot.dtsi create mode 100644 arch/powerpc/dts/kmcoge5ne.dts create
Re: [PATCH v2 0/5] powerpc, mpc83xx: add DM_ETH support
Hello Mario, Am 27.05.2020 um 14:43 schrieb Heiko Schocher: This patch series adds DM ethernet support for mpc83xx based keymile boards. Travis build: https://travis-ci.org/github/hsdenx/u-boot-test/builds/691607214 Changes in v2: - new in v2 - remove RFC - fixed Codingstyle errors, therefore new patch powerpc, mpc83xx: fix codingstyle issues for qe_io.c - moved DM part to drivers/pinctrl - add comments from Qiang Zhao: - add device node documentation - I did not drop the dm_qe_uec_phy.c and use drivers/net/fsl_mdio.c because using drivers/net/fsl_mdio.c leads in none existent udevice mdio@3320 instead boards with DM ETH support should use now this driver. - remove RFC tag - add patch which fixes Codingstyle errors in drivers/qe - add patch which converts the mpc83xx based boards from keymile to DM_ETH Heiko Schocher (5): mpc83xx: remove unneeded extern declaration in cpu_init powerpc, qe: fix codingstyle issues for drivers/qe powerpc, qe: add DTS support for parallel I/O ports net, qe: add DM support for QE UEC ethernet mpc83xx, keymile boards: enable DM_ETH and add DTS arch/powerpc/cpu/mpc83xx/Kconfig |8 + arch/powerpc/cpu/mpc83xx/Makefile |2 + arch/powerpc/cpu/mpc83xx/cpu_init.c | 11 +- arch/powerpc/cpu/mpc83xx/qe_io.c | 98 +- arch/powerpc/dts/Makefile |8 + arch/powerpc/dts/km8309-uboot.dtsi| 33 + arch/powerpc/dts/km8321-uboot.dtsi| 67 + arch/powerpc/dts/km8321.dtsi | 220 arch/powerpc/dts/km836x-uboot.dtsi| 61 + arch/powerpc/dts/km836x.dtsi | 182 +++ arch/powerpc/dts/kmcoge5ne-uboot.dtsi | 22 + arch/powerpc/dts/kmcoge5ne.dts| 320 + arch/powerpc/dts/kmeter1-uboot.dtsi | 42 + arch/powerpc/dts/kmeter1.dts | 480 +++ arch/powerpc/dts/kmopti2.dts | 161 +++ arch/powerpc/dts/kmsupc5.dts | 139 ++ arch/powerpc/dts/kmsupm5.dts | 129 ++ arch/powerpc/dts/kmtegr1.dts | 392 ++ arch/powerpc/dts/kmtepr2.dts | 142 ++ arch/powerpc/dts/kmtuge1.dts | 100 ++ arch/powerpc/dts/kmtuxa1.dts | 100 ++ board/keymile/km83xx/Kconfig | 17 + board/keymile/km83xx/MAINTAINERS | 23 +- board/keymile/km83xx/km83xx.c | 64 - configs/kmcoge5ne_defconfig | 11 +- configs/kmeter1_defconfig | 10 +- configs/kmopti2_defconfig | 11 +- configs/kmsupx5_defconfig | 10 +- configs/kmtegr1_defconfig | 12 +- configs/kmtepr2_defconfig | 10 +- configs/tuge1_defconfig | 10 +- configs/tuxx1_defconfig | 11 +- .../soc/fsl/cpm_qe/qe/ucc.txt | 53 + drivers/net/Kconfig |2 + drivers/net/Makefile |1 + drivers/net/qe/Kconfig|9 + drivers/net/qe/Makefile |5 + drivers/net/qe/dm_qe_uec.c| 1167 + drivers/net/qe/dm_qe_uec.h| 22 + drivers/net/qe/dm_qe_uec_phy.c| 163 +++ drivers/net/qe/uccf.c | 507 +++ drivers/net/qe/uccf.h | 119 ++ drivers/net/qe/uec.h | 693 ++ drivers/pinctrl/Kconfig |7 + drivers/pinctrl/Makefile |1 + drivers/pinctrl/pinctrl-qe-io.c | 255 drivers/qe/qe.c | 96 +- drivers/qe/uccf.c | 449 --- drivers/qe/uccf.h | 90 +- drivers/qe/uec.c | 598 - drivers/qe/uec.h | 381 +++--- drivers/qe/uec_phy.c | 334 ++--- drivers/qe/uec_phy.h | 71 +- include/configs/km/km-mpc832x.h | 14 - include/configs/km/km-mpc8360.h | 14 - include/configs/km/km-mpc83xx.h | 10 - include/fsl_qe.h |3 + 57 files changed, 6826 insertions(+), 1144 deletions(-) create mode 100644 arch/powerpc/dts/km8309-uboot.dtsi create mode 100644 arch/powerpc/dts/km8321-uboot.dtsi create mode 100644 arch/powerpc/dts/km8321.dtsi create mode 100644 arch/powerpc/dts/km836x-uboot.dtsi create mode 100644 arch/powerpc/dts/km836x.dtsi create mode 100644 arch/powerpc/dts/kmcoge5ne-uboot.dtsi create mode 100644 arch/powerpc/dts/kmcoge5ne.dts create mode 100644 arch/powerpc/dts/kmeter1-uboot.dtsi create mo
[PATCH v2 0/5] powerpc, mpc83xx: add DM_ETH support
This patch series adds DM ethernet support for mpc83xx based keymile boards. Travis build: https://travis-ci.org/github/hsdenx/u-boot-test/builds/691607214 Changes in v2: - new in v2 - remove RFC - fixed Codingstyle errors, therefore new patch powerpc, mpc83xx: fix codingstyle issues for qe_io.c - moved DM part to drivers/pinctrl - add comments from Qiang Zhao: - add device node documentation - I did not drop the dm_qe_uec_phy.c and use drivers/net/fsl_mdio.c because using drivers/net/fsl_mdio.c leads in none existent udevice mdio@3320 instead boards with DM ETH support should use now this driver. - remove RFC tag - add patch which fixes Codingstyle errors in drivers/qe - add patch which converts the mpc83xx based boards from keymile to DM_ETH Heiko Schocher (5): mpc83xx: remove unneeded extern declaration in cpu_init powerpc, qe: fix codingstyle issues for drivers/qe powerpc, qe: add DTS support for parallel I/O ports net, qe: add DM support for QE UEC ethernet mpc83xx, keymile boards: enable DM_ETH and add DTS arch/powerpc/cpu/mpc83xx/Kconfig |8 + arch/powerpc/cpu/mpc83xx/Makefile |2 + arch/powerpc/cpu/mpc83xx/cpu_init.c | 11 +- arch/powerpc/cpu/mpc83xx/qe_io.c | 98 +- arch/powerpc/dts/Makefile |8 + arch/powerpc/dts/km8309-uboot.dtsi| 33 + arch/powerpc/dts/km8321-uboot.dtsi| 67 + arch/powerpc/dts/km8321.dtsi | 220 arch/powerpc/dts/km836x-uboot.dtsi| 61 + arch/powerpc/dts/km836x.dtsi | 182 +++ arch/powerpc/dts/kmcoge5ne-uboot.dtsi | 22 + arch/powerpc/dts/kmcoge5ne.dts| 320 + arch/powerpc/dts/kmeter1-uboot.dtsi | 42 + arch/powerpc/dts/kmeter1.dts | 480 +++ arch/powerpc/dts/kmopti2.dts | 161 +++ arch/powerpc/dts/kmsupc5.dts | 139 ++ arch/powerpc/dts/kmsupm5.dts | 129 ++ arch/powerpc/dts/kmtegr1.dts | 392 ++ arch/powerpc/dts/kmtepr2.dts | 142 ++ arch/powerpc/dts/kmtuge1.dts | 100 ++ arch/powerpc/dts/kmtuxa1.dts | 100 ++ board/keymile/km83xx/Kconfig | 17 + board/keymile/km83xx/MAINTAINERS | 23 +- board/keymile/km83xx/km83xx.c | 64 - configs/kmcoge5ne_defconfig | 11 +- configs/kmeter1_defconfig | 10 +- configs/kmopti2_defconfig | 11 +- configs/kmsupx5_defconfig | 10 +- configs/kmtegr1_defconfig | 12 +- configs/kmtepr2_defconfig | 10 +- configs/tuge1_defconfig | 10 +- configs/tuxx1_defconfig | 11 +- .../soc/fsl/cpm_qe/qe/ucc.txt | 53 + drivers/net/Kconfig |2 + drivers/net/Makefile |1 + drivers/net/qe/Kconfig|9 + drivers/net/qe/Makefile |5 + drivers/net/qe/dm_qe_uec.c| 1167 + drivers/net/qe/dm_qe_uec.h| 22 + drivers/net/qe/dm_qe_uec_phy.c| 163 +++ drivers/net/qe/uccf.c | 507 +++ drivers/net/qe/uccf.h | 119 ++ drivers/net/qe/uec.h | 693 ++ drivers/pinctrl/Kconfig |7 + drivers/pinctrl/Makefile |1 + drivers/pinctrl/pinctrl-qe-io.c | 255 drivers/qe/qe.c | 96 +- drivers/qe/uccf.c | 449 --- drivers/qe/uccf.h | 90 +- drivers/qe/uec.c | 598 - drivers/qe/uec.h | 381 +++--- drivers/qe/uec_phy.c | 334 ++--- drivers/qe/uec_phy.h | 71 +- include/configs/km/km-mpc832x.h | 14 - include/configs/km/km-mpc8360.h | 14 - include/configs/km/km-mpc83xx.h | 10 - include/fsl_qe.h |3 + 57 files changed, 6826 insertions(+), 1144 deletions(-) create mode 100644 arch/powerpc/dts/km8309-uboot.dtsi create mode 100644 arch/powerpc/dts/km8321-uboot.dtsi create mode 100644 arch/powerpc/dts/km8321.dtsi create mode 100644 arch/powerpc/dts/km836x-uboot.dtsi create mode 100644 arch/powerpc/dts/km836x.dtsi create mode 100644 arch/powerpc/dts/kmcoge5ne-uboot.dtsi create mode 100644 arch/powerpc/dts/kmcoge5ne.dts create mode 100644 arch/powerpc/dts/kmeter1-uboot.dtsi create mode 100644 arch/powerpc/dts/kmeter1.dts create mode 100644 arch/powerpc/dts/kmopti2.dts create mode 100644 arch/powerpc/dts/kmsupc5.dts crea
