Re: [PATCH v2 0/9] Introduce HPE GXP Architecture

[Tom Rini]

On Wed, Jun 22, 2022 at 07:41:56PM +, Hawkins, Nick wrote:

> Greetings All,
> I just wanted to make sure I did not make a mistake with how I submitted the 
> second version of this patch as I am still learning the u-boot patch 
> submission process. Thanks ahead of time for any feedback.

I'm reviewing it for next currently and aside from some Kconfig
migrations have posted:
https://patchwork.ozlabs.org/project/uboot/patch/20220622192145.3696770-1-tr...@konsulko.com/

As a follow-up cleanup.

-- 
Tom


signature.asc
Description: PGP signature

Re: [PATCH v2 0/9] Introduce HPE GXP Architecture

[Hawkins, Nick]

Greetings All,
I just wanted to make sure I did not make a mistake with how I submitted the 
second version of this patch as I am still learning the u-boot patch submission 
process. Thanks ahead of time for any feedback.
Thanks for your time,
-Nick Hawkins

[PATCH v2 0/9] Introduce HPE GXP Architecture

[nick . hawkins]

From: Nick Hawkins 

Changes since v2:
 *Added SPI Controller Support
 *Removed hpe,gxp.yaml and hpe,gxp-timer.yaml as those bindings are
  already in linux
 *Added hpe,gxp-spi.yaml as it is necessary to boot the OS and is not
  present in linux.
 *Ported hpe-gxp.dtsi and hpe-bmc-dl360gen10.dts from Linux discarding
  all changes from previous patch.
 *Created hpe-gxp-u-boot.dtsi
 *Added hpe,gxp-spi.yaml and gxp_spi.c to MAINTAINERS
 *Removed hpe,gxp.yaml and hpe,gxp-timer.yaml from MAINTAINERS
 *Removed CONFIG_SYS_SDRAM_SIZE usage from gxp.h and moved SRAM
  calculation to gxp_board.c
 *Removed n for GXP_ECC as n is default in board Kconfig
 *Fixed indentation in board Kconfig
 *Removed use of common.h headers from files
 
The GXP is the HPE BMC SoC that is used in the majority of HPE current
generation servers. Traditionally the asic will last multiple
generations of server before being replaced.

Info about SoC:

 HPE GXP is the name of the HPE SoC. This SoC is used to implement many
 BMC features at HPE. It supports ARMv7 architecture based on the Cortex
 A9 core. It is capable of using an AXI bus to which a memory controller
 is attached. It has multiple SPI interfaces to connect boot flash and
 BIOS flash. It uses a 10/100/1000 MAC for network connectivity. It has
 multiple i2c engines to drive connectivity with a host infrastructure.
 The initial patches enable the timer and spi driver enabling U-Boot
 prompt to work and boot to the OS.

Nick Hawkins (9):
  ARM: hpe: gxp: add core support
  timer: gxp: Add HPE GXP timer support
  spi: gxp_spi: Add GXP SPI controller driver
  board: hpe: gxp: add HPE GXP soc support
  dt-bindings: spi: Add hpe gxp spi
  ARM: dts: Add device tree files for hpe gxp soc
  configs: gxp: add core support
  configs: gxp: add gxp_defconfig
  MAINTAINERS: Introduce HPE GXP Architecture

 MAINTAINERS   |  12 +
 arch/arm/Kconfig  |   8 +
 arch/arm/Makefile |   1 +
 arch/arm/dts/Makefile |   2 +
 arch/arm/dts/hpe-bmc-dl360gen10.dts   |  26 ++
 arch/arm/dts/hpe-gxp-u-boot.dtsi  |  25 ++
 arch/arm/dts/hpe-gxp.dtsi | 127 
 arch/arm/mach-hpe/Makefile|   1 +
 arch/arm/mach-hpe/gxp/Kconfig |   9 +
 arch/arm/mach-hpe/gxp/Makefile|   1 +
 arch/arm/mach-hpe/gxp/reset.c |  25 ++
 board/hpe/gxp/Kconfig |  46 +++
 board/hpe/gxp/Makefile|   1 +
 board/hpe/gxp/gxp_board.c |  75 +
 configs/gxp_defconfig |  59 
 doc/device-tree-bindings/spi/hpe,gxp-spi.yaml |  37 +++
 drivers/spi/Kconfig   |   6 +
 drivers/spi/Makefile  |   1 +
 drivers/spi/gxp_spi.c | 304 ++
 drivers/timer/Kconfig |   7 +
 drivers/timer/Makefile|   1 +
 drivers/timer/gxp-timer.c |  64 
 include/configs/gxp.h |  55 
 23 files changed, 893 insertions(+)
 create mode 100644 arch/arm/dts/hpe-bmc-dl360gen10.dts
 create mode 100644 arch/arm/dts/hpe-gxp-u-boot.dtsi
 create mode 100644 arch/arm/dts/hpe-gxp.dtsi
 create mode 100644 arch/arm/mach-hpe/Makefile
 create mode 100644 arch/arm/mach-hpe/gxp/Kconfig
 create mode 100644 arch/arm/mach-hpe/gxp/Makefile
 create mode 100644 arch/arm/mach-hpe/gxp/reset.c
 create mode 100644 board/hpe/gxp/Kconfig
 create mode 100644 board/hpe/gxp/Makefile
 create mode 100644 board/hpe/gxp/gxp_board.c
 create mode 100644 configs/gxp_defconfig
 create mode 100644 doc/device-tree-bindings/spi/hpe,gxp-spi.yaml
 create mode 100644 drivers/spi/gxp_spi.c
 create mode 100644 drivers/timer/gxp-timer.c
 create mode 100644 include/configs/gxp.h

-- 
2.17.1