Re: [PATCH v2 02/14] rockchip: rk3308: Sort imply statements alphabetically

2024-04-22 Thread Kever Yang



On 2024/4/9 02:13, Jonas Karlman wrote:

Sort imply statements under ROCKCHIP_RK3308 alphabetically and remove
the config SPL_SERIAL statement from soc Kconfig file, it is already
implyed in arch Kconfig.

Signed-off-by: Jonas Karlman 

Reviewed-by: Kever Yang 

Thanks,
- Kever

---
v2: No change
---
  arch/arm/mach-rockchip/Kconfig| 8 
  arch/arm/mach-rockchip/rk3308/Kconfig | 3 ---
  2 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
index f68a0a48949a..2fde8655d18a 100644
--- a/arch/arm/mach-rockchip/Kconfig
+++ b/arch/arm/mach-rockchip/Kconfig
@@ -161,13 +161,13 @@ config ROCKCHIP_RK3308
select SPL_ATF_NO_PLATFORM_PARAM
select SPL_LOAD_FIT
imply ROCKCHIP_COMMON_BOARD
-   imply SPL_ROCKCHIP_COMMON_BOARD
imply SPL_CLK
-   imply SPL_REGMAP
-   imply SPL_SYSCON
imply SPL_RAM
-   imply SPL_SERIAL
+   imply SPL_REGMAP
+   imply SPL_ROCKCHIP_COMMON_BOARD
imply SPL_SEPARATE_BSS
+   imply SPL_SERIAL
+   imply SPL_SYSCON
help
  The Rockchip RK3308 is a ARM-based Soc which embedded with quad
  Cortex-A35 and highly integrated audio interfaces.
diff --git a/arch/arm/mach-rockchip/rk3308/Kconfig 
b/arch/arm/mach-rockchip/rk3308/Kconfig
index 749e9995d91f..fac966207a92 100644
--- a/arch/arm/mach-rockchip/rk3308/Kconfig
+++ b/arch/arm/mach-rockchip/rk3308/Kconfig
@@ -23,9 +23,6 @@ config ROCKCHIP_COMMON_STACK_ADDR
  config TEXT_BASE
default 0x0060
  
-config SPL_SERIAL

-   default y
-
  source "board/rockchip/evb_rk3308/Kconfig"
  source "board/firefly/firefly-rk3308/Kconfig"
  


[PATCH v2 02/14] rockchip: rk3308: Sort imply statements alphabetically

2024-04-08 Thread Jonas Karlman
Sort imply statements under ROCKCHIP_RK3308 alphabetically and remove
the config SPL_SERIAL statement from soc Kconfig file, it is already
implyed in arch Kconfig.

Signed-off-by: Jonas Karlman 
---
v2: No change
---
 arch/arm/mach-rockchip/Kconfig| 8 
 arch/arm/mach-rockchip/rk3308/Kconfig | 3 ---
 2 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
index f68a0a48949a..2fde8655d18a 100644
--- a/arch/arm/mach-rockchip/Kconfig
+++ b/arch/arm/mach-rockchip/Kconfig
@@ -161,13 +161,13 @@ config ROCKCHIP_RK3308
select SPL_ATF_NO_PLATFORM_PARAM
select SPL_LOAD_FIT
imply ROCKCHIP_COMMON_BOARD
-   imply SPL_ROCKCHIP_COMMON_BOARD
imply SPL_CLK
-   imply SPL_REGMAP
-   imply SPL_SYSCON
imply SPL_RAM
-   imply SPL_SERIAL
+   imply SPL_REGMAP
+   imply SPL_ROCKCHIP_COMMON_BOARD
imply SPL_SEPARATE_BSS
+   imply SPL_SERIAL
+   imply SPL_SYSCON
help
  The Rockchip RK3308 is a ARM-based Soc which embedded with quad
  Cortex-A35 and highly integrated audio interfaces.
diff --git a/arch/arm/mach-rockchip/rk3308/Kconfig 
b/arch/arm/mach-rockchip/rk3308/Kconfig
index 749e9995d91f..fac966207a92 100644
--- a/arch/arm/mach-rockchip/rk3308/Kconfig
+++ b/arch/arm/mach-rockchip/rk3308/Kconfig
@@ -23,9 +23,6 @@ config ROCKCHIP_COMMON_STACK_ADDR
 config TEXT_BASE
default 0x0060
 
-config SPL_SERIAL
-   default y
-
 source "board/rockchip/evb_rk3308/Kconfig"
 source "board/firefly/firefly-rk3308/Kconfig"
 
-- 
2.43.2