Re: [PATCH v2 05/10] gpio: dw: Fix warnings about casting int to pointer

[Simon Glass]

On Sun, 7 Jun 2020 at 19:27, Sean Anderson  wrote:
>
> Change the type of gpio_dwabp_platdata.base from fdt_addr_t to a void
> pointer, since we pass it to readl.
>
> Signed-off-by: Sean Anderson 
> Reviewed-by: Bin Meng 
> ---
> This patch was previously submitted as part of
> https://patchwork.ozlabs.org/project/uboot/list/?series=161576
>
> (no changes since v1)
>
>  drivers/gpio/dwapb_gpio.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Simon Glass 

RE: [PATCH v2 05/10] gpio: dw: Fix warnings about casting int to pointer

[Tan, Ley Foon]

> -Original Message-
> From: Sean Anderson 
> Sent: Monday, June 8, 2020 9:27 AM
> To: u-boot@lists.denx.de
> Cc: Tom Rini ; Bin Meng ;
> Rick Chen ; Simon Glass ;
> Sean Anderson ; Anatolij Gustschin ;
> Tan, Ley Foon ; Marek Vasut ;
> Simon Goldschmidt 
> Subject: [PATCH v2 05/10] gpio: dw: Fix warnings about casting int to pointer
> 
> Change the type of gpio_dwabp_platdata.base from fdt_addr_t to a void
> pointer, since we pass it to readl.
> 
> Signed-off-by: Sean Anderson 
> Reviewed-by: Bin Meng 
> ---
> This patch was previously submitted as part of
> https://patchwork.ozlabs.org/project/uboot/list/?series=161576
> 
> (no changes since v1)
> 
>  drivers/gpio/dwapb_gpio.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: Ley Foon Tan 

[PATCH v2 05/10] gpio: dw: Fix warnings about casting int to pointer

[Sean Anderson]

Change the type of gpio_dwabp_platdata.base from fdt_addr_t to a void
pointer, since we pass it to readl.

Signed-off-by: Sean Anderson 
Reviewed-by: Bin Meng 
---
This patch was previously submitted as part of
https://patchwork.ozlabs.org/project/uboot/list/?series=161576

(no changes since v1)

 drivers/gpio/dwapb_gpio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/dwapb_gpio.c b/drivers/gpio/dwapb_gpio.c
index e5e3518194..bf324f5239 100644
--- a/drivers/gpio/dwapb_gpio.c
+++ b/drivers/gpio/dwapb_gpio.c
@@ -40,7 +40,7 @@ struct gpio_dwapb_platdata {
const char  *name;
int bank;
int pins;
-   fdt_addr_t  base;
+   void __iomem*base;
 };
 
 static int dwapb_gpio_direction_input(struct udevice *dev, unsigned pin)
@@ -176,7 +176,7 @@ static int gpio_dwapb_bind(struct udevice *dev)
if (!plat)
return -ENOMEM;
 
-   plat->base = base;
+   plat->base = (void *)base;
plat->bank = bank;
plat->pins = ofnode_read_u32_default(node, "snps,nr-gpios", 0);
 
-- 
2.26.2